Hash the file name portion and make the string constant portions
more relevant to what the keys are actually used for (e.g. there
is no URL parameter in the key)
Bug: T198279
Change-Id: Idf6f97db26f5be291cdd3a50a91346677fe9c3e6
Most of these are simply changing annotations to reflect
reality. If a function can return false to indicate failure
the @return should indicate it.
Some are fixing preg_match calls, preg match returns 1, 0 or false,
but the functions all claim to return booleans.
This is far from all the incorrect return types in mediawiki, there
are around 250 detected by phan, but have to start somewhere.
Change-Id: I1bbdfee6190747bde460f8a7084212ccafe169ef
A large amount of real time is spent in fetching Commons
descriptions pages from wikipedias, according to xenon
flame graphs.
Change-Id: I3935bf8bf23da58b734f897d7a1979e9b2f7e5c8
Strict Standards: Declaration of ForeignDBFile::delete() should be
compatible with that of LocalFile::delete()
Followed-Up: I60cab27e0708a818c77791cc89194b6dd726da0b
Change-Id: I11d32c0a529ec76978cde38c038b4984ca13e8ba
Swapped some "$var type" to "type $var" or added missing types
before the $var. Changed some other types to match the more common
spelling. Makes beginning of some text in captial.
Also added some missing @param.
Change-Id: I8804ebe0922d3a414863b162a2110e0b9e49b80f
I want to get the file description in a language other then
the user language in an extension (I5e6bc45f9751).
Change-Id: Ifcae821a51f4207e7816e710d3b3857c7ed438b6
Moves the giving of a user one level up, because File::recordUpload2
already needs this (and fallback to $wgUser).
Can also use the user for the watching of the file, which was using
$wgUser before.
Change-Id: I697ae0df65b07ea59ab11b62804853cdc03cb172
Strict Standards: Declaration of ForeignDBFile::publish() should be
compatible with that of LocalFile::publish() in
\includes\filerepo\file\ForeignDBFile.php on line 122
Change-Id: If3de7ec3a6794752bfe6ef7644b66497c1ad9c8b
