Thijs/wiki.techinc.nl

Fork 0

Commit graph

Author	SHA1	Message	Date
Fomafix	3ee1560232	No yoda conditions Replace if ( 42 === $foo ) by if ( $foo === 42 ) Change-Id: Ice320ef1ae64a59ed035c20134326b35d454f943	2018-11-21 17:54:39 +01:00
Erik Bernhardson	2a43939ffb	Push pagination decision for search into SearchEngine Various code using the search engine shouldn't need to implement it's own methods, such as over-fetching, to determine if there are more results available. This should be knowledge internal to search that is exposed by a boolean. Change-Id: Ica094428700637dfdedb723b03f6aeadfe12b9f4	2018-06-11 13:35:44 -07:00
Erik Bernhardson	c2a308075f	Convert SearchResultSet to typical iteration The funky iteration here was at best annoying. Switch it over to an iterator based approach with appropriate BC code to simulate the old iteration style. Depends-On: I19a8d6621a130811871dec9335038797627d9448 Change-Id: I9fccda15dd58a0dc35771d3b5cd7a6e8b02514a0	2018-06-11 13:35:41 -07:00

Author

SHA1

Message

Date

Fomafix

3ee1560232

No yoda conditions

Replace
  if ( 42 === $foo )
by
  if ( $foo === 42 )

Change-Id: Ice320ef1ae64a59ed035c20134326b35d454f943

2018-11-21 17:54:39 +01:00

Erik Bernhardson

2a43939ffb

Push pagination decision for search into SearchEngine

Various code using the search engine shouldn't need to implement it's
own methods, such as over-fetching, to determine if there are more
results available. This should be knowledge internal to search that is
exposed by a boolean.

Change-Id: Ica094428700637dfdedb723b03f6aeadfe12b9f4

2018-06-11 13:35:44 -07:00

Erik Bernhardson

c2a308075f

Convert SearchResultSet to typical iteration

The funky iteration here was at best annoying. Switch
it over to an iterator based approach with appropriate
BC code to simulate the old iteration style.

Depends-On: I19a8d6621a130811871dec9335038797627d9448
Change-Id: I9fccda15dd58a0dc35771d3b5cd7a6e8b02514a0

2018-06-11 13:35:41 -07:00

3 commits