Commit graph

58 commits

Author SHA1 Message Date
JuneHyeon Bae
17ebbe492c Remove obsolete RC_MOVE and RC_MOVE_OVER_REDIRECT rc types
RC_MOVE and RC_MOVE_OVER_REDIRECT are obsolete, since at least 2006.
So it is considered safe to remove.

Bug: 63755
Change-Id: I0f17c4d164585a48fb9f0d40b90a7d3b975c7ab8
2014-06-11 02:44:48 +00:00
Timo Tijhof
c0b0a12eab RCFeed: Use named types instead of exposing internal MW constant
Like we do in ApiQueryRecentChanges as well, expose the named
rc.type property, not the internal integer constants.

Change-Id: I89a948eee999032bb2e42cc23345affa879afb42
2014-06-04 04:55:02 +00:00
Kunal Mehta
8e980dfbf5 Allow more flexibility in RC feeds
The user can now specify which feeds to send to in
RecentChange::notifyFeeds if they don't want to use
$wgRCFeeds.

Additionally, the 'formatter' in $wgRCFeeds can now be an object
rather than just a class name.

Change-Id: Ibfdffc17a934e35223887c123331795563102752
2014-05-26 19:27:54 -07:00
aude
e0536cae6f Add method to determine EnhancedChangesList cache grouping key
Change-Id: Iaf3734baa53b71affca77d5243a579cc70bb522b
2014-05-21 13:28:13 +00:00
kishanio
b7cc86cdc0 Move ApiQueryRecentChanges::parseRCType to static method on RecentChange
Prior parseRCType was an private method in includes/api/ApiQueryRecentChanges and also
duplicated in includes/api/ApiQueryWatchList. This method has been made static and moved
to includes/changes/RecentChange.php.

Bug: 65071
Change-Id: Ic911fbcf9411c782685c4f956f8522051f2517f0
2014-05-17 15:07:01 +00:00
Nemo bis
ccd7758c1e Extend AbortEmailNotification hook to access log type etc.
Bug: 42458
Change-Id: Ifc3935f031c49f9b49ae76c5a8af8334e70ca2b1
2014-05-11 09:39:14 +00:00
withoutaname
866f478dc9 Append redirect=no to RecentChanges/Watchlist redirect entries
This change adds redirect=no in the URL of redirect entries in the RecentChanges or in the Watchlist.
Entries which are not redirects will not be affected.
Some typos in documentation were also fixed.

Bug: 890
Change-Id: I79593811d92b2f57abd742c8ba9e66769d8bc9b7
2014-04-28 18:11:13 -07:00
Bartosz Dziewoński
59002d8935 Consistently use '@deprecated since <version>'
Variants included 'in <version>', 'as of <version>' and just the
version number.

Some @deprecated annotations do not have the version number at all,
I want to hunt them down separately.

Change-Id: I8208c6097098f4735d4f51bc42254675f1f27f6d
2014-04-15 22:18:19 +02:00
umherirrender
9c614ac02d Fixed some @params documentation
Swapped some "$var type" to "type $var" or added missing types
before the $var. Changed some other types to match the more common
spelling. Makes beginning of some text in captial.

Change-Id: I8c9f30128b46086064326708a4878228ba459447
2014-04-14 19:52:18 +00:00
aude
7c4278f3f1 Split part of EnhancedChangesList::recentChangesLine into new method
Change-Id: I57f22ac0969fe3ba324a2b9d107c6f2d9968769c
2014-04-08 11:57:01 +00:00
Tyler Anthony Romeo
4211404e02 Added more filter options to $wgRCFeeds
Changed RecentChange::notifyRCFeeds() to allow more
filter options than just omit_bots. In order to mirror
the on-wiki Special:RecentChanges UI, the options
omit_anon, omit_user, omit_minor, omit_patrolled were added,
which omits anonymous, registered, minor, and patrolled
edits, respectively.

Bug: 60941
Change-Id: I716c741f1f7d42b6506a97e9a5733beac23ac16c
2014-04-07 23:36:36 +00:00
Erik Bernhardson
36a664643b New Hook rc/watchlist hook ChangesListInitRows
An extension hooking into recent changes may need to load additional
data that did not fit into the recentchanges table.  This hook gives
extensions an opportunity to see the full result prior to rendering
and batch load where approprite rather than loading piecemeal during
the render process.

This is implemented as an optional method called by the ChangesList
consumer, since the ChangesList never sees the full result set. Hook
implementers must be able to work regardless of the hook being called,
they just have the oportunity to be more efficient when it is called.

Change-Id: If74ae600ffba949364dd381dd3d466cbbaa27286
2014-04-01 09:38:16 -07:00
Siebrand
34c239655e Revert "New Hook rc/watchlist hook ChangesListBegin"
This reverts commit 01798c3813.

The patch set changed a RecentChanges interface used in at least the
extension CleanChanges so that it was generating a lot of warnings.
Additional parameters to existing methods that are used elsewhere
should have defaults to not break backward compatibility.

Change-Id: I1851e23e186ba7aaeb001ba212e56888657a3ae0
2014-03-26 14:08:40 +00:00
Erik Bernhardson
01798c3813 New Hook rc/watchlist hook ChangesListBegin
An extension hooking into recent changes may need to load additional
data that did not fit into the recentchanges table.  This hook gives
revisions an opportunity to see the full result prior to rendering
and batch load where approprite rather than loading piecemeal during
the render process.

Change-Id: I28d4e41437e485e518f2a23b6da00cdc430a8c23
2014-03-24 18:33:15 -07:00
jenkins-bot
9089232169 Merge "Method to identify if a ChangesList is watchlist or normal" 2014-03-18 13:08:59 +00:00
umherirrender
194e54b116 Fix variable name of param doc in RCCacheEntryFactory
Change-Id: I8039ab9ea117ba351061da71a92409e320d8eb84
2014-03-15 13:13:05 +00:00
Erik Bernhardson
1b8db29ed5 Method to identify if a ChangesList is watchlist or normal
There are differences, like grouping, between watchlist and
normal rendering that hook recipients need to know about.
This exposes if the setWatchlistDivs method has been called
which currently happens immediatly after instantiation in
SpecialWatchlist

Change-Id: Ibc06c6d9b878cad3f5da92cfbe3f650ad3f63efa
2014-03-13 10:35:56 -07:00
jenkins-bot
102076134f Merge "Add RCCacheEntryBuilder, split from EnhancedChangesList and cleaned up" 2014-03-12 16:40:28 +00:00
This, that and the other
6cbdf65b4f Add $wgLocalInterwikis to handle multiple local prefixes
This is akin to $wgSkipSkin/$wgSkipSkins. It is quite plausible for a wiki
to have more than one self prefix (e.g. enwiki has w: en: wikipedia: and
maybe others).

Some recent changes code seems to use $wgLocalInterwiki for quite unclear
purposes:
- I removed the line using $wgLocalInterwiki from the RecentChange
  class, as the 'lang' field of $mExtra is not used anywhere in core code.
  Extensions may use it, but it would seem more appropriate for them to
  use something like $wgDBname (or indeed to consult $wgLocalInterwikis
  directly) if they need to identify a particular wiki.
- In the IRC formatter, the first prefix in the array is used (if set).
  Appropriate documentation is added to DefaultSettings.php.

Related to bug 954 comment 3.

Bug: 954
Bug: 955
Change-Id: I9dbb566385b464402c5e78510b95dd2ffb4d9489
2014-03-12 13:32:07 +01:00
aude
1c6b7c7485 Add RCCacheEntryBuilder, split from EnhancedChangesList and cleaned up
This makes it more feasible for Wikibase, Flow, etc. to support
enhanced changes format, and allow better support for the rc_source
column in the future.

Change-Id: I873f6b86007000a94337f0c963df4bf8fec5b715
2014-03-12 11:23:49 +01:00
Erik Bernhardson
4029c76d25 Only generate date header when rendering is guaranteed
The OldChangesListRecentChangesLine hook can skip rendering of
a particular rc line.  If that line was the one that would have
added a new date header then no date header is output.  The
pushes checking for a new date header until after we know a
line will be output so none of the headers get lost.

Change-Id: I64ddd99c6af0b562802504b803563cf77fc2eb28
2014-03-03 14:37:19 -08:00
Siebrand Mazeland
f077c4b1d6 Update formatting
Change-Id: I18aff576262479c9bb1c56eb8e1d1aaae200e4b1
2014-02-06 09:27:05 +01:00
umherirrender
712cdc59af Remove outdated todo from RecentChange.php
Documentation was added with r85781

Change-Id: I769e2a340dee3e41a0b7b05fe856f54bd55a32e6
2014-02-01 11:44:37 +01:00
jenkins-bot
ddb03593a1 Merge "Changes list legend modules cleanup" 2014-01-24 00:55:23 +00:00
Reedy
896149ec79 Short circuit in notifyRCFeeds
Save instantiating classes unnecesserily

Add getEngine return type hint. Also make public

Change-Id: Ie2610516f99fe7b01742e7e95e13c4b1b90c77d7
2014-01-22 07:18:27 +00:00
Bartosz Dziewoński
2ec4ed4711 Changes list legend modules cleanup
The legend is not part of the ChangesList itself, but a part of the
ChangesListSpecialPage; move around modules and calls appropriately.

Followup to I02f2ced4.

Change-Id: I2c8922135404aab1960158cee06e2d8d07a1ace7
2014-01-16 19:26:43 +01:00
Brad Jorsch
8bbf41ec84 SECURITY: Fix RevDel log entry information leaks
DELETED_ACTION is supposed to hide the target of the log entry. But a
few places weren't doing this properly.

This fixes:
* API list=logevents no longer returns the pageid when the target is
  hidden.
* Enhanced RecentChanges no longer includes the log target page in the
  CSS class. This should also make the CSS class actually useful.
* Watchlist no longer shows log entries with DELETED_ACTION unless the
  user has deletedhistory, and with SUPPRESSED_ACTION unless the user
  has suppressrevision.

Bug: 58699
Change-Id: I57f13bfc970a33ffd5a399ffb450d9ed0b77902f
2014-01-13 22:20:09 -08:00
Siebrand Mazeland
84e69f75b3 Various fixes for EnhancedChangesList
* Document class property type
* Update documentation and doc formatting
* Ensure variables are defined

Change-Id: I0c7db08d27ac807e989b626c36e72ae52be85d52
2013-12-30 17:48:14 +01:00
Bartosz Dziewoński
f2e55d1273 Rename SpecialRecentchangeslinked class to SpecialRecentChangesLinked
For consistency with SpecialRecentChanges.

This introduces no incompatibilities as PHP classes are case-insensitive.

Change-Id: I5855074deed52fd7492f033c8a8fced8af647602
2013-12-18 20:00:34 +00:00
Bartosz Dziewoński
a9e0c52c06 Make legend on Special:RecentChanges and Special:Watchlist collapsible
Some of the code added here is duplicated, redundant or would be
better off placed somewhere else. I know about this, but this is not
the time to fix that (and nobody would review such patches anyway…).

Bug: 52005
Change-Id: I02f2ced42f33649b6c972d35a4739372ca265e10
2013-12-18 17:40:03 +01:00
Bartosz Dziewoński
48cc8109c8 Wrap changes lists in <div class="mw-changeslist" />
This affects Watchlist, RecentChanges and RecentChangesLinked.

A <div class="mw-changeslist-empty" /> is already used on all of these
when the list isn't generated (somewhat inconsistently coded, though).

Bug: 8844
Change-Id: I1ab2a54e22f318713c2211d63b29c184751a3589
2013-11-26 23:13:51 +01:00
aude
322ecffcd1 Create cachedEntry after processing change block
Change-Id: I8b6b85104f15eb8325abace9b0a0653e16d748b9
2013-11-26 12:37:38 +01:00
aude
8f22e5eda0 Get date in EnhancedChangesList::recentChangesLine from baseRC
$cachedEntry gets set with baseRC, so baseRC timestamp is the
same as $cachedEntry timestamp.

Doing things this way makes it more feasible to split out some
of the change formatting code.

Change-Id: I1cae6174c827802d525bb95ed152c64008ce7360
2013-11-26 11:39:59 +01:00
jenkins-bot
166bba1443 Merge "EnhancedChangesList: Add missing </td></tr>" 2013-11-23 20:25:25 +00:00
jenkins-bot
276a5e4197 Merge "Add $counter which was defined dynamically" 2013-11-19 20:52:35 +00:00
jenkins-bot
2a57a1e986 Merge "Declare visibility on class properties of RCCacheEntry" 2013-11-19 20:04:49 +00:00
Siebrand Mazeland
8b2fa84356 Add $counter which was defined dynamically
Used in SpecialRecentChanges, ChangesList and SpecialWatchlist to keep
track of line numbers for RC list entries.

Change-Id: Ib0e76a325c36a5c019db8d55c150e3bf3bf1d19b
2013-11-19 20:56:18 +01:00
jenkins-bot
95dbbcf0d5 Merge "Declare visibility on class properties of RecentChange" 2013-11-19 19:53:15 +00:00
jenkins-bot
003e7e34da Merge "Various fixes for ChangesList" 2013-11-19 19:42:16 +00:00
jenkins-bot
cd07334e1e Merge "Update documentation for OldChangesList" 2013-11-19 19:32:09 +00:00
Bartosz Dziewoński
7a98f64b84 EnhancedChangesList: Add missing </td></tr>
Add closing </td></tr> tags for "title" of changes list row.

Change-Id: I5500b23bf35f302f0410b6fca3e4d02c490752f9
2013-11-19 20:09:00 +01:00
Siebrand Mazeland
14057d6e51 Declare visibility on class properties of RecentChange
All are referenced directly outside inheritence; declare all public.
Removed unused $mMovedToTitle.

Change-Id: I3ba8f377e1a1082d3a2bb4b043e10bc351c0b5dd
2013-11-19 12:45:14 +00:00
Siebrand Mazeland
8a0eb6de15 Various fixes for ChangesList
* Define dynamic class properties
* Update documentation and doc formatting
* Ensure variables are defined

Change-Id: I309affea9a8e8cfa24bd8fe694a16bf79d6f2419
2013-11-19 12:44:15 +00:00
Siebrand Mazeland
32e4fa931f Update documentation for OldChangesList
Change-Id: Ied9ec5219ff7b458a69c6d989b813dffa1583cd3
2013-11-19 12:43:28 +00:00
Siebrand Mazeland
df28a0043d Various fixes for RecentChange
* Do not return the value of a function that returns void
* Update documentation

Change-Id: I2b25bf34f578be516a19c84d45860ab6c7f93e0e
2013-11-19 12:43:02 +00:00
Siebrand Mazeland
c85e4668aa Declare visibility on class properties of RCCacheEntry
All are referenced directly outside inheritence; declare all public.
Removed unused $secureName and $versionlink.

Change-Id: If491d0f1cbf4d53692e0ecfd0e1df1f4c3761ca6
2013-11-19 09:46:46 +01:00
Siebrand Mazeland
0470a55b77 Update formatting
Change-Id: I7586c4d50f7332c515b8377749c4250cc9e04d83
2013-11-19 06:32:18 +00:00
Siebrand Mazeland
511d594bf6 Address CodeSniffer errors and warnings
Change-Id: Ie119db7d6d9e9eb3c1cd9c07b8f84fd155847c62
2013-11-19 06:28:51 +01:00
umherirrender
974562aee9 Remove recentchanges.rc_cur_time from sql statements
Field is unused since many versions, so remove the use in sql
statements, to allow dropping in a later version.

The field must not be reference from INSERT because it has a default
value, which is used, when no value is specified in the statement.

Keeping the field allows easier rollback on version update, when
something gets wrong with the new version.

Existing Comment in tables.sql was added with r101293, was already
disused in r11088

Bug: 40667
Change-Id: I4a9c2fa813d1f25dfb755e564f7677a212934d7b
2013-11-09 18:20:54 +01:00
jenkins-bot
fcf8c469ea Merge "Improve variable naming in EnhancedChangesList" 2013-11-08 15:57:52 +00:00