* This avoids excess contention where inserts of rows for
similarly named files get blocked. This often would effect
users of UploadWizard or any bot doing mass uploads.
Change-Id: Ie7a328f7d4f03aa249770804417347a50356ea42
* Fixed bug where even using Swift/Azure on Windows
would disallow non-ASCII file names.
bug: 1780
Change-Id: I19ed72da0b099d35cae74fb08eeb22c113da1065
Swapped some "$var type" to "type $var" or added missing types
before the $var. Changed some other types to match the more common
spelling. Makes beginning of some text in captial.
Also added some missing @param.
Change-Id: I8804ebe0922d3a414863b162a2110e0b9e49b80f
Changed closure to capital word Closure in doc and type hint,
also changed callback in docs to callable
Change-Id: I52c8e8f13d38a837052101c38b9986be780ca057
* The preloadFileStat() call acts as a good canary for whether all
affected servers are up. If anything failed in it, then it's not
worth bothering to send the actual write requests.
* Also made FileBackend::preloadFileStat abstract while at it since
the two subclasses implemented it and so should any others.
* Fixed a silly comment typo.
Change-Id: I5bd427f654aa4a9d6bfe4ed7566276e8ac520b30
* Let "latest" stat entries override non "latest" so
that future getFileStat() calls with the "latest" flag
can actually have a cache hit.
Change-Id: I1e9391039537d608b89773b4d51575e3b364a751
- Added spaces after if/foreach/catch
- Added new line before end of file
- Added or removed spaces before/after parenthesis, comma
- Added spaces around string concat
Change-Id: I0590070f1b3542108e242730e8d9a3ba9831e94f
* Make sure that global backends do not prefix the cache keys
with local wiki IDs for container and file stat entries.
This causes fragmentation and breaks invalidation.
Change-Id: Ic02d6e41f828dc82cc07c7d24c8af29c46392a9c
* This adds a new preloadFileStat() method to FileBackend.
* FileBackend::doOperations() makes use of this instead of primeFileCache().
The later was mostly useless due to the 'latest' flag, which stat entries
rarely had (and since they use add(), 'latest' ones do not override the
non-'latest' ones).
* Simplified primeContainerCache/primeFileCache to no longer accept
FileOp objects and made sure nothing passes those in anymore.
Change-Id: Iee3878cadd69c3a594c701c0aff81aab5f473de5
* Fixed bug where operations that failed after precheck() would
not properly update the Status. This could cause failed ops to
be treated as successful.
* Removed special casing for 1-sized batches, this was mostly
for Swift and is irrelevant after it was rewritten.
* Removed unused return value and fixed the docs
bug: 60318
Change-Id: I7f12ebf711bc196313745f943070f8bdb6335964
Correct the behavior of SwiftFileBackend::addMissingMetadata to match
the documentation and calling code expectations by always returning an
array.
Bug: 60477
Change-Id: I8d12888a6ebfa23502f8cf3a28866dcb00a18ec8
* The API behavior is not well-documented in that it wants the HMAC
to use the unencoded object name. CloudFiles had this same issue.
bug: 59894
Change-Id: I3f0c80eed55991bb85d0c12f98927efa19af6760
