Commit graph

18 commits

Author SHA1 Message Date
Aaron Schulz
334e8f8f9d Remove $wgEnotifUseJobQ
Always treat this as on and simplify the code.
This will also make it easier to move updateWatchlistTimestamp() into
the EnotifNotifyJob class to avoid query timeouts.

Change-Id: I8ceaa42cdcfe3ad00a26368be6a73052be329045
2016-01-29 12:24:16 -08:00
saper
f415a29a15 $wgUsersNotifiedOnAllChanges should not send mail twice
Also make sure that normal watchlist functionality
works for the $wgUsersNotifiedOnAllChanges, for
example changes should marked 'bold' since last visit.

Bug: T69041
Change-Id: I7d53f07ed3dceb5b1c541091fd69beca3fb3e94f
2015-12-14 01:11:05 +00:00
addshore
06b3acc333 Of course EmailNotification::updateWatchlistTimestamp returns users ids
Change-Id: I04b2a8f97527c2bcd3f993b60e4100915b7f4c18
2015-10-13 17:30:04 +01:00
Siebrand Mazeland
6f1db0e3c9 Fix PHPCS warnings in /includes/mail/
Change-Id: Iea420ddecac86ef9a6f34b420b0cd151ba604e91
2015-09-28 13:47:16 +02:00
Kunal Mehta
4e09a3e903 Set 'List-Help' header for watchlist emails
Added an option to UserMailer::sendMail() to allow adding arbitrary
headers to emails.

Bug: T58315
Change-Id: I01a60430bf39f6bd104269b7246767f016eb9cd5
2015-08-19 09:37:45 +00:00
jenkins-bot
02f609e068 Merge "Don't send email notifs to blocked users if $wgBlockDisablesLogin is true" 2015-08-13 16:44:05 +00:00
Kunal Mehta
c8ac9622ea Clean up UserMailer::send() parameters
$replyto and $contentType should now be passed as an array of $options.
This will make it easier to add more options in the future without
having a long list of optional parameters.

Change-Id: I2c38bb438bd01e0ed2552024a40311f3e8e2dc08
2015-07-20 21:34:44 -07:00
Matthew Flaschen
40761e9ee7 Fix inaccurate documentation re $wgEnotifMinorEdits
In actuallyNotifyOnPageChange, the $wgEnotifUserTalk is inside
a check involving $wgEnotifMinorEdits, so it won't fire if
it's a minor edit and $wgEnotifMinorEdits is false.

Change-Id: I6576cb1735db5d9288257e6877b8755450d0dacd
2015-07-08 20:30:17 -04:00
Glaisher
32359cca9a Don't send email notifs to blocked users if $wgBlockDisablesLogin is true
Previously, private data could be leaked on private wikis where
this configuration is common. To prevent this, do not send email
notifications on page changes for blocked watchers and blocked
talk page owners if $wgBlockDisablesLogin is true.

Bug: T54453
Change-Id: I17408e1038ae10ee01eab747591ef2d9c86b106e
2015-06-16 09:52:49 +00:00
jenkins-bot
34ebdaff86 Merge "wl_notificationtimestamp code comments typo, false statement" 2015-06-03 13:37:33 +00:00
Federico Leva
17b05db14c wl_notificationtimestamp code comments typo, false statement
The timestamp is updated earlier.

Change-Id: I5c40affc346b85fa5350c381ee3f93c86b26d454
2015-06-02 10:23:24 -06:00
Aaron Schulz
a17cdcbf5b Use lazyPush() instead of push() in a few places for jobs
Change-Id: I56661ea29988e4ee217a63f4c3ffcb78333cc454
2015-05-18 10:31:24 -07:00
Ricordisamoa
2ae155da52 Fix phpcs errors in includes/
Mostly Squiz.WhiteSpace.SuperfluousWhitespace.EmptyLines

Change-Id: I678b2f0902f11cd1dfa1611b9da24e7237df9122
2015-01-08 20:15:07 +01:00
Chad Horohoe
aa21e125a3 Remove obvious function-level profiling
Xhprof generates this data now. Custom profiling of various
sub-function units are kept.

Calls to profiler represented about 3% of page execution
time on Special:BlankPage (1.5% in/out); after this change
it's down to about 0.98% of page execution time.

Change-Id: Id9a1dc9d8f80bbd52e42226b724a1e1213d07af7
2015-01-07 11:14:24 -08:00
Aaron Schulz
e369f66d00 Replace wfRunHooks calls with direct Hooks::run calls
* This avoids the overhead of an extra function call

Change-Id: I8ee996f237fd111873ab51965bded3d91e61e4dd
2014-12-10 12:26:59 -08:00
Erik Bernhardson
3069453eb3 Move EmailNotification watchlist handling into helper method
Pulls one pure method with no state from EmailNotification into a 
public static method.  This is done so that extensions (Flow, maybe
others) can replace the Email notifications with alternative ones (Echo)
while still updating the watchlist.

A better solution might be to extricate watchlist update from email
notifications, but this seems like a reasonable first step.

Bug: 66876
Change-Id: Iae213b87706c447b880244711e7747954423bb69
2014-09-18 13:55:31 +00:00
Kunal Mehta
eab5a7d6ef Add MailAddress::newFromUser()
And tests!

Change-Id: I5214c50855f6bc756f6d748e435ae2124b2264c1
2014-09-14 19:03:18 +00:00
Kunal Mehta
bf8810d6bc Split UserMailer.php into includes/mail/
Change-Id: Ic435bbdbb690028a5d34e8176522fcf4aa44fa92
2014-09-14 19:03:03 +00:00
Renamed from includes/UserMailer.php (Browse further)