* Update extensions/AbuseFilter from branch 'REL1_43'
to f16f3d042e37223141df777b7f22ade857cd3c80
- Protected variables logging: Only compute protected variable values
Why:
* To log when a user views the value of a protected variable,
the AbuseFilter code needs to determine if the value of those
protected variables are not null and the variable is set.
** To do this we need to compute all protected variable values
even if the values are lazily loaded.
** However, the code that does this also loads all other lazily
loaded variables.
* Loading all the lazily loaded variables causes expensive
variables to be loaded even if they are not used.
** This causes noticeable issues when testing filter conditions
against a set of recent actions.
* Instead of computing all lazily loaded variables, the code only
needs to compute lazily protected variables.
** In some cases we can also not load any variable values, because
the code was only looking for the list of defined variables
and not their values.
What:
* Update CheckMatch, SpecialAbuseLog, AbuseFIlterViewExamine,
and AbuseFilterViewTestBatch to not compute all lazily loaded
variables via VariablesManager::dumpAllVars:
** In cases where it is possible, the ::dumpAllVars call is replaced
with a calls to VariableHolder to get the variables.
** In all other cases update the second argument to ::dumpAllVars
from `true` to the list of all protected variables.
Bug: T400673
Change-Id: I7136c61f4e4574de8ffde21076df1c6645a36f81
(cherry picked from commit 7d948eead42241aa6495bf2d0c3fc9b3c42aea72)
* Update skins/MinervaNeue from branch 'REL1_43'
to 8733e6bf633cbd2885fa6f6939e1c33910afa501
- Localisation updates from https://translatewiki.net.
Change-Id: I41f55538f80a11ce54804aaf7b46b060b79e0a34
* Update skins/Vector from branch 'REL1_43'
to 8258e3d519fefc2c36629ac15922c6a8a96ba1f0
- Localisation updates from https://translatewiki.net.
Change-Id: Icc39ca5e3cb377aaf1b074a41967da19213338c1
* Update extensions/TemplateData from branch 'REL1_43'
to ea4424ec99eff40d71149d04da65ca86376ac075
- Localisation updates from https://translatewiki.net.
Change-Id: Iebab15d3e6af1528589ab6dca393eb3dcc0503a2
* Update extensions/VisualEditor from branch 'REL1_43'
to 00fc695507fd01767be8ed91154fd2474c816b9b
- Localisation updates from https://translatewiki.net.
Change-Id: I40cafdac96d191eb018621f9a988d504c7671e8c
* Update extensions/WikiEditor from branch 'REL1_43'
to 6c5e81ad24aaaef6546229c4ef3f2988c1aa2f37
- Localisation updates from https://translatewiki.net.
Change-Id: If6049d29f370b7bb1de5ef0b2a77c8098a49e931
* Update extensions/SyntaxHighlight_GeSHi from branch 'REL1_43'
to 08a01c78dc284f02ece3c5f909857769664d0176
- Localisation updates from https://translatewiki.net.
Change-Id: I369de5f5329037f3007adf6f36a16350b2d1692e
* Update extensions/Scribunto from branch 'REL1_43'
to ea571ce91012ee211c02adfcb7fe7232565ee2e9
- Localisation updates from https://translatewiki.net.
Change-Id: Ifc597c5085c3cbead7aa2ef0d240a9b8ae1e7fdd
* Update extensions/ParserFunctions from branch 'REL1_43'
to f5aaf52e31bc79d5104d4186fdf79b5a90fdd00a
- Localisation updates from https://translatewiki.net.
Change-Id: Idfcbc038dfd4de1dcea33e25c86e1533c9fbb5e6
* Update extensions/Nuke from branch 'REL1_43'
to fc8661532e4f9c54c8f97c41e34b90c98e04614e
- Localisation updates from https://translatewiki.net.
Change-Id: I7f6507188400f36053beef75c38f925a9414aacb
* Update extensions/OATHAuth from branch 'REL1_43'
to 07812f4994641de8fdbaaf284356c2c7793f0df5
- Localisation updates from https://translatewiki.net.
Change-Id: Ib143d2789b2fc4808b51febbb2e27766eb4d2b2a
* Update extensions/Math from branch 'REL1_43'
to 3d0e697cde146880f429ed46fe0fe5a1fa8cce45
- Localisation updates from https://translatewiki.net.
Change-Id: If768b49ccc790472ceb3620945dc62bc82128d23
* Update extensions/InputBox from branch 'REL1_43'
to 1b0f0e91afed194a9f9479c61c142e669d17acdc
- Localisation updates from https://translatewiki.net.
Change-Id: Ibc315d69cabc7244022cef610f032acbaa618743
* Update extensions/DiscussionTools from branch 'REL1_43'
to 185036b0ab5150b4706c73ae583a6a1611d7c4a9
- Localisation updates from https://translatewiki.net.
Change-Id: I0a66b92cdebd59ce03b88cba0ff5b4f9dc12bf18
* Update extensions/Echo from branch 'REL1_43'
to c1b049e6e36d9cedd2f0b771b00131e722a55586
- Localisation updates from https://translatewiki.net.
Change-Id: I0a66b92cdebd59ce03b88cba0ff5b4f9dc12bf18
* Update extensions/CodeEditor from branch 'REL1_43'
to c7c4a0f8c31203139635d8fe7ed836e8bf62096b
- Localisation updates from https://translatewiki.net.
Change-Id: Ifb23df690981bda70adf504f149ce954e5d3942f
* Update extensions/ConfirmEdit from branch 'REL1_43'
to 845db6e7f68b11c96e347397f732837a3579a4f0
- Localisation updates from https://translatewiki.net.
Change-Id: I70a480c0d69ea60a6bd4e2e598958d74bf2986b6
* Update extensions/Cite from branch 'REL1_43'
to 9f098f6fd88476d28e43b39c6cd237f759c4b406
- Localisation updates from https://translatewiki.net.
Change-Id: Ie57039c07cf9954a0006a60261f544316bfdd3e7
* Update extensions/CategoryTree from branch 'REL1_43'
to 3194c7ae4d41972c45f07bdb2150864431c418ed
- Localisation updates from https://translatewiki.net.
Change-Id: I8535848e96de9f8b157e6140e4e1db06929f3fb3
* Update extensions/AbuseFilter from branch 'REL1_43'
to b77316f3518d94e4836d167542d3f416f9094601
- Localisation updates from https://translatewiki.net.
Change-Id: I4c65dc26eeae26c190843d86a01167c6bd53ffe2
These requests are usually sent to a wiki operated by a different
organization so UA etiquette is important.
* Add the site's URL (the URL of the main page, more specifically)
as a contact address.
* Add the site's URL as a referer as well.
Considered but not done:
* Use $wgEmergencyContact as the contact part of the UA. It's not
guaranteed to be set correctly, while the main page URL always
exists and will usually be enough to pinpoint the wiki (except
maybe in some intranet scenarios).
* Include information about the user making the request. Would
be a privacy risk + probably useless due to caching.
* Include information about the page the request is for. Would
require lots of refactoring (making the patch harder to
backport) or relying on the context title (which might be
fragile), and in any case probably unreliable due to caching,
and doesn't seem very relevant to the operator of the foreign
site.
Bug: T400881
Change-Id: I968fac6ee0ebbc5a2bd3244f57851eb64125c93d
Running "SELECT @@GLOBAL.read_only" on MariaDB 12.0.2 returns "OFF"
instead of "0", which appears as "true" when cast to boolean in PHP. We
fix that by adding a specific check.
Discord thread where the bug is discussed:
https://discord.com/channels/178359708581625856/1404036592527741049
JIRA ticket in MariaDB: https://jira.mariadb.org/browse/MDEV-37429
Bug: T401570
Change-Id: Ifb04e8b7d04403b6f3dd8517c20c9c0070bd57ac
(cherry picked from commit 54d2416fbcb3a7d0e2a197ca58a755134bd18866)
* Update skins/Vector from branch 'REL1_43'
to c193424bc8894fa80964c47deb6bfe990d5f7dc6
- Localisation updates from https://translatewiki.net.
Change-Id: Ic9a07a46d989a98a23ed8f096033267ada9bf873
* Update skins/MonoBook from branch 'REL1_43'
to c23ebf1470dfbae311c2b5b1df0b68cc612692c3
- Localisation updates from https://translatewiki.net.
Change-Id: Iec38c68efea56a87ce5835fe2682caac7b99b46a
* Update skins/MinervaNeue from branch 'REL1_43'
to 1a30ba7bcd342534b8de9c3105212fca5f9fbc93
- Localisation updates from https://translatewiki.net.
Change-Id: Iec38c68efea56a87ce5835fe2682caac7b99b46a
* Update extensions/VisualEditor from branch 'REL1_43'
to 483821613a584fc78e4a9abffebce53d9905b564
- Localisation updates from https://translatewiki.net.
Change-Id: I73fb417d5f7f14e90c8d7a1081d7cc982cc9d9f1
* Update extensions/WikiEditor from branch 'REL1_43'
to 668a9ae0d567d28ab82533f63e9107d89e289421
- Localisation updates from https://translatewiki.net.
Change-Id: Ibd99d922aa275f6882ea88705c2a411f03cc7905
* Update extensions/TitleBlacklist from branch 'REL1_43'
to f4860fe5efbf5fab7260dc2af1490ca9ecbe2aeb
- Localisation updates from https://translatewiki.net.
Change-Id: I46c410f4332864f03c506f05abbb64376527ee02
* Update extensions/Thanks from branch 'REL1_43'
to b2baee710a3e7d2b9b28b78cade4077348537a2e
- Localisation updates from https://translatewiki.net.
Change-Id: Ib3cc2ac8bf0c109f5dff6c74d28f553fdfa8611a
* Update extensions/TextExtracts from branch 'REL1_43'
to 273dcfbace0a1b018876adaf4294a541972dc5cd
- Localisation updates from https://translatewiki.net.
Change-Id: I65a20a2def398fad69dfab6c3694a0b7f5426898
* Update extensions/TemplateData from branch 'REL1_43'
to edb9922eebbb743fbcafee80e0e03a05f38e3e87
- Localisation updates from https://translatewiki.net.
Change-Id: Ia7bafadfe4277d0abc185153ec3d3df3ce5d8596
* Update extensions/SpamBlacklist from branch 'REL1_43'
to b293eb55c6a0a2ac73759741ede7acc5bc5dad1b
- Localisation updates from https://translatewiki.net.
Change-Id: I88aaf1b4056c1ff2b11242e70b6ab8ca589118b4
* Update extensions/PageImages from branch 'REL1_43'
to 36794241028ff2cdb43476d453516bb486923391
- Localisation updates from https://translatewiki.net.
Change-Id: I8a34e8702c66cd926e8e728a05eb7a3eaa6b8476
* Update extensions/Nuke from branch 'REL1_43'
to 5b372fccf7581e6f9d88f1407ce29307e5593f0d
- Localisation updates from https://translatewiki.net.
Change-Id: If9327498288aabb96ac18becebd9ec38e80a0985
* Update extensions/MultimediaViewer from branch 'REL1_43'
to fa281f47e698dccb53243d33f045c597ed64d859
- Localisation updates from https://translatewiki.net.
Change-Id: Ide820d64b8cc690837e0f28782e2df33a32a9c22
* Update extensions/Math from branch 'REL1_43'
to bc019b90ce63820660fc2eca7c3fe2499b694b05
- Localisation updates from https://translatewiki.net.
Change-Id: I1294f32370d3a577c46cf59f2640d49c8e9dc8fe
* Update extensions/Linter from branch 'REL1_43'
to 82a282ffa2a98d25d79e7486c9139d82ab2eb7a7
- Localisation updates from https://translatewiki.net.
Change-Id: I3ae55ea74d723962ca1e32938388a90bfdaaafcc
* Update extensions/LoginNotify from branch 'REL1_43'
to 6ead73513e28511b296ae55f08ca785457eba89e
- Localisation updates from https://translatewiki.net.
Change-Id: I3ae55ea74d723962ca1e32938388a90bfdaaafcc
* Update extensions/ImageMap from branch 'REL1_43'
to 757a82efee9be763aa053651658a188ba3c00aa1
- Localisation updates from https://translatewiki.net.
Change-Id: I591bbc01f5f9a2e1b1052bf2a22f8cb1dbade79c
* Update extensions/Gadgets from branch 'REL1_43'
to 622e41b45e5beca3d8884d23ec165294af1a24b2
- Localisation updates from https://translatewiki.net.
Change-Id: Icd01c578c7472ec759cd84659160c7f88321b946
* Update extensions/Echo from branch 'REL1_43'
to ca7be2cf530b895c306d0530b9d1df79c7ed3660
- Localisation updates from https://translatewiki.net.
Change-Id: I372d0f8514ebfe0d0bc990b70680f7f5c9617f2e
* Update extensions/DiscussionTools from branch 'REL1_43'
to 5f59dc1c68462afa5beb6673d04047d4633230f1
- Localisation updates from https://translatewiki.net.
Change-Id: I48944ca863a7cc67300fef4bcd2d4cfb82b53e87
* Update extensions/ConfirmEdit from branch 'REL1_43'
to 16cd01f1191ba75a36647a11e2c37413110db5d3
- Localisation updates from https://translatewiki.net.
Change-Id: I4c8dcca0496849673a8abfe894b7ac2e8f4d8aad
* Update extensions/CodeEditor from branch 'REL1_43'
to 0ca5fa45f54d4ca75af1fb1a43defcee8b0ff304
- Localisation updates from https://translatewiki.net.
Change-Id: Ic0ca86dcfb7b26b1d01c22e7d7266c4e6e882a36
* Update extensions/CiteThisPage from branch 'REL1_43'
to bb1d9e36549a4eca7144c97ff330da29b9de2138
- Localisation updates from https://translatewiki.net.
Change-Id: Ic1be9d95a37cb4bf1a8ce0a486317c4edf7784ec
* Update extensions/CategoryTree from branch 'REL1_43'
to a3ef6648eae994b79c7eb468140b01b83314439e
- Localisation updates from https://translatewiki.net.
Change-Id: I055844035b00f2b2a7c0ad9295ae3f9345eb55d9
* Update extensions/Cite from branch 'REL1_43'
to 94035f6b6efa7a7c81a63ee2dbca7b280c58aff6
- Localisation updates from https://translatewiki.net.
Change-Id: Ic1be9d95a37cb4bf1a8ce0a486317c4edf7784ec
* Update extensions/AbuseFilter from branch 'REL1_43'
to 9d8147a7c167a32f28204c1e7beb9dcf94d00225
- Localisation updates from https://translatewiki.net.
Change-Id: Ic04a4739f8a942f6b89992f0c6f39ef8952e6785