Commit graph

42 commits

Author SHA1 Message Date
Jack Phoenix
231a00ffcc *coding style cleanup
*marked public functions as such in memcached-client.php
2009-12-13 17:57:21 +00:00
Jure Kajzer
17821ff2f1 Fixed parserTests to work with Oracle (added Anonymous user 0 to fix FK violations). Fixed a few bugs identified by parserTests fails. 2009-11-09 14:34:03 +00:00
Tim Starling
562a5e393b No it is not a FIFO, what's your point? 2009-03-17 08:37:25 +00:00
Aaron Schulz
2626ac372d Add gripe about FIFO and random row selection 2009-02-16 18:06:04 +00:00
Domas Mituzas
6cc115e45b add some useless WHERE condition instead of 'Job::pop' :) 2008-08-04 05:07:53 +00:00
Domas Mituzas
ccb3f4b198 don't limit random range, no need, and not efficient 2008-07-29 09:51:02 +00:00
Tim Starling
5ad5cb4f0a * (bug 4578) Automatically fix redirects broken by a page move. Works via the job queue, controllable by a checkbox on Special:Movepage.
* Renamed some excessively short variables in SpecialMovepage.php
* Allow $wgReservedUsernames to be localised using "msg:..." syntax
2008-07-22 22:44:34 +00:00
Alexandre Emsenhuber
087a9f70c5 WARNING: HUGE COMMIT
Doxygen documentation update:
* Changed alls @addtogroup to @ingroup. @addtogroup adds the comment to the group description, but doesn't add the file, class, function, ... to the group like @ingroup does. See for example http://svn.wikimedia.org/doc/group__SpecialPage.html where it's impossible to see related files, classes, ... that should belong to that group.
* Added @file to file description, it seems that it should be explicitely decalred for file descriptions, otherwise doxygen will think that the comment document the first class, variabled, function, ... that is in that file.
* Removed some empty comments
* Removed some ?>

Added following groups:
* ExternalStorage
* JobQueue
* MaintenanceLanguage

One more thing: there are still a lot of warnings when generating the doc.
2008-05-20 17:13:28 +00:00
Siebrand Mazeland
79d5225c0e * remove end of line whitespace
* remove empty lines at end of file
* remove "?>" where still present
2008-04-14 07:45:50 +00:00
Tim Starling
353f203ce2 WARNING! NEEDS CAREFUL DEPLOYMENT
* Bug 9213: Fixed the plainly broken user_newtalk updating and caching scheme. I tried to keep my changes roughly performance-neutral, but the update on Wikimedia should be watched carefully for performance problems.
* Made UserMailer a class, use the autoloader to load it
* General UserMailer refactoring
* If the user has email-on-newtalk enabled, send them an email for every change, not just the first one before they view the page again.
* Don't add a watchlist entry automatically on change of user talk page
2007-10-03 08:46:17 +00:00
Aryeh Gregor
a15c419b3d Remove ?>'s from files. They're pointless, and just asking for people to mess with the files and add trailing whitespace. (Yes, I looked over every one and reverted those that were bogus. Slash-enter a million times in less worked well enough, although it was a bit mind-numbing.) 2007-06-29 01:19:14 +00:00
Rob Church
b6b52063ec Some job cleanup:
* Move Jobs left in JobQueue.php to their own file
* Ditch $wgCustomJobs in favour of $wgJobClasses, which acts as a dictionary and allows extensions to add custom jobs
* Standardise Job derivative constructors and update everywhere
* Make sure all overriding implementations of Job::run() return true to avoid bogus "Error" report in runJobs.php
2007-06-21 19:11:24 +00:00
Rob Church
1dce23fce7 Remove errant return, breaks switch statement for 'htmlCacheUpdate' jobs 2007-06-21 14:21:44 +00:00
Aaron Schulz
b8cd62a858 *Add $wgCustomJobs for adding functions/subclasses to jobqueue 2007-06-21 14:12:50 +00:00
River Tarnell
a6f6e04841 instead of storing every mail as a job, have a job to send enotif updates for the whole mail at once. 2007-05-11 16:42:18 +00:00
River Tarnell
6f53fc41af runJobs should have a way to only run certain types of job 2007-05-11 07:36:05 +00:00
River Tarnell
848d8f4611 allow enotif mails to be sent via job queue 2007-05-05 12:44:55 +00:00
Antoine Musso
9c8da6b486 * Comments
* Abstract methods at the top
* Move a static function in the static part
2007-04-21 12:33:41 +00:00
Nick Jenkins
113bb1c772 Documentation tweaks to help documentation systems (Doxygen + PHPDocumentor)
pick up the appropriate tags, and documentation blobs for classes. This is 
the same as per r20769, but with the grouping changes (e.g. removing "@{{") omitted.
Please be advised that more related documentation tweaks may follow later - e.g. 
Doxygen generates a log file of warnings that is 574 Kb in size, when run over 
the just the trunk/phase3 code ... eek! Thankfully, much of that is just 
whining about functions without documentation   ;-)
2007-04-04 05:22:37 +00:00
Brion Vibber
3a6ac5a3c3 Revert r20769: we don't use PHPDocumentor anymore, we use doxygen.
If making mass changes to tweak to its preferences, probably better to do it for the tool we actually generate docs with. :)
2007-03-28 14:16:43 +00:00
Nick Jenkins
5fef2333d4 PHPDocumentor [http://en.wikipedia.org/wiki/PhpDocumentor] documentation tweaking stuff.
Minor doc tweaks to prevent some PHPDocumentor warnings or errors when run on the includes/ directory. PHPDocumentor uses a syntax very similar to javadoc - mostly we already use this, but there were a few scattered places that were adjusted to make them consistent with the rest of the code. In practical terms, these changes were made:
* @url becomes @link
* @fixme becomes @todo
* HTML tags in descriptions must be closed / balanced.
* @bug was removed (where the bug was long fixed), or changed into a @todo (in the few situations where the bug was still pending)
* @obsolete becomes @deprecated
* Things like "/**@{{" and "/**@}}*/" which cause "unknown tag" warnings were removed
* @access must be a valid access level.
* @desc tag not needed, removed.
* Doesn't seem to like @licence, will accept @license however.
* Use full comment block notation in a few places (i.e. open block with "/**", start each line with " *", and end block with " */")

Then additional to this, to get some class docs associated with their respective classes:
* Moved some docs to right above those classes (deleting blank lines, or moving descriptions from the file headers)
* Marked some classes without docs as "@todo document"
* (done up to "class MIMEsearchPage" on the "classtrees_MediaWiki.html" page for the includes/ directory)
2007-03-28 08:53:02 +00:00
Domas Mituzas
a0055ae2d9 oops 2007-03-25 20:09:21 +00:00
Domas Mituzas
f56fa12475 allow to specify offset at which to pop a Job.
needed for efficiency of really large sites (ok, single site :)
2007-03-25 15:55:39 +00:00
Nick Jenkins
f88c771756 The war on redundant ampersand usage!
* Convert "$dbw =& wfGetDB( DB_MASTER );" --> "$dbw = wfGetDB( DB_MASTER );"
* convert "$skin =& $wgUser->getSkin();" --> "$skin = $wgUser->getSkin();"

For the time being have not changed the function definitions of wfGetDB() or User::getSkin() [i.e. they are still both return-by-ref], so as to ensure the interface does not change for extensions [some of which may still be trying to run on PHP4 environments]. However presumably at some point this can be changed too.

Also includes tiny tweak to newlines in parserTests - will show 1 rather than 2 newlines between the "Reading tests from" strings when in quiet mode.
2007-01-22 23:50:42 +00:00
Tim Starling
ed7d87d98c As we say on Wikipedia, might it not have been easier to fix it, rather than complain about it? 2006-07-03 16:30:46 +00:00
Tim Starling
671e35cbb3 Fixed job command naming style 2006-06-19 02:29:21 +00:00
Tim Starling
0e2714b61d Added a new method to update the cache of all pages linking to a given page without using excessive time or memory. This turns out to be a common operation in MediaWiki, I needed to fix callers in a lot of files. Backwards compatibility is maintained (of course). Also did some cleanup in Article.php, another 3 years of that and it'll be looking pretty. New job type added to the job queue, some refactoring done in JobQueue.php to support it. 2006-06-18 12:42:16 +00:00
Rob Church
67ee817f0e (bug 6095) Introduce RunUnknownJob hook, see docs/hooks.txt for more information 2006-06-15 06:35:24 +00:00
Brion Vibber
d120efcea6 * (bug 5527) Batch up job queue insertions for, hopefully, better survivability
of lock contention etc. Duplicates are now removed at pop time instead of
  at insert time.
2006-05-31 23:56:41 +00:00
Antoine Musso
7ebdb6de89 Revert to r14165 . Did too many changes, didnt even run parserTests (i am bad) 2006-05-11 22:40:38 +00:00
Antoine Musso
bc14eb8045 Replacing var keyword with private / public as we now require PHP5. 2006-05-11 19:10:41 +00:00
Antoine Musso
473cd5cbcc unused variables as per #3692 2006-05-01 10:53:59 +00:00
Lupin
c7408b9223 trailing whitespace removal 2006-03-11 17:13:49 +00:00
Ævar Arnfjörð Bjarmason
6c5d3c8c6a * Adding a trailing ?> 2006-03-07 13:32:27 +00:00
Tim Starling
deada22846 profiling 2006-02-25 03:01:21 +00:00
Tim Starling
7098564cca Fixed SQL error, keep track of job_id 2006-02-25 01:38:06 +00:00
Tim Starling
5bed313c7f Avoid circular links updates 2006-02-25 01:31:07 +00:00
Tim Starling
174264806c Different pop method 2006-02-25 01:12:35 +00:00
Tim Starling
c9fb5e475d If there's a duplicate, don't delete and recreate, just leave it. 2006-02-25 00:29:15 +00:00
Tim Starling
7561eba197 The live immediateBegin hack didn't actually do anything, removing. 2006-02-24 23:51:01 +00:00
Domas Mituzas
89ae8b1d49 * live immediatebegin hack
* remove ORDER BY for pop operation, InnoDB sorts by PK anyway, MyISAM would work as 'pool' rather than 'stack',
  submited to http://bugs.mysql.com/bug.php?id=17711
2006-02-24 20:38:46 +00:00
Tim Starling
eeb84cce20 Added job table, for deferred processing of jobs. The immediate application is to complete the link table refresh operation when templates are changed. 2006-02-24 01:56:31 +00:00