Commit graph

83 commits

Author SHA1 Message Date
Matthias Mullie
fd64488787 Add hook EnhancedChangesList::getLogText
Enhanced RC generates these "(3 changes | history)" links for
every block of grouped recentchanges. That changes-link links
to a diff page.

For Flow, that is all wrong: we have different ids (not integers),
on a different page (&curid=&oldid=&diff= means nothing). Even
the concept of a "diff" page seems wrong here for us - a new post
is not part of some document that can be diffed.
In short: we'll want to generate a different link, and we'll need
a hook to let us change them.

Meanwhile also split the code that generates those links into a
separate method.

Bug: T72513
Change-Id: Ib32fb9552b80f9581d89b3b47da6e5d32e3d84a3
2015-03-03 01:50:32 +00:00
Aaron Schulz
99e6b43ab8 Moved RecentChange::purgeExpiredChanges to a job
* Also added a selectFieldValues helper method to the DB classes
  since this use case keeps coming up.

Change-Id: I62cdbb497dc2c8fe4758e756d13688b85165e869
2015-01-16 17:39:31 -08:00
Niklas Laxström
80ca508ed1 Add User::equals
Seems stupid omission. Title has one. Why do I need to think how
to determine how to users objects point to the same user. Allows
more expressive code.

Also fixes a bug in multiple places where users "0" and "00" were
considered equal.

Change-Id: I682392e564b332b77ab489f2ad394fa2d28098a5
2015-01-13 15:04:45 +01:00
Ricordisamoa
2ae155da52 Fix phpcs errors in includes/
Mostly Squiz.WhiteSpace.SuperfluousWhitespace.EmptyLines

Change-Id: I678b2f0902f11cd1dfa1611b9da24e7237df9122
2015-01-08 20:15:07 +01:00
Chad Horohoe
aa21e125a3 Remove obvious function-level profiling
Xhprof generates this data now. Custom profiling of various
sub-function units are kept.

Calls to profiler represented about 3% of page execution
time on Special:BlankPage (1.5% in/out); after this change
it's down to about 0.98% of page execution time.

Change-Id: Id9a1dc9d8f80bbd52e42226b724a1e1213d07af7
2015-01-07 11:14:24 -08:00
Reedy
4d9143c7f5 Add lots of @throws
Change-Id: I09d0c13070f966fcf23d2638d8fc1328279a5995
2014-12-24 13:49:20 +00:00
Aaron Schulz
e369f66d00 Replace wfRunHooks calls with direct Hooks::run calls
* This avoids the overhead of an extra function call

Change-Id: I8ee996f237fd111873ab51965bded3d91e61e4dd
2014-12-10 12:26:59 -08:00
umherirrender
c0151eec5f Fix case of various newFromID/newFromId functions
User::newFromID -> User::newFromId
Revision::newFromID -> Revision::newFromId
RecentChange::newFromID -> RecentChange::newFromId

WikiPage::newFromId -> WikiPage::newFromID
Title::newFromId -> Title::newFromID

Change-Id: I310f26653613951e9b21ce915a92d205a87937f1
2014-12-10 19:40:27 +00:00
Ricordisamoa
f86a5590aa Always use 'bool' instead of 'boolean' after '@param' and '@return'
The former is by far the most common.

Skipped:
* resources/lib/jquery.ui/jquery.ui.datepicker.js
* resources/src/mediawiki.special/mediawiki.special.upload.js

Change-Id: I73c93797e745128ba703e4865080c36784caa474
2014-12-10 11:57:31 +00:00
Chad Horohoe
6c30fff0ba Swap and for &&
Change-Id: I7821a62586cc2d2f929fb3d7d5046958a70efbd0
2014-10-23 13:03:14 -07:00
aude
9ec6c4967e Fix undefined argument in OldChangesList
Bug: 70407
Change-Id: I17bbaeaf7c9cae51e33c859867ef3a3199b68a43
2014-09-09 16:05:53 +02:00
jenkins-bot
00f9ce1105 Merge "Bound the cache size of numberofWatchingusers()" 2014-09-04 20:03:11 +00:00
Aaron Schulz
220d30f8f4 Bound the cache size of numberofWatchingusers()
Change-Id: I60c9898318e340ee3c97d24b528d85a5f8c492e5
2014-09-04 12:49:43 -07:00
jenkins-bot
af9c5d49fd Merge "Move actual OldChangesList line formatting to separate method" 2014-09-01 09:50:19 +00:00
aude
9ec0095e3d Move actual OldChangesList line formatting to separate method
Change-Id: I31100c79abc30460bd08eb50862b51a56b807fba
2014-08-28 13:36:26 +02:00
umherirrender
7c6a25856c Add missing @return to function docs
Change-Id: I45b9d02f94ecc58372268ec5e6a0b572a0b7e2a9
2014-08-23 23:14:57 +02:00
umherirrender
26e71dd640 Use getConfig for ChangesList
Change-Id: I1f440a2fca2dd8f1973987d635c70954938b6ea6
2014-08-22 22:01:08 +02:00
Bartosz Dziewoński
07aef8f753 Remove EnhancedChangesList::arrow() and friends
Not used in core, the only usage outside removed in Ieb5bb6f9.

Also removed two now-unused files from skins/common/.

Bug: 69675
Change-Id: Ia0e9fc2af25af903db085f2a05c04dcd9aff213e
2014-08-18 00:08:48 +02:00
jenkins-bot
ab972997ee Merge "Remove various functions and globals deprecated since 1.22 from RecentChange" 2014-08-14 18:06:35 +00:00
umherirrender
21e0c1c533 Correct variable names in @param to match method declarations
Some @param have a typo in the variable name,
some @param's were in wrong order.

Change-Id: Ie25806831027112b398f6f4a909c59147ac3a5fa
2014-08-13 21:48:28 +02:00
withoutaname
557b2cf3ef Remove various functions and globals deprecated since 1.22 from RecentChange
Change-Id: I5200892e75ffa894133e2e386d53c09536547de9
2014-08-12 22:19:36 -07:00
Tom Arrow
510da8d776 Remove unreachable return in ChangesList.php
Change-Id: Ic00d7b4eaebdaa795b550c4213c518b1c56bd297
2014-08-09 12:25:33 +00:00
umherirrender
02dc9da399 Cleanup some docs (includes/[a-d])
- Swap "$variable type" to "type $variable"
- Added missing types
- Fixed spacing inside docs
- Makes beginning of @param/@return/@var/@throws in capital
- Changed some types to match the more common spelling

Change-Id: I7b65fe04db431342cc58b469dc48f41a50c4e891
2014-07-24 19:42:45 +02:00
umherirrender
4ee680a8b3 Fixed spacing
- Removed spaces after not operator (!)
- Removed spaces inside array index
- use tab as indent instead of spaces
- Add newline at end of file
- Removed spaces after casts

Change-Id: I9ba17c4385fcb43d38998d45f89cf42952bc791b
2014-07-24 11:53:04 +02:00
withoutaname
2be66e38e2 Move ChangesFeed to includes/changes/ folder
Change-Id: I4ec541e8fe4234970972904592af2e11375e974d
2014-07-15 17:30:46 -07:00
JuneHyeon Bae
17ebbe492c Remove obsolete RC_MOVE and RC_MOVE_OVER_REDIRECT rc types
RC_MOVE and RC_MOVE_OVER_REDIRECT are obsolete, since at least 2006.
So it is considered safe to remove.

Bug: 63755
Change-Id: I0f17c4d164585a48fb9f0d40b90a7d3b975c7ab8
2014-06-11 02:44:48 +00:00
Timo Tijhof
c0b0a12eab RCFeed: Use named types instead of exposing internal MW constant
Like we do in ApiQueryRecentChanges as well, expose the named
rc.type property, not the internal integer constants.

Change-Id: I89a948eee999032bb2e42cc23345affa879afb42
2014-06-04 04:55:02 +00:00
Kunal Mehta
8e980dfbf5 Allow more flexibility in RC feeds
The user can now specify which feeds to send to in
RecentChange::notifyFeeds if they don't want to use
$wgRCFeeds.

Additionally, the 'formatter' in $wgRCFeeds can now be an object
rather than just a class name.

Change-Id: Ibfdffc17a934e35223887c123331795563102752
2014-05-26 19:27:54 -07:00
aude
e0536cae6f Add method to determine EnhancedChangesList cache grouping key
Change-Id: Iaf3734baa53b71affca77d5243a579cc70bb522b
2014-05-21 13:28:13 +00:00
kishanio
b7cc86cdc0 Move ApiQueryRecentChanges::parseRCType to static method on RecentChange
Prior parseRCType was an private method in includes/api/ApiQueryRecentChanges and also
duplicated in includes/api/ApiQueryWatchList. This method has been made static and moved
to includes/changes/RecentChange.php.

Bug: 65071
Change-Id: Ic911fbcf9411c782685c4f956f8522051f2517f0
2014-05-17 15:07:01 +00:00
Nemo bis
ccd7758c1e Extend AbortEmailNotification hook to access log type etc.
Bug: 42458
Change-Id: Ifc3935f031c49f9b49ae76c5a8af8334e70ca2b1
2014-05-11 09:39:14 +00:00
withoutaname
866f478dc9 Append redirect=no to RecentChanges/Watchlist redirect entries
This change adds redirect=no in the URL of redirect entries in the RecentChanges or in the Watchlist.
Entries which are not redirects will not be affected.
Some typos in documentation were also fixed.

Bug: 890
Change-Id: I79593811d92b2f57abd742c8ba9e66769d8bc9b7
2014-04-28 18:11:13 -07:00
Bartosz Dziewoński
59002d8935 Consistently use '@deprecated since <version>'
Variants included 'in <version>', 'as of <version>' and just the
version number.

Some @deprecated annotations do not have the version number at all,
I want to hunt them down separately.

Change-Id: I8208c6097098f4735d4f51bc42254675f1f27f6d
2014-04-15 22:18:19 +02:00
umherirrender
9c614ac02d Fixed some @params documentation
Swapped some "$var type" to "type $var" or added missing types
before the $var. Changed some other types to match the more common
spelling. Makes beginning of some text in captial.

Change-Id: I8c9f30128b46086064326708a4878228ba459447
2014-04-14 19:52:18 +00:00
aude
7c4278f3f1 Split part of EnhancedChangesList::recentChangesLine into new method
Change-Id: I57f22ac0969fe3ba324a2b9d107c6f2d9968769c
2014-04-08 11:57:01 +00:00
Tyler Anthony Romeo
4211404e02 Added more filter options to $wgRCFeeds
Changed RecentChange::notifyRCFeeds() to allow more
filter options than just omit_bots. In order to mirror
the on-wiki Special:RecentChanges UI, the options
omit_anon, omit_user, omit_minor, omit_patrolled were added,
which omits anonymous, registered, minor, and patrolled
edits, respectively.

Bug: 60941
Change-Id: I716c741f1f7d42b6506a97e9a5733beac23ac16c
2014-04-07 23:36:36 +00:00
Erik Bernhardson
36a664643b New Hook rc/watchlist hook ChangesListInitRows
An extension hooking into recent changes may need to load additional
data that did not fit into the recentchanges table.  This hook gives
extensions an opportunity to see the full result prior to rendering
and batch load where approprite rather than loading piecemeal during
the render process.

This is implemented as an optional method called by the ChangesList
consumer, since the ChangesList never sees the full result set. Hook
implementers must be able to work regardless of the hook being called,
they just have the oportunity to be more efficient when it is called.

Change-Id: If74ae600ffba949364dd381dd3d466cbbaa27286
2014-04-01 09:38:16 -07:00
Siebrand
34c239655e Revert "New Hook rc/watchlist hook ChangesListBegin"
This reverts commit 01798c3813.

The patch set changed a RecentChanges interface used in at least the
extension CleanChanges so that it was generating a lot of warnings.
Additional parameters to existing methods that are used elsewhere
should have defaults to not break backward compatibility.

Change-Id: I1851e23e186ba7aaeb001ba212e56888657a3ae0
2014-03-26 14:08:40 +00:00
Erik Bernhardson
01798c3813 New Hook rc/watchlist hook ChangesListBegin
An extension hooking into recent changes may need to load additional
data that did not fit into the recentchanges table.  This hook gives
revisions an opportunity to see the full result prior to rendering
and batch load where approprite rather than loading piecemeal during
the render process.

Change-Id: I28d4e41437e485e518f2a23b6da00cdc430a8c23
2014-03-24 18:33:15 -07:00
jenkins-bot
9089232169 Merge "Method to identify if a ChangesList is watchlist or normal" 2014-03-18 13:08:59 +00:00
umherirrender
194e54b116 Fix variable name of param doc in RCCacheEntryFactory
Change-Id: I8039ab9ea117ba351061da71a92409e320d8eb84
2014-03-15 13:13:05 +00:00
Erik Bernhardson
1b8db29ed5 Method to identify if a ChangesList is watchlist or normal
There are differences, like grouping, between watchlist and
normal rendering that hook recipients need to know about.
This exposes if the setWatchlistDivs method has been called
which currently happens immediatly after instantiation in
SpecialWatchlist

Change-Id: Ibc06c6d9b878cad3f5da92cfbe3f650ad3f63efa
2014-03-13 10:35:56 -07:00
jenkins-bot
102076134f Merge "Add RCCacheEntryBuilder, split from EnhancedChangesList and cleaned up" 2014-03-12 16:40:28 +00:00
This, that and the other
6cbdf65b4f Add $wgLocalInterwikis to handle multiple local prefixes
This is akin to $wgSkipSkin/$wgSkipSkins. It is quite plausible for a wiki
to have more than one self prefix (e.g. enwiki has w: en: wikipedia: and
maybe others).

Some recent changes code seems to use $wgLocalInterwiki for quite unclear
purposes:
- I removed the line using $wgLocalInterwiki from the RecentChange
  class, as the 'lang' field of $mExtra is not used anywhere in core code.
  Extensions may use it, but it would seem more appropriate for them to
  use something like $wgDBname (or indeed to consult $wgLocalInterwikis
  directly) if they need to identify a particular wiki.
- In the IRC formatter, the first prefix in the array is used (if set).
  Appropriate documentation is added to DefaultSettings.php.

Related to bug 954 comment 3.

Bug: 954
Bug: 955
Change-Id: I9dbb566385b464402c5e78510b95dd2ffb4d9489
2014-03-12 13:32:07 +01:00
aude
1c6b7c7485 Add RCCacheEntryBuilder, split from EnhancedChangesList and cleaned up
This makes it more feasible for Wikibase, Flow, etc. to support
enhanced changes format, and allow better support for the rc_source
column in the future.

Change-Id: I873f6b86007000a94337f0c963df4bf8fec5b715
2014-03-12 11:23:49 +01:00
Erik Bernhardson
4029c76d25 Only generate date header when rendering is guaranteed
The OldChangesListRecentChangesLine hook can skip rendering of
a particular rc line.  If that line was the one that would have
added a new date header then no date header is output.  The
pushes checking for a new date header until after we know a
line will be output so none of the headers get lost.

Change-Id: I64ddd99c6af0b562802504b803563cf77fc2eb28
2014-03-03 14:37:19 -08:00
Siebrand Mazeland
f077c4b1d6 Update formatting
Change-Id: I18aff576262479c9bb1c56eb8e1d1aaae200e4b1
2014-02-06 09:27:05 +01:00
umherirrender
712cdc59af Remove outdated todo from RecentChange.php
Documentation was added with r85781

Change-Id: I769e2a340dee3e41a0b7b05fe856f54bd55a32e6
2014-02-01 11:44:37 +01:00
jenkins-bot
ddb03593a1 Merge "Changes list legend modules cleanup" 2014-01-24 00:55:23 +00:00
Reedy
896149ec79 Short circuit in notifyRCFeeds
Save instantiating classes unnecesserily

Add getEngine return type hint. Also make public

Change-Id: Ie2610516f99fe7b01742e7e95e13c4b1b90c77d7
2014-01-22 07:18:27 +00:00