This way of doing continue was built when when externallinks didn't have
el_to as an auto_increment PK. Now that it has had something to use for
continue, it doesn't need to rely on those fields in order by nor
continue. These fields are set in the query and order by on a field
that's already specified in WHERE condition is not useful nor gives any
value.
Bug: T341000
Bug: T47237
Change-Id: I5c3bea57792bdce0ea611c3b33b4259b8cafc9d0
These pieces are known to be trivial HTML. The content is known to
be a plain text identifier. We don't need to parse it again as if it
is wikitext. rawParams() is the way to mark such parameters as "show
as is, don't parse again".
This also removes some double escaping that was added as part of
Ida2b686 in 2015. It was most certainly never doing anything because
the incoming identifiers are plain ASCII with nothing to escape.
Change-Id: I74fcdab3bbd9fb4f692176a6ac4cef6202db7f7e
Also, turned to override checkCanExecute() in FileDeleteAction instead,
to preserve the behaviour before the commit 3e43d318.
Bug: T341002
Change-Id: I8faa2ae97373d332d8c126d02d4969565489bf90
Locally this page doesn't load reliably for me, as
I have extensions which register broken resource loader
modules (eg. Math depends on VE, which I don't have
locally). This will lead to mw.loader.using rejecting
its promise directly, before any of the (working) tests
have been loaded. In order to work around this, wait for
each test module seperately and only start qunit
once all are resolved/ rejected.
Note: This shouldn't start more requests than the old
version as all modules will already be requested by
a single mw.loader.load call running before this logic
is invoked.
Change-Id: Ibee18d5a96068a6f00e5e0bae58355662324c2b4
This reverts commit df1312b799.
Reason for revert: More updates to callers are needed to prevent
throwing errors.
Bug: T340468
Change-Id: I604bef13a550c1bd8fc10396284505f24cf17802
While this is not really a bottleneck, I found this does quite a lot
of unnecessary things that are not used in this particular context.
All we want to know is if one or more help messages exist. We don't
need the actual, parsed help messages in this context.
Note this patch changes the code in a way that is not 100% the same as
before. Let's say there is only 1 message, and it's disabled. Since
the possibly expensive exists() check is delayed shouldInfuseOOUI()
might return true in rare edge-case situations where it returned
false before. I would like to argue this is worth it. We just trade
one performance optimization for another.
Change-Id: Ib4550e954853355f361249b13ec877478de9c789
This showed up as a major time sink in a profile run I did. What this
code does is turning the two fields "homepage" and "name" into a
wikitext snippet and do a separate wikitext parser run just to create
an <a> element. This adds up because it happens almost 300 times.
Instead we can create the <a> element directly.
External libraries are not expected to contain wikitext in a "name"
field.
Change-Id: Iba6ecf68d527f11d81be3f2dcc2d968a75a9db70
And remove commented-out code also dating from 1.32 with no near-term
prospect of being implemented.
Change-Id: I526c558b2efae4b77ae38d0b5bb8127c8b31c280
