Commit graph

7 commits

Author SHA1 Message Date
jenkins-bot
ce6ccd1216 Merge "Update search-rewritten i18n message to clarify how it is used in practice" 2019-12-18 13:12:26 +00:00
Erik Bernhardson
edad5ea487 Update search-rewritten i18n message to clarify how it is used in practice
Bug: T236296
Change-Id: I4a1ecf3173d918ce90956abfa7b8a46f9dc2548d
2019-12-17 23:53:12 +00:00
Erik Bernhardson
930b8fcd73 Update ISearchResultSet snippet/HtmlArmor documentation
Followup to I76231d6f adding more clarity to the doc blocks that were
changed with respect to when and why they can return different values.

Change-Id: I9afe50c8ee7a74b2c99a89ab19817e466153ba78
2019-12-17 10:21:54 -08:00
Erik Bernhardson
0c8289e5db Return HtmlArmor for Search ResultSet snippets
Passing around strings that are expected to be safe html and are
known to be based on user input is a fairly unsafe operation. Make
it harder to do the wrong thing by requiring HtmlArmor to be returned
from the ResultSet snippets. This does not address the snippets on
individual result objects as the api surface is larger and requires
more bc handling.

Change-Id: I76231d6fc53c4982eb4cd174d2e6a75eb2740497
2019-12-12 10:14:50 -08:00
David Causse
e97ff3524b Add BaseSearchResultSet
Meant to hold the B/C behaviors and be the base class implemented
by extensions.

Bug: T228626
Change-Id: I072a9bd0f94bd785d1ff51f0e6ee13790e37b417
2019-07-25 15:47:01 +02:00
David Causse
79895c7882 Add explicit visibility to ISearchResultSet methods
Change-Id: Ic1ad60fac6183004c4dfc110c8dfde95b57cdd9b
2019-07-23 10:59:41 +02:00
David Causse
6af636fb03 Add ISearchResultSet
Bug: T228626
Change-Id: I3306bf6107c97dd58adf578fd965bd11a422627d
2019-07-22 18:27:39 +00:00