9 commits

Author	SHA1	Message	Date
Jeroen De Dauw	0b54ec0e80	added since tag for people that care about compat	2011-04-29 21:29:20 +00:00
Siebrand Mazeland	02e44a71b0	Revert r86872: Breaks LiquidThreads page moves with the below failure. Threads are lost and nowhere to be found any more. ... [25-Apr-2011 18:12:45] /wiki/Special:MoveThread/Thread:User_talk:Siebrand/test/One_new_message: Exception: MWNamespace::getTalk does not make any sense for given namespace -1 #0 /www/w/includes/Namespace.php(81): MWNamespace::isMethodValidFor(-1, 'MWNamespace::ge...') #1 /www/w/includes/WatchedItem.php(73): MWNamespace::getTalk(-1) #2 /www/w/includes/User.php(2304): WatchedItem->addWatch() #3 /www/w/includes/actions/WatchAction.php(53): User->addWatch(Object(Title)) #4 /www/w/includes/Action.php(376): WatchAction->onView() #5 /www/w/extensions/LiquidThreads/classes/Thread.php(115): FormlessAction->execute() #6 /www/w/extensions/LiquidThreads/classes/Thread.php(435): Thread::create(Object(Article), Object(Article), NULL, 1, 'One new message') #7 /www/w/extensions/LiquidThreads/classes/Thread.php(414): Thread->leaveTrace('move test', Object(Title), Object(Title)) #8 /www/w/extensions/LiquidThreads/pages/SpecialMoveThread.php(107): Thread->moveToPage(Object(Title), 'move test', true) #9 [internal function]: SpecialMoveThread->trySubmit(Array) #10 /www/w/includes/HTMLForm.php(279): call_user_func(Array, Array) #11 /www/w/includes/HTMLForm.php(228): HTMLForm->trySubmit() #12 /www/w/includes/HTMLForm.php(242): HTMLForm->tryAuthorizedSubmit() #13 /www/w/extensions/LiquidThreads/pages/ThreadActionPage.php(37): HTMLForm->show() #14 /www/w/includes/SpecialPageFactory.php(459): ThreadActionPage->execute('Thread:User_tal...') #15 /www/w/includes/Wiki.php(252): SpecialPageFactory::executePath(Object(Title), Object(RequestContext)) #16 /www/w/includes/Wiki.php(98): MediaWiki->handleSpecialCases() #17 /www/w/index.php(145): MediaWiki->performRequestForTitle(NULL) #18 {main}	2011-04-25 18:20:53 +00:00
Happy-melon	70bdc008c4	Implement an interface and abstract class to hold the widely-reused get(Request|User|Title|Lang|Skin|Output) accessors for objects acting as a context source. Article is rather messier because both getTitle() and getUser() are in use for other things, and Article::$mTitle is in extremely wide use both within Article.php and outside.	2011-04-25 17:37:43 +00:00
Daniel Friesen	3c48938f9f	Instead of creating an OutputPage and then setting a context start initializing OutputPages 'with' a context and send depreciated calls to extensions directly creating OutputPage instances. ... Now that we've taken care of the mess of mTitle inside OutputPage and Skin and made RequestContext track Skin instead of $wgUser we don't need the hack in SpecialPage anymore.	2011-04-04 00:37:42 +00:00
Daniel Friesen	ff33175e96	Update index.php and Wiki.php to make better use of the context.	2011-04-04 00:18:33 +00:00
Happy-melon	df5f627e56	Implement magic accessors for RequestContext variables: you can now just call $context->request->stuff(), and that is internally mapped to the get accessor. Rename the private variables to the old $mName syntax: I know that that's "discouraged in new code", but in this case it stops over-clever IDEs highlighting the magic accesses as potential visibility errors and sticking big error tags on them.	2011-04-03 22:09:35 +00:00
Happy-melon	bfdcdd1371	Follow-up r85278, r85240: ... * Internalise $title in MediaWiki base class * Fix access fatal in SpecialPage by getting the context from the MediaWiki base class rather than the OutputPage * Fix a couple of typos in RequestContext which would have thrown errors/fatals if anyone had ever called them.	2011-04-03 21:32:50 +00:00
Daniel Friesen	b185adf24f	Continue with r85240; Move getSkin from User to RequestContext, do it without globals, strip out the non-functional $title related stuff, and update Skin to use a RequestContext.	2011-04-03 12:46:36 +00:00
Daniel Friesen	f14eb05489	Followup r85240; Commit the additional file that was part of that change. ;) this wouldn't have happened if we were using git... seriously!	2011-04-03 11:09:49 +00:00