Commit graph

47 commits

Author SHA1 Message Date
Siebrand Mazeland
79d5225c0e * remove end of line whitespace
* remove empty lines at end of file
* remove "?>" where still present
2008-04-14 07:45:50 +00:00
Aryeh Gregor
a15c419b3d Remove ?>'s from files. They're pointless, and just asking for people to mess with the files and add trailing whitespace. (Yes, I looked over every one and reverted those that were bogus. Slash-enter a million times in less worked well enough, although it was a bit mind-numbing.) 2007-06-29 01:19:14 +00:00
Antoine Musso
7ba6fcbbbe Kill some more whitespaces 2007-04-21 21:35:21 +00:00
Nick Jenkins
f9619da3f0 Yet more doc tweaks:
* Add @addtogroup tags to various classes, to try and group conceptually-related classes together.
* Add brief descriptions to various Special pages, thanks to Phil Boswell.
* Moving some docs to be right above the classes they represent, so that they are picked up.
2007-04-20 08:55:14 +00:00
Nick Jenkins
113bb1c772 Documentation tweaks to help documentation systems (Doxygen + PHPDocumentor)
pick up the appropriate tags, and documentation blobs for classes. This is 
the same as per r20769, but with the grouping changes (e.g. removing "@{{") omitted.
Please be advised that more related documentation tweaks may follow later - e.g. 
Doxygen generates a log file of warnings that is 574 Kb in size, when run over 
the just the trunk/phase3 code ... eek! Thankfully, much of that is just 
whining about functions without documentation   ;-)
2007-04-04 05:22:37 +00:00
Brion Vibber
3a6ac5a3c3 Revert r20769: we don't use PHPDocumentor anymore, we use doxygen.
If making mass changes to tweak to its preferences, probably better to do it for the tool we actually generate docs with. :)
2007-03-28 14:16:43 +00:00
Nick Jenkins
5fef2333d4 PHPDocumentor [http://en.wikipedia.org/wiki/PhpDocumentor] documentation tweaking stuff.
Minor doc tweaks to prevent some PHPDocumentor warnings or errors when run on the includes/ directory. PHPDocumentor uses a syntax very similar to javadoc - mostly we already use this, but there were a few scattered places that were adjusted to make them consistent with the rest of the code. In practical terms, these changes were made:
* @url becomes @link
* @fixme becomes @todo
* HTML tags in descriptions must be closed / balanced.
* @bug was removed (where the bug was long fixed), or changed into a @todo (in the few situations where the bug was still pending)
* @obsolete becomes @deprecated
* Things like "/**@{{" and "/**@}}*/" which cause "unknown tag" warnings were removed
* @access must be a valid access level.
* @desc tag not needed, removed.
* Doesn't seem to like @licence, will accept @license however.
* Use full comment block notation in a few places (i.e. open block with "/**", start each line with " *", and end block with " */")

Then additional to this, to get some class docs associated with their respective classes:
* Moved some docs to right above those classes (deleting blank lines, or moving descriptions from the file headers)
* Marked some classes without docs as "@todo document"
* (done up to "class MIMEsearchPage" on the "classtrees_MediaWiki.html" page for the includes/ directory)
2007-03-28 08:53:02 +00:00
Antoine Musso
c771fc9c96 Use Doxygen @addtogroup instead of phpdoc @package && @subpackage 2007-01-20 15:09:52 +00:00
Antoine Musso
b144fcb85d Rename constructors to __constructor 2007-01-20 13:34:31 +00:00
Brion Vibber
cf506938b5 * fix last commit so quickUserCan() actually skips the cascading query
* use quick check for move tab privilege check
* drop quickUserCan(Edit|Move|*); just provide one quickUserCan and use the permission keys explicitly. the other (non-quick) funcs are i think deprecated, so marking them so
* adjusted some whitespace
2007-01-13 03:22:20 +00:00
Andrew Garrett
78eb71793d Possibly partial patch to make userCanEdit avoid running cascade-protection queries on page-view. 2007-01-13 02:37:02 +00:00
Nick Jenkins
ae8554c45b Completing code housekeeping stuff for rest of includes/ directory: removing unused local vars, removing unused globals, replacing extract() where simple to do, declaring output arrays before calling preg_match(), and so forth. 2006-11-29 11:43:58 +00:00
Tim Starling
e174a4ddfb Abolished $wgDBname as a unique wiki identifier, it doesn't work with the new-fangled feature we call "table prefixes". Instead use wfWikiID() for an identifier containing the DB name and the prefix if there is one, and wfMemcKey() for cache key construction.
Caches for wikis with table prefixes will be lost on upgrade, caches for wikis without table prefixes will be preserved. Custom cache keys in extensions can be migrated at leisure. Extensions which write to core cache keys should be migrated ASAP, as I have done with Special:Makesysop.
2006-10-04 09:06:18 +00:00
Antoine Musso
fd912a148b A lot more of static issues when using E_STRICT from the commandline. 2006-07-10 15:41:30 +00:00
Rob Church
93f968cef8 (bug 5683) Respect parser output marked as uncacheable when saving 2006-05-13 17:40:59 +00:00
Antoine Musso
7ebdb6de89 Revert to r14165 . Did too many changes, didnt even run parserTests (i am bad) 2006-05-11 22:40:38 +00:00
Antoine Musso
c3c2084ee2 Some more PHP5 stuff 2006-05-11 20:24:28 +00:00
Tim Starling
ff375dd5f7 Save the last modified timestamp to the parser cache, to avoid the need for a revision row load on hits. 2006-03-16 02:57:44 +00:00
Lupin
11337038b3 removing unused globals and some whitespace cleaning 2006-03-07 01:10:39 +00:00
Domas Mituzas
8613886134 move hardcoded ParserCache expire time to DefaultSettings.php, 1 day now 2006-01-09 10:45:47 +00:00
Ævar Arnfjörð Bjarmason
a26d5a49d7 * s~\t+$~~ 2006-01-07 13:31:29 +00:00
Tim Starling
3fc92e0c28 removed $wgParserCache, converted to a singleton 2006-01-05 04:26:52 +00:00
Brion Vibber
148b30c81a * (bug 4385) Separate parser cache entries for non-editing users, so section
edit links don't vanish / appear unwanted on protected pages
2005-12-28 22:28:04 +00:00
River Tarnell
5af5e209b5 key parser cache on ($action==render) 2005-07-03 07:27:43 +00:00
River Tarnell
8ff36ebd62 remove wfdebug in pagehistory
set ETag header on article views
2005-07-01 00:03:31 +00:00
Tim Starling
ad01e39c51 stats changes ported from 1.4 2005-06-19 03:05:51 +00:00
Ævar Arnfjörð Bjarmason
273671cf32 Adding cache related stuff to a new 'Cache' subpackage 2005-04-12 01:29:21 +00:00
Tim Starling
9daededf7f stats merged from REL1_3A 2005-01-04 12:54:07 +00:00
Brion Vibber
e39dd4532c (bug 934) List each category on a page only once.
Dan Keshet's patch (http://bugzilla.wikipedia.org/attachment.cgi?id=134&action=view) plus an added version check on parser cache objects, to automatically discard cached objects using the incompatible older format.
2004-11-25 22:02:30 +00:00
Brion Vibber
c7620a7106 Let the parser cache use the objectcache table if memcached isn't set up,
and enable it by default. This provides significant speedups on medium
to long pages, though for busier sites the garbage collection probably
should be adjusted.
2004-11-22 01:16:44 +00:00
Tim Starling
f2102da371 Debug info 2004-10-23 10:22:38 +00:00
Tim Starling
97dc6c150c correcting for what was probably an odd one-off error 2004-10-23 08:23:13 +00:00
Antoine Musso
ba2afcd9fa Split files and classes in different packages for phpdocumentor. I probably changed some double quotes to single and used function foo () { shema 2004-09-03 23:00:01 +00:00
Antoine Musso
90155b8a97 Changing comments layout preparing for generated documentation with Phpdocumentor 2004-09-02 23:28:24 +00:00
Antoine Musso
3d60242fb5 massive double to single quotes conversion. I have not noticed any bug after a lot of testing 2004-08-22 17:24:50 +00:00
Tim Starling
797e29aead bug fix 2004-06-04 12:31:32 +00:00
Tim Starling
e7ac88064a don't load so much stuff on parser cache hit (experimental) 2004-06-04 10:40:44 +00:00
Tim Starling
54bc266fe0 Extra debugging info and a typo fix 2004-05-30 08:18:40 +00:00
Tim Starling
3d1698b760 Fixed $wgCacheEpoch handling 2004-05-30 07:31:26 +00:00
Tim Starling
cdf68120b1 oops 2004-05-29 15:17:46 +00:00
Tim Starling
abce963238 Save a tag into the cached text indicating the key and the timestamp 2004-05-29 12:36:05 +00:00
Tim Starling
384183ba5e Parser cache respects $wgCacheEpoch 2004-05-29 11:39:29 +00:00
Tim Starling
727d419e7e Support for database profiling, profiling bracket in ParserCache.php 2004-05-28 05:45:13 +00:00
Tim Starling
a42101c0a0 Parser cache moved to memcached 2004-05-27 15:24:04 +00:00
Brion Vibber
59c6e92429 Some changes to the link tables. They now all use a key on cur_id for the *_from column instead of strings, and have a unique index to force prevent any duplicate entries. There's not yet a clean step in the update script, so just clear out your links tables (patch-linktables.sql) and rebuild them with refreshLinks.php.
This saves trouble in a number of places where we can now do joins with the link tables to get other info (such as cur_is_redirect!) as well as the name, and fewer bits need to be juggled on page renaming, as outgoing links no longer have to be changed (cur_id remains the same when a page is renamed).

rebuildLinks.inc and some of the tools in the 'maintenance page' still need to be updated to work with the new setup. (Special:Maintenance needs a *lot* of cleanup in general. It's kind of a catch-all of vaguely defined features which suck performance like a hydroelectric dam.)

Also I've slipped in some extra debug code. And, I think 'indexes.sql' is a big waste of time and should all be moved into tables.sql. Building indexes separately doesn't help on InnoDB and won't do anything on MyISAM either if you're just going to replace the table after it's built with an imported one from a dump which creates it with indexes.
2004-03-11 09:06:13 +00:00
Tim Starling
683ba962d1 bug fix 2004-02-28 09:26:16 +00:00
Tim Starling
ee73b49007 Split parser from OutputPage into Parser.php, corrected spelling of "suppress", a few other bits and pieces 2004-02-26 13:37:26 +00:00