The history page in backwards mode showed revisions in forwards
chronological order instead of reverse chronological order, due to an
error in the CommentFormatter patch. So:
* Restore $firstInList as it was prior to the CommentFormatter change
* Instead of trying to derive the result offset from $this->counter, use
$this->getResultOffset(). I avoided this in my CommentFormatter patch
because of the weird way HistoryPager offsets its results by one,
ignoring the first call to formatRow(). But on closer inspection, it's
still the easiest way to get the correct offset, you just have to store
it alongside the fetched row.
Bug: T292791
Change-Id: I5c0822138b244402930e192a18f01b61246b95ee
This change replaces in the HTML of Special:AllMessages
<table class="mw-datatable mw-datatable" id="mw-allmessagestable">
by
<table class="mw-datatable" id="mw-allmessagestable">
Remove unnecessary space at the start of the value of the class
attribute in TablePager.
Inline the one-time used variable
$tableClass = $this->getTableClass()
Change-Id: I4353d47bda3136cd3a8341677a0288f59895d5c6
Tweak testLockTSESlow() tests to reduce mt_rand() dependency.
Also, rename last few $now variables to $mockWallClock and use
integral floats to make it easier to find raw microtime() values
via debugging statements.
Change-Id: Ie2b125e42d3ac37104f5b87b75a9a81558956518
I intent to remove Profiler::getContext/setContext after a week
without deprecation. I consider these methods as internal (they
predate the stable interface policy, and we forgot to triage this
class, it has neither `@stable` nor `@internal`).
The hard-deprecation in this commit is to detect any use that may
have gone unnoticed in WMF production from Codesearch analysis alone,
where no usage was found.
Bug: T292269
Change-Id: Id40679f21cc7a3f77a1b96a4bbd55daeaea16892
The new module retains the name .ui name so that existing
skin style overrides continue to work. We can consider renaming it
to just "mediawiki.rcfilters.filters" in a future patch.
This does not handle file reorganization, since both of the
modules used package files - instead, in the main script we also
require() the old main script for the .dm module so that its
setup code runs. But, we did need to rename the virtual
config file from the .dm module to not clash with the
virtual config file from the .ui module, since the
latter uses a callback instead of retrieving configuration
variables directly. These can be merged later as well.
Bug: T256836
Change-Id: I5ec0af8b8e6bcdba6b7881f946f777b854a33739
This feature was removed in 2013 (Ia8d79b4a, T49504), with further
remnants removed in (1965df8df3, I7c24128f7b1).
* Simplify the code of transformCssMedia() as it now only needs to
support printable=yes.
* Remove query parameter abstraction from test cases, use query
array directly.
* Remove internal use of the $handheld parameter.
Function signature of makeLoaderQuery() left in-tact for
compatibility with $extraData. This will be deprecated and removed
in a follow-up commit.
Bug: T49504
Bug: T32956
Change-Id: Id16ef3f4630538de1887ac2327eb317c6c6b1f9d
Follow up to Iff2bdc3aa02f84f0bf4ca55d177706823934cc08
This corrects an omission from the previous patch, aligning it with Parsoid's output.
Change-Id: Ic64af85f5969717a4ea536a695874359a13645c5
Follow-up: Ieab0606068a78e5b5e5b9b3337f3a75a0b64adbc
This is concatenating an object and a number, so the index is always
"[object Object]0.5"
Ops :)
Bug: T292600
Change-Id: Icf9df9a3e1fbbb08f1868131cf3fb740ee3a3e08
The ::getProperty() naming is too generic and doesn't clearly indicate
that these are "page properties" (which have their own table in the DB).
As part of refactoring a clean API out of ParserOutput which can be used
by Parsoid, clean up the naming here.
Soft-deprecation in this patch, there are a handful of external users
which need to be cleaned up before we hard-deprecate.
Bug: T287216
Change-Id: Ie963eea5aa0f0e984ced7c4dfa0fd65d57313cfa
Dependency injection and cleanup. Rename ::isDeleted
to more clear ::hasArchivedRevisions.
Bug: T290022
Change-Id: Ifff6076f79ee2ad08e4635fba8fd141e4de93b01
Copy and paste methods. Subsequent patches will tidy this up.
Also improve test coverage.
Bug: T290022
Change-Id: I549ecc3ec89f0303a3cc342916f06da4bf77595e
* Tidy is always enabled, so enable/disable tidy checks not needed
* +tidy parsertest options are gone. So, tweak how output sections
are switched around.
Bug: T198214
Change-Id: I735a9dc2979bcc165423bfdc3ffca12c5602e2c1
