Commit graph

622 commits

Author SHA1 Message Date
Rob Church
e68b7441c9 Had a bash at cleaning up the horrendous-looking deletion log on the edit page:
* Suppress if no deletion log entries
* Provide a message to explain what it is
* Allow the whole thing to be dismissed
* Remove the mess in Article
* Some prettification
2007-06-04 23:43:08 +00:00
Raimond Spekking
31730c106d Adding CSS-IDs to deletion log section 2007-06-04 08:39:13 +00:00
Aaron Schulz
1948c9a798 *Add two vars to ArticleViewHeader hook, $outputDone, $pcache 2007-06-03 22:31:09 +00:00
Daniel Cannon
6cb029c915 Minor doc goof -- displays *after* not before. 2007-06-02 00:45:26 +00:00
Daniel Cannon
b0d24a3a10 (bug 7691) Show deletion log following noarticletext and newarticletext when creating a new page. 2007-06-02 00:41:16 +00:00
Tim Starling
52fe665df7 Added $wgArticleRobotPolicies 2007-05-31 23:09:36 +00:00
River Tarnell
e2c99c9d37 (bug 9812) (regression) Edit links in regular pages now include "oldid"
Article::isCurrent() is called with no Revision object when the article was retrieved from the parser cache.  in this case, and then no oldid was given in the URL, it would return false, causing spurious &oldid= parameters in the edit link.  instead, if no oldid was given, assume we are viewing the current revision.
2007-05-07 07:57:29 +00:00
Nick Jenkins
1a60bd4c84 (bug 7958) Special:Cite of older version of an article should use old version id.
Applying Brion's patch, with one-line tweak:
 - uses the existing Skin/$wgOut-based revision ID record, rather than oldid value from WebRequest.
 - additionally sets it to the current revision for parser cache hits (where
   it was not previously needed, since it was only used to feed to parser objects
   to fill the {{REVISIONID}} variable).
 - Explicit declaration of the existing $mRevisionId data member in Skin.
 - "Permanent link" should now work too when paging through historical versions (previously it
   would be greyed out when paging backwards or forwards through old revisions).
2007-05-03 06:08:12 +00:00
Daniel Kinzler
fb7306acf8 fixed isFileCacheable: use && instead of 'and', check user language, added hook point 2007-04-25 13:07:29 +00:00
Aaron Schulz
c8352e9248 *Actually enforce when you can cascade, add missing [cascade] comment to dummy edit summary 2007-04-24 02:20:04 +00:00
Aryeh Gregor
369ebc657a (bug 9656) Generate autosummaries on the deletion of all pages, not just those < 500 bytes. 2007-04-22 03:09:42 +00:00
Tim Starling
b15d8cffc4 * Introduced media handler modules for file-type specific operations: thumbnailing, img_metadata, capabilities, etc.
* Deprecated $wgUseImageResize, thumbnailing will be enabled unconditionally.
* Fixed interaction of page parameter to ImagePage with the HTML file cache
* Improved error reporting for image thumbnailing
* Fixed MIME type for SVG files, will be silently changed from image/svg to image/svg+xml after loading from the database.
* Workaround for djvutoxml bug #1704049 (poor performance). Use djvudump instead.
* Fixed odd behaviour in ImagePage on DjVu thumbnailing errors
* Improved error reporting for image thumbnailing
* Added sharpening option for ImageMagick thumbnailing
* Removed Image::selectPage(), added page parameters to getWidth() and getHeight(), deprecated Image::renderThumb() and Image::getThumbnail()
* Changed default contents of img_metadata to empty string instead of a:0:{}
* Moved responsibility for respecting $wgGenerateThumbnailOnParse from the UI to Image.php
2007-04-20 12:31:36 +00:00
Antoine Musso
096c1d0e7d In regex, do not capture stuff when you dont need it, use (?:) 2007-04-13 00:23:49 +00:00
Nick Jenkins
113bb1c772 Documentation tweaks to help documentation systems (Doxygen + PHPDocumentor)
pick up the appropriate tags, and documentation blobs for classes. This is 
the same as per r20769, but with the grouping changes (e.g. removing "@{{") omitted.
Please be advised that more related documentation tweaks may follow later - e.g. 
Doxygen generates a log file of warnings that is 574 Kb in size, when run over 
the just the trunk/phase3 code ... eek! Thankfully, much of that is just 
whining about functions without documentation   ;-)
2007-04-04 05:22:37 +00:00
Rob Church
271443f2ba (bug 9466) "Rollback failed" page doesn't format edit comment 2007-04-01 03:31:58 +00:00
Brion Vibber
3a6ac5a3c3 Revert r20769: we don't use PHPDocumentor anymore, we use doxygen.
If making mass changes to tweak to its preferences, probably better to do it for the tool we actually generate docs with. :)
2007-03-28 14:16:43 +00:00
Nick Jenkins
5fef2333d4 PHPDocumentor [http://en.wikipedia.org/wiki/PhpDocumentor] documentation tweaking stuff.
Minor doc tweaks to prevent some PHPDocumentor warnings or errors when run on the includes/ directory. PHPDocumentor uses a syntax very similar to javadoc - mostly we already use this, but there were a few scattered places that were adjusted to make them consistent with the rest of the code. In practical terms, these changes were made:
* @url becomes @link
* @fixme becomes @todo
* HTML tags in descriptions must be closed / balanced.
* @bug was removed (where the bug was long fixed), or changed into a @todo (in the few situations where the bug was still pending)
* @obsolete becomes @deprecated
* Things like "/**@{{" and "/**@}}*/" which cause "unknown tag" warnings were removed
* @access must be a valid access level.
* @desc tag not needed, removed.
* Doesn't seem to like @licence, will accept @license however.
* Use full comment block notation in a few places (i.e. open block with "/**", start each line with " *", and end block with " */")

Then additional to this, to get some class docs associated with their respective classes:
* Moved some docs to right above those classes (deleting blank lines, or moving descriptions from the file headers)
* Marked some classes without docs as "@todo document"
* (done up to "class MIMEsearchPage" on the "classtrees_MediaWiki.html" page for the includes/ directory)
2007-03-28 08:53:02 +00:00
Manuel Schneider
d133a108c6 fixed bug in call of hook ArticleViewHeader 2007-03-22 08:19:47 +00:00
Brion Vibber
9150412fe7 For now revert the rev_deleted branch merge; don't want trunk to get too far gone before changes are reviewed!
Reverted: 20511, 20510, 20507, 20474, 20461, 20460, 20457, 20448, 20446
2007-03-16 16:01:07 +00:00
Aaron Schulz
8250faf941 *Put ['protect'] is isset() to avoid any errors 2007-03-15 02:34:19 +00:00
Aaron Schulz
be7409947a *Do not cascade unless each protection type is set to a group that can "protect" (bug 8796) 2007-03-14 19:37:56 +00:00
Aaron Schulz
2448539ad9 *Merge in phase3_rev_deleted/includes 2007-03-14 15:50:06 +00:00
Aaron Schulz
399e139bed *Get rev_len to carry across delete/undelete 2007-03-13 23:28:34 +00:00
River Tarnell
21f50c06f4 real fix for 9097 2007-03-08 01:46:12 +00:00
River Tarnell
dfa5c2fe7c * (bug 9097) column "pr_pagetype" does not exist
misuse of uniqueindexes parameter to replace() caused SQL error on postgres
2007-03-07 22:58:34 +00:00
Aaron Schulz
e84ef7ce50 *Show deletion log on confirmdelete (bug 9118) (patch by Tango42) 2007-03-06 00:10:37 +00:00
Andrew Garrett
12dc557a1e Show expiry time in the null revision inserted on protection with an expiry date. 2007-01-23 10:51:33 +00:00
Nick Jenkins
f88c771756 The war on redundant ampersand usage!
* Convert "$dbw =& wfGetDB( DB_MASTER );" --> "$dbw = wfGetDB( DB_MASTER );"
* convert "$skin =& $wgUser->getSkin();" --> "$skin = $wgUser->getSkin();"

For the time being have not changed the function definitions of wfGetDB() or User::getSkin() [i.e. they are still both return-by-ref], so as to ensure the interface does not change for extensions [some of which may still be trying to run on PHP4 environments]. However presumably at some point this can be changed too.

Also includes tiny tweak to newlines in parserTests - will show 1 rather than 2 newlines between the "Reading tests from" strings when in quiet mode.
2007-01-22 23:50:42 +00:00
Brion Vibber
50d9a5ec18 Further fixes to protection expiry:
* Use RFC 2822-style date/time format instead of localized formatting for
  the expiry time in the protection form; while ugly, it actually works;
  a localized time is usually lossy (changing the time on submit) and
  more significantly will fail for any UI language that's not english!
* Rearrange some of the form display logic to handle error conditions
  a little more gracefully; invalid expiry format caused the form to
  be displayed twice.
* Should be nicer on session token expiration as well, showing the
  form instead of just an exception message.
2007-01-22 20:59:00 +00:00
Andrew Garrett
698095516a Make my last three commits interoperate (display protection expiry on Special:Protectedpages). Message slightly changed (brackets removed) so I've updated the translation so kindly provided by Rotem :-) 2007-01-22 08:57:40 +00:00
Andrew Garrett
957839573b * (bug 4133) Allow page protections to be made with an expiry date, in the same format as block expiry dates. Existing protections are assumed to be infinite, as are protections made with the new field left blank. 2007-01-22 08:26:41 +00:00
Antoine Musso
c771fc9c96 Use Doxygen @addtogroup instead of phpdoc @package && @subpackage 2007-01-20 15:09:52 +00:00
Antoine Musso
b144fcb85d Rename constructors to __constructor 2007-01-20 13:34:31 +00:00
Brion Vibber
4c436c3614 Fix for MySQL strict mode; explicitly set the deprecated page_restrictions field when inserting a new page record.
Also removed the now-useless $restrictions parameter from Article::insertOn(); it was optional and wasn't used anywhere anyway.
Aaaand while in there, cleaned up an unnecessary reference parameter (old php 4 compat)
2007-01-19 09:50:19 +00:00
Antoine Musso
278309b2d0 whitespaces 2007-01-17 22:32:40 +00:00
Niklas Laxström
ba8fc3cf5e * Escaping 2007-01-17 22:09:30 +00:00
Brion Vibber
d88bf87284 Apply most of the code tweaks from the live site:
* use configured cache servers for mctest.php
* bucket details in mcc.php
* fix input validation and remove debugging code in compressOld
* full ID range for moveToExternal
* fix resolveStubs.php for compatibility with older serialized data
* maximum line length for bar graphs in getLagTimes.php
* recognize specieswiki in rebuildInterwiki.inc
* --purge option to do additional parser-cache purging for purgeList.php
* default changed in MiniDonation extension
* profile unicode cleanup in Xml
* log slow parses in Article.php
* profile wfMsgReal
* log mkdir failures
* profile AutoLoader
* rebuild empty DjVu metadata containing ''
* security fix for DjVu metadata retrieval
2007-01-17 00:54:54 +00:00
Rob Church
5aa9b2e5a6 Don't do auto-patrolling if patrolling is switched off 2007-01-16 21:24:27 +00:00
Rob Church
c16298f2d2 * (bug 8621) Log revisions marked as patrolled
* Uses normal logging framework, but
** doesn't duplicate the log in recentchanges ;)
** uses a cleaner method to override LogPage::actionText() and do all the formatting
* Introduces PatrolLog::record()
2007-01-16 17:05:30 +00:00
Rob Church
88074c62a9 (bug 8407) Disallow indexing of "printable" versions 2007-01-14 21:28:23 +00:00
Brion Vibber
cafdbbc5ca * (bug 8632) Fix regression in page protection null edit update
r19095 removed the code that updated the page record's cache timestamp and revision number, leaving the wrong page_latest reference.
Putting it back, merging in the other query to clean out the old page_restrictions field.
2007-01-14 12:03:56 +00:00
Brion Vibber
0c0c0eff81 Temporary(?) optimization; only update templatelinks on view if the page has cascading restrictions. 2007-01-14 10:55:23 +00:00
Brion Vibber
6f93347ccd * Add 'purge' privilege to replace the hardcoded check for login state in
determining whether action=purge can be done via GET. Switching the
  permission on for anons can be helpful for benchmarking.
2007-01-13 04:25:25 +00:00
Nick Jenkins
784e69d028 For the "includes/" directory:
* removing unused local vars
* removing used global declarations
* adding FIXMEs against extract() calls and lines that seem to be using uninitialized variables
* adding some array() declarations.
2007-01-12 10:03:51 +00:00
Ilmari Karonen
7338549d8d (bug 3446) Add user preference to hide page content below diffs, can be
overridden by adding diffonly=1 or diffonly=0 to the URL of the diff page
2007-01-12 03:36:46 +00:00
Andrew Garrett
19cca14f69 Restore backwards-compatibility for old types of restrictions; wipe page_restrictions column in update for page_restrictions and on updateRestrictions 2007-01-12 01:44:33 +00:00
Andrew Garrett
4e14efacc7 Fix a couple of mistyped variable names, mysql strict incompatibilities, make cascading protect checkbox disabled for users without protect permission. 2007-01-11 01:17:19 +00:00
Andrew Garrett
146f6316b3 Next batch of bug-fixes. 2007-01-11 00:52:50 +00:00
Andrew Garrett
4b46b8022e More bugfixes. Fantastic. (and I tested, too! brion will be proud of me.) 2007-01-11 00:44:55 +00:00
Andrew Garrett
b6d674623e Fixes for a couple of embarrassing bugs I should have caught in testing. Brion and Tim save the day... 2007-01-11 00:31:04 +00:00