Commit graph

152 commits

Author SHA1 Message Date
Brion Vibber
63badd2b1d Forgot to bump the cache version when making RTL fixes 2007-05-17 21:04:50 +00:00
Brion Vibber
8315cbe263 * Right-align diff line numbers in RTL language display
Use .diff-lineno class instead of hardcoding a <strong> and an alignment. Leaving default alignment does the right thing in both LTR and RTL; forcing left was unnecessary.
Also swapping alignment for the +/- marker column to improve look on RTL.
2007-05-17 18:33:00 +00:00
Brion Vibber
b17e44b367 Fix a couple regressions due to diff style changes, where diffs were shown unstyled:
* move the addition of common/diffs.css from showDiffPage() to showDiff() which catches most 'legit' cases
* hack it in to a couple of uses where getDiff() is used and manually spit out
* hack around the hacked-up custom diff table in Oversight... that should be refactored in the base class
2007-05-16 21:57:55 +00:00
Brion Vibber
e7c73bda54 Add a version constant for diff cache so it can be cleared on major updates.
Added a release note for a related diff bug
2007-05-16 19:10:41 +00:00
Brion Vibber
4376a04946 * (bug 1438) Fix for diff table layout on very wide lines.
Diff style rules have been broken out to common/diff.css,
  and the dupes removed from the default skin files.
  Skins can still override the default rules.

Improvements over r22192, now known to work in:
* Firefox 2.0.0.3
* Opera 9.10 and 9.20
* Safari 2.0.4
* Konqueror 3.5.6
* MSIE/Win 7.0 (wide cells may produce vertical scrollbars as well)
* MSIE/Win 6.0 (wide cells are cropped instead of scrolling)
* MSIE/Mac 5.2.3 (wide words break instead of scrolling)
* iCab 3.0.3 (some cells provoke unnecessary horizontal scrollbar)

I've cleaned up the diff table formatting a bit, moving some attributes
from the HTML to the style sheet and consolidating the duplicated styles
into a common/diff.css file which is conditionally loaded for diff views.

Individual skins or site/user CSS can still override that style if they wish.
2007-05-16 17:57:00 +00:00
Brion Vibber
1291682170 Fix regression in even sizing of diff columns; forgot to restore a couple bits I removed when experimenting. 2007-05-16 13:59:23 +00:00
Brion Vibber
6213efe017 * (bug 1438) Fix for diff table layout on very wide lines for Gecko and
Opera-based browsers (incomplete, does not fix KHTML or MSIE)

This adds a <div> inside the <td> for diff content cells, and declares
the style for these <div>s to have overflow: auto.

In Gecko (tested Firefox 2.0) and Opera (tested 9.10 and over) this does
two things:
* The table layout treats the cells as the requested width instead of bloating
  out to the widest line of content, so the table stays visible on screen
* The individual cells that are too long get horizontal scroll bars

Unfortunately this doesn't have the hoped-for effects in other tested browsers:
* MSIE 7
* Safari 2
* Konqueror 3.5
* iCab 3

But neither has it any ill effects, so... it's a start.
There's probably some other way to force the layout algorithm to behave
that I haven't quite stumbled on yet... Might have better luck with the
fixed table layout option, though that seems less friendly to the little
+ and - columns.

The C++ diff plugins will have to be updated to support this scheme, but
no harm will be done if they're not (just they won't do anything new).
2007-05-15 21:24:56 +00:00
Nick Jenkins
113bb1c772 Documentation tweaks to help documentation systems (Doxygen + PHPDocumentor)
pick up the appropriate tags, and documentation blobs for classes. This is 
the same as per r20769, but with the grouping changes (e.g. removing "@{{") omitted.
Please be advised that more related documentation tweaks may follow later - e.g. 
Doxygen generates a log file of warnings that is 574 Kb in size, when run over 
the just the trunk/phase3 code ... eek! Thankfully, much of that is just 
whining about functions without documentation   ;-)
2007-04-04 05:22:37 +00:00
Aaron Schulz
0fe87673b7 *Re-add r20317 with support for older URL param, rename "undoto" to just "undo" 2007-03-28 19:41:53 +00:00
Brion Vibber
3a6ac5a3c3 Revert r20769: we don't use PHPDocumentor anymore, we use doxygen.
If making mass changes to tweak to its preferences, probably better to do it for the tool we actually generate docs with. :)
2007-03-28 14:16:43 +00:00
Nick Jenkins
5fef2333d4 PHPDocumentor [http://en.wikipedia.org/wiki/PhpDocumentor] documentation tweaking stuff.
Minor doc tweaks to prevent some PHPDocumentor warnings or errors when run on the includes/ directory. PHPDocumentor uses a syntax very similar to javadoc - mostly we already use this, but there were a few scattered places that were adjusted to make them consistent with the rest of the code. In practical terms, these changes were made:
* @url becomes @link
* @fixme becomes @todo
* HTML tags in descriptions must be closed / balanced.
* @bug was removed (where the bug was long fixed), or changed into a @todo (in the few situations where the bug was still pending)
* @obsolete becomes @deprecated
* Things like "/**@{{" and "/**@}}*/" which cause "unknown tag" warnings were removed
* @access must be a valid access level.
* @desc tag not needed, removed.
* Doesn't seem to like @licence, will accept @license however.
* Use full comment block notation in a few places (i.e. open block with "/**", start each line with " *", and end block with " */")

Then additional to this, to get some class docs associated with their respective classes:
* Moved some docs to right above those classes (deleting blank lines, or moving descriptions from the file headers)
* Marked some classes without docs as "@todo document"
* (done up to "class MIMEsearchPage" on the "classtrees_MediaWiki.html" page for the includes/ directory)
2007-03-28 08:53:02 +00:00
Brion Vibber
7501310a7a Revert r20317 for the moment; incompatible changes to URL parameters for undo 2007-03-27 21:30:39 +00:00
Brion Vibber
9150412fe7 For now revert the rev_deleted branch merge; don't want trunk to get too far gone before changes are reviewed!
Reverted: 20511, 20510, 20507, 20474, 20461, 20460, 20457, 20448, 20446
2007-03-16 16:01:07 +00:00
Aaron Schulz
2448539ad9 *Merge in phase3_rev_deleted/includes 2007-03-14 15:50:06 +00:00
Aaron Schulz
f35f38276b * Enable multi-edit undo (bug 8133) 2007-03-10 23:03:24 +00:00
Aaron Schulz
57b47a742d * Fix exception with "undo", use revText() for proper diffs 2007-02-05 23:28:17 +00:00
Aaron Schulz
614c860b5c Restore minor visual updates for rev_deleted 2007-02-04 18:16:38 +00:00
Aaron Schulz
0d24136805 revert; first commit should not be to trunk, even if its a small patch. 2007-02-04 05:19:58 +00:00
Aaron Schulz
78a86b2d8f Improve diff behavoir for rev_deleted a tad; first commit, don't stab please :). 2007-02-04 05:07:46 +00:00
Antoine Musso
fe7d2d15d4 Fix #6844: Semantically correct tags for diffchanges (<ins> && <del>)
Bumps wgStyleVersion to 55.
Patch by Messi <messias+spam@gmail.com>
2007-02-03 21:47:53 +00:00
Antoine Musso
c771fc9c96 Use Doxygen @addtogroup instead of phpdoc @package && @subpackage 2007-01-20 15:09:52 +00:00
Ilmari Karonen
ccc2a58cf5 make section links in edit summaries non-local when in diffonly mode 2007-01-14 23:39:25 +00:00
Tim Starling
10728de893 Fixed diff-related regression, tidy accidentally disabled 2007-01-14 17:37:29 +00:00
Nick Jenkins
784e69d028 For the "includes/" directory:
* removing unused local vars
* removing used global declarations
* adding FIXMEs against extract() calls and lines that seem to be using uninitialized variables
* adding some array() declarations.
2007-01-12 10:03:51 +00:00
Ilmari Karonen
7338549d8d (bug 3446) Add user preference to hide page content below diffs, can be
overridden by adding diffonly=1 or diffonly=0 to the URL of the diff page
2007-01-12 03:36:46 +00:00
Andrew Garrett
c490d265fa Per discussion on wikitech-l, add an (undo) link for on-top revisions as well. Also, don't do a merge if (undo) is being used for a straight revert 2006-12-11 09:39:39 +00:00
Aryeh Gregor
e55b5b5a6f Fix for oldtitle too 2006-12-10 02:39:30 +00:00
Aryeh Gregor
fd3c4bd537 * Removed a redundant <strong> tag from diff pages that was causing display issues for some users (patch based on one by Patrick Collison/adxp) 2006-12-10 01:11:27 +00:00
Brion Vibber
bdd943ce0c Fix for new diff revision counter: suppress intermediate revision count when
comparing revisions from different pages
2006-12-06 21:27:04 +00:00
Rotem Liss
09af7c4abd Merging 'diff-multi' and 'diff-multi-revs'. 2006-12-06 15:27:30 +00:00
Rotem Liss
58c070601f Combining new 'diff-multi-rev' and 'diff-multi-revs' to one message with plural. 2006-12-06 15:20:15 +00:00
Ilmari Karonen
c1902105b7 fix "show changes" edit button breakage from r18194 2006-12-06 08:46:22 +00:00
Ilmari Karonen
efe38a9d83 (bug 5485) Show number of intervening revisions in diff view.
Also clean up RELEASE-NOTES some more after SpecialContributions revert.
2006-12-06 08:28:44 +00:00
Ilmari Karonen
21667dfead ...the previous line can also me moved inside the if block 2006-12-06 06:58:50 +00:00
Ilmari Karonen
3f3a113117 avoid calling wfMsg( 'missingarticle' ) unless needed 2006-12-06 06:55:34 +00:00
Nick Jenkins
ae8554c45b Completing code housekeeping stuff for rest of includes/ directory: removing unused local vars, removing unused globals, replacing extract() where simple to do, declaring output arrays before calling preg_match(), and so forth. 2006-11-29 11:43:58 +00:00
Andrew Garrett
f062b09dc3 * (bug 6295) Add a 'revision patching' functionality, where an edit can be undone (with a functionality similar to diff rev1 rev2 | patch -R rev3 -o rev3). This is triggered by including &undo=revid in an edit URL. A link to a URL that will undo a given edit is shown on NEW NON-CURRENT revision headers on diff pages. 2006-11-26 10:54:01 +00:00
Aryeh Gregor
a94b77d29e After discussion with Fyren on IRC, apply last patch for both sides of diff. 2006-11-17 04:14:19 +00:00
Aryeh Gregor
7f33a86ead (bug 7688) When viewing diff, section anchors in autosummary jump to section on current page. Patch by Mark Haidar (Fyren) with slight modifications. 2006-11-17 03:59:32 +00:00
Aryeh Gregor
3a0c45e93c * urlencode username so rollback-on-history works for users with funny names
* Move rollback-link-generating code to Linker::generateRollback
2006-11-16 22:53:01 +00:00
Tim Starling
36ed0cd96c Reverting 17479/17480, breaks subclassing of Linker methods by skins. See my comment on bug 7405. 2006-11-08 07:12:03 +00:00
Nick Jenkins
fa239349f2 * (bug 7405) Make Linker methods static. Patch by Dan Li. 2006-11-08 05:21:15 +00:00
Andrew Garrett
256c6e2c04 (bug 5936) Show an 'm' to the left of the edit summary on diff pages for minor edits. 2006-11-07 13:22:34 +00:00
Tim Starling
e174a4ddfb Abolished $wgDBname as a unique wiki identifier, it doesn't work with the new-fangled feature we call "table prefixes". Instead use wfWikiID() for an identifier containing the DB name and the prefix if there is one, and wfMemcKey() for cache key construction.
Caches for wikis with table prefixes will be lost on upgrade, caches for wikis without table prefixes will be preserved. Custom cache keys in extensions can be migrated at leisure. Extensions which write to core cache keys should be migrated ASAP, as I have done with Special:Makesysop.
2006-10-04 09:06:18 +00:00
Tim Starling
3005679b0e * Removed lots of explicit require_once statements. The autoloader should theoretically be faster, because it always uses an absolute path, eliminating the need for a search, and it is never called unnecessarily. Absolute paths are also more robust in the face of odd configurations or usage patterns. Moved a few constants around to support this, they always have to be available before the method call.
* Deleted DatabaseMysql.php, no longer necessary, database classes are autoloaded. 
* Moved wfGetMimeMagic() to MimeMagic::singleton()
* Fixed a couple of __CLASS__.'::'.__FUNCTION__ things.
2006-10-03 13:00:52 +00:00
Tim Starling
43b2fb56b6 Merged localisation-work branch:
* Made lines from initialiseMessages() appear as list items during installation
* Moved the bulk of the localisation data from the Language*.php files to the Messages*.php files. Deleted most of the Languages*.php files.
* Introduced "stub global" framework to provide deferred initialisation of core modules. 
* Removed placeholder values for $wgTitle and $wgArticle, these variables will now be null during the initialisation process, until they are set by index.php or another entry point.
* Added DBA cache type, for BDB-style caches. 
* Removed custom date format functions, replacing them with a format string in the style of PHP's date(). Used string identifiers instead of integer identifiers, in both the language files and user preferences. Migration should be transparent in most cases.
* Simplified the initialisation API for LoadBalancer objects.
* Removed the broken altencoding feature.
* Moved default user options and toggles from Language to User. Language objects are still able to define default preference overrides and extra user toggles, via a slightly different interface.
* Don't include the date option in the parser cache rendering hash unless $wgUseDynamicDates is enabled.
* Merged LanguageUtf8 with Language. Removed LanguageUtf8.php. 
* Removed inclusion of language files from the bottom of Language.php. This is now consistently done from Language::factory(). 
* Add the name of the executing maintenance script to the debug log. Start the profiler during maintenance scripts.
* Added "serialized" directory, for storing precompiled data in serialized form.
2006-07-26 07:15:39 +00:00
Antoine Musso
93154120cc Remove forced dereferencements (new() returns a reference in PHP5) 2006-07-11 14:11:23 +00:00
Brion Vibber
6f2a8eb640 * (bug 6304) Show timestamp for current revision in diff pages
* Vertically align current version with old version header in diff display
2006-06-18 22:53:35 +00:00
Brion Vibber
4674fa8fa6 * (bug 4280) Use 'noindex,nofollow' instead of 'noindex,follow' for default
meta robots tag on diff view and special pages. Should reduce impact of
  robots on scrolling special pages, diffs etc on sites where robots.txt
  doesn't forbid access.
2006-06-07 00:21:39 +00:00
Domas Mituzas
e6085d6e36 AutoLoad Revision 2006-06-06 10:56:46 +00:00