Commit graph

8 commits

Author SHA1 Message Date
Timo Tijhof
ce96bed119 jobqueue: combine Logger channels, improve docs, add missing ingroup tags
* combine `JobQueueFederated` and `JobQueueRedis` into a single
  `JobQueue` channel.

* Remove duplicate descriptions from file blocks in favour of class
  doc blocks. This reduces needless duplication and was often
  incorrect or outdated, and helps (ironically) to make the file header
  more consistently visually ignorable. Various files in this patch
  contained bogus copy-pasta descriptions from unrelated classes,
  and re-defined `defgroup JobQueue` many times, showing exactly
  how this is defacto ignored and counter-productive to maintain
  in two places.

  Remove `ingroup` from file blocks in class files as otherwise
  the file is indexed twice (e.g. in Doxygen) which makes navigation
  on doc.wikimedia.org rather messy for classes in this group.

  Ref <https://gerrit.wikimedia.org/r/q/message:ingroup+is:merged>

Change-Id: I926a3aec2bc98fefa1075c4a794c46108579ae3f
2024-03-25 15:00:38 -07:00
Brian Wolff
16706787f2 Add comment warning about how allowRetries() ignored during timeout
When using WMF style change-propagation, the code processing
allowRetries() may not execute during a timeout resulting in the
job being retried even if it should not be. This is confusing
so add a code comment about it.

Bug: T358939
Change-Id: Iecf7fe452f16413199fee75131274d65a5ccd5e0
2024-03-02 05:07:20 +00:00
Derick Alangi
92800e8d63
jobqueue: Deprecate ::toSerializableArray() and remove unused
JobSpecification::toSerializableArray() has no usage so should be
deprecated and removed.

Also, JobSpecification::getTitle() has long been deprecated and
can now be removed as there are no callers.

NOTE: Some minor typo fix in documentation.

Change-Id: I83bb9c70d7942d376d585b119b685250c45c1e88
2023-07-08 19:10:01 +03:00
daniel
e6e0ad2472 Replace "@stable for implementation" with "@stable to implement"
For compliance with the new version of the table interface policy
(T255803).

This patch was created by an automated search & replace operation
on the includes/ directory.

Bug: T257789
Change-Id: I17e5e92e24c708ffc846945a136347670a3a20c7
2020-07-13 11:05:49 +02:00
daniel
442fb30ce1 Stability annotations for interfaces.
Per the Stable Interface Policy, PHP interfaces should not be
directly implemented by extensions, unless they are marked to be safe
for that purpose.

Bug: T247862
Change-Id: Idd5783b70fc00c03d57f5b1a887f0e47c4d7b146
2020-07-07 22:01:29 +00:00
Reedy
d53e91d272 Fix more PSR12.Properties.ConstantVisibility.NotFound
Change-Id: I94520b10d78a17ea8e965633dd475ea711f25c99
2020-05-15 00:33:32 +01:00
Aaron Schulz
2c74f7205b jobqueue: mention more methods in RunnableJob to fix various IDEA warnings
Change-Id: I156411062ae7831c935869d226fc4934bde55107
2019-07-05 21:02:17 -07:00
Aaron Schulz
fc5d51f129 jobqueue: add GenericParameterJob and RunnableJob interface
Simplify the code of jobs that do not care about titles and removes
the direct Title dependency from JobQueue. Remove getTitle() from
IJobSpecification itself. Move all the Job::factory calls into a
single JobQueue::factoryJob() method.

Depends-on: Iee78f4baeca0c0b4d6db073f2fbcc56855114ab0
Change-Id: I9c9d0726d4066bb0aa937665847ad6042ade13ec
2019-04-08 11:05:23 -07:00