Needs to be a real path, not relative one
6) FileTest::testGetThumbnailSource with data set #2 (array(true,
array('/tmp'), 1024, 2048, '/tmp', 'Temporary path because temp f...
found'))
Temporary path because temp file was found
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'/tmp'
+'fsFilePath'
The file_exists in File::getThumbnailSource gets the path '/tmp' and
that does not exists on windows, because it is relative to one of the
core folder
Change-Id: I8618c8b34261451da42f88360a9d65353960e91f
These accounts are usually very old and User::getRegistration returns
null for them because user_registration is null. Treat these accounts
as old enough to be in the most experienced group and only decide
on edit count. Fix queries in recent changes to avoid comparisons
with nulls as well.
Also improve documentation of User::getExperienceLevel.
Change-Id: I6090cf9b9097069469e8e547b217f0d16f0fe372
This does not help to avoid the suppression inside the class,
but it avoids the suppression for all callers
Remove unneeded local vars while looking at the code
Bug: T269895
Bug: T216348
Change-Id: I5ce9a2dddca2b3bb556eb7adb5305178db09a71a
Some changes needed for the migration:
Postgres:
- Add default to five fields that have it in MySQL
- Make log_params not nullable
- Change log_comment_id and log_actor type to big integer
- Change log_namespace to integer
- Drop logging_actor_time index
MySQL/SQLite
- Change log_title to varbinary/BLOB
Bug: T230428
Bug: T164898
Change-Id: Iad59d2a78f61d93637917ca320d3e173863ce5e1
Since the legacy parser will also be emitting the new media structure
that requires these styles. For now, the feature is only shipped by
default when $wgUseNewMediaStructure is enabled.
Bug: T51097
Bug: T266148
Change-Id: Id20d716ce145e0bae37621fd6e218a793b5332ae
Described at https://www.mediawiki.org/wiki/Parsing/Media_structure
This flag is only intended to be around for a few months as we make the
transition.
Bug: T51097
Bug: T266148
Change-Id: I08eb34123b40bbe1cdfa4b1fb8e405680b441011
empty arrays are not valid icons and cannot be output.
Rather than expecting skins to handle this, this should be taken care
of in the getFooterIcons method
Bug: T269776
Change-Id: Ie4474cee5f618569604b0d84d9290b5bcc53f495
Log errors in Vue.js components to:
- The console via console.error(), the default behavior of the Vue.js
runtime; and
- Any subscriber of the global.error analytics event topic. On the
Wikipedias, for example, global.error analytics events make their way
to Wikimedia's Logstash instance via EventGate.
Bug: T249826
Change-Id: I3038e88ac82992bf50e966f52cc800626b020860
As we further develop the capabilities of the skin, we will make
breaking changes as we fold functionality of extensions into
core (e.g. DismissableSiteNotice) and deprecate/change the data
provided in SkinMustache::getTemplateData
Providing a skin version which changes with major changes, allows
us to safely update extensions and skins.
It will be used immediately in I276325d
Change-Id: Ib4799e5380b472f6c2372c5982b24a404b756a7e
Some function using union type string|Message where string is a message
key and not html. This can be marked as tainted to avoid double escape
issues from taint-check
Bug: T216348
Change-Id: I40a305b5e49d67b3f6d7737c0846b93a80b78fa9
This reverts commit 05821b8c0d.
Reason for revert: Fixed with backport in OOUI lib itself, instead of masking only one (popular) instance. Backport at I468cf0bbee9de896e75a9a3e926d31a9f934e204
Change-Id: Iaa82bfdd4728481789404aecd64215f3f8705209
Create mw.errorLogger.logError() so that developers can log errors that,
for whatever reason, won't cause the JavaScript runtime to raise an
error event on the window object.
A motivating usecase is logging thrown by Vue.js components. Those
errors are caught by the Vue.js runtime and logged via console.error().
Bug: T249826
Change-Id: Icdb5ea4678df61d8cb7fd5cba5091cab1ec5b7cb
When the previous/next texts are proper links (i.e. we’re not at the end
of that range), we don’t want them to be escaped for the message.
Bug: T269830
Change-Id: I2bd214d8df7153c5780332998600251b191b6396
