Commit graph

85 commits

Author SHA1 Message Date
River Tarnell
a6f6e04841 instead of storing every mail as a job, have a job to send enotif updates for the whole mail at once. 2007-05-11 16:42:18 +00:00
Aryeh Gregor
7125495256 (bug 9860) Fix bug caused by true == 'default' (don't you love PHP?). Thanks to Ben White/Philip.
I'm not sure how to phrase this for RELEASE-NOTES since I'm not sure what it does exactly; does it only affect extension-writers or something?  From looking at the code I can't even see how the execution path is ever even followed, except maybe from maintenance scripts.
2007-05-10 01:24:51 +00:00
Brion Vibber
9150412fe7 For now revert the rev_deleted branch merge; don't want trunk to get too far gone before changes are reviewed!
Reverted: 20511, 20510, 20507, 20474, 20461, 20460, 20457, 20448, 20446
2007-03-16 16:01:07 +00:00
Aaron Schulz
2448539ad9 *Merge in phase3_rev_deleted/includes 2007-03-14 15:50:06 +00:00
Nick Jenkins
f88c771756 The war on redundant ampersand usage!
* Convert "$dbw =& wfGetDB( DB_MASTER );" --> "$dbw = wfGetDB( DB_MASTER );"
* convert "$skin =& $wgUser->getSkin();" --> "$skin = $wgUser->getSkin();"

For the time being have not changed the function definitions of wfGetDB() or User::getSkin() [i.e. they are still both return-by-ref], so as to ensure the interface does not change for extensions [some of which may still be trying to run on PHP4 environments]. However presumably at some point this can be changed too.

Also includes tiny tweak to newlines in parserTests - will show 1 rather than 2 newlines between the "Reading tests from" strings when in quiet mode.
2007-01-22 23:50:42 +00:00
Nick Jenkins
468a8890c5 Prevent minor E_STRICT warning:
* Strict Standards: Non-static method RecentChange::newFromRow() should not be called statically in includes/SpecialRecentchanges.php on line 243.
2007-01-22 05:57:04 +00:00
Antoine Musso
c771fc9c96 Use Doxygen @addtogroup instead of phpdoc @package && @subpackage 2007-01-20 15:09:52 +00:00
Nick Jenkins
784e69d028 For the "includes/" directory:
* removing unused local vars
* removing used global declarations
* adding FIXMEs against extract() calls and lines that seem to be using uninitialized variables
* adding some array() declarations.
2007-01-12 10:03:51 +00:00
Brion Vibber
803b3c07f8 Because I just know someone's going to complain about watchlists/RC being cluttered up by 'X bytes' instead of 'X', for the moment I'm splitting this to use the new rc-change-size message, and leave it at '$1' by default (so no change from the old behavior, showing number alone).
One could stick in the labeling if one desired, or leave it blank.
2007-01-07 10:54:02 +00:00
Niklas Laxström
febd48e588 * nbytes uses {{plural}}, support it 2007-01-05 23:18:37 +00:00
Antoine Musso
5110025fd0 Fix #8330: Recentchanges counter is confusing 2007-01-04 19:12:52 +00:00
Leon Weber
483d545d09 Corrected the description... 2006-12-25 15:17:33 +00:00
Leon Weber
3e8d663fe1 * (bug 8331) Added the change size value to watchlists; therefor made
watchlists use RecentChange::newFromRow() instead of newFromCurRow()
2006-12-23 23:08:41 +00:00
Rob Church
cb8b609a39 Sort out user rights when patrolling. If a user has the "autopatrol" right, then their edits are auto-marked as patrolled. If a user *doesn't* have this right, then they can't mark their own edits as patrolled in the normal fashion. 2006-12-22 19:43:20 +00:00
Brion Vibber
8ae8e5f587 Revert r18468
Makes no sense
2006-12-20 22:04:44 +00:00
Aryeh Gregor
3d8659162d * Fix typos in new class names (thanks to BrokenArrow)
* Use <strong class="mw-plusminus-neg">, not <span class="mw-plusminus-bold">
* Add correct coloring for null edits to non-Monobook-based skins
2006-12-20 21:54:04 +00:00
Leon Weber
40b3805dbf Made the change size value on recentchanges show minuses instead of dashs. Workaround until they've fixed bug 8327. 2006-12-20 16:37:27 +00:00
Leon Weber
985ca55b8a Added missing closing bracket when the diff is below the threshold. 2006-12-16 18:56:40 +00:00
Leon Weber
c62e068b27 * Made the show change size function work on page moves, page creations, and
log entries.
* Also fixed it in the javascript recentchanges.
* Moved the value behind the page title to ensure the columns are still lined up
* Merged both sql patches into one.
* Set the default for both columns to NULL to make it work on edits before the db
  update.
2006-12-13 20:08:02 +00:00
Leon Weber
4ff0b373ac Fix to use the correct css class 2006-12-10 09:49:29 +00:00
Leon Weber
6362c4f645 Fixing a bug in my last commit to make it also work on related changes. 2006-12-09 12:28:02 +00:00
Leon Weber
7531338080 * DB schema change: added two columns (rc_old_len and rc_new_len) to the recentchanges table to store
the text lengths before and after the edit
* (bug 1085) Made Special:Recentchanges show the character difference between the changed revisions
2006-12-09 11:36:35 +00:00
Nick Jenkins
74ea267553 Prevent the following strict-standards warnings - i.e. when running with error_logging(E_ALL | E_STRICT); - which seems to disable the yucky "@" operator, as well as maxing out the pedantry of warnings. Nothing major found, just nice to be as explicit and as forward-compatible as possible.
* Strict Standards: Undefined index: switch in includes/Parser.php on line 3849
* Strict Standards: Undefined index: ref in includes/Parser.php on line 3818
* Strict Standards: Non-static method OutputPage::setEncodings() should not be called statically in index.php on line 11
* Strict Standards: Only variables should be assigned by reference in includes/Skin.php on line 888
* Strict Standards: Non-static method Title::newFromURL() should not be called statically in includes/SpecialContributions.php on line 178
* Strict Standards: Only variables should be assigned by reference in includes/GlobalFunctions.php on line 2054
* Strict Standards: Undefined index:  contributions-summary in languages/Language.php on line 764
* Strict Standards: Undefined index:  trackbackhtml in skins/MonoBook.php on line 86
* Strict Standards: Undefined index:  blockip in skins/MonoBook.php on line 204
* Strict Standards: Undefined index:  tagline in skins/MonoBook.php on line 261
* Strict Standards: Undefined index: uselang in includes/SkinTemplate.php on line 1159
* Strict Standards: Non-static method CoreParserFunctions::plural() cannot be called statically in includes/Parser.php on line 2902
* Strict Standards: Undefined offset:  0 in includes/SkinTemplate.php on line 196
* Strict Standards: Undefined index:  USE INDEX in includes/Database.php on line 1015
* Strict Standards: Undefined index:  image_tests in includes/Parser.php on line 3488
* Strict Standards: Undefined offset:  0 in includes/Parser.php on line 3507
* Strict Standards: Non-static method ChangesList::newFromUser() should not be called statically in includes/SpecialWatchlist.php on line 361
* Strict Standards: Non-static method RecentChange::newFromCurRow() should not be called statically in includes/SpecialWatchlist.php on line 367
* Strict Standards: is_a(): Deprecated. Please use the instanceof operator in includes/Exception.php on line 168
* Strict Standards: Non-static method LogPage::logName() should not be called statically in includes/SpecialContributions.php on line 325
* Strict Standards: ob_end_flush(): failed to delete and flush buffer. No buffer to delete or flush. in maintenance/commandLine.inc on line 191
* Strict Standards: Undefined index:  meatball in languages/Language.php on line 234
* Strict Standards: rmdir(/tmp/mwParser-2108164586-images/thumb): Directory not empty in maintenance/parserTests.inc on line 605
* Cleaning out some new temp files left over by parserTests (there were one or two straggler dirs/files that would persist after the test run ended, due to new tests being added over time)
* Strict Standards: Non-static method CoreParserFunctions::special() cannot be called statically in includes/Parser.php on line 2902
* Strict Standards: Declaration of ListUsersPage::preprocessResults() should be compatible with that of QueryPage::preprocessResults() in includes/SpecialListusers.php on line 38
* Strict Standards: Only variables should be passed by reference in includes/SpecialBlockip.php on line 175
* Strict Standards: Skin::include_once(skins/Standard.deps.php) [<a href='function.include-once'>function.include-once</a>]: failed to open stream: No such file or directory in includes/Skin.php on line 121
* Strict Standards: Declaration of ApiMain::getResult() should be compatible with that of ApiBase::getResult() in includes/api/ApiMain.php on line 35
* Strict Standards: is_a(): Deprecated. Please use the instanceof operator in includes/WikiError.php on line 63
* Strict Standards: Non-static method WikiError::isError() should not be called statically in includes/SpecialImport.php on line 64
* Strict Standards: Non-static method ImportStreamSource::newFromInterwiki() should not be called statically in includes/SpecialImport.php on line 58<b
* Strict Standards: Only variables should be assigned by reference in includes/SpecialUndelete.php on line 501
* Strict Standards: Non-static method Image::newFromName() should not be called statically in thumb.php on line 56
* Strict Standards: Non-static method CoreParserFunctions::numberoffiles() cannot be called statically in includes/Parser.php on line 2902
* Strict Standards: Non-static method CoreParserFunctions::statisticsFunction() should not be called statically in includes/CoreParserFunctions.php on line 139
* Strict Standards: Non-static method CoreParserFunctions::isRaw() should not be called statically in includes/CoreParserFunctions.php on line 128
* Strict Standards: Non-static method CoreParserFunctions::grammar() cannot be called statically in includes/Parser.php on line 2902
* Strict Standards: Undefined offset:  1 in includes/SpecialMIMEsearch.php on line 130
* Strict Standards: Undefined index:  recentchangeslinked in skins/MonoBook.php on line 184
* Strict Standards: Declaration of DumpNotalkFilter::pass() should be compatible with that of DumpFilter::pass() in includes/Export.php on line 612
* Strict Standards: Declaration of DumpNamespaceFilter::pass() should be compatible with that of DumpFilter::pass() in includes/Export.php on line 665
* Strict Standards: Non-static method ImportStreamSource::newFromUpload() should not be called statically in includes/SpecialImport.php on line 46
* Strict Standards: Undefined offset:  5 in includes/Sanitizer.php on line 396
* Strict Standards: Undefined index:  wikidbUserName in includes/SpecialUserlogin.php on line 562
* Strict Standards: Only variables should be assigned by reference in includes/api/ApiQueryBase.php on line 95
* Strict Standards: Only variables should be assigned by reference in includes/api/ApiQueryBase.php on line 116
* Strict Standards: Only variables should be assigned by reference in includes/api/ApiQueryWatchlist.php on line 128
* Strict Standards: Undefined property:  stdClass::$rc_id in includes/api/ApiQueryBase.php on line 131
* Strict Standards: Undefined property:  stdClass::$rc_last_oldid in includes/api/ApiQueryBase.php on line 164
* Strict Standards: Undefined property:  stdClass::$rc_moved_to_ns in includes/api/ApiQueryBase.php on line 285
* Strict Standards: Undefined property:  stdClass::$rc_patrolled in includes/api/ApiQueryBase.php on line 176
* Strict Standards: Undefined index:  comment in includes/api/ApiFeedWatchlist.php on line 85
* Strict Standards: Undefined offset:  0 in includes/Skin.php on line 302
* Strict Standards: Non-static method User::SetupSession() should not be called statically in includes/SpecialUserlogin.php on line 15

... There are certain to be other things too, so this is not intended to be comprehensive, rather the above just stops most of the notifications I observed.
2006-11-29 05:45:03 +00:00
Nick Jenkins
14c53b728f Code housekeeping stuff (and barring any stuff-ups on my behalf, there should be no changes in behaviour whatsoever after this) -
* removing some unused global declarations.
* removing or commenting out or adding comments for unused local vars.
* Adding one or two local var declarations.
* Declaring $matches array passed to preg_match() / preg_match_all() as array() before using [not required, just have a slight preference for the explicitness].
* remove one or two pass-by-reference function declarations where the value is not modified.
* Adding some braces to if-else blocks.
* In Parser.php, stripstrate is now an object rather than an array as per r17820, so we no longer need ask for a reference to it (as in "$x =& $this->mStripState;"), and in fact it's probably just simpler to get rid of $x altogether.
* Moving some preg regexes from "" quoting to '' quoting to stop static analyzer whinging about bad escape sequences.

... up to "LinksUpdate.php" in the includes/ directory.
2006-11-23 08:25:56 +00:00
Tim Starling
588a83905b hook for RC events 2006-09-30 12:34:53 +00:00
Brion Vibber
f99565fbab * (bug 7305) Proper compare for bot check on RC notify, should fix overrides
that force edits by non-bot users to bot mode
2006-09-13 15:35:30 +00:00
Greg Sabino Mullane
4b6d775b37 Use NULL not empty string for rc_ip if our DB is picky. 2006-08-16 00:59:34 +00:00
Greg Sabino Mullane
a9d232c10b Use NULL instead of 0 to indicate "no page" for cases where rc_cur_id is a FK. 2006-07-23 01:13:56 +00:00
Rotem Liss
ee7ab4900e Making User::isBot deprecated, using User::isAllowed('bot') instead, making it a wrapper of User::isAllowed, and deleting several obsolete comments. 2006-07-16 16:42:15 +00:00
Antoine Musso
fd912a148b A lot more of static issues when using E_STRICT from the commandline. 2006-07-10 15:41:30 +00:00
Tim Starling
044f563110 fixed minor bug 2006-06-20 09:38:14 +00:00
Brion Vibber
0a26267688 Revert to r14512; domas introduced massive breakage with incomplete experimental changes. They will be recommitted when they work. :) 2006-06-01 08:19:02 +00:00
Domas Mituzas
bda0b8e104 Use AutoLoader to load classes:
* remove require_once() throughout whole code, yet left in few places
* move global functions in HttpUtils, ProxyTools, Credits to class methods
* php5 only: __autoload() now used, combined with class->file map and require()
* move initialization of $wgValidSkinNames to Skin::getSkinNames()
* few more changes that will surely break stuff.
2006-06-01 07:22:49 +00:00
Rob Church
fb0cb8b760 (bug 4610) Indicate patrolled status on watchlists and allow users to mark changes as patrolled using the diff links there 2006-05-23 18:23:29 +00:00
Antoine Musso
7ebdb6de89 Revert to r14165 . Did too many changes, didnt even run parserTests (i am bad) 2006-05-11 22:40:38 +00:00
Antoine Musso
3d4ea7c485 public / private / static stuff when loading Special:Recentchanges 2006-05-11 19:46:58 +00:00
Rob Church
4f4f6a42ce (bug 5424) "autopatrol" doesn't mark new articles as patrolled 2006-04-04 16:31:44 +00:00
Brion Vibber
d5064f7f5f Live IRC output fixes:
* Clean up bad chars
* Work properly with alternate entry points (eg secure.wikimedia.org)
2006-04-02 04:09:00 +00:00
Tim Starling
8966398dbe Specify both revisions in the diff link in IRC 2006-03-21 00:28:37 +00:00
Rob Church
94215f3416 (bug 4729) Add user preference that marks a user's edits as patrolled if user is able to 2006-03-18 22:47:40 +00:00
Tim Starling
8ae723cf37 better IRC lines for log entries 2006-03-06 13:51:58 +00:00
Brion Vibber
26cc539cac * Skip loading of RecentChange.php except where needed
Moved constants to Define.php; removed unneeded includes until use of RecentChange:: in Article, Log, CheckUser
2006-01-09 21:09:33 +00:00
Magnus Manske
a80b614846 Setting dummy variable to prevent error message in SpecialRecentchangeslinked 2006-01-08 15:26:20 +00:00
Ævar Arnfjörð Bjarmason
a26d5a49d7 * s~\t+$~~ 2006-01-07 13:31:29 +00:00
Brion Vibber
1c9c38d38c Cleanup...
* Move template / squid purging back to onArticleEdit() out of updateArticle()
* Move email notifications from showArticle() to RecentChange::save(), next to the IRC updates
* Use INSERT IGNORE instead of REPLACE for WatchedItem::watch(), avoids breaking notification timestamps for the auto-add on the user talk
2005-12-08 01:36:33 +00:00
Antoine Musso
0ae5e02990 * really comment commented live hack (some calls were still around)
* redundant ip=''
* code formatting
2005-12-04 20:51:02 +00:00
Ævar Arnfjörð Bjarmason
7d657c5116 * (bug 327��) modify teh rc putput 2005-11-04 12:07:32 +00:00
Ævar Arnfjörð Bjarmason
b3c89f2975 * (bug 3270) show put rc_id in the IRC RC url for wikis that have $wgUseRCPatrol enabled 2005-11-03 11:27:10 +00:00
Brion Vibber
67ccbfd605 * Skip update of disused 'rc_cur_time' field (todo: discard the field) 2005-09-20 00:14:01 +00:00
Tim Starling
9260c3b7ca Deferred initialisation of $wgIP, because it's potentially slow, especially if and when we add the 200 NTL proxies to the trusted XFF list. I was hoping to avoid initialisation altogether for anonymous page views, but that turns out to be difficult because of user_newtalk. It is, however, avoided for action=raw. Tested page view, newtalk, IP registration in history and recentchanges, IP block, autoblock and Special:Version.
Also moved the old proxy scan code from EditPage.php to a more appropriate location in ProxyTools.php.
2005-09-05 02:22:20 +00:00