Adds a CSS-only version of Codex Radio via HTMLRadioField.
Iterates through the list of options obtained from `getOptions()`
and generates the HTML markup for each radio input, radio icon,
and radio label. The three elements (input, icon, label)
combined make a single Codex Radio. The Radios are appended to
an empty `$html` string variable. The function returns the
concatenated HTML markup.
Bug: T359015
Change-Id: I73b2e95cff0bc50ba1bc70457d65e286592288ac
Since the method for constructing a serialized value container via
`newUnified()` has been removed in Id5179be032d45732db659d506d2781,
its corresponding `isUnified()` method is now obsolete and this
patch deprecates it to be removed in 1.43.
Bug: T344521
Change-Id: I5a90028c2a596dfec9a1df306cc9d0ab90dfedd6
* Add a comment explaining why we need table aliases in HideUserUtils
subqueries.
* Use the table aliases consistently in inner field references. While
this does not appear to be strictly necessary, since unprefixed fields
refer to the inner query by default, it helps to improve the clarity
of the code.
Change-Id: Id68684ea12060a259dc87e66edd63b925da2c3b1
Seen in CI for php8
PHP Fatal error: Declaration of PublishStashedFileJob::getUpload() must
be compatible with UploadJobTrait::getUpload(): UploadBase in
/workspace/src/includes/jobqueue/jobs/PublishStashedFileJob.php on line
68
Follow-Up: I28d0be0239f3b25efc6ea8bc3d400b9d0f5bc7bf
Change-Id: Icb516ac1cfffd9589aa047aa8450c49bc1ab2379
The Codex implementation of HTMLNamespacesMultiselectField and
HTMLTitlesMultiselectField falls back to a simple `<textarea>`, which is
also what the OOUI implementation does if JS is not available. However,
OOUI sets rows=10, which results in a much more reasonably sized
textarea then HTMLTextAreaField's default of rows=25.
Pass rows=10 to HTMLTextAreaField, but allow the field params to
override this.
Change-Id: I1e9a1ab6b4a71fb247bfe7861a49bb6cfeb61f54
This patch deletes the `::getConfig()` method in the SiteConfiguration
class. It's no longer used and due for removal.
Bug: T289543
Change-Id: Ie94b95feb7fd0885b7c224533868e654453071cd
This patch deletes the `::newUnified()` method from this class, it's
already hard deprecated and due for removal.
Bug: T344521
Change-Id: Id5179be032d45732db659d506d2781752f03f8be
There's no index on bt_user_text alone, only one that is prefixed with
bt_ip_hex. So include a condition on bt_ip_hex when searching for blocks
by username.
Bug: T360165
Change-Id: I99ed17ed66449ab7c3f76c98d90f91a75fbd8fd5
Only docs needs adjust, but phan is using this needs changes in the
search related classes.
Doc change in IForeignRepoWithDB is needed, the implementation in
LocalRepo returns the value from IConnectionProvider::getReplicaDatabase
Change-Id: I01a1aa0ddbc756226d8e3404ac1cc3350ad5df64
Add a temporary feature flag that is going to be covering the work
around implementing a logout confirmation.
Bug: T357484
Change-Id: I3ee8f52976cb956e24f32115c02903c5c4f358c3
Every Wednesday, we get hundreds of user-visible storage failures,
because there is only one global storage token and it has a lifetime of
one week. The code assumes that requesting a token regularly will avoid
expiry, but that is not the case.
So, when a request fails with a 401, refresh the auth token, then retry
the request. Factor out HTTP request handling to allow this.
Swift gives us the remaining lifetime of the token in seconds, so use
that as the server and process cache expiry time. There will be a
stampede when it expires, but my laptop can do 700 req/s single-
threaded, so it should be OK.
Add tests to cover the cases previously handled by checking the return
value of getAuthentication().
Bug: T358830
Change-Id: If9fe4dde4127592adae1b81e8eb925c4f59443d9
QUERY_CHANGE_[SCHEMA|LOCKS] includes QUERY_IGNORE_DBO_TRX, which
messed up the write query detection logic which assumed a lone
QUERY_IGNORE_DBO_TRX flag is enough to fulfill the condition
that the query has either some read query flag or some write
query flag. Query::isWriteQuery() (correctly) disagreed and that
lead to exceptions thrown in some cases.
Bug: T358236
Change-Id: I8cd2d85e96d52158f9fb5462be2df5c07d0e982a
ExternalStoreDB table initialization fails in Query:isWriteQuery(),
as Query couldn't determine if it is a write query.
ExtenrlaStoreDB should use ::QUERY_CHANGE_SCHEMA flag instead.
Bug: T358236
Change-Id: Ib23d7ff4b23c7dbb4a2d66ffcf03dc256136f024
