Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
92336 commits 1 branch 0 tags 744 MiB
Commit graph

13 commits

Author SHA1 Message Date
Thiemo Kreuz
e06ce9f467 tests: Prefer PHPUnit's assertSame() when comparing empty strings 
assertSame() is guaranteed to never do any magic type conversion.
This can be critical when accidentially comparing empty strings (a
value PHP considers to be "falsy") to false, 0, 0.0, null, and such.

Change-Id: I2e2685c5992cae252f629a68ffe1a049f2e5ed1b
 2019-09-20 15:27:58 +00:00
Thiemo Kreuz
f5a31f5be0 Remove comments literally documenting unit tests being unit tests 
The name of the test class and method as well as the @covers tags already
explain well enough which code a test is testing. Repeating this does not
provide additional information.

Change-Id: Ieec4ec131e5925d11704a11e1df46bc00c9fad9b
 2019-02-19 15:18:12 +01:00
Umherirrender
45da581551 Use ::class to resolve class names in tests 
This helps to find renamed or misspelled classes earlier.
Phan will check the class names

Change-Id: Ie541a7baae10ab6f5c13f95ac2ff6598b8f8950c
 2018-01-26 22:49:13 +01:00
Kunal Mehta
6e9b4f0e9c Convert all array() syntax to [] 
Per wikitech-l consensus:
 https://lists.wikimedia.org/pipermail/wikitech-l/2016-February/084821.html

Notes:
* Disabled CallTimePassByReference due to false positives (T127163)

Change-Id: I2c8ce713ce6600a0bb7bf67537c87044c7a45c4b
 2016-02-17 01:33:00 -08:00
Vivek Ghaisas
c54766586a Fix issues identified by SpaceBeforeSingleLineComment sniff 
Change-Id: I048ccb1fa260e4b7152ca5f09b053defdd72d8f9
 2015-09-26 23:06:52 +00:00
Timo Tijhof
b4bac102b6 tests: Clean up file headers 
* Remove redundant @licence/@license from test suite files.
  They already have full licence headers. And @licence raises a
  warning in Doxygen.

* Fix weird messes of comments inside comments and other things.

Change-Id: I38da8ca76330f72b8dc22b0ecf1ea69d5ea55ede
 2015-04-01 00:17:12 +01:00
addshore
4e941cf4ca Add @covers tags for more tests 
Change-Id: Iff3af78e9b41c445b7f066b6c0d0f4a87d2d6c4e
 2013-10-21 11:28:39 +02:00
Siebrand Mazeland
791d0b2a98 Update code formatting 
Change-Id: I16a9b42651f1cfb1a70dffbb67b7b83dfeb90d03
 2013-04-26 14:21:20 +00:00
Timo Tijhof
b36d883017 Tests: Make phpunit providers "public static". 
Follows-up I9d2b148e57 (including phpunit/languages this time).

Bug: 46434
Change-Id: I30e5efcd88c516121c454676bd7a18f9b7c8fca6
 2013-03-22 03:12:37 +01:00
Siebrand Mazeland
49dfbc59d0 Update formatting 
6 of n.

Change-Id: I0ca3f1f72349623631ce1d7f3a4e2ed5edbdbdf4
 2013-02-15 12:44:42 +00:00
Antoine Musso
0fd05285d7 pass codesniffer on tests/ 
Fix almost all occurences of the following sniffs:

Generic.CodeAnalysis.UselessOverridingMethod.Found
Generic.Formatting.NoSpaceAfterCast.SpaceFound
Generic.Functions.FunctionCallArgumentSpacing.SpaceBeforeComma
Generic.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLine
Generic.PHP.LowerCaseConstant.Found
PSR2.Classes.PropertyDeclaration.ScopeMissing
PSR2.Files.EndFileNewline.TooMany
PSR2.Methods.MethodDeclaration.StaticBeforeVisibility

Change-Id: I96aacef5bafe5a2bca659744fba1380999cfc37d
 2013-01-28 12:14:26 +01:00
jeroendedauw
232dfda61c Implemented Serializable interface in Site 
Change-Id: I1d8394e0aa65e6ba16f1a1c1021bcae93ebb3e41
 2013-01-24 14:41:59 +01:00
jeroendedauw
a00337c3f8 Design improvements to sites code 
Change-Id: I08ffa6a97093abbe85169f664b97498c5f39bf8e
 2013-01-22 15:39:23 +01:00
Renamed from tests/phpunit/includes/site/SiteObjectTest.php (Browse further)