Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
36605 commits 1 branch 0 tags 744 MiB
Commit graph

92 commits

Author SHA1 Message Date
Alexandre Emsenhuber
48192cfe7c Follow-up r90334 and r90337: made DifferenceEngine::addHeader() non-static to be able to use $this->mTitle instead of $wgTitle 2011-06-29 10:51:15 +00:00
Platonides
71a0ad0101 Follow up r90334. 
Removes the space after the class name in $wgBetterDirectionality = false,
I think it is clearer to have the variable to hold the classes, instead of the *additional* classes.
Renamed to be clearer and be camelCase.
Added redundant htmlspecialchars() and spaces.
 2011-06-19 18:53:55 +00:00
Robin Pepermans
ca6fcb7e3f Address comment by Platonides on r90320: 
* undefined variable $list in CategoryPage.php
* move code in ParserOptions to a new member of Title class, which falls back to $wgContLang
 2011-06-18 14:49:01 +00:00
Robin Pepermans
9077baef30 Follow-up to r90265: directionality improvements as part of bug 6100 (under $wgBetterDirectionality): 
* Correct directionality when viewing diffs
* Correct arrows for Pager
* CSS/JS pages always 'en' (LTR)
* Messages on Special:Allmessages have lang and dir attributes based on the selected language
 2011-06-18 13:12:52 +00:00
Sam Reed
bdf84cb20e Swap else if for elseif 
Trimming trailing whitespace also

Doing in 3 commits, so hopefully reviewable in CR...
 2011-06-17 16:03:52 +00:00
Sam Reed
94bf573c03 Remove some unused variables, add/improve some documentation 2011-06-01 16:27:46 +00:00
Siebrand Mazeland
75c6696aa8 Use consistent notation for "@todo FIXME". Should update http://svn.wikimedia.org/doc/todo.html nicely. 2011-05-17 22:03:20 +00:00
Roan Kattouw
0ee7b5c2ea Kill diff.js with fire. It only applies to versions of Gecko that were released before Nov 2002, which is waaaay beyond what we support, or what anyone could conceivably be using in this day and age. 2011-05-14 23:49:29 +00:00
Brion Vibber
0c8ecd43bc * (bug 21279, bug 28820) Workaround for standard diff links to deleted revs; Special:Undelete links to deleted rev when allowed. 
Adds links to Special:Undelete to view the requested revisions onto the 'revision data not found' error message, if they can be found via ar_rev_id and the user has permission to deletedhistory.

Follow-up to r87804; allows the 'diff' links on log entries for Special:RevisionDelete actions on deleted revs referenced by rev-id to continue to go someplace semi-sane.
Could benefit a more transparent forwarding -> bug 28820.
 2011-05-10 01:17:01 +00:00
Sam Reed
15df9a9d5c Kill off the long deprecated $wgInputEncoding and $wgOutputEncoding globals 2011-05-06 22:09:47 +00:00
Sam Reed
c8079f0b81 * (bug 27185) API: Add Special:ComparePages 2011-05-01 21:56:02 +00:00
Chad Horohoe
716fd5bd76 (bug 28610) unsegement is not a word 2011-04-19 14:04:00 +00:00
Alexandre Emsenhuber
b5966436ea No need to call wfSuppressWarnings() and wfRestoreWarnings(); wfDl() already does this 2011-04-11 16:52:51 +00:00
Alexandre Emsenhuber
2300787fdc dl() -> wfDl() 2011-04-10 14:21:37 +00:00
Aaron Schulz
b845e4899a Follow up r85467: changed some countRevisionsBetween/countAuthorsBetween callers to pass in objects, which avoids queries 2011-04-05 23:28:39 +00:00
Aaron Schulz
624dfd884e * Cleanups to getFirstRevision and getEarliestTime 
* Rewrote countRevisionsBetween/countAuthorsBetween to avoid assuming rev_id is in chronological order
* Made countAuthorsBetween use $limit+1 automatically for convenience; updated callers
 2011-04-05 20:42:45 +00:00
Alexandre Emsenhuber
2fecd3ac70 Use Html::element() to generate the element; the url and the title attribute are now build only when really necessary 2011-03-12 13:45:12 +00:00
Sam Reed
8230d93a43 Explicitally define variables 2011-02-19 21:44:20 +00:00
Sam Reed
8b1bdb6e68 Remove unreachable line in DifferenceEngine 
Documentation for ObjectCache.php

Remove unused variables from CompareParsers and PreprocessDump
 2011-02-18 01:06:04 +00:00
Trevor Parscal
a8b81f9a8d Grouped diff and history modules together to help reduce cache invalidation. Loaded diff styles statically. This should help with bug #27418, but I suspect there are more cases where we need to do this sort of thing before the bug is truly resolved. 2011-02-15 22:14:03 +00:00
Mark A. Hershberger
b4cee86beb w/s fixups 2011-02-12 04:06:22 +00:00
Platonides
57e0786ec3 More wfProfileOut()ing 2011-02-10 16:04:19 +00:00
Daniel Friesen
3d220be8d6 Completely remove support for legacy style skins. All legacy skinning options are now part of a SkinLegacy/LegacySkinTemplate pair that inherits from the normal SkinTemplate setup. Also ported our three built in skins to use the new legacy classes. ( ;) if you want to kill legacy skins now, you only have to svn rm 4 files) 2011-02-04 04:18:05 +00:00
Happy-melon
e147220482 Add IDs to various revdel notices for skinning. 2011-01-05 21:25:04 +00:00
Tim Starling
ccfe5ad97b Fix for bug 26561: clickjacking attacks. See the bug report for full documentation. 2011-01-04 06:12:33 +00:00
Alexandre Emsenhuber
683dcdc83a Fix fatal error from r78264 2010-12-12 20:45:32 +00:00
Sam Reed
0de35fc275 Followup r75763, fixup wrong change of deprecated method 
No need to do separate htmlspecialchars et al, Xml::expandAttributes
 2010-12-12 18:35:19 +00:00
Aaron Schulz
0bb1fb5cbd * Removed redundant revdelete msg above content 
* Show bottom patrol link even if hook replaces preview content
* Hook doc tweaks
* Assorted minor cleanups
 2010-12-11 05:32:48 +00:00
Priyanka Dhanda
5d95c385be If we only want to show the diff this should make it faster. Sort of related to to bug 25757 2010-12-10 22:47:16 +00:00
Priyanka Dhanda
3b23590869 Reverting r77516. It ain't gonna work 2010-12-06 18:21:41 +00:00
Priyanka Dhanda
8e47474df6 Fixes bug 26163 - Missing categories and iw links on diff pages. 2010-12-01 00:12:43 +00:00
Antoine Musso
e060167c57 Stylize. No differences when using: svn diff -x -wu 2010-11-27 19:01:51 +00:00
Aaron Schulz
19ec266f5a getDiffBody() cleanups: 
* marked it explicitly public
* cleaned up return types on failure
* broke long lines
 2010-11-18 20:34:02 +00:00
Aaron Schulz
3cb06693a9 * Moved author count check to new Title::countAuthorsBetween() function 
* Added static DifferenceEngine::intermediateEditsMsg() function
* diff-multi msg use by FlaggedRevs wasn't updated after $2 param was added. Fixed this.
* Minor cleanups to getMultiNotice()
 2010-11-18 00:08:37 +00:00
Alexandre Emsenhuber
f8f6417965 * (bug 24833) Files name in includes/diff/ are now less confusing 
Diff.php                -> WikiDiff3.php, more descriptive
DifferenceEngine.php    -> WikiDiff.php, for consistency with the above and to make way for the file below
DifferenceInterface.php -> DifferenceEngine.php, since it contains the DifferenceEngine class
 2010-11-07 16:28:11 +00:00
Derk-Jan Hartman
86baf59b9c Avoid unnecessary linebreaks in difflines. Fixes bug 25725 2010-11-01 00:14:21 +00:00
Sam Reed
39c005ca79 bug 25517 Assignment in conditions should be avoided/ http://www.mediawiki.org/wiki/Manual:Coding_conventions#Assignment_expressions 2010-11-01 00:07:17 +00:00
Derk-Jan Hartman
cf881ba76d Switch the hyphen in diff output to actually minus signs. 2010-10-29 18:52:59 +00:00
Derk-Jan Hartman
53bc659170 Add a nbsp to each empty "diff-marker". 
Fixes Bug 25697
Prevent collapsed table row if both pre and post lines in the diff are totally empty.
 2010-10-29 18:28:44 +00:00
Sam Reed
a2589ff8c6 Assignment in loop conditions suck 
while ( $row = $dbw->fetchObject( $res ) ) { to foreach ( $res as $row ) in includes

Add some braces
 2010-10-13 23:11:40 +00:00
Chad Horohoe
9e6c7cc8ef Get rid of PHP4-style constructors 2010-08-30 16:52:51 +00:00
Alexandre Emsenhuber
fb36e6ac3e * standardised file headers 
* added a basic description
* added @file
 2010-08-08 11:55:47 +00:00
Aryeh Gregor
74a21f3bd1 Remove most named character references from output 
Recommit of r66254 to trunk.  This was just

find extensions phase3 -iname '*.php' \! -iname '*.i18n.php' \! -iname 'Messages*.php' \! -iname '*_Messages.php' -exec sed -i 's/ /\ /g;s/—/―/g;s/•/•/g;s/á/á/g;s/´/´/g;s/à/à/g;s/α/α/g;s/ä/ä/g;s/ç/ç/g;s/©/©/g;s/↓/↓/g;s/°/°/g;s/é/é/g;s/ê/ê/g;s/ë/ë/g;s/è/è/g;s/€/€/g;s/↔//g;s/…/…/g;s/í/í/g;s/ì/ì/g;s/←/←/g;s/“/“/g;s/·/·/g;s/−/−/g;s/–/–/g;s/ó/ó/g;s/ô/ô/g;s/œ/œ/g;s/ò/ò/g;s/õ/õ/g;s/ö/ö/g;s/£/£/g;s/′/′/g;s/″/″/g;s/»/»/g;s/→/→/g;s/”/”/g;s/Σ/Σ/g;s/×/×/g;s/ú/ú/g;s/↑/↑/g;s/ü/ü/g;s/¥/¥/g' {} +

followed by reading over every single line of the resulting diff and
fixing a whole bunch of false positives.  The reason for this change is
given in <http://lists.wikimedia.org/pipermail/wikitech-l/2010-April/047617.html>.
I cleared it with Tim and Brion on IRC before committing.  It might
cause a few problems, but I tried to be careful; please report any
issues.

I skipped all messages files.  I plan to make a follow-up commit that
alters wfMsgExt() with 'escapenoentities' to sanitize all the entities.
That way, the only messages that will be problems will be ones that
output raw HTML, and we want to get rid of those anyway.

This should get rid of all named entities everywhere except messages.  I
skipped a few things like &nbsp that I noticed in manual inspection,
because they weren't well-formed XML anyway.

Also, to everyone who uses non-breaking spaces when they could use a
normal space, or nothing at all, or CSS padding: I still hate you.  Die.
 2010-05-30 17:33:59 +00:00
Mark A. Hershberger
edc744dcd9 * remove function_exists calls for things that functions that always 
exist under supported versions of PHP
** assert() is always defined for DifferenceEngine()
** mail() is always defined for UserMailer()
** is_executable() is defined for Windows from PHP 5.0.0 on
 2010-05-19 05:33:27 +00:00
Aaron Schulz
1c4e82f84d Moved UI diff stuff into its own DifferenceInterface file 2009-09-30 15:36:55 +00:00
Aaron Schulz
942a84716a * Split off deletedrevision (view only) right and give it to sysops 
* Allow show/hide link on top revision just like history
 2009-09-28 03:09:48 +00:00
Tim Starling
51e9917aa8 Fix for bug 20601: disable debug output. It can be re-enabled by patching. 2009-09-16 03:48:29 +00:00
Niklas Laxström
22f142a99c Recommit r53710 without the hack for preventing style sheets being added multiple times (is not possible with OutputPage::addStyle in the first place) 2009-08-24 05:37:40 +00:00
Brion Vibber
82b80fc483 Revert r53710 "* Allow suppressing "line 1" from the diffs, which can get quite annoying with many diffs" 
Use of static variable here means that running multiple diffs during one request may mess things up. It should rather check if it's been added in $wgOut already.
 2009-08-21 22:01:16 +00:00
Aryeh Gregor
3f3b9d28a2 Show change flag tooltips everywhere, not just RC 
Follow-up to r54242.  Pointed out by Umherirrender on CodeReview.
 2009-08-04 00:28:20 +00:00