Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
48155 commits 1 branch 0 tags 744 MiB
Commit graph

227 commits

Author SHA1 Message Date
Reedy
c3e4057e06 Kill off numerous unused variables 
Change-Id: I7039f1328f37ee669b694f73ee282602186bffd1
 2013-03-08 02:36:24 +00:00
umherirrender
de7380b56e Change intval( User::getOption() ) to User::getIntOption() 
Also changed some getOption with int or bool cast

Change-Id: Ia551a50e9de047c62be84065481fdf8c02e2ef96
 2013-03-04 14:08:48 +00:00
Aaron Schulz
fbf34d84ab [Upload] Moved async upload stuff to the job queue. 
* (bug 44080) Also carry-over the IP and HTTP header info.
* This adds a RequestContext::importScopedSession() function.

Change-Id: Ie9c0a4d78fb719569c8149b9cc8a5430f0ac5673
 2013-02-15 15:00:35 -08:00
umherirrender
ca31ebad3f fix some spacing 
Added/removed spaces after opening/before closing parentheses

Added a space after a comma

Removed unneeded parentheses in condition

Change-Id: I306091347ccaaf11dee0cdfda3019cb0c12be51b
 2013-02-09 23:03:53 +01:00
umherirrender
1044b0b8df fix some spacing 
Change-Id: I8f976013f33c5818e4402604fe8610aa3f43b0c6
 2013-02-04 20:18:33 +00:00
Alex Monk
c2c982c4e8 (bug 36537) Rename calls to wfArrayToCGI to wfArrayToCgi 
Done with this command:
grep wfArrayToCGI * -R -l -Z | xargs -0 -l sed -i -e 's/wfArrayToCGI/wfArrayToCgi/g' && git checkout -- HISTORY

Change-Id: If7f4d4bfc199289c11c43cf519c2415a1aad1c51
 2013-01-28 18:04:20 +00:00
umherirrender
9d6575af15 The static declaration must come after the visibility declaration 
From phpcs

Change-Id: Ieab0207f965630eda113abdc0259aa2eddcf5ca7
 2013-01-26 21:03:52 +01:00
Niklas Laxström
833f87a037 (bug 44010) FauxRequest leaks cookie data from primary request 
Change-Id: I6baf972352fd69660c09a5d413ff55b81aa31305
 2013-01-16 09:45:36 +00:00
awjrichards
b786347996 Makes WebRequest::detectProtocolAndStdPort() take HTTP_X_FORWARDED_PROTO headers into account 
Change-Id: I4debf1460b6357962fc634f781416929bcca2d76
 2013-01-03 15:46:34 -08:00
IAlex
3b0f9bfe28 Merge "Tidy up some unbalanced returns in methods" 2012-12-09 09:48:40 +00:00
Reedy
d537d96868 Add numerous missing @throws to method documentation 
Change-Id: Iba868e82a75fef7c7d011bc5be192bf059d037c0
 2012-12-09 03:09:48 +00:00
Reedy
d0a242abb4 Tidy up some unbalanced returns in methods 
Leave a TODO

Change-Id: Ic49ac8630650b341aafb3c17abd22f3a07805d27
 2012-12-09 02:59:04 +00:00
umherirrender
e5f5e95137 Fix indentation whitespace errors 
Change-Id: Ie268bee2098c589c050e1b5b0e93fe1b3feca86f
 2012-10-26 17:42:13 +02:00
Aaron Schulz
5e2ac408f8 Merge "(bug 26585) Detect CSV/array values in $_SERVER['REMOTE_ADDR']." 2012-10-23 21:18:21 +00:00
Tyler Anthony Romeo
c4ed43cf6b (bug 26585) Detect CSV/array values in $_SERVER['REMOTE_ADDR']. 
Changed WebRequest::getRawIP to check for values of
$_SERVER['REMOTE_ADDR'] that are either an array
or a comma separated list of IP addresses, and throw
an exception.

Original patch by Ilmari Karonen. Adapted from original
patch to work with newer MediaWiki version.

Change-Id: I4b3c56adf46b336c5032db3f2a1e621c873f0d83
 2012-10-23 17:14:33 -04:00
umherirrender
85d8ee1f87 Remove a bunch of trailing spaces and unneeded newlines 
Change-Id: I00f369641320acd7f087427ef031f3ee7efa0997
 2012-10-10 20:14:40 +02:00
Siebrand Mazeland
d4b046a893 Update docs for return and exception info 
* Removed some inline tabs in the process.
* IDE fixed some incorrect leading spaces, too.

Change-Id: Ic9303eff6db4424ac3f1fa2816839692b43e6190
 2012-10-09 09:41:58 +00:00
Alexandre Emsenhuber
53b3c82fd7 Added WebRequest::getMethod() to get the HTTP method of the request. 
This is to replace the usage of $_SERVER['REQUEST_METHOD'].

Change-Id: I45084254c5452b00b0665df78628cfd214e39cab
 2012-08-07 18:28:43 +02:00
Alexandre Emsenhuber
737ccd82c6 In WebRequest, don't use isset() to check that a variable is null 
Change-Id: If4577b911e774e1e0c6a1d90c585bbb027d6b7cd
 2012-08-06 13:02:34 +02:00
Reedy
c61744b0d8 Suppress warnings around parse_url call 
From the docs:
On seriously malformed URLs, parse_url may return false and emit a E_WARNING

We're already checking for false, but we can get spammed with E_WARNING..

Change-Id: I44a9ef2b163e64113bd2a30b081c1256ffeada1e
 2012-07-28 19:50:34 +01:00
Antoine Musso
aab43dd495 escape tags and entity in doxygen comments 
When inserting XML elements inline <such as this one>, doxygen chokes
about it not being known. Simply enclosing the tag in double quotes
prevents doxygen from emitting a warning.

Also enclosed a few invalid functions calls such as \. and double quoted
the HTML entities such as &foobar;

Change-Id: I4019637145e683c2bec3d17b2fd98b0c50a932f1
 2012-07-10 17:08:32 +02:00
awjrichards
c29fd59775 Big oops - merged to wrong branch. 
Revert "Revert to arbitrarily old point before initial remote branch creation to help clean up"

This reverts commit ee0d3d330f
 2012-06-05 22:58:54 +00:00
awjrichards
ee0d3d330f Revert to arbitrarily old point before initial remote branch creation to help clean up 
Change-Id: I41a3d1e55d3ea9dffa42451237fe065f9334361d
 2012-06-02 08:43:04 -07:00
Platonides
1ea18dfaf2 Minor changes to Ic50d01f5 Accept-Language code. 
Minor improvments to commit 894c5c1

Change-Id: I8cc63cb1ba2c3aa74ca9e225022d5be75e75ad23
 2012-05-29 20:38:48 +02:00
Liangent
894c5c108d Tweak Accept-Language sorting method to respect RFC 3282. 
Now in Accept-Language handling (in the language converter),
languages appearing earlier in the list are treated as more
preferred languages (variants).

Change-Id: Ic50d01f52dce1ae1f4f4e747d5f8b8399ca03b0b
 2012-05-28 19:03:19 +08:00
Max Semenik
40e35d5b32 Deprecate WebRequest::escapeAppendQuery() 
It is an ugly piece of UI-related code in an infrastructure class.
Its only user, MobileFrontend, is currently in process of getting rid of it.

Patchset 2: Fixed commit message

Change-Id: I62f9f707532a95be01c1ecdcb1fbfbd0c4117be6
 2012-04-25 12:09:01 +04:00
Reedy
8f9563ce7b A set method doesn't need to return anything (and besides, niether does $this->base->setSessionData()) 
Change-Id: I1315697ee2879898b033c1dd01fecb809c4fe0dd
 2012-04-07 17:21:16 +01:00
Daniel Friesen
9d83797631 Separate $wgArticlePath from $wgUsePathInfo. 
- $wgUsePathInfo is now only used on servers not passing REQUEST_URI to determine if PATH_INFO should be used
- WebRequest now extracts information from REQUEST_URI even when $wgUsePathInfo is false
- HTMLForm bases it's decision on whether or not to include a hidden 'title' input on whether $wgArticlePath uses a query instead of assuming that $wgUsePathInfo was used to set the article path

Change-Id: I1b461fef88b26d045f4edd7553b59255c5e595d8
 2012-03-24 03:44:08 -07:00
Benny Situ
586285e1f3 followup to -r113545 - add null for missing $default param 2012-03-10 00:31:54 +00:00
Roan Kattouw
f5f30aa959 (bug 34521) Returning to the previous page after logging in loses any array-valued parameters in the query string. This happens because WebRequest::getValues() calls getVal() which strips arrays, even though the doc comment says that no transformation is applied. Changed getValues() to call getGPCVal() instead. The only difference is that arrays are no longer stripped, so the doc comment is no longer a lie 2012-03-09 23:27:28 +00:00
Niklas Laxström
7476c290d3 Hrrrmp *grumbles* 2012-03-01 13:38:49 +00:00
Arthur Richards
1c242d9690 Added unsetVal() method as antithesis to setVal() 2012-02-29 21:56:05 +00:00
Sam Reed
c052fc3b7b Documentation followups from lastnight 2012-02-10 15:37:33 +00:00
Sam Reed
0a626db6e1 Fixing some of the "@return true" or "@return false", need to be "@return bool" and then the metadata can say true if foo, false if bar 
Other documentation improvements
 2012-02-09 19:29:36 +00:00
Sam Reed
85bbb0b080 Fixing some of the "@return true" or "@return false", need to be "@return bool" and then the metadata can say true if foo, false if bar 
Other documentation improvements
 2012-02-09 18:01:10 +00:00
Mark A. Hershberger
2d72930472 w/s 2012-02-07 13:05:31 +00:00
Sam Reed
657ecdebfa Add @since to getIP/getRawIP 
Came in r94932, soemwhere after 1.18 was branched, so is in 1.19
 2012-02-06 20:20:43 +00:00
Antoine Musso
ffbb4a0ed2 FauxRequest now has empty data per default 2012-01-09 10:42:44 +00:00
Jeroen De Dauw
0b105ebf1d added missing deprecation notices 2011-12-13 19:51:03 +00:00
Daniel Friesen
8ddf933100 Followup r104676, r104688: 
- Update our woefully out of date doc comment for WebRequest::getPathInfo (we haven't simply been extracting a PATH_INFO for ages)
- Make PathRouter::makeWeight protected
- Add more comments to the PathRouter code
- Add two more edge case tests to the PathRouter tests.
 2011-12-09 00:28:34 +00:00
Daniel Friesen
fba28f5233 Followup r104688, reintroduce the full PathRouter code now that the bug with url encoded paths is fixed. 2011-11-30 15:12:19 +00:00
Brion Vibber
73b6bd244a Revert r104274, r104284, r104285 -- breaks special pages on non-english 2011-11-28 19:55:49 +00:00
Daniel Friesen
63e93db2d8 Implement path routing code. 
- Makes extending paths with extensions simpler.
- Should fix bug 32621 by parsing paths based on pattern weight rather than pattern order.
 2011-11-26 16:29:25 +00:00
Daniel Friesen
ae1d5aefbf Update img_auth.php and WebRequest code to handle non index.php scripts like img_auth.php better. 
Also update img_auth.php so it's abuse of $wg variables is done in a way that doesn't let "/*" action paths clobber it's handling.
This should theoretically fix bug 32486.
 2011-11-24 09:55:33 +00:00
Roan Kattouw
0a4f6dd7ac Revert r102949. Broke tests (undefined variable $_SESSION because session_start() hadn't been called) and is unnecessary because we have DerivativeRequest now 2011-11-14 09:23:58 +00:00
Roan Kattouw
eca300daff Followup r101149: make FauxRequest::__construct() use $_SESSION if the session parameter isn't given 2011-11-14 08:40:06 +00:00
Alexandre Emsenhuber
0510056e5a Fix for r101858: forgot the override those methods 2011-11-03 19:25:30 +00:00
Alexandre Emsenhuber
df4b6e4c3a Per Aaron, fix for r89405: introduced DerivativeRequest to allow to override the request parameters, but not headers, cookies and session. Updated ApiEditPage (for the bug) and ApiLogin (for future use) 2011-11-03 19:14:46 +00:00
Sam Reed
450814de00 More documentation updates 2011-10-28 18:11:47 +00:00
Sam Reed
6906724935 Add, update, tweak documentation 
Fix document comment blocks

Tweak some returns
 2011-10-26 03:45:13 +00:00