Commit graph

9 commits

Author SHA1 Message Date
Jeff Janes
7e3fcc39ea PHPUnit: Add Database tags
Several unit tests access the database, but did not declare
themselves in the Database @group.  This causes
"make databaseless" to fail needlessly.  Add the
missing tags.

tests/phpunit/includes/LinkerTest.php
tests/phpunit/includes/actions/ActionTest.php
tests/phpunit/includes/specials/ImageListPagerTest.php
tests/phpunit/includes/specials/SpecialMIMESearchTest.php
tests/phpunit/includes/title/MediaWikiPageLinkRendererTest.php

Other than ActionTest.php, these also are problematic in 1.23

Change-Id: I7c1c957e2194c13e48b7ba68d7529e5d89901875
2014-09-16 18:42:27 -07:00
Thiemo Mättig
5043b4993b Add tests for IE workarounds to ActionTest
Change-Id: Iafaa3266e57f22f108c0253053103681bd88bd10
2014-07-22 13:55:44 +02:00
Thiemo Mättig
e2675eaeef Add tests for NULL to ActionTest
NULL should default to 'view'. But both the exists check and the
factory should fail when asked for a NULL action.

Change-Id: I5751489eed890bb44101f2a4ef73002bff68b207
2014-07-22 13:55:44 +02:00
Thiemo Mättig
1ccdd5bec0 Add tests for disabled actions in ActionTest
Change-Id: I2c742fca0fa87604c1d503b938ecc495aafd8376
2014-07-22 13:55:44 +02:00
Thiemo Mättig
d3e26d2906 Add more test cases to ActionTest
1. The 'dummy' test case already tested ucfirst(), but strtolower()
was not tested. The new 'DUMMY' tests fixes that.

2. Add a new test where the requested action is false.

3. Refactored the dummy builder a bit to make it easier to reuse.

Change-Id: Id7d9adac064b307b04bf6accb83ffd7f217a857c
2014-07-22 12:37:05 +02:00
umherirrender
53c420e278 Fixed spacing
- use tab as indent instead of spaces
- Added space after closures "function"
- Added spaces around string_concat
- Added newline inside empty blocks
- Removed four spaces after comma

Change-Id: I4425b0c6a69b36f40acfea6511b8950cf09ce2b2
2014-07-20 21:41:41 +02:00
umherirrender
2b021dc48a Fixed spacing
- Added/removed spaces around parenthesis
- Added space after switch/if/foreach
- changed else if to elseif

Change-Id: I99cda543e0e077320091addd75c188cb6e3a42c2
2014-07-19 23:12:10 +02:00
Thiemo Mättig
bf0d2a110a Improve tests for Action::exists
Change-Id: I905fd8e88ff625cd88c672ddac7a5ac4f4a94b36
2014-07-18 15:33:21 +00:00
Thiemo Mättig
20a1087bd5 Add ActionTest for static Action methods
Change-Id: Ifea52280486b8aa29fbab42e4c7d3ea907849b52
2014-07-18 15:29:35 +02:00