A crude solution for the acquireTarget() race condition. Use SQL
GET_LOCK() to lock the target from the acquireTarget() call until the
transaction is committed.
Add FOR UPDATE to the acquireTarget() SELECT, otherwise it just sees the
snapshot version of the row and inserts a new row anyway.
Add a test which reliably failed prior to the change.
Reword the ipb-block-not-found message. This is normal for simultaneous
blocks of the same target. Don't contact us. In the API, remap it to
"alreadyblocked".
Bug: T389028
Change-Id: I1fa35bf08d456a93930194786f77df389217ba61
(cherry picked from commit 2b65587e4d92e7f27661e8821b14f74ade939cfa)
Added in 2022 with I7d97c9e2d4 (c6a0d433ec) for Ie430acd075
(e82f11c246) which was (after a revert and re-apply) eventually
removed after the warmup completed (I852060c8a4, 3df4952385).
Bug: T322672
Bug: T387478
Change-Id: I1921b4f985fb27b2227aef4a0eba6751c1c0b8d5
(cherry picked from commit 2a5cf3fde93263156557bc1efd21c5a74ce67725)
These .htaccess files are intended to prohibit all web access. But if
the user sets "Satisfy Any" on a parent directory, in conjunction with
any permissive require directive like "Require all granted", access will
be allowed despite "Require all denied" in .htaccess.
So, override Satisfy so that the "Require all denied" will reliably take
effect.
Note that "Satisfy All" is the default. This only affects non-default
installations.
Change-Id: Ia5862fb69e439b7ea2ed7af011e1ebf8f1b1f6d6
(cherry picked from commit a50d2e69f8ce9e5720b05615d04c35cc9008b6ae)
Why:
`ChangeTags::buildTagFilterSelector` is an opinionated chain of calls
that results in the markup for a select input with specific tag options
(explicitly and software defined tags that have hits). In order to
support customization to the `HTMLTagFilter` widget, add support for
parameters.
These parameters will support filtering for active-only tags or not
and choosing between all on-wiki tags or software-defined tags only.
What:
- Support an `activeOnly` parameter, which will either show all defined
tags or only tags that have hits (active)
+ For legibility, add `TAG_SET_ACTIVE_ONLY` and `TAG_SET_ALL` constants
to support this parameter
- Support a `useAllTags` parameter, which if true will use all tags
and if which false will only use software-defined tags
+ For legibility, add `USE_ALL_TAGS` and `USE_SOFTWARE_TAGS_ONLY`
constants to support this parameter
Bug: T378622
Change-Id: Ib6ba27944cdf22bdb05dbfd34b2e5f8727261da7
* Update skins/Vector from branch 'REL1_43'
to b3b626ca4c4c2ad1fd0826df66584e44b0abce9e
- Localisation updates from https://translatewiki.net.
Change-Id: Icf5e320c04f81628b08ed5840b6f652ffa7653ae
* Update skins/MinervaNeue from branch 'REL1_43'
to b2ba6a11714b4174e7480812f651f6c025800cde
- Localisation updates from https://translatewiki.net.
Change-Id: I367af2b7e95a4cfe3c494c134b3869d9c880f1aa
* Update extensions/VisualEditor from branch 'REL1_43'
to 5ed4cace4d4dabea008aadfbd38eb016dd829262
- Localisation updates from https://translatewiki.net.
Change-Id: I0a4d84e4dfffdc131236b24a4c026e0b0cc17138
* Update extensions/WikiEditor from branch 'REL1_43'
to 5849697112b4262b84641b3c75134fc51fce4d7d
- Localisation updates from https://translatewiki.net.
Change-Id: Ic554b3e9be177206c1b3e859e332f007683e232c
* Update extensions/Thanks from branch 'REL1_43'
to d9f54da5ea3c26147eb524c057dafddb5111bfc7
- Localisation updates from https://translatewiki.net.
Change-Id: Iabd3669bb4e655160fd8f77402f48566c9b77344
* Update extensions/TemplateData from branch 'REL1_43'
to b28df6b9e0481eef4b8267f0680b15eae35f01e3
- Localisation updates from https://translatewiki.net.
Change-Id: I258cdf282a7883bee6ccfb88e2e6971a35711a6f
* Update extensions/ReplaceText from branch 'REL1_43'
to f5d1655cb951c223b651b995026a1277a9f54687
- Localisation updates from https://translatewiki.net.
Change-Id: I862f888cb58f33f8804406ec73e8ae3c45b69c79
* Update extensions/OATHAuth from branch 'REL1_43'
to 29a92b55cf924904ce4db26480a04640b4d75bb8
- Localisation updates from https://translatewiki.net.
Change-Id: I488e0d21c7e161c4cfb5e86b1435c8319f4a57ee
* Update extensions/Math from branch 'REL1_43'
to 5cb946d0414a88e4dfb987c4b2c8f914fcdd4512
- Localisation updates from https://translatewiki.net.
Change-Id: I3f0137fd8acaee8008c71cd41df6f941546ba0c7
* Update extensions/LoginNotify from branch 'REL1_43'
to 704c0935c328a6d54ac9de35d267d20bafa95662
- Localisation updates from https://translatewiki.net.
Change-Id: Ib9b795ec6d16de89318e44bcf068f440166aeca7
* Update extensions/Gadgets from branch 'REL1_43'
to dbb306d688eff92960462d6665a813dfb1e473aa
- Localisation updates from https://translatewiki.net.
Change-Id: I9d8b307f104f8bfd1e7499860ad73389ceec53b2
* Update extensions/DiscussionTools from branch 'REL1_43'
to b393b26919e8b0569f20fb92e346bae4d3bce6fe
- Localisation updates from https://translatewiki.net.
Change-Id: I7659470856cf85aa8fd0440587adbf0fa144622e
* Update extensions/Echo from branch 'REL1_43'
to 1d763647b62657e2e6ef1f9de634e22c5addbed5
- Localisation updates from https://translatewiki.net.
Change-Id: I15a4e3b176374b0651167fc50d7b02f4a8ec4303
* Update extensions/ConfirmEdit from branch 'REL1_43'
to 6e607bd765d7c7aee9953740d43be5af34b62449
- Localisation updates from https://translatewiki.net.
Change-Id: I167c54df611c9b640a713c4f4901b64f084e29a3
* Update extensions/Cite from branch 'REL1_43'
to 059a478748aeb63ebe96c10b33bcedc46bd993d4
- Localisation updates from https://translatewiki.net.
Change-Id: I66b42034141c63e577f0fc466b8b5d57605b5c0f
* Update extensions/CategoryTree from branch 'REL1_43'
to 577b42353f8201e5499e55cf91175293ee3c9ef7
- Localisation updates from https://translatewiki.net.
Change-Id: I988976cada0dc18f10eb81e33e40d44c5b4d45e1
* Update extensions/AbuseFilter from branch 'REL1_43'
to 40818d5f14e24216685d3d7b102226e1f9c9e09b
- Localisation updates from https://translatewiki.net.
Change-Id: Iccd75cd10d0fd87fc5a26efe4a56bd94465aaad9
```
PHP Deprecated: strrpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in /srv/mediawiki/1.42/includes/libs/filebackend/FileBackend.php on line 1588
```
Bug: T384851
Change-Id: I36c401587d94e7c1ab444d355b03ea88da8fb6e8
(cherry picked from commit 1a4d7d410c527f6a9f57b5c3e6f733a4a64f41c1)
* Update extensions/AbuseFilter from branch 'REL1_43'
to a57f0700a4443585a50e09bef9c237b4fb8a650b
- Parser: avoid PHP warning for unterminated escape sequences
If an escape sequence is not terminated (i.e., there is not character
after the backslash), then the whole string isn't terminated either. So,
throw an exception immediately, rather than trying to get the next
character, emitting a PHP warning in the process.
Bug: T390416
Change-Id: Iff8a86add30048efd6ccec454f790a1ce77f1414
(cherry picked from commit ec7f90efb0681d9939009a6d9e00ba99ffa6ec91)
* Update extensions/Echo from branch 'REL1_43'
to 629e7a3ce07e7d987895315ef6bf9de32261f390
- Fix for Watchlist Notifications for deleted pages created in 1.35
Bug: T286192
Change-Id: I9d4ab915ca33a3d52018470f1147eb77f5590c86
(cherry picked from commit 4c35cecea0f7cd43b08fbc462faacc09005306ff)
* Update extensions/ConfirmEdit from branch 'REL1_43'
to ffcbccd61e08481966fb56246bc620f5cdc39b83
- CaptchaPreAuthenticationProvider: Improve log messages
Why:
- We want to distinguish between showing a CAPTCHA and submitting
one, and also have some more meta data for processing logs
What:
- Clarify the log message action, event type, and fall back to 'unknown'
for cases when the CAPTCHA is shown on login before any submission
- Add the user agent to the login and account creation messages
Bug: T379178
Change-Id: Idaeec7689629e2a79b5188f57c9f5c003fd4b31c
(cherry picked from commit 64ab657ef2e2fb911ebd4817a1bfde0e4e71f86c)
* Update extensions/ConfirmEdit from branch 'REL1_43'
to c1192fcbfcd71446ef979d8c1e83a0af6cde3ee1
- CaptchaPreAuthenticationProvider: Check if a login attempt would trigger a captcha in testForAuthentication
Bug: T379178
Change-Id: I1ec25cadafee404801727c8d716b864bd34b31b6
(cherry picked from commit b02ab0936ae5c6af3c33ac18934b0e07f17961eb)
* Update extensions/LoginNotify from branch 'REL1_43'
to b3c78b992ea01b11fba41496826739f8d1e67341
- LoginNotify#sendNotice: Add IP and UA to log message
Why:
- IP and user agent are important for being able to trace abuse of
logins
What:
- Add the request IP and user agent header to the log message
- Update the doc string to specify that 'login-success' is also a
possible parameter
Bug: T390141
Change-Id: Ib66f06965c872e234ffe2c03d4a5553a20b4c7e0
(cherry picked from commit 0a22ef37fd69aebecb5b8ac9c192e34cefa3f3eb)
* Update extensions/ConfirmEdit from branch 'REL1_43'
to 2251b9e8d410252f21f5b7af4180f55cb3e0e3d0
- CaptchaPreAuthenticationProvider: Run triggerCaptcha for login attempts
Why:
- Extensions may want decide if ConfirmEdit should show a CAPTCHA on a
login attempt
What:
- Invoke the onConfirmEditTriggersCaptcha hook on all login attempts,
not just bad logins
- Fix incorrect log message variable from earlier code
Bug: T379178
Change-Id: I2e9a1af2e567baf3d9aa55b70c74fef8711f8bf0
(cherry picked from commit bc0c157c1d42dc14c594553c097dc013e3c7c9c0)
* Update extensions/ConfirmEdit from branch 'REL1_43'
to 0ac16f7b26f58c49ffbd212089d4bf86d7e5b3f4
- LoginAttemptCounter: Add extra hardening for long period too
The current method of showing captcha with 3 attempts in 5 minutes is
nice but it would be even better to show captcha in more attempts but
longer period of time, the default roughly translates to showing captcha
if bad login is more than 100 times in every day.
It is extremely ugly but it already has todo to migrate to Throttler,
once that's in place, it could be simplified a lot.
Change-Id: I8bfcd52f4c77946182ca7c58b31fd8b38bbcd3cf
* Update extensions/ConfirmEdit from branch 'REL1_43'
to c1e4a5867d3aa79581b8208503b09bc3a7b4d8c4
- Attempt to more consistently document $wg values in extension.json and README
Change-Id: I83ae3dc8a2bd1d9e4655eba1d8da5e5974930357
(cherry picked from commit 12490340ff549d4dcdca01baf6e075f1da0f2baa)
* Update skins/Vector from branch 'REL1_43'
to e2f121833a9254f10c2dcbfe2c434e3169929c5f
- Localisation updates from https://translatewiki.net.
Change-Id: Id2f40caae32c4b9937fba8e11b34cf9d37ec6a11
* Update skins/MinervaNeue from branch 'REL1_43'
to d2999cd21fea9083a7604b0e12b1294e336e5997
- Localisation updates from https://translatewiki.net.
Change-Id: I79ddb7c02e234df70d01580a99c19dbf3f5caf0b
* Update extensions/WikiEditor from branch 'REL1_43'
to a15547438ff89a8d88d23d7a4f579443b9f531a3
- Localisation updates from https://translatewiki.net.
Change-Id: Ie0e8746806c2886ef1a4020867e14f9748e012e2
* Update extensions/VisualEditor from branch 'REL1_43'
to 6870ad5844b8345d2e30230f3e5ea48dae2c7f70
- Localisation updates from https://translatewiki.net.
Change-Id: I35f64cd13fcf1e3e959d7437f5c1dfe174543fbd
* Update extensions/Thanks from branch 'REL1_43'
to 8a44d9d2048f16c8873af72df39daf2e5a276eac
- Localisation updates from https://translatewiki.net.
Change-Id: I2febc43dac3d9bd6fab06c4746bb912aabf6896f
* Update extensions/SpamBlacklist from branch 'REL1_43'
to b7e906f612971a9de2c64eaeb5c2104b60fc6109
- Localisation updates from https://translatewiki.net.
Change-Id: Id3392e57a0de39c8c170df1adbf68a65b42184fe
* Update extensions/TemplateData from branch 'REL1_43'
to 107821689360855c570cae58d6483c520ae46d0f
- Localisation updates from https://translatewiki.net.
Change-Id: I9b150c0aa2f4c3d5a34079eadf2bdb271eea6a88
* Update extensions/PageImages from branch 'REL1_43'
to d180283a0d786e122899287efa0160690e8f33e4
- Localisation updates from https://translatewiki.net.
Change-Id: I86c242f3a10e361a81a9870c7c7fc0fddc510a1c
* Update extensions/Nuke from branch 'REL1_43'
to 0326b9f4ebb91b220a99a92251710c13bd33298e
- Localisation updates from https://translatewiki.net.
Change-Id: I787ee6ab4947a73465ec1781eee2c948e81e1dcd
* Update extensions/MultimediaViewer from branch 'REL1_43'
to df4c8ca9c2045ed05ed27f00c7810b62d8483089
- Localisation updates from https://translatewiki.net.
Change-Id: I2931f5ccb76e1ddd25abad450bfd8e8ae588f25b
* Update extensions/Math from branch 'REL1_43'
to 820a7e391fe3527e91fd53c8656a4dc698f28d09
- Localisation updates from https://translatewiki.net.
Change-Id: I82a78d8ca1021bd610daac853a3ea074d8b6e971
* Update extensions/Gadgets from branch 'REL1_43'
to 5872c102d288b289672fbb08913c0973f6ad6b92
- Localisation updates from https://translatewiki.net.
Change-Id: Id80bfe786b0f68ffa46a28e0c867cac7e5140d61
