Commit graph

73 commits

Author SHA1 Message Date
Brion Vibber
c2f924a509 * (bug 28634) document possible API caveat caused by accounts without the registration time field 2011-05-13 15:04:55 +00:00
Sam Reed
0b96c67a9e Remove unneeded manual quoting from r87180 2011-05-01 11:20:14 +00:00
Sam Reed
5283490bdd * (bug 28225) Allow hiding of user groups in list=allusers
Yay, a LEFT OUTER JOIN
2011-05-01 00:24:39 +00:00
Sam Reed
ab28af877c Followup r85884
Fixup the APIs strange way of doing table aliases on a join....

Only used in very few places
2011-04-30 23:18:34 +00:00
Sam Reed
76a4e7d4ce Followup r84363
Looks like I made a complete hash of that commit. Commit correct version from vm working copy
2011-03-26 18:39:22 +00:00
Sam Reed
74cfe3df00 Followup r79549, only try and filter by group (or right) if there are some groups to do a WHERE on 2011-03-24 20:27:30 +00:00
Sam Reed
e696d174eb Actually list implicit groups in allusers.
Looks like I might've regressed this in the course of fixing other bugs. Oh well, fixed now
2011-03-20 00:23:41 +00:00
Sam Reed
82dd198876 Followup r83849, fix join to be on indexed user_name 2011-03-14 11:07:58 +00:00
Sam Reed
886a70a3f7 Add missing group by from r83849 per Bryan 2011-03-13 19:35:08 +00:00
Sam Reed
237eb87db4 * (bug 26630) Add api for Special:ActiveUsers
Not sure if this would be better having been done as list=activeusers or something...

Meh, done! :P
2011-03-13 19:07:22 +00:00
Sam Reed
cb94b8f191 * (bug 27342) Add audir param to list=allusers 2011-03-13 17:23:45 +00:00
Sam Reed
aea7a5a482 Followup r83390
If the user is allowed to view hidden users, put a missing property on all users.

For list=users, do the same, but we can't easily distinguish to other people the difference between "hidden", or "missing", so no reason to do it
2011-03-06 20:51:31 +00:00
Sam Reed
67d4ee1d26 Followup r83390, change cache modes 2011-03-06 18:16:44 +00:00
Sam Reed
c488abeeb8 * (bug 27897) list=allusers and list=users list hidden users
Refactored addition of block information, and also checked if user is allowed to view hidden user fields
2011-03-06 17:59:08 +00:00
Sam Reed
20d56c63b3 * (bug 27708) list=users does not have a property to return user id
Add userid to ApiQueryUsers

Move userid in ApiQueryAllUsers before name
2011-02-25 16:19:44 +00:00
Sam Reed
35296f391f Followup to r82739 (bug 27688)
Remove u1 table aliases
2011-02-24 18:46:12 +00:00
Sam Reed
57923b31fa * (bug 27688) Simplify queries to list user block information
Also expose block expiry information, listed on Users, but not all users

Some minor simplifications to come
2011-02-24 18:43:44 +00:00
Sam Reed
521044a529 Explicitally define $fld_rights on all code paths 2011-02-09 22:42:26 +00:00
Sam Reed
22832a2527 * (bug 26560) On allusers if limit < total number of users, last user gets duplicate
If $lastUserData is set to null, it won't get added again!
2011-01-04 04:05:32 +00:00
Sam Reed
df0a765cfe * (bug 26559) list=allusers auprop=rights does not match list=users usprop=rights 2011-01-04 03:36:39 +00:00
Sam Reed
0014c1113c * (bug 26558) list=allusers auprop=groups does not list groups a user is automatically a member of 2011-01-04 02:48:02 +00:00
Sam Reed
f1b7c91cf8 Followup r79545, we don't really care for duplicate userrights 2011-01-04 02:18:03 +00:00
Sam Reed
97a0295e34 Add rights to array. Grrr 2011-01-04 02:13:51 +00:00
Sam Reed
b30c1e7e72 Crappy spaces from r79549 2011-01-04 02:08:38 +00:00
Sam Reed
58df1dc895 Rest of * (bug 25767) Add userrights properties to allusers and users query lists
Add missing parameter from r79545
2011-01-04 02:06:55 +00:00
Sam Reed
e1bcab1ab8 * (bug 25767) Add userrights properties to allusers and users query lists
First part of this bug. Listing of all rights that users have
2011-01-04 01:39:02 +00:00
Sam Reed
1da2cd2dde Move comment about groups potentially returning less results from server.
Comment out description line about rights from ApiQueryUsers, as that prop doesn't exist (Might do in future. Possible artifact from large scale comment addition?)
2011-01-03 20:41:22 +00:00
Sam Reed
6309c920dd Delete all the "API for MediaWiki 1.8+" comments
Add since to ApiQueryQueryPage
2010-12-22 20:52:06 +00:00
Sam Reed
fd976ad072 Part of Bug 19195 - Make user IDs more readily available with the API
ApiQueryAllUsers, ApiQueryImageInfo and ApiQueryRevisions exposing user_id
2010-08-28 00:37:48 +00:00
Sam Reed
ec744522af I really do hate whitespace 2010-08-26 22:12:01 +00:00
Sam Reed
ca6dc55a0d * (bug 24724) list=allusers is out by 1 (shows total users - 1) 2010-08-26 22:09:29 +00:00
Sam Reed
4ef46d0006 Followup to r68338, remove useless code (row is overwritten by loop) 2010-08-18 20:34:42 +00:00
Sam Reed
1e0f0c4574 Prefix searches for users, not pages 2010-08-10 10:05:31 +00:00
X!
0f6085a585 (bug 24722) Only show blockinfo if user is actually blocked for list=allusers 2010-08-08 15:33:43 +00:00
Alexandre Emsenhuber
457eb73b61 Standardised file description headers, added @file 2010-08-07 19:59:42 +00:00
X!
7147b264bc * (bug 24677) axto= parameters added to allcategories, allimages, alllinks, allmessages, allpages, and allusers 2010-08-06 18:58:10 +00:00
Tim Starling
b2dc451c82 Rewrote r69339 etc. to clean up API cache header handling.
* Introduced a "cache mode" concept to simplify the header generation code, and to avoid odd results when conflicting cache header requests are received from submodules, or at least to formalise the handling of such cases.
* Made the cache mode private by default, so that code written in ignorance of caching tends to be safe. If different query modules are used in a single request, private caching is preferred over public caching.
* Removed the "must-revalidate" option from all CC headers, this is really specific to page views with a hacked squid in front, I don't think it's applicable here.
* Made the watchlist module private. This is really the definition of private data. There's nothing in the HTTP spec that says the URL for a CC:public request is private and can't be leaked. CC:private provides protection against unknown proxy behaviour.
* In ApiQueryAllmessages: avoid calling $wgLang->getCode() to check if it's necessary to make a new $wgLang when lang= is specified, since this is the only thing that unstubs $wgUser.
* Removed "FIXME: should this check $user instead of $wgUser?" Answer is no.
2010-07-23 07:17:56 +00:00
Sam Reed
8f1d2cb199 Big blitz on unused variables (a lot of $db = $this->getDb() ) 2010-07-22 22:13:21 +00:00
Sam Reed
2d8f0de854 Rem superfluous code, as per comments on r68338 2010-06-29 20:22:52 +00:00
Sam Reed
2d21295243 * (bug 23473) - Give description of properties on all modules
Commit patch by John Du Hart with a few minor tweaks/fixes
2010-06-23 19:36:26 +00:00
Derk-Jan Hartman
921619b119 Correct the address of the FSF in some of the GPL headers
59 Temple Place -> 51 Franklin Street
2010-06-21 13:13:32 +00:00
Sam Reed
53c5e4b942 Do ApiQueryAllUsers per r68337 (was using while (true)..) 2010-06-20 18:52:46 +00:00
Sam Reed
a90a0783de Nuke $db->freeResult() from Api stuffs 2010-06-20 17:48:21 +00:00
Roan Kattouw
37cf6f133b API: (bug 23534) Fix regression from r46809 (!) causing DB query error 2010-05-15 18:00:55 +00:00
Sam Reed
e55ed729c4 Mixture of things.
Couple of class comments

Normalisation of "." usage at end of lines (removed)

Normalisation of {prefix}parameter as per bug 23461
2010-05-11 22:30:18 +00:00
Jack Phoenix
96b4f302af API: fix copyright symbol, coding style cleanup, more braces 2010-02-24 13:34:11 +00:00
Greg Sabino Mullane
7766537c2c Use 'AS' for column alias 2010-01-26 20:36:22 +00:00
Aryeh Gregor
3758769f0d stylize.php on API code
"I wouldn't object to stylizing the API code to bring it in line with
the rest of MW on principle, but I'm not gonna bother myself." --Roan
<http://www.mediawiki.org/wiki/Special:Code/MediaWiki/60657#c5108>

If you're seeing this commit in blames, tell your blame tool to ignore
whitespace, e.g., git blame -w or svn blame -x -w.
2010-01-11 15:55:52 +00:00
Roan Kattouw
0dc85a3658 Followup to r60587: wrong user_groups join 2010-01-03 20:16:25 +00:00
Roan Kattouw
e91308e012 API: Per Domas, don't FORCE INDEX when doing an INNER JOIN with the user_groups table 2010-01-03 20:12:59 +00:00