Commit graph

40 commits

Author SHA1 Message Date
Tim Starling
377561cd1e * Introduced OutputPage::addWikiMsg() and OutputPage::wrapWikiMsg(), to make it easier to avoid double-parsing. Double-parsing introduces differences between the old and new parsers.
* Used the new functions in the relevant places throughout the core. Where this was not possible, used wfMsgNoTrans() to avoid double-parsing.
* Calling wfEscapeWikiText() on a title before passing it to a message is unnecessary and causes bugs. The best idea is to let the message do its own escaping. Removed wfEscapeWikiText() from the caller of addedwatchtext, removedwatchtext, deletedtext, protect-text, nosuchusershort and movepage-moved. Updated all message files to use <nowiki>$1</nowiki> where appropriate in these messages. 
* Removed unnecessary empty message handling from semiprotectedpagewarning
* Removed nonsense warning about the output of wfMsg() not being safe for inclusion in HTML. 
* Changed wfShellExec() to use passthru/ob_get_contents instead of exec(). This avoids corruption of whitespace in the response. 
* Added $wgValidateAllHtml feature, to optionally validate HTML on output. 
* Fixed missing newline in cascadeprotected in MessagesEn.php
* Belatedly updated addedwatchtext to take account of the new "monobook" skin. No unwatch link in the sidebar anymore.
2008-02-18 07:25:35 +00:00
Aryeh Gregor
a15c419b3d Remove ?>'s from files. They're pointless, and just asking for people to mess with the files and add trailing whitespace. (Yes, I looked over every one and reverted those that were bogus. Slash-enter a million times in less worked well enough, although it was a bit mind-numbing.) 2007-06-29 01:19:14 +00:00
Raimond Spekking
84ca3c0284 Per talk with River on IRC:
Removing extra message from r22793, seem to be just unintuitive.
2007-06-06 11:42:02 +00:00
Raimond Spekking
cd488ce953 Show result of Special:Booksources in wiki content language always,
it's normally better maintained than the generic list from the standard message files
2007-06-06 09:51:38 +00:00
Niklas Laxström
c22292cdd6 * E_STRICT 2007-05-05 20:31:08 +00:00
Nick Jenkins
9648f3b4d0 Some small doc tweaks to reduce Doxygen warnings, namely:
* @link. You might think @link would surely mean "here comes a web URL" ... but @link is a valid command 
  in Doxygen, which means an entirely different kind of link (an internal link to somewhere, so that you can separate 
  documentation and implementation). The result is a mess, and the best solution I can see is to use "@see" instead of "@link".
* Warning: argument `nourl' of command @param is not found in the argument list of Linker::makeMediaLinkObj($title,$text='')
* Moving few class descriptions to right above classes, and/or formatting into Javadoc style.
* "@addtogroup Special Pages" --> "@addtogroup SpecialPage" so that all special pages have the same @addtogroup tag.
* @fixme --> @todo (must have missed these before)
* "@param $specialPage @see" remove the "@" in the "@see" to stop warning.
* @throws wants type, then a brief description, to stop warning.

This last one is for PHPdocumentor only, but it fixes something for PHPDocumentor, and should be neutral for Doxygen:
* WARNING in includes/api/ApiFormatYaml_spyc.php on line 860: docblock template never terminated with /**#@-*/
2007-04-18 09:50:10 +00:00
Antoine Musso
c771fc9c96 Use Doxygen @addtogroup instead of phpdoc @package && @subpackage 2007-01-20 15:09:52 +00:00
Rob Church
5cf4e5e937 * Introduce "BookInformation" hook; see docs/hooks.txt for more details 2007-01-16 19:06:56 +00:00
Rob Church
1a7b4f9d62 Fix regressions in behaviour of Special:Booksources 2006-12-20 16:51:26 +00:00
Rob Church
759520e85c Bring back "booksources-summary", displayed above the search form on Special:Booksources in any case 2006-12-19 23:42:00 +00:00
Nick Jenkins
b0f18ca264 * prevent minor W3C validator/tidy error on Special:Booksources about nesting of "</form>" tag by swapping the order of two lines.
* stop minor tidy warning: "<input> attribute 'size' lacks value", by setting size to 20 (which allows enough visual field width for 10 ISBN digits + some leeway for extra dashes and spaces and whatnot).
2006-12-19 05:35:35 +00:00
Rob Church
58f17c71e1 * (bug 8164) Special:Booksources should use GET for form submission
* Rewrite Special:Booksources to clean up interface and remove redundant code
2006-12-16 19:20:44 +00:00
Nick Jenkins
ae8554c45b Completing code housekeeping stuff for rest of includes/ directory: removing unused local vars, removing unused globals, replacing extract() where simple to do, declaring output arrays before calling preg_match(), and so forth. 2006-11-29 11:43:58 +00:00
Antoine Musso
7ebdb6de89 Revert to r14165 . Did too many changes, didnt even run parserTests (i am bad) 2006-05-11 22:40:38 +00:00
Antoine Musso
bbbbb2a90a last round of PHP5 stuff for now. 2006-05-11 21:07:41 +00:00
Brion Vibber
8dd2ee8057 * Fix missing bad title check in Special:Booksources
* Remove empty booksources string in fy
2006-02-18 01:09:45 +00:00
Brion Vibber
04a7e6291e * (bug 1103) Fix up redirect handling for images, categories
Redirects are now followed from the top-level, outside of the Article
  content loading and viewing, for clarity and consistency.
2006-01-13 00:29:20 +00:00
Ævar Arnfjörð Bjarmason
a26d5a49d7 * s~\t+$~~ 2006-01-07 13:31:29 +00:00
Antoine Musso
2ca68a256d Clean up unused globals! 2005-12-04 18:27:59 +00:00
Niklas Laxström
4082923226 plaintext to wiki 2005-09-14 14:56:37 +00:00
Ævar Arnfjörð Bjarmason
7b08b2d9be * Using wfMsgHtml() for safe html output 2005-08-02 13:09:08 +00:00
Ævar Arnfjörð Bjarmason
ec4d899cf4 * empty() => '' 2005-07-16 22:07:38 +00:00
Niklas Laxström
e361fc54f3 Check if page actually exists 2005-07-03 13:03:33 +00:00
Brion Vibber
64ac6b8e77 Merge SCHEMA_WORK into HEAD. Lots of changes, some things are probably broken:
* Page moves/overwrites are a little iffy
* Compression might not be working right
* Profit!
2004-12-19 08:00:50 +00:00
Zheng Zhu
14052ee5e5 Second batch of files modified to replace selected wgLang with wgContLang 2004-09-24 16:24:43 +00:00
Antoine Musso
ba2afcd9fa Split files and classes in different packages for phpdocumentor. I probably changed some double quotes to single and used function foo () { shema 2004-09-03 23:00:01 +00:00
Antoine Musso
90155b8a97 Changing comments layout preparing for generated documentation with Phpdocumentor 2004-09-02 23:28:24 +00:00
Arne Heizmann
f621158326 NP_WIKIPEDIA => NP_PROJECT, and code readability stuff 2004-08-28 17:53:12 +00:00
Brion Vibber
82571fa72d Add back the slower version of Title::makeTitle as Title::makeTitleSafe()
and use it in a few places where user names, images, or messages are being
used to create titles.
2004-08-22 23:55:36 +00:00
Tim Starling
ac549401d4 * Support for table name prefixes throughout the code. No support yet for converting static SQL, which also means no installation. But it has been tested by creating the tables in the ordinary way and then renaming them
* DB_WRITE now called DB_MASTER, DB_READ now called DB_SLAVE
* Converted to use SQL wrapper functions instead of direct SQL in various places
* Experimental method for preserving the chronological order of events when slave servers are used. Untested.
* Fixes to the new post-parse existence test feature
* Some.. other stuff
2004-07-18 08:48:43 +00:00
Brion Vibber
56abcd25c4 If somebody accidentally wanders into Special:Booksources, ask for an ISBN
number. The raw list isn't that useful, and will lead to broken search
pages.
2004-04-09 06:27:18 +00:00
Brion Vibber
09e87fed72 Uninitialized variable cleanup 2004-03-20 08:55:22 +00:00
Brion Vibber
0332f4c598 Fix for compatibility with short_open_tag = Off 2004-02-18 02:15:00 +00:00
Tim Starling
7057b4e609 wfQuery now takes three parameters -- one extra for DB replication purposes 2003-09-20 01:34:06 +00:00
Brion Vibber
586e074ce5 Remove non-digit chars from isbn to prevent html insertion attacks 2003-05-24 21:07:31 +00:00
Erik Moeller
6b59c5c0d3 replaced WIKI-ISBN with MAGICNUMBER as replacement variable for ISBN page
to avoid triggering the "ISBN*" regex parser.
2003-05-20 01:13:07 +00:00
Erik Moeller
2fb252391d minor layout fixes:
* media style did not exist, replaced with internal
* some styles specfied (e.g. booksellers=external)
2003-05-19 21:46:33 +00:00
Brion Vibber
d153f26a0e Code style tweaks, use wfStrencode just in case some language ends up using an apostrophe in the book sources title 2003-05-19 21:30:19 +00:00
Erik Moeller
b9d208a4f2 Support for [[Wikipedia:Book sources]] (or localized text), content of
this page, with WIKI-ISBN replaced by ISBN number, is used instead of the
text in LanguageFoo.php for queries that include an ISBN.
2003-05-19 21:01:09 +00:00
Lee Daniel Crocker
d82c14fb4f Initial revision 2003-04-14 23:10:40 +00:00