This was done automatically using the
`Universal.WhiteSpace.CommaSpacing` sniff, which will be included in the
next release of the MW PHPCS config.
Some of these have been adjusted manually where the autofix broke
vertical alignment.
Change-Id: I54a4668d8a2759b9d7de47742c943a535a04e211
* Was used during the Parsoid JS -> PHP port and is no longer used.
* This also eliminated the need to inject ParsoidSettings into some
classes.
* Once this merges and lands in core, I'll remove this from the Parsoid
repo as well.
Change-Id: I008d30ea81f5a3db26e512c87762b90e3ca3c4ff
* Without this, the TransformHandler creates a 'newMainPage' in
TransformHandler::tryToCreatePageIdentity. This then causes the
page and revision to not correspond to each other.
* This somehow didn't matter so far, but in my patch where I try
to integrate ParsoidOutputAccess and ParserOutputAccess,
ParserOutputAccess has a precondition check asserting that the
page and revision object agree on the page id and causes some
of these selser tests to fail.
* Got rid of the titleMissing derived property in request attributes
since it felt extraneous.
Change-Id: I10ea62c2076f0ca9ba160b753bdca2ad0f8b40cd
Just methods where adding "static" to the declaration was enough, I
didn't do anything with providers that used $this.
Initially by search and replace. There were many mistakes which I
found mostly by running the PHPStorm inspection which searches for
$this usage in a static method. Later I used the PHPStorm "make static"
action which avoids the more obvious mistakes.
Bug: T332865
Change-Id: I47ed6692945607dfa5c139d42edbd934fa4f3a36
* ParserTestRunner: LocalisationCache needs to be reset since it has a
reference to LanguageNameUtils which has a copy of
$wgUsePigLatinVariant. Also factor out some
MediaWikiServices::getInstance() calls.
* In some other tests, set the variable.
Change-Id: I6c1e9bfad9790cf805809c28a3f8d45952cbb981
Mixing Handlers with Helpers doesn't look nice for consistency
reasons. Helpers should be in their own place (grouped) in the
Handlers directory as they're really "helpers for the handlers".
Change-Id: Ieeb7a0a706a4cb38778f312bfbfe781a1f366d14
* Without this fix, the test fails vendor patches whenever Parsoid's
default version number is bumped in the Parsoid repo.
Change-Id: Icce7b61dfbbbbd57b4f1ed76a32d160e92b48b15
