Commit graph

22 commits

Author SHA1 Message Date
Aryeh Gregor
a15c419b3d Remove ?>'s from files. They're pointless, and just asking for people to mess with the files and add trailing whitespace. (Yes, I looked over every one and reverted those that were bogus. Slash-enter a million times in less worked well enough, although it was a bit mind-numbing.) 2007-06-29 01:19:14 +00:00
Nick Jenkins
f9619da3f0 Yet more doc tweaks:
* Add @addtogroup tags to various classes, to try and group conceptually-related classes together.
* Add brief descriptions to various Special pages, thanks to Phil Boswell.
* Moving some docs to be right above the classes they represent, so that they are picked up.
2007-04-20 08:55:14 +00:00
Nick Jenkins
f88c771756 The war on redundant ampersand usage!
* Convert "$dbw =& wfGetDB( DB_MASTER );" --> "$dbw = wfGetDB( DB_MASTER );"
* convert "$skin =& $wgUser->getSkin();" --> "$skin = $wgUser->getSkin();"

For the time being have not changed the function definitions of wfGetDB() or User::getSkin() [i.e. they are still both return-by-ref], so as to ensure the interface does not change for extensions [some of which may still be trying to run on PHP4 environments]. However presumably at some point this can be changed too.

Also includes tiny tweak to newlines in parserTests - will show 1 rather than 2 newlines between the "Reading tests from" strings when in quiet mode.
2007-01-22 23:50:42 +00:00
Antoine Musso
c771fc9c96 Use Doxygen @addtogroup instead of phpdoc @package && @subpackage 2007-01-20 15:09:52 +00:00
Antoine Musso
9148811f64 Strict standards. 2006-12-16 21:53:34 +00:00
Nick Jenkins
a474761d9a Changing lines like this: "extract( $dbw->tableNames( 'page', 'archive' ) );" to be like this: "list ($page, $archive) = $dbw->tableNamesN( 'page', 'archive' );".
Three reasons for this:
1) It's better for analysis tools [which want explicit variable declaration]
2) It's easier for a human to read, as it's completely explicit where the variables came from [which is something you don't get with extract() ]
3) It makes it easier to find everywhere where a variable is used with search/grep [which you can't currently do with $tbl_page variables from things like: "extract($db->tableNames( 'page', 'revision'), EXTR_PREFIX_ALL, 'tbl');"].

Otherwise, from a functionality/efficiency perspective the two forms should be identical.

By doing this have been able run static analysis over the usages of these variables, thus eliminating 5 unneeded table names from calls, plus removing 3 unused calls entirely, and it just feels subjectively slightly nicer to me.
2006-11-27 08:36:57 +00:00
Tim Starling
36ed0cd96c Reverting 17479/17480, breaks subclassing of Linker methods by skins. See my comment on bug 7405. 2006-11-08 07:12:03 +00:00
Nick Jenkins
fa239349f2 * (bug 7405) Make Linker methods static. Patch by Dan Li. 2006-11-08 05:21:15 +00:00
Tim Starling
a3b490d2c4 * Made special page names case-insensitive and localisable. Care has been taken to maintain backwards compatibility.
* Used special page subpages in a few more places, instead of query parameters
2006-10-30 06:25:31 +00:00
Greg Sabino Mullane
5b5f413496 Change GROUP BY to standard SQL form by specifying all fields. 2006-07-14 19:48:22 +00:00
Domas Mituzas
6a65a49206 Autoload QueryPage 2006-06-06 12:35:47 +00:00
Niklas Laxström
b786a4ec2b * plural support for nlinks 2006-05-14 17:44:15 +00:00
Niklas Laxström
93eb6f30d7 * Added many missing formatNum calls 2006-05-08 18:17:55 +00:00
Rob Church
f9a7e53464 (bug 5812) Use appropriate link colour in Special:Mostlinked 2006-05-03 14:50:16 +00:00
Niklas Laxström
6136b2fee4 * Bidi-aid on list pages
* Some lists with bidi titles should be more readable now
2006-05-01 21:17:31 +00:00
Tim Starling
3afcc87e40 Removed extra GROUP BY terms introduced in revision 13603, pending review, following a total DoS of enwiki due to the slow Special:Listusers query. Changing from "GROUP BY user_name" to "GROUP BY user_name,user_id" increaed the time for a LIMIT 50,50 query from 0.01 seconds to 33 seconds. 2006-04-21 03:35:01 +00:00
Brion Vibber
3c9cf267a1 * (bug 385) Installer support for PostgreSQL, fixes for PG compatibility
Applied from: http://bugzilla.wikimedia.org/attachment.cgi?id=1517&action=view
I haven't tested it with PG personally yet, but it doesn't appear to interfere with other functionality.
2006-04-12 08:15:28 +00:00
Ævar Arnfjörð Bjarmason
a26d5a49d7 * s~\t+$~~ 2006-01-07 13:31:29 +00:00
Ævar Arnfjörð Bjarmason
5151b0e105 * @copyright Copyright �� 2005, ��var Arnfj��r�� Bjarmason 2005-09-27 19:50:49 +00:00
Ævar Arnfjörð Bjarmason
58993df36c * Documentation
* Fixes for when $this->isCached() is true
2005-09-16 15:07:07 +00:00
Ævar Arnfjörð Bjarmason
ede771f428 * Added a FIXME
* code style
2005-09-13 17:33:33 +00:00
Ævar Arnfjörð Bjarmason
5620dbebef * New special page: SpecialMostlinked 2005-08-15 02:57:19 +00:00