Commit graph

39 commits

Author SHA1 Message Date
Željko Filipin
9873815e55 Cleanup Cucumber tags in Selenium tests
Removing no longer used @login tag. We are no longer running tests
using internet explorer or phantomjs, so removing those tags too.

Renamed @clean tag with @vagrant, since it makes more sense and is used
in other repositories.

Bug: T127423
Change-Id: Ib5e0a1600c3df45889e97d5ff52cd0a77a15001f
2016-02-29 11:29:41 +00:00
Željko Filipin
b211da1dd4 Fixed Selenium tests by removing skins not installed by default
Looks like the tests were developed targeting
en.wikipedia.beta.wmflabs.org that has 4 skins by default. The commit
removes checks for all skins but Vector, which is installed by default. (At least in
my MediaWiki-Vagrant installation.)

Bug: T94150
Change-Id: I68f864bd194dbb251acab3d94699f1e701300ab2
2016-02-22 12:46:49 +00:00
Željko Filipin
88e5638e82 Browser test: fix log in Selenium tests
LoginPage is removed from mediawiki_selenium Ruby gem. This repository
is the only repository that needs it, so the file is copied here.

Also, user used to be logged in via the API, not really testing if log
in via the web site works. It is fixed now.

Bug: T127042
Change-Id: Iff85d66a9a6d3343c212fe648c589539e889a313
2016-02-17 13:09:34 +00:00
Željko Filipin
282e13a0c2 Update mediawiki_selenium Ruby gem from 1.2.1 to 1.6.3
Bring in User factory and support for IE/Android among other
things.

Bug: T114241
Change-Id: Ie0b0eb924e010533f34408b2fe3eef5b926b1cd9
2015-12-15 23:15:16 +00:00
Antoine Musso
d737e57624 Browser test: avoid loading elements over network
Page object let us search elements for which attributes match a given
regex.  Unfortunatly it loads the list of elements first, then foreach
of them trigger a call to Selenium to retrieve the attribute to match.

Attempting to regex match a link href, would cause hundred of roundtrip
to the Selenium host.

Instead, use a CSS selector to get the element we are interested in
which skips the bad page object code.

Bug: T92613
Bug: T112291
Change-Id: I12949a4d0ef61d38adbaaf622722c89033949cad
2015-09-17 13:07:30 +00:00
Antoine Musso
405f2225e6 rubocop: ignore node_modules and fix a single offense
Make rubocop pass:
- fix a trivial double quotes error
- ignore 'node_modules' useful when one ran 'npm install'

Change-Id: Id1ab83df0bec4fc7b223f33016c8f18316509b7a
2015-07-10 12:41:47 +02:00
Željko Filipin
7b4e7c1fb5 Update environments.yml file according to the documentation
Bug: T105174
Change-Id: Ib049d12f24444029f5aeb8ef3149c731c2b9c810
2015-07-08 17:56:59 +02:00
Tyler Cipriani
f12268f26b Add login error browser test
Change-Id: I19a7f708825d5f11859d8ea70db4cdde752df26c
2015-05-27 08:51:59 -07:00
jenkins-bot
257d7ff0cb Merge "Fixed Style/StringLiterals RuboCop offense" 2015-03-23 19:20:08 +00:00
jenkins-bot
94b2a4e907 Merge "Fixed Style/HashSyntax RuboCop offense" 2015-03-23 19:06:33 +00:00
Željko Filipin
bbb16ed91d Fixed Style/StringLiterals RuboCop offense
$ bundle exec rubocop --auto-correct
Inspecting 25 files
CC....C.......CCCCCCCCC.C

Offenses:

Gemfile:4:8: C: [Corrected] Prefer single-quoted strings when you don't
need string interpolation or special symbols.
source "https://rubygems.org"
^^^^^^^^^^^^^^^^^^^^^^
…
25 files inspected, 81 offenses detected, 81 offenses corrected

Bug: T91485
Change-Id: Ic6f1337fa465e8c90e5aa7ea3540eb6bfad15af8
2015-03-23 18:52:13 +00:00
Željko Filipin
6755869d20 Fixed Style/HashSyntax RuboCop offense
$ bundle exec rubocop --auto-correct
Inspecting 25 files
.CCC.....................

Offenses:

maintenance/jsduck/custom_tags.rb:16:16: C: [Corrected] Use the new
Ruby 1.9 hash syntax.
      return { :tagname => @tagname, :doc => :multiline }
               ^^^^^^^^^^^
...
25 files inspected, 8 offenses detected, 8 offenses corrected

Bug: T91485
Change-Id: Ic2aff32e106c5b5eaa45839ad3310b97fcec6ddf
2015-03-23 18:38:41 +00:00
jagori
d9ba5ad121 Use rspec-expectations "expect" syntax instead of "should" syntax
Bug: T68369
Change-Id: I502ba4b0d10c35aaf32fd4dcbfff8cec8ea34582
2015-03-20 13:35:35 +00:00
Dan Duvall
7a5bd933d4 QA: Refactor for mediawiki_selenium 1.0
Refactored by following steps outlined in UPGRADE.md under the
mediawiki_selenium project.

Change-Id: I52717292df0541eb489b34ec083ec4a957f7546d
2015-03-06 14:15:18 +00:00
Amir E. Aharoni
8c690195ac Fix the Rubocop offense TrailingBlankLines
Done using
bundle exec rubocop -c .rubocop.yml --auto-correct

Change-Id: Ieb5d7d47056f6ca17b0016147a057ad10266b6b9
2015-02-19 16:58:50 +02:00
Amir E. Aharoni
deb9990743 Fix the Rubocop offense SpaceInsideHashLiteralBraces
Done using
bundle exec rubocop -c .rubocop.yml --auto-correct

Change-Id: I8266fe28678c0e30f6dcf67f3d2136254d86d59e
2015-02-19 16:58:50 +02:00
Amir E. Aharoni
6fcd6ad4b5 Fix the Rubocop offense EmptyLinesAroundBody
Change-Id: I8f25f4a417f40db263ebaf0a4b5afed97218635a
2015-02-19 16:58:50 +02:00
Amir E. Aharoni
e0a7120f69 Fix the Rubocop offense EmptyLines
Change-Id: Ib05319b6af0b85df0966ae660ad01fc440361368
2015-02-19 16:58:50 +02:00
Amir E. Aharoni
edc88630c4 Fix the Rubocop offense AmbiguousRegexpLiteral
Change-Id: Ic060ce7fd85970cbfec4e9cbee8954dd69492e23
2015-02-19 16:58:50 +02:00
Željko Filipin
70f391997b Prepare repository for running RuboCop after every push to Gerrit
For now fixed only one trivial whitespace problem that “bundle exec
rubocop --auto-gen-config” did not put into .rubocop_todo.yml file.

Bug: 69245
Change-Id: I667941521220ee8761fdd691c138400fcda388e0
2014-10-24 13:11:12 +02:00
Alexandre Emsenhuber
a2d2f7009e Remove executable bit from non-executable files
Change-Id: I6def7588b970a15c4e6bd49dc4f7a7138687a99e
2014-09-27 20:21:43 +02:00
Željko Filipin
a422b38a01 QA: Do not mention Wikimedia Foundation wikis in browser tests
Change-Id: Iab47a1deff9f7ecda7edf3de18afdfcc00815819
Paired-With: Chris McMahon
Bug: 67616
2014-09-26 15:46:40 +00:00
Timo Tijhof
c34a4f9d3d QA: Remove logic for inexistant "wpvector-collapsiblenav" option
This option was never part of MediaWiki core and shouldn't have
been here in the first place.

It was removed from the Vector extension in October 2013 with I33dc0033c.

Not sure what this code is for or why it's not failing.

Change-Id: Ie552d9de3aa1f123a8f1c9414b444481461b4ec6
2014-09-01 18:11:13 +02:00
Cmcmahon
66afa50ba6 QA: update to fix deprecated API token call
Change-Id: Ie62cbcd40556c54444fdf1825dbb3ddebea5afde
2014-08-27 08:30:06 -07:00
helderwiki
07f49e4f96 Use <pre> to format bash commands
Change-Id: Iae36e9d2e16fbeede03e983b69b04bbaee573345
2014-07-30 22:34:45 -03:00
jenkins-bot
00081c453e Merge "Porting file test from browsertests" 2014-07-03 15:16:16 +00:00
jenkins-bot
237ee60fa9 Merge "QA: updates to edit test ported from qa/browsertests" 2014-07-03 15:15:42 +00:00
jenkins-bot
071a0fd3bb Merge "QA: porting login test from /qa/browsertests" 2014-07-03 15:15:25 +00:00
jenkins-bot
e1318c96aa Merge "chunky_png Ruby gem is not used" 2014-07-02 21:08:03 +00:00
Cmcmahon
7cf1051458 QA: need login tags for Jenkins build
Change-Id: I6663c6f6f59d692a9825ff8b462b30e1b2214ae0
2014-07-02 08:37:32 -07:00
Željko Filipin
72e4ca7f83 chunky_png Ruby gem is not used
Also fixed the order of gems in env.rb and updated Ruby gems in
Gemfile.lock.

Change-Id: I1ff294a50f37373bfdd3d04404c498e94b6f79ba
2014-07-02 15:55:58 +02:00
Cmcmahon
5c7c36baec QA: updates to edit test ported from qa/browsertests
Change-Id: I2ceae6ee6f98df78c12d257fd6503f5bf6395284
2014-07-01 12:27:32 -07:00
Cmcmahon
4540fea379 QA: porting login test from /qa/browsertests
Tested in local bare wiki, beta hewiki and enwiki

Change-Id: Icf060de7697cb43d9a8d28c036d4efcbdfd64720
2014-06-30 16:57:36 -07:00
Cmcmahon
0d30940db6 Porting file test from browsertests
Testing in bare wiki, beta enwiki and hewiki

Change-Id: If8262a7798c19dad84f9ceb88a5e286a90cf2a39
2014-06-30 12:14:24 -07:00
jenkins-bot
a85d6665cc Merge "Make Preferences tests language-agnostic" 2014-06-30 17:12:24 +00:00
Cmcmahon
e420ede80f Make Preferences tests language-agnostic
Change-Id: I2a0bd6e4306de11a8b3f13505bc3e65439211e23
2014-06-30 09:58:31 -07:00
Željko Filipin
d3d0e72a7b Added missing Cucumber tags to Selenium tests
Also:
- updated Ruby to version 2.1.2
- added missing ruby-gemset section to Gemfile

Change-Id: I2e6e7213ce51e8a15ecea34f76dd265d9d2f8594
2014-06-28 16:09:39 +02:00
Cmcmahon
36e9a6d834 Port preferences test from /qa repo
Add tests for preferences, make  core tests language-independent.
Change-Id: I1ba4e2c53a9e1bdb7b832efec4c2c8f6f64d2b86
2014-06-27 08:27:25 -07:00
cmcmahon
72e85be15a browser acceptance tests
Apropos of https://www.mediawiki.org/wiki/Wikimedia_Release_and_QA_Team/Quarterly_review,_April_2014#Action_items

Tests pass on a bare wiki install, beta enwiki, beta dewiki, beta hewiki

Bug: 66272

Ported create_account.feature and supporting files from /qa/browsertest without needing updates
Change-Id: I2b4bfa512a33ff31cc0369dfd9ec19cb875d5e36
2014-06-23 08:03:06 -07:00