Commit graph

3 commits

Author SHA1 Message Date
umherirrender
f153998317 Fixed spacing
- Removed double spaces
- Added space after if/switch/foreach
- Removed space on elseif
- Added space around parentheses
- Added newline at end of file
- Removed space before semicolon at end of line

Change-Id: Id40b87e04786c6111e6686d7f7eea1e588bdf37d
2013-11-19 19:03:54 +01:00
Brad Jorsch
405acaeba6 Add test for getRedactedTrace and reference args
This tests the issue PleaseStand noticed when reviewing I3d570a63, where
if some function in the call stack took arguments by reference then
passing the exception to MWExceptionHandler::getRedactedTrace would
clobber those arguments.

Change-Id: Iaaba3ef2fb5eb6a338ab229201105ed4308b0692
2013-11-01 23:36:13 +00:00
Antoine Musso
0ee7ea85d0 redact exception traces and abstract getTrace
* Partially reverts I0a9e92448 (rationale:
   http://www.gossamer-threads.com/lists/wiki/wikitech/401558)
  - wfDebugLog()'d exceptions are always unredacted
  - Other backtraces are redacted by replacing all argument values with class /
    type names.
* Adds a pair of static methods to MWExceptionHandler:
  - MWExceptionHandler::getRedactedTrace
	equivalent to Exception::getTrace, but replaces each argument value
	in the trace with its class or type name.
  - MWExceptionHandler::getRedactedTraceAsString
    equivalent to Exception::getTraceAsString, but with argument values
	likewise redacted.
* The rename of 'formatRedactedTrace' to 'getRedactedTraceAsString' is
  justified on two grounds:
  - 'formatRedactedTrace' didn't actually take a trace object (it took an
	exception).
  - 'getRedactedTraceAsString' maintains the symmetry with
    Exception::getTraceAsString.

Change-Id: I3d570a6385f96a606e1af53c50faa03b9ebacd38
2013-11-01 11:07:18 -07:00