The test was failing because a popup was added to the beta cluster.
Popup text:
Download a browser extension to get new features and help us improve Wikipedia
Bug: T270771
Change-Id: I6ba0026fcaa05610d4a310605f5ff6ae93705bc0
Instruct Special:Block to only load OOUI and the old JS module
when we're not using Codex.
Fix six year-old bug (from I20d11d7cc4) in mediawiki.htmlform's
selectandother.js where OOUI was incorrectly being assumed, causing
'Widget not found' errors at Special:Block when $wgUseCodexSpecialBlock
is true.
Bug: T358934
Change-Id: Ia959d297ac9043804975f170eec66ddd4c1fe492
With this change, the ?wpExpiry query param and the interface message
[[MediaWiki:Ipb-default-expiry]] accept only the following formats:
* /\d+ [a-z]+s?/ – such as "1 month", "2 weeks", etc.
* infinity values: 'infinite', 'indefinite', 'infinity', 'never'
* ISO 8601-like datestamp
In addition, [[MediaWiki:Ipboptions]] now requires an option be preset
with the value 'infinite'.
Rename `blockDefaultExpiry` to `blockExpiryDefault` for consistency.
Bug: T368583
Change-Id: Ibc648117e6d4981c84e9df9f933ba033d339e908
Fix form error display logic, doubly broken in If864607cbece8992:
it used too much array dereferencing in the error.length === 1 case
so only the first character of the string was shown, and it passed
a HTML string to messageBox() which expects a DOM node or plain
text. (Ideally, there would be some mechanism similar to
OO.ui.HtmlSnippet that allows passing HTML, but that's left for the
future.)
Also deduplicate the error formatting logic.
Bug: T376428
Change-Id: I053b4bd0cf3d6a0962540a90ae7f6b25129362a4
When temp users are not configured, temp() was a no-op; it should
be the empty condition instead.
Didn't cause any problems (the only caller is
expireTemporaryAccounts.php and that does check the isKnown() flag
first) but would be an easy mistake to make in the future.
Corresponding CentralAuth patch:
I107222c77d8f6dc4caee0db4f706108a2581b4bd
Bug: T372702
Change-Id: I904bbb97b028702ecfe98c97e3f821ba6038e27a
According to https://www.php.net/strtotime, strtotime() can emit
E_WARNING, but not E_STRICT. Anyway, which type of error it emits
doesn't really matter. The cure is the same either way, to use AtEase
or "@" silencing operator, and to explain why.
Remove outdated error code from the explaination, and while at it
replace AtEase with the silence operator (per T253461 and T272554).
Bug: T375707
Change-Id: I641d27b7e73f5ef202f096ceccf16d9f2b89a684
*Most* implementations of ContentHandler::fillParserOutput() ensure
that the returned ParserOutput has had
ParserOutput::resetParseStartTime() called on it at an appropriate
time -- but not *all*. This is a belt-and-suspenders fix that ensures
that every code path which creates a ParserOutput has *some* "start
time" defined. This could be misleading if the parsing is done first
and the parser output is created at the very end of the parse, but in
all the code that I've looked at the ParserOutput is the first thing
created and so this default should be reasonable.
While we're at it, remove the parseStartTime from the serialized form
of the ParserOutput, because it is useless after the object is
unserialized.
Bug: T376433
Change-Id: I3bdf3996401a7d5ac4d8e1e5e6afb7ca410cbe6c
Why:
- JobSpecification is the preferred way to enqueue jobs without
instantiating a full Job subclass instance, and the only way to
enqueue a job in the context of a foreign wiki.
- As such, it's used by several extensions. However, it's not explicitly
marked as newable.
What:
- Mark JobSpecification as newable.
Change-Id: I3dca96857c875da1ee6f0f6054a12aa6ec276697
Why:
- Calling getMessage()/getWikiText() with a good Status is a logic error
that converts the Status being operated on into a fatal one.
- However, this error is never logged anywhere, which can make it
difficult to diagnose such cases, as seen in
I17166e988bf389a5b03d4a74f539f7bec7f5997f.
What:
- Add a warning-level log for the case when getMessage() or
getWikiText() is invoked with a good Status.
Bug: T374436
Change-Id: I3efae5c4c336156924f1c9b4186fa9142aaed9ca
