Commit graph

39 commits

Author SHA1 Message Date
Matěj Suchánek
9f2b1c20fd Do not require titles on Special:ComparePages
By default, title fields are required, so the form cannot be submitted
without them. However, here we need either the title or the revision id.

Change-Id: Iedafec485851d7e91affb69a2c9c3fd40d31ded4
2018-06-09 14:09:00 +00:00
Timo Tijhof
15eac4c279 mediawiki.special: Combine various tiny specialpage style modules
These stylesheets are sufficiently tiny that it doesn't make sense to
offer them the ability to be loaded separately from each other (saving
bytes in double-digits) at the cost of 1) exporting a dedicated registry
item with meta data shipped on every page view, 2) reduced cache re-use
from increased fragmentation.

Instead, move these to the 'mediawiki.special' style module.
The entries retain their own files to keep them as easy to find
and edit as before.

Where not already, ensure addModuleStyles() is always placed above
any addModules() call in the same method. The load order isn't
affected by the call order, but given blocking style-modules load
before async JS, it helps to order them in a way that visually
matches the effective load order (from top to bottom).

The following 7 modules were remove without deprecation:

1. "mediawiki.special.apisandbox.styles" (1 rule)
2. "mediawiki.special.edittags.styles" (3 rules)
3. "mediawiki.special.movePage.styles" (1 rule)
4. "mediawiki.special.pagesWithProp" (1 rule)
5. "mediawiki.special.upload.styles" (2 rules)
6. "mediawiki.special.watchlist.styles" (3 rules)
7. "mediawiki.special.comparepages.styles" (4 rules)

These module names were only used on the core classes loading them, and
aren't depended on outside core by module name, rather, extensions and
gadgets depend on the styles styles being loaded in a blocking manner on
these pages, which remains unaffected.

Bug: T192623
Change-Id: I6e663dc3c80c7104c9b9abdde44c654543185373
2018-05-16 22:47:15 +00:00
Kunal Mehta
6e9b4f0e9c Convert all array() syntax to []
Per wikitech-l consensus:
 https://lists.wikimedia.org/pipermail/wikitech-l/2016-February/084821.html

Notes:
* Disabled CallTimePassByReference due to false positives (T127163)

Change-Id: I2c8ce713ce6600a0bb7bf67537c87044c7a45c4b
2016-02-17 01:33:00 -08:00
jenkins-bot
5bd4dd1f26 Merge "SpecialComparePages: Float the boxes, if available space is given" 2016-01-12 00:07:45 +00:00
Florian
0a8dcdb451 SpecialComparePages: Float the boxes, if available space is given
Follow up: I480c2165c908ca7c8e08ed5990e386ddb515f3b0

Bug: T122907
Change-Id: Iaf139974e850621a668c8ac32f3dc88ba3b70508
2016-01-11 12:53:38 -08:00
Fomafix
b538915975 SpecialComparePages: Remove outdated comment
The class 'mw-searchInput' got removed in 828a99e7.

Change-Id: I8cd1f85b7af6bb4552764fa8210d889fcb205746
2016-01-11 17:11:57 +00:00
Florian
828a99e75a Convert Special:ComparePages to OOUI
Bug: T117752
Change-Id: I480c2165c908ca7c8e08ed5990e386ddb515f3b0
2016-01-02 16:24:05 +00:00
Southparkfan
8c32adf323 Enable autocompletion for Special:ComparePages
Bug: T26235
Change-Id: Ia55ff14ceeef4eb49facd42a71c6330dd3384eb8
2015-08-27 18:08:28 +00:00
umherirrender
f971300427 Fixed some @params documentation (includes/[specialpage|specials])
Swapped some "$var type" to "type $var" or added missing types
before the $var. Changed some other types to match the more common
spelling. Makes beginning of some text in captial.
Also added some missing @param.

Change-Id: Icf6f36bb53322b39cd5c89523dbd0e4ab10b9ec9
2014-04-19 10:16:52 +02:00
Siebrand Mazeland
87ec7ad22e Update formatting
Change-Id: I0e334d910a311f067276215b6bff94cd814fc3b3
2013-04-20 10:02:19 +02:00
Siebrand Mazeland
80f4ee1720 Update code formatting
Used PHPStorm's code formatting feature, with manual checks and updates.

Change-Id: I0496eba007056bc9c4b09163387f11d6cea2a55d
2013-03-27 13:03:33 +00:00
umherirrender
96a5486ed0 Add SpecialPage::getGroupName and use it
Having all group mapping for Special:SpecialPages in the global
$wgSpecialPageGroups is not a good OO style.
Created a method SpecialPage::getGroupName, which than can be overridden
by each subclasses to the featured group name.

Added also SpecialPage::getFinalGroupName to get the groupname on
Special:SpecialPages to handle the customization and
to keep $wgSpecialPageGroups for b/c

Change-Id: I1de3a186f0a59ec5ecb8996c5f805cf164e9637f
2013-03-07 21:15:54 +01:00
umherirrender
824fad9956 fix some spacing
Change-Id: I78a97ad87e0bfe724fc851daf6ffeeed81887800
2013-01-26 19:15:35 +01:00
daniel
2bc191889a Fixing creation of DifferenceEninge
Creation of DifferenceEninge insteances was based on invalid assumptions
in several places.

Change-Id: Ib67ca893ea53a27d4ac7efd8a9ca0d3b2d93949f
2012-08-24 20:49:19 +02:00
Tim Starling
072416fa2d Fix indenting errors introduced in Wikidata branch
Change-Id: I487a0966a26359d4a6769331a6e2ee356eeb41db
2012-06-19 19:45:31 +10:00
daniel
cbc2014b2d Use integers for content_model and content_format.
Representing content_model and content_format as integers in the
database was suggested by Asher mainly to save space.

This change entails some refactoring and renaming, but no big
change in logic.
2012-05-14 10:22:52 +02:00
daniel
02b78b2c15 renamed getDifferenceEngine to createDifferenceEngine 2012-04-17 21:02:03 +02:00
Daniel Kinzler
88f8ab8e90 use factory method to get difference engine everywhere 2012-04-04 19:59:46 +02:00
Alexandre Emsenhuber
dca66e1c48 Use local context to get messages 2011-12-17 13:24:40 +00:00
John Du Hart
96ceb5b6a5 Fix for r102649 2011-11-15 02:42:07 +00:00
Alexandre Emsenhuber
2b78de3f02 Made DifferenceEngine use a context instead of global variables and updaters calls to constructor in core 2011-11-10 13:06:52 +00:00
Alexandre Emsenhuber
b49ab4a240 And I forgot to commit this in r99038: make "unhide" parameter work in Special:ComparePages, now that the links points to the correct place 2011-10-06 08:47:59 +00:00
Alexandre Emsenhuber
e4e9a7d897 Follow-up r93527: $value can also be null when not set 2011-07-30 20:27:32 +00:00
Alexandre Emsenhuber
c8b3faddff In Special:ComparePages:
* Validate title and revision when passed
* Don't display the diff if a field is not valid
* Pass the context to the HTMLForm and removed the setTitle() call
2011-07-30 15:03:21 +00:00
Sam Reed
f8fb526ea6 Refactor out common code 2011-05-01 21:28:00 +00:00
Happy-melon
128f33aa5e More ancient deprecated functions:
* OutputPage::setParserOptions() - 1.6 (r12183)
* OutputPage::addPrimaryWikitext() - 1.10 (r19095)
* OutputPage::addSecondaryWikiText() - 1.10 (r19520)
* OutputPage::tryParserCache() - 1.16 (r52888)
* OutputPage::reportTime() - 1.6 (r11117)
* OutputPage::<various error pages> - 1.7 (r14631)
2011-01-06 20:40:42 +00:00
Sam Reed
c15c1c6abb More reversion of r77297, 2 of 2 commits to keep it readable in CR (hopefully) 2010-11-25 22:24:28 +00:00
Antoine Musso
6fe29c9c30 revert r76464
* mixed style changes and variable removing
* logic changes
* useful comments removed
2010-11-25 20:01:34 +00:00
Sam Reed
10ecfeb03b Various unused variables, add some braces
Explicitally define some variables used in hook type calls
2010-11-10 19:49:04 +00:00
Sam Reed
604ae0ca1c Update deprecated method calls
Remove some unused stuff
2010-10-31 16:20:48 +00:00
Max Semenik
ae03d7a03b Bug 24832: fatal in Special:ComparePages. I've just removed the diffonly URL parameter, because: (1) you can't intuitively expect which page should be rendered below a diff of two different pages; (2) diffonly was never available as a UI option, just a hacky GET parameter; (3) it didn't work anyway. This commit reverts most of r68885. 2010-08-19 20:06:54 +00:00
Alexandre Emsenhuber
144c825809 Standardised file description headers; first path 2010-08-14 19:19:41 +00:00
Alexandre Emsenhuber
be4a77b5ce Pass a title to DifferenceEngine's constructor so that it won't fall back to $wgTitle (Special:ComparePage) and produce invalid links 2010-07-02 16:12:30 +00:00
Alexandre Emsenhuber
89e017a67f * Removed unused globals
* Fixed some whitespaces
* Use Html class instead of Xml when possible
* Make the page valid when using HTML5
2010-07-02 15:57:58 +00:00
Max Semenik
ca8d802763 Special:ComparePages: output titles in a more human-readable form 2010-07-02 14:04:39 +00:00
Derk-Jan Hartman
aab4c25820 Add a copyright line for myself to SpecialComparePages 2010-06-21 13:55:55 +00:00
Derk-Jan Hartman
f68b7bddb4 Correct the address of the FSF in some of the GPL headers
59 Temple Place -> 51 Franklin Street
Follow up to r68351
2010-06-21 13:16:32 +00:00
Sam Reed
7b229a2047 GPL Headers for all! 2010-06-21 12:59:04 +00:00
Derk-Jan Hartman
385bd8a911 (bug 23621) New Special:ComparePages to compare (diff) two articles. 2010-06-19 21:17:42 +00:00