Commit graph

42 commits

Author SHA1 Message Date
Bartosz Dziewoński
bdf40d7cca BaseTemplate: Remove code for unused 'ispermalink' toolbox item
This code path is never used.

When introduced in 2005 (bf0d92d5 / rSVN10709), the "Permanent link"
item in the MonoBook sidebar was a link to an oldid only when viewing
the latest version of an article (using the ID 't-permalink'), and
otherwise it was a greyed out link to nowhere to indicate you're
already viewing a permanent link (using the ID 't-ispermalink').

Later, in 2007, when the behavior of "Cite this page" item (now part
of the CiteThisPage extension) was corrected for old revisions
(1a60bd4c / rSVN21819), the "greying out" of the permalink was removed
to be consistent with the new item. Only half of the feature was
removed though: permalink was no longer a link to nowhere, but the
code in MonoBook to make permalinks that are links to nowhere greyed
out (by using different ID) stayed.

This code was then dutifully preserved when BaseTemplate, MonoBook was
rewritten, and then through several refactorings.

I think we can safely remove it. Leftover styles in MonoBook are being
removed in I58aca1f4255df14d6289e167e180dad31b546a8c.

Change-Id: I2fb3d7e0ecb3bbbd0c09774e2d86f86502a48bf1
2018-03-27 21:45:57 +02:00
Chad Horohoe
5c93fabafd Drop XCache support
It was never super popular anyway, APC was always the best option.
The project has no plans to move to PHP7, so it's quickly reaching
its end of life. Oh, and Fedora dropped it from their repos 2 years
ago.

Change-Id: Ia3257e86a6323d8943f04a5c05c72c0bd4c4b0a9
2018-02-07 13:45:40 -08:00
Bartosz Dziewoński
352cea4a94 Fix submit button id on Special:Preferences
For reasons beyond human fathoming, the button had the id set
to 'prefsubmit' in PHP code and then changed to 'prefcontrol'
in JS code. This functionality has been carefully preserved
across multiple rewrites of this code since 2004, when it was
added in 30d0ccd0 (rSVN3618). Let's just set the id in PHP.

Change-Id: Ib23bd0e481e73a51ff0a16731f47a2df11b2c1b8
2017-09-13 22:06:51 +02:00
Timo Tijhof
0977b6c1f6 phpunit: Avoid use of wmf-production host names
* Remove used of 'eqiad' and 'wmnet' in unit tests.

Change-Id: I5bf19b63876e4dc8deaca8cd9907dca0bfa15455
2017-04-12 02:53:33 +00:00
zppix1
0a6f7f5796 Remove "editusercssjs" user right
Deprecated since MediaWiki1.16

Change-Id: Ic9851d53affe0f4ece7a79f541ec5cb39133b109
2017-04-11 14:54:43 +01:00
Ed Sanders
5ee5ae6f69 Move link-underline user preference rule to body class
ResourceLoaderUserCSSPrefsModule is now empty and can be removed.

Change-Id: I806e117131765b859e990c14735bb9494db9a37e
2016-12-02 11:25:03 -08:00
Bartosz Dziewoński
771964fdea ApiMain: Correct typo in variable name
https://en.wikipedia.org/wiki/Asterisk

Change-Id: I6f2d968c92f4e472fe574ebc8a2a5f9932e0d6f2
2016-03-28 16:45:02 +00:00
Bartosz Dziewoński
1ebc9128d0 Remove putrid remains of $wgAllowAsyncCopyUploads
None of this works and it's been long begging for a mercy kill.
All it does is waste contributor time on updating deprecations
in the dead code. I imagine we wouldn't reuse much of this
code if we're ever going to reimplement it.

Bug: T119336
Change-Id: Ibd26a4bea621857aac77823017e9be9b7dc52cca
2016-01-22 00:18:25 +00:00
Timo Tijhof
4a68d17b02 Remove $wgAjaxWatch configuration variable
This is now enabled by default.
We still check $wgUseAjax and $wgEnableWriteAPI, however.

Originally introduced in r18598 (69ea9bcf9b; MediaWiki 1.9.0; T9169).

Change-Id: I87b1926e727ae0870a0239d6e8ad87cc3a5ad72b
2015-10-20 22:51:09 +01:00
Alex Monk
8682b8b90e Purge remaining oversight references from code
i18n change coming in a separate commit

Change-Id: I46b9311cd01e95e524587ce40dcbae62f58dc5a8
2015-09-16 18:21:44 +00:00
Gilles Dubuc
584a239318 TinyRGB support for JPG thumbnails
TinyRGB is an ICC profile released by Facebook under CC0.
It is designed to be fully compatible with sRGB.
It offers the vast advantages of being much smaller than sRGB,
as well as being free as in freedom (the sRGB profile found in the
majority of JPGs is copyrighted).

This change aims to provide the ability to swap sRGB for TinyRGB at
the time thumbnails are generated.

JPGs that use another ICC profile than sRGB or no profile at all are
unaffected.

Bug: T100976
Change-Id: I2ae35ddad4e8a82db8b9541974367dc76c884e7a
2015-06-22 16:17:54 +00:00
Mark A. Hershberger
671adf39db Remove i18n references to Popularpages
bug: T100676
Change-Id: I66002cbfb6b210fa08b57782665450b59439d17f
2015-06-15 17:48:52 -04:00
Chad Horohoe
5f8edb2c0a Drop ss_total_views and page_counter fields from MediaWiki
Follows up removal of code using hitcounters in 90d90dad6

RFC: https://www.mediawiki.org/wiki/Requests_for_comment/Removing_hit_counters_from_MediaWiki_core
Change-Id: Ieeb558f9523c11965cbc1941cad4f316c00c85c5
2015-01-09 19:01:01 +00:00
Ricordisamoa
fc5fd5c37a Typo fixes and non-code tweaks
Skipped replacements:
* prefered → preferred
* prolly → probably

Skipped files:
* resources/lib/jquery.ui/jquery.ui.mouse.js
* resources/lib/jquery/jquery.form.js

Change-Id: Ib7923f362ddfca1b892bf5d601785d6b5aa5d44c
2014-12-12 18:31:15 +00:00
Chad Horohoe
90d90dad6e Remove hitcounters and associated code
The hitcounter implementation in MediaWiki is flawed
and needs removal. For proper metrics, it is suggested to use
something like Piwik or Google Analytics.

RFC: https://www.mediawiki.org/wiki/Requests_for_comment/Removing_hit_counters_from_MediaWiki_core
Change-Id: I0e5006a7e8a09c800f8fa4effa9399e8afdd7a57
2014-10-20 13:01:55 -07:00
jenkins-bot
bb2d133137 Merge "Remove unused system messages "loginstart", "loginend" and "loginend-https"" 2014-09-24 17:29:54 +00:00
Yuri Astrakhan
38d7a2abf1 Updated mediawiki dict
Change-Id: Ia8eb4213fbc83be27de88a62d1c9c332f17b6579
2014-09-15 21:03:22 -04:00
Bartosz Dziewoński
35a9942ca7 Typo fix: HMTL → HTML
Change-Id: Id2bb52b92b7cf47a7a22506a01663acfee606ac4
2014-09-05 15:40:52 +02:00
withoutaname
081c3d428b Remove unused system messages "loginstart", "loginend" and "loginend-https"
Change-Id: Ib55492fb0e61f364bdc2a599d926e78ba98fe698
2014-09-05 02:07:38 +00:00
Yuri Astrakhan
ff4741cdce Updated dictionary
Change-Id: Ie727553268892d8b7f9b46fefebeee4463d5fecb
2014-08-18 01:02:44 +00:00
withoutaname
344e6c7b75 Move function xmlsafe() from Export.php to OAI extension
Exporting function from Export.php.

Change-Id: I82a78ff7a34402f2cc065643d90b064b996c525d
2014-07-19 23:26:23 +02:00
Yuri Astrakhan
474a55f0be Updated spelling dictionary
Copied words from my .idea/dictionaries/user.xml, sanitized, and merged
with the main dictionary.

Change-Id: I1ed1424646eb31721726585552a93f280d6b085a
2014-07-04 20:32:59 -04:00
jrobson
fb33b959db Move Modern and CologneBlue out of core
Import in the new repositories:

- Modern: I5348fedddf14affcee2688833f4e759e5af6499c
- CologneBlue: I9cc051f48074a033c684e5efa56a7b4dde51d366

Change-Id: I65768b4c29faf46895a7005a3090f43cf6e86258
2014-05-27 11:29:24 -07:00
tonythomas01
74756a2409 Removed 'Remember my login' preference
Removed 'Remember my login' from Preferences, as it was unwanted. It adds
to the complexity of the user preferences

Bug: 52342
Co-Author: Tyler Romeo <tylerromeo@gmail.com>
Change-Id: I7c957e1e1aaecf47f7c47bc063b5d3b364644afc
2014-04-16 12:49:44 +05:30
Waldir Pimenta
1078e93358 skin: Remove the id "anonlogin" and merge pt-anonlogin with pt-login
This was used as an alternative id for the login link in the
personal tools at the top right for ShowIPinHeader context.

This seems to have been inherited since the days of the
PHPTal-based skins (at least git-blame shows their presence back
in Brion's rewrite of the skin in november 2004).

I've asked several maintainers about this and nobody could figure
out why it would need a different id. After all, whenever the
user sees the login link it means they are using the wiki as an
anonymous user.

My best guess is that this was meant to allow the ability to
style the login differently when the (anonymous) user has
already made an edit (or if we init a session for other reasons).

This is also what toggles the anon userlinks are shown (i.e. the
links to the IP userpage and talkpage), but I see no evidence of
this, and in any case it would be better to change the class of
the whole personal tools div instead of changing the IDs.

Change-Id: Ib3445934853db5361c3c6fecfe75623b0b921400
2014-01-27 18:04:22 -08:00
Chad Horohoe
19873e7693 Ehcache more like mehcache
mehcache isn't a caching system, it's a pun.

I'm removing Ehcache support because it's an experiment didn't pan out
and the code's just sitting here abandoned now.

Change-Id: Ief5728b4c61bb5ad8f5a5f0b55415b23ef6727eb
2014-01-16 18:44:09 +00:00
tonythomas01
3d17f0dabf Removed "Disable search suggestions" from Mediawiki Preference
It's rarely used and provide more interface clutter and code complexity than
any benefit it provides.

Bug: 52812
Change-Id: I4b1d243b1b1a9da484147c4a682f44aa08a22803
2013-12-05 09:34:02 +05:30
jenkins-bot
db765aa9af Merge "Remove 'prefsnologin' message, don't use 'watchnologin' where inappropriate" 2013-11-23 20:31:35 +00:00
jenkins-bot
bb48a4618e Merge "Kill 'newmessageslink' and 'newmessagesdifflink' messages" 2013-11-23 19:14:30 +00:00
Bartosz Dziewoński
8c85bb762b Kill 'newmessageslink' and 'newmessagesdifflink' messages
Superseded ages ago by 'newmessageslinkplural' and 'newmessagesdifflinkplural'.

Also updated any docs that still referred to them.

Change-Id: Id4d99270acabbd7d72b877a091a6e3015d616826
2013-11-22 16:28:18 +01:00
Bartosz Dziewoński
cd20fd5995 Remove 'prefsnologin' message, don't use 'watchnologin' where inappropriate
There is no reason why the default can't be used instead.
No other special pages requiring login have special messages for the
title, as far as I know.

Left one use of 'watchnologin' in WatchAction alone, since it also uses
another special message there. This message is also currently used by
the MobileFrontend extension.

Change-Id: I7878ed3692358cee1f5785b34ab48a0cc83c05bc
2013-11-19 20:57:29 +00:00
Bartosz Dziewoński
68f3a22654 Consistently handle anonymous users on logged-in-only special pages
Added new helper function SpecialPage#requireLogin() to check if the
current user is logged in and, if not, format an error message linking
to Special:Userlogin and throw UserNotLoggedIn exception, to be
handled by OutputPage later.

Reused old error messages. Not all use the new parameter and they're
very inconsistent, but this is a matter for another patch.

Used it on 7 special pages. I don't think there are any other ones
which specifically require having an account, instead of just some
rights usually associated with logged-in users.

* SpecialChangeEmail
* SpecialChangePassword: It allows anonymous users under specific
  circumstances, but is logged-in-only in general.
* SpecialConfirmemail
* SpecialEditWatchlist
* SpecialPreferences
* SpecialResetTokens: It was missing the check, added it.
* SpecialWatchlist

Change-Id: I43ceaddb370d09784021b3fc2d5d1ff6616fef1f
2013-11-19 12:03:49 +01:00
MarkAHershberger
c24f8be729 Revert "Remove unsupported and mostly non-functional Mssql support"
This reverts commit 5e1efc3144.

This sort of thing needs to be discussed.  Please do not self-approve changes like this.

Change-Id: I9eb9ea315d90584b7fe95db43a6759884f9506b5
2013-11-16 02:06:01 +00:00
Chad Horohoe
5e1efc3144 Remove unsupported and mostly non-functional Mssql support
Change-Id: Id0a688865a5b7b6bb363f7b118fad4f455d2b3b6
2013-11-15 10:59:37 -08:00
MatmaRex
250caa19a0 Remove 'mediawiki.legacy.wikiprintable' module
It's a relic of simpler times, no longer used by any core skin. The
'mediawiki.legacy.commonPrint' module can be used instead.
(SkinTemplate-based skins do it automatically.)

* The 'mediawiki.legacy.wikiprintable' module has been removed.
* The skins/common/wikiprintable.css file has been deleted.
* Skin#commonPrintStylesheet has been deprecated; its return value is
  ignored.

Dependency: I96e66ff8905416bea906d40cdd72ba646399191b
Change-Id: Icbcebc8f539f7786d037b717d262684e9931aca6
2013-09-16 17:31:58 +00:00
kaldari
e517e9be57 Removing all disambiguation code from core
Disambiguation related functions have been re-implemented in the
Disambiguator extension.

Bug: 35981
Change-Id: I4afa30bf2677c6541ef355013f8eaef46abfbe03
Dependency: I41637ea43a9e5000bcb8a782441ce36f1068881f
2013-09-05 14:07:51 -07:00
Brad Jorsch
d24779328e Fix protection rights usage
It has long been recognized that using the 'protect' right to control
the ability to edit sysop-protected pages is troublesome. r31247 fixed
this by adding an 'editprotected' right, but for some reason in r32164
this was changed to bypass protection completely instead of fixing the
bug identified in r31462.

This patch goes back to do it the right way: editprotected no longer
bypasses all protection, and it is used instead of 'protect' for
controlling access to sysop-protected pages. For good measure, the same
is done with autoconfirmed protection (semiprotection): a new
editsemiprotected right is created instead of overloading the
existing autoconfirmed right.

This also fixes bug 27152 by making editprotected no longer special.

Bug: 13137
Bug: 27152
Change-Id: I6bf650a3fbdab8589ae6945c8c916eafd949e41c
2013-07-04 15:38:36 +10:00
Brad Jorsch
08adf46b26 Add 'viewmyprivateinfo', 'editmyprivateinfo', and 'editmyoptions' rights
These are needed for OAuth grants.

Note that we don't bother with a 'viewmyoptions' right, since the
majority will be determinable from just observing the interface.

Note that the fact of having a confirmed email address cannot be
reliably hidden, and if the user has 'sendemail' they may be able to
determine the real name and email address by sending an email to another
account that they control.

Change-Id: I3f03dd010020e8d43cc2d3bca7b3ef7196d1c548
2013-07-03 13:40:04 -04:00
Brad Jorsch
18062eb3b0 Add user rights 'viewmywatchlist', 'editmywatchlist'
These are needed for OAuth grants.

Note that, even if 'editmywatchlist' is not granted, various actions
will still allow for adding but not removing of pages.

Change-Id: Ie33446a228dd6ed0114730935c1bf65667f5ce01
2013-06-26 10:20:40 -04:00
Brad Jorsch
fc989b468d Add user rights 'editmyuserjs' and 'editmyusercss'
These are needed for OAuth grants.

Change-Id: I52f8e4a5cb48573cb2dbc26fc508e61a95d748c3
2013-06-10 15:44:22 -04:00
Alex Monk
a1f1ccee35 Gitweb -> Gitblit
Change-Id: I54387a6ca5ed020e66594d4bf410a042d4ae010f
2013-06-07 23:05:13 +01:00
Yuri Astrakhan
bb53df6bc8 A list of many words mediawiki uses as strings, comments, names.
This file can be attached to various IDEs to significantly reduce
the number of false positive spellchecking errors.

Change-Id: Ibfb0d89a1cbf58ea031e7873b5e6e01009f141bc
2013-03-22 01:12:30 -04:00