Deprecate the second argument to Maintenance::error() in favor of a new
Maintenance::fatalError() method. This is intended to make it easier to
review flow control in maintenance scripts.
Change-Id: I75699008638f7e99b11210c7bb9e2e131fca7c9e
Add the test entry point, because it contains documented hooks.
Filter out empty args, coming from trailing commas
Removed empty lines from hooks.txt, because a hook must be one block
without newlines between.
Change-Id: I71e0625da96cad03f5e38a000fa61d1d2bdac8ef
Use HTTPS instead of HTTP where the HTTP link is a redirect to the HTTPS link.
Also update some defect links.
Change-Id: Ic3a5eac910d098ed5c2a21e9f47c9b6ee06b2643
Also fix the use of RecursiveDirectoryIterator::SKIP_DOTS, which was
passed to the wrong constructor.
Follows I29280dfe629126c71adfb65ac1a59394bc459dc4
Follows I6c01b8768f9f70152e320d254f8025a0ffde8c62
Change-Id: Ib35ca10b809afd5f6da80cd5edd1a71479c917a7
* check 4 new paths
* strip 'NormalizeMessageKey' hook from docs/hooks.txt,
last call was removed in 1ea4f23b05
Change-Id: Id36ab478b94f74be451cae848d5ef2a318d23040
Check if all hooks in hooks.txt have a &, if the code also have & and
the other way round.
Fix all hooks in hooks.txt to have a clean run of the script.
Change-Id: I1b45253e20dc310e825cdc17e0e2e9c8fb315bab
This will make it easier to have something automated run
the script since it can check the exit code of the script
so see if any issues were found.
Also fixed the printing of "Looks good!", which wasn't happening
if a hook was being ignored. The check for ignoring was moved up
and out of the print logic.
Change-Id: I683a131a804d4fac9a21f386b2756e050219d392
* includes/changetags/
created with commit 5c4681012e
* includes/exception/
created with commit 557af13086
* includes/password/
created with commit 95a8974c6b
Change-Id: Ie9047a1849969a078465d1e81ada16a7b47bc0ec
bf8810d6bc split some
email-related code into a separate directory, along
with references to five hooks, thus listed as
'Documented and not found':
* AbortTalkPageEmailNotification
* AlternateUserMailer
* SendWatchlistEmailNotification
* UpdateUserMailerFormattedPageStatus
* UserMailerChangeReturnPath
Change-Id: I7601ea2f2b0c4c9dcf802114e464be9af88fa5cb
* Also added query continuation support to findHooks.php.
* Also fixed query continuation support in importSiteScripts.php
(broken by 2b3f4d821c).
Change-Id: I7ef62d370f5e2f598ac4c5857ac0dbf3ee4c8fa2
Added includes/skins/ to the list of directories and removed
the skins that were moved out of core.
The MonoBook hook is moved to skins/MonoBook in Ieb85b4bed.
Change-Id: Ie8ad1eb694575b8e1485177e2d14f2a9dcab179d
MediaWiki default is "@return type Description", so set a type after
return and start the description with a capital letter. Also use the
more common spelling of boolean.
See http://phpdoc.org/docs/latest/references/phpdoc/tags/return.html for
more about @return
Change-Id: I4e5198822fe92836f9cef9918a9fc1a1a1e0a043
* Correct typo in docs/hooks.txt.
* Add a few directories.
Left unfixed is "Undocumented: Special{$this->getName()}BeforeFormDisplay",
which will be addressed separately.
Change-Id: I4fda8960642c23500bd20e0b89c1d1327456313b
Swapped some "$var type" to "type $var" or added missing types
before the $var. Changed some other types to match the more common
spelling. Makes beginning of some text in captial.
Also added some missing @param.
Change-Id: I727deec35a712de0f0c676cc87dfa661f1ee965b
Added a ":" after the second quote so that only strings in the form
'Hook': are matched, otherwise the line 1172 of hooks.txt provoques the
the following message:
Documented and not found: value
because the line starts with 'value'.
Change-Id: I1d603e3fa10dcabf25e31f6a71aad233571738b5
The Line continuation Coding conventions prefers the closing parenthesis
on the same line than the beginning curly braces. This is done for ifs
and functions.
Also move some boolean operator from the end of a line to the beginning
and changed some indentation to make the condition hopefully better
readable.
Change-Id: Id0437b06bde86eb5a75bc59eefa19e7edb624426
Follows-up I1343872de7, Ia533aedf63 and I2df2f80b81.
Also updated usage in text in documentation and the
installer LocalSettingsGenerator.
Most of them were handled by this regex:
- find: (require|include|require_once|include_once)\s*\(\s*(.+?)\s*\)\s*;$
- replace: $1 $2;
Change-Id: I6b38aad9a5149c9c43ce18bd8edbab14b8ce43fa
Squiz.WhiteSpace.LanguageConstructSpacing:
Language constructs must be followed by a single space;
expected "require_once expression" but found
"require_once(expression)"
It is a keyword (e.g. like `new`, `return` and `print`). As
such the parentheses don't make sense.
Per our code conventions, we use a space after keywords like
these. We appeared to have an unwritten exception for `require`
that doesn't make sense. About 60% of require/include usage
was missing the space and/or had superfluous parentheses.
It is as silly as print("foo") or return("foo"), it works
because keywords have no significance for whitespace between
it and the expression that follows, and since experessions can
be wrapped in parentheses for clarity (e.g. when doing string
concatenation or mathematical operations) the parenthesis
before and after basiclaly just ignored.
Change-Id: I2df2f80b8123714bea7e0771bf94b51ad5bb4b87
- Added includes/content/ to the list of directories
- Added ContentHandler::runLegacyHooks() to the list of functions that run hooks
Change-Id: I1f21af71443468232b4bc119454f1c93ad343137
We can now do this since we finally switched to PHP 5.3 for MW 1.20 and get rid of the silly dirname(__FILE__) stuff :)
Change-Id: Id9b2c9cd2e678197aa81c78adced5d1d31ff57b1
