Commit graph

4 commits

Author SHA1 Message Date
Timo Tijhof
64ecc77422 resourceloader: Remove redundant getModifiedTime implementations
Follows-up f37cee996e which replaced the getHashMtime() and
getDefinitionMtime() methods with dummies that always return 1.

These getModifiedTime() implementations were only tracking the
definition summary or custom hash, which is already tracked
by getVersionHash().

Notes:
* SpecialCharacterDataModule: This one was odd as it was tracking
  both the mtime *and* the file contents.

* UserCSSPrefsModule/UserOptionsModule: Remove redundant caching.
  Already taken care of by getVersionHash() as of f37cee996e.

Bug: T94074
Change-Id: I6e37c3c2f85ef4599a8643b0efabc18de2f51ec4
2015-06-03 14:27:38 +00:00
Timo Tijhof
281a1847d7 resourceloader: Use absolute file path in SpecialCharactersDataModule
Follows-up ec2330f.

When called, it fails fails:
> file_get_contents(resources/src/mediawiki.language/specialcharacters.json):
> failed to open stream: No such file or directory

Needs to be expanded relative to $IP, just like ResourceLoaderFileModule
and others do already.

Not previously caught by unit tests because this method was never
called from any tests.

Change-Id: Id87b3de29a61039d87b630202f1f71f112cbd752
2015-05-09 04:48:24 +00:00
Alex Monk
8388cde849 Fix dependency of ResourceLoaderSpecialCharacterDataModule
I think this is probably what's causing the test failure in I3fafc561 on PS7

Follows-up If9c5cdbe

Change-Id: I8fafd734db49fdfaf088c68098c41920a2e6011b
2015-03-27 22:11:01 +00:00
Alex Monk
ec2330f7f9 Move WikiEditor's special character data and messages into core for use in other extensions
Using a ResourceLoader module to send the data to the client

For I3fafc561

Message changes:
wikieditor-toolbar-characters-page-.* -> special-characters-group-
wikieditor-toolbar-characters-(endash|emdash|minus) -> special-characters-title-

Bug: T91608
Change-Id: If9c5cdbe077e8796e1ebae99f759331251b5c4b1
2015-03-27 17:40:09 +00:00