Commit graph

43 commits

Author SHA1 Message Date
Yuri Astrakhan
9506e3d812 Spellchecked /includes directory
* Ran spell-checker over code comments in /includes/
* A few spellchecking fixes for wfDebug() calls

Found one very strange (NOOP?) line in Linker.php - see "TODO: BUG?"

Change-Id: Ibb86b51073b980eda9ecce2cf0b8dd33f058adbf
2013-03-13 03:42:41 -04:00
Tyler Anthony Romeo
4dcc7961df Fixed @param tags to conform with Doxygen format.
Doxygen expects parameter types to come before the
parameter name in @param tags. Used a quick regex
to switch everything around where possible. This
only fixes cases where a primitve variable (or a
primitive followed by other types) is the variable
type. Other cases will need to be fixed manually.

Change-Id: Ic59fd20856eb0489d70f3469a56ebce0efb3db13
2013-03-11 13:15:01 -04:00
rahul21
577f6ad214 (Bug 34798) Synced the FeedUtils.php page with mediawiki.action.history.diff.css
->Added the background,border in diff-context,diff-addedline,diff-deleted line in $styles array in the FeedUtils.php

Change-Id: Icbfb6cfc659652c146e565b760d0815640fdad64
2013-03-09 00:19:12 -05:00
IAlex
3f92a5672e Merge "remove space before semicolon" 2013-02-10 12:51:02 +00:00
umherirrender
ca31ebad3f fix some spacing
Added/removed spaces after opening/before closing parentheses

Added a space after a comma

Removed unneeded parentheses in condition

Change-Id: I306091347ccaaf11dee0cdfda3019cb0c12be51b
2013-02-09 23:03:53 +01:00
umherirrender
f3cf109e62 remove space before semicolon
Change-Id: Ic0d890f5e27cec017c7f7910a67d53b2edf82079
2013-02-09 22:44:24 +01:00
umherirrender
1044b0b8df fix some spacing
Change-Id: I8f976013f33c5818e4402604fe8610aa3f43b0c6
2013-02-04 20:18:33 +00:00
umherirrender
85d8ee1f87 Remove a bunch of trailing spaces and unneeded newlines
Change-Id: I00f369641320acd7f087427ef031f3ee7efa0997
2012-10-10 20:14:40 +02:00
daniel
ff03cf38cc get rid of Revision::getText
Change-Id: Ia0b16813fa1688b6faccbe8ca81b1099001b1f3b
2012-09-14 18:23:21 +02:00
daniel
9994968774 merged master
Change-Id: Ib2b879c4daa17401eeeb50767c0e5a54254855c3
2012-08-29 15:20:15 +02:00
Daniel Kinzler
392af46809 Revert "merged master"
This reverts commit 67bfdc7a68
2012-08-29 13:14:49 +00:00
daniel
67bfdc7a68 merged master
Change-Id: Ib2b879c4daa17401eeeb50767c0e5a54254855c3
2012-08-29 12:06:38 +02:00
daniel
2bc191889a Fixing creation of DifferenceEninge
Creation of DifferenceEninge insteances was based on invalid assumptions
in several places.

Change-Id: Ib67ca893ea53a27d4ac7efd8a9ca0d3b2d93949f
2012-08-24 20:49:19 +02:00
daniel
29719f846b merging latest master
Change-Id: I36b7f2f63ab8c08f8412d521dc68ea45c8b67711
2012-08-20 16:55:28 +02:00
Tim Starling
072416fa2d Fix indenting errors introduced in Wikidata branch
Change-Id: I487a0966a26359d4a6769331a6e2ee356eeb41db
2012-06-19 19:45:31 +10:00
daniel
181641792a merged master after 1.20wmf3 2012-05-15 08:46:34 +02:00
Alexandre Emsenhuber
15e9fcca01 Added missing GPLv2 headers in some places.
Also made file/class documentation more consistent.

Change-Id: Iaebd4e253ff3b35b568e9b394231a5691445ac95
2012-05-14 19:59:58 +02:00
daniel
02b78b2c15 renamed getDifferenceEngine to createDifferenceEngine 2012-04-17 21:02:03 +02:00
Jens Ohlig
10e91851b2 Merge branch 'master' into Wikidata
Conflicts:
	.gitreview
	includes/Article.php
	includes/AutoLoader.php
	includes/EditPage.php
	includes/LinksUpdate.php
	includes/WikiPage.php
	includes/installer/Ibm_db2Updater.php
	includes/installer/MysqlUpdater.php
	includes/installer/OracleUpdater.php
	includes/installer/SqliteUpdater.php
	maintenance/refreshLinks.php
2012-04-11 14:24:29 +02:00
Daniel Kinzler
88f8ab8e90 use factory method to get difference engine everywhere 2012-04-04 19:59:46 +02:00
Sam Reed
560ebfb721 Fix possibly undefined variables
Move $db further up

Return something on all paths
2012-02-18 01:07:42 +00:00
Sam Reed
76246b9bf5 More return documentation 2012-02-09 21:33:27 +00:00
Aaron Schulz
4ccf5a9a90 r96546: Made FeedUtils::formatDiff() use the new LogFormatter class rather than a broken LogPage::actionText() call (the <summary> tag only had the log action name in it). This change means that log actions in feeds now have the user name in them, unlike 1.18. Also, broke a long code line. 2012-02-07 23:57:33 +00:00
Platonides
9bf2a06c7d Follow-up r106189. The $wgUser are no longer needed. 2011-12-15 21:53:02 +00:00
Siebrand Mazeland
d093043131 Remove users of deprecated User::getSkin(). 2011-12-14 13:01:27 +00:00
Tim Starling
82ff85e67c Fix for r102295 per CR r105654: don't double-escape the URL 2011-12-09 09:32:15 +00:00
Tim Starling
b36df6ecc6 Fixes for r102295:
* Rename getDiffText to getDiffLink since that's what it actually gets. Fix associated variable names. 
* Use Html::element() not Html::rawElement() when escaping is desired.
2011-12-09 05:54:26 +00:00
Tim Starling
6d626866de Fix comment from r102287 2011-12-09 05:37:57 +00:00
Antoine Musso
92d98413ce bug 29110 - $wgFeedDiffCutoff doesn't affect new pages
Patch by John Du Hart. Rewritten to avoid code duplication, duplicate
code is now in a helper function.
2011-11-07 16:12:37 +00:00
Antoine Musso
c20f7be60f early returns to avoid long code in if / else
Instead of enclosing a lot of code in a if() {} block. I reverted the logic
to exit early. That makes code a bit easier to read.

Logic was:
 if( $title->getNamespace() >= 0 && !$accErrors && $newid ) {
   // LOT OF CODE
 }
 return;

Now:
 if( $title->getNamespace() < 0 || $accErrors || !$newid ) {
   return;
 }
 // LOT OF CODE
2011-11-07 14:57:55 +00:00
Alexandre Emsenhuber
ec9b551ca9 * Added HttpError exception as replacement for wfHttpError(); changed alls core calls to it except AjaxDispatcher.php
* Changed FeedUtils' call to it to be similar than feeds are completely disabled
* Use local context instead of global variables in Special:Userlogout
2011-09-16 18:50:13 +00:00
Sam Reed
ad39f2da86 Trim trailing whitespace
Add/tweak/update documentation

Simplify some boolean returns
2011-09-04 21:40:17 +00:00
Sam Reed
bdc31bb9bc Change usages of $wgUser->getSkin() in special pages to use $this->getSkin()
Fix trailing whitespace
2011-07-01 02:25:19 +00:00
Alexandre Emsenhuber
dc81854161 Avoid PHP notice about undefined variable $diffText if $wgFeedDiffCutoff is 0 2010-04-04 12:01:42 +00:00
Alexandre Emsenhuber
92421b974b * (bug 19393) Feeds now format dates in user language rather than content language
There's no more need to do this with content language since the language code was added to the cache key in r58978.
2010-04-02 15:46:41 +00:00
Alexandre Emsenhuber
6a9bb1f6d2 __FUNCTION__ -> __METHOD__ 2010-01-10 18:36:26 +00:00
Alexandre Emsenhuber
36d2910fa9 * Document a bit
* Add new doxygen group "Feed"
* Fix some doxygen warnings
2010-01-09 21:59:40 +00:00
Chad Horohoe
523ce0a9b9 (bug 19394) Recent changes feed items corresponding to some log entries are broken. Patch by Mormegil 2009-08-02 03:07:07 +00:00
Purodha B Blissenbach
00a913cecd Message 'revisionasof' - date and time separated as of request by user "Der Umherirrende" at
http://translatewiki.net/w/i.php?title=Support&oldid=1243738#split_date_and_time
2009-06-01 20:45:46 +00:00
Chad Horohoe
2664b438f1 Remove some unused $wgOut's. 2009-04-07 15:56:26 +00:00
Chad Horohoe
1a0017a76f (bug 14868) Setting $wgFeedDiffCutoff to 0 now stops generation of the diff entirely, not just display of it. No point in wasting time doing the former if you don't want the latter :) 2008-08-08 13:48:16 +00:00
Brion Vibber
2e2141866b * (bug 14646) Fix some double-escaping of HTML in feed output
Log entry action text was being double-escaped by running HTML through the comment parser.
Log action text is now output as straight HTML.

The link for long diffs was also coming out wrong on English Wikipedia due to overloading of messages.
Switched from 'differenes' (which is a label text which had gotten turned into an HTML link there) to 'showdiff', which is a plaintext button label. (Might consider making it a separate message which is a little more descriptive.)
2008-07-06 20:19:04 +00:00
Niklas Laxström
58f7bb30a0 Refactored SpecialRecentchanges:
* Use a class and new frameworks
* Split into functions
* Two new hooks
* Split feed related items to new classes that are autoloaded
2008-06-17 08:24:00 +00:00