Thijs/wiki.techinc.nl

Fork 0

Commit graph

Author	SHA1	Message	Date
Domas Mituzas	7303df44a2	I have no idea why I'm doing this, but this has to be done, force order on *links,page reads	2009-02-19 10:38:42 +00:00
Tim Starling	4f3efbf406	Don't do any backlink batches if there are no backlinks.	2009-02-19 02:10:55 +00:00
Tim Starling	4b66381cbf	* Mostly reverted r41081 and related. Although the motivation (to save a query) is noble, it's a complex special case relying on subtle inter-module effects, making the code quite unclear and the performance advantage hard to reproduce in new code. * r41081 was causing the job queue to be flooded with tiny htmlCacheUpdate jobs which were less than the batch size and so, according to the original logic, should have been done immediately. This was causing template updates to be delayed even when the template has few backlinks. This is fixed. * Introduced a shared cache called BacklinkCache with the main purpose of sharing data from these backlink queries, thus recovering the performance of r41081. * Refactored backlink partitioning code, which in r40741 was copied from HTMLCacheUpdate to LinksUpdate with a bug intact. The bug caused every htmlCacheUpdate or refreshLinks2 job to be split into at least two pieces even when number of rows is less than the batch size. * Fixed a bug from r40741 causing refreshLinks2 jobs with end=false to be ignored. * Made SquidUpdate::newFromTitles() accept a TitleArray	2009-02-16 14:26:34 +00:00

Author

SHA1

Message

Date

Domas Mituzas

7303df44a2

I have no idea why I'm doing this, but this has to be done, force order on *links,page reads

2009-02-19 10:38:42 +00:00

Tim Starling

4f3efbf406

Don't do any backlink batches if there are no backlinks.

2009-02-19 02:10:55 +00:00

Tim Starling

4b66381cbf

* Mostly reverted r41081 and related. Although the motivation (to save a query) is noble, it's a complex special case relying on subtle inter-module effects, making the code quite unclear and the performance advantage hard to reproduce in new code.

* r41081 was causing the job queue to be flooded with tiny htmlCacheUpdate jobs which were less than the batch size and so, according to the original logic, should have been done immediately. This was causing template updates to be delayed even when the template has few backlinks. This is fixed.
* Introduced a shared cache called BacklinkCache with the main purpose of sharing data from these backlink queries, thus recovering the performance of r41081.
* Refactored backlink partitioning code, which in r40741 was copied from HTMLCacheUpdate to LinksUpdate with a bug intact. The bug caused every htmlCacheUpdate or refreshLinks2 job to be split into at least two pieces even when number of rows is less than the batch size.
* Fixed a bug from r40741 causing refreshLinks2 jobs with end=false to be ignored.
* Made SquidUpdate::newFromTitles() accept a TitleArray

2009-02-16 14:26:34 +00:00

3 commits