Commit graph

118 commits

Author SHA1 Message Date
umherirrender
41988661e4 GROUP BY and ORDER BY supports arrays in Database class
Change-Id: Ib431b07ffa2ce6843e21536de2ff19c648e0a595
2012-05-13 00:06:48 +02:00
Alexandre Emsenhuber
d1f8640a3b Added missing GPLv2 headers in some places.
Also made file/class documentation more consistent.

Change-Id: Ia45d0756cd84138da267bf1cbd1a58be7f28c6d1
2012-05-11 10:34:29 +02:00
jeroendedauw
190952379e code style tweaks
Change-Id: I992459cd740678d0eb0b2dd70de6c092d7dba67e
2012-04-05 20:29:30 +02:00
Antoine Musso
e58513eb9c (bug 34736) empty limit on special pages causes navigation issues
On special pages, the older link showed a limit='' query parameter which
made the page show nothing ('' is evalued to a limit of 0 articles).

The cause is r105809 which changed the way we interprets parameters in
wfArrayToCGI() and wfCGIToArray(). Previously, An empty string value would skip
the key, after r105809, we need to use null.
2012-02-27 10:17:01 +00:00
Siebrand Mazeland
ec4bb05069 (bug 34702) Localised parentheses are now used in more special pages. 2012-02-26 13:08:41 +00:00
Siebrand Mazeland
fa53862b3f Wow. Messy. Follow-up r112426, r112424: Fix incorrect calls. Should have been escaped() instead of escape(). 2012-02-26 12:11:35 +00:00
Siebrand Mazeland
7e7079374f Follow-up r112424: Per IAlex on IRC: Use escape() instead of plain() for improved security. 2012-02-26 12:07:21 +00:00
Siebrand Mazeland
fbe974a6f8 Follow-up r112410, r112412: Cheaper processing using plain(). 2012-02-26 11:49:01 +00:00
Siebrand Mazeland
68643f5079 (bug 34702) Use localised parentheses in Special:Contributions. 2012-02-25 20:42:08 +00:00
Jeroen De Dauw
8054075513 fix doc, this is not an array 2012-02-23 22:58:11 +00:00
Jeroen De Dauw
b996890e4e docs++ 2012-02-23 22:26:38 +00:00
Sam Reed
85bbb0b080 Fixing some of the "@return true" or "@return false", need to be "@return bool" and then the metadata can say true if foo, false if bar
Other documentation improvements
2012-02-09 18:01:10 +00:00
Jeroen De Dauw
780b62663e spacing fix 2012-01-24 00:25:00 +00:00
Aaron Schulz
5a6559d8b1 Reverted r108743 per CR comment. This should at least be discussed first. 2012-01-12 19:41:18 +00:00
Sam Reed
a5c200a25b Kill "* @return void" 2012-01-12 19:12:24 +00:00
Brion Vibber
1200ae7dae Revert r104353, r104354, r104356, r104358, r104383: changes to pagers breaking existing links as noted in CR. 2011-12-06 19:32:29 +00:00
John Du Hart
d8dd0c6507 Followup r104353, updating Special:ProtectedTitles
Adds HTML form fields for namespaces and restriction levels
Adds getVal() to HTMLForm
2011-11-28 00:31:05 +00:00
John Du Hart
54dd841a6f This is the rework I was talking about in r104318 for 1.19. Instead of having Pager subclasses build HTML forms by hand build HTMLForm into the Pager class. Much less painful, no?
This is simply a first pass, there's many more classes to convert.
2011-11-27 18:23:50 +00:00
John Du Hart
216d661d3b Bug 29524 - Rename RequestContext::getLang to getLanguage
I'll be amazed if this doens't break any tests.
2011-11-21 16:13:21 +00:00
Aaron Schulz
c8575ffd7a FU r101629, made Pager only call doBatchLookups() if there are rows 2011-11-02 17:33:00 +00:00
Aaron Schulz
dab142d5f0 Moved contribs rev parent ID batch query into doBatchLookups() 2011-10-20 02:26:59 +00:00
Aaron Schulz
ddaa5d800e * Added a proper Pager::doBatchLookups() function
* Made HistoryPager use a link batch via Pager::doBatchLookups()
2011-10-20 00:43:43 +00:00
Happy-melon
a73791be74 Documentation and type hinting. 2011-10-06 13:22:53 +00:00
Daniel Friesen
8ca8e37db7 More RequestContext -> IContextSource. 2011-10-02 17:42:21 +00:00
Daniel Friesen
aa6573c7ab Merge r98679 from the pageoutput branch into trunk. 2011-10-02 16:37:32 +00:00
Alexandre Emsenhuber
00b6d465f1 * Made IndexPager extend ContextSource
* Updated special pages using IndexPager or one if its subclasses to pass the context object and use it instead of global variables
* Call Linker methods statically
* Changed LogPager::getUser() to LogPager::getAuthor() to avoid conflict with ContextSource::getUser()
2011-09-20 20:00:05 +00:00
Aaron Schulz
4ab31fc35b FU r97022: Fallback to empty array for getExtraSortFields() result in __construct() if no value is set for the sort order/type. 2011-09-14 17:42:28 +00:00
Aaron Schulz
d2d59e246c Possible fix for issue reported in r83762. I had a hard time confirming the problem/fix with profiling. Committing this now to get more attention. 2011-09-13 23:24:34 +00:00
Krinkle
f98a0ec075 Split up TablePager css class, introduce .mw-datatable
* All tables generated with the TablePager PHP class use this css class for their styling. This visual look has since inspired several templates and other tables on the wikis and in extensions to present data with row-highlighting functionality. To make it easier to do that, separating the generic styling into a new css class "mw-datatable" and use it in the TablePager PHP class.
* Kept pager-specific "min-width" rule under .TablePager
* Other CSS classes for TablePager are also untouched
* Changed table-heading color slightly to not be exactly the same as the hover-style (design/usability)
2011-09-01 10:38:19 +00:00
Robin Pepermans
7c624542f0 (bug 6100; follow-up to r91315) Being bold and removing $wgBetterDirectionality (and dependent wfUILang) in core, as most or all work is finished.
Also:
* Introduce classes mw-float-end, mw-float-start so we don't have to use inline css depending on wfUILang()/$wgLang (see HistoryPage and SpecialFileDuplicateSearch)
* Add direction mark to protection log
* Remove specialpageattributes as it is obsoleted by this commit (also fixes bug 28572)
* Add two direction marks in wfSpecialList, which makes ltr links on rtl wiki (and vice versa) display nicely as well (only on those special pages however)
* Revert r91340 partially: use mw-content-ltr/rtl class anyway in shared.css. Both ways have their [dis]advantages...
* Set the direction of input fields by default to the content language direction (except buttons etc.) in shared.css
2011-07-06 02:26:06 +00:00
Sam Reed
77b42e01ff Followup r89617, r91428 call $pager->doQuery explicitally so we get a set result object, from which, we can then get a row count
Expliticly marking doQuery() in pager as public
2011-07-05 00:09:09 +00:00
Robin Pepermans
9b9dc2fdfd Simpler code 2011-06-30 15:20:57 +00:00
Robin Pepermans
9077baef30 Follow-up to r90265: directionality improvements as part of bug 6100 (under $wgBetterDirectionality):
* Correct directionality when viewing diffs
* Correct arrows for Pager
* CSS/JS pages always 'en' (LTR)
* Messages on Special:Allmessages have lang and dir attributes based on the selected language
2011-06-18 13:12:52 +00:00
Sam Reed
50d5b074d0 And some more parameter documentation!! 2011-05-28 16:31:00 +00:00
Alexandre Emsenhuber
3bc50f6984 Use WebRequest::getQueryValues() to get all query strings parameters instead of $_GET 2011-05-26 16:18:35 +00:00
Leo Koppelkamm
9aa24fcb9f Switching arrows in Special:FileList to match the usual behaviour in MW. Bug 18962 2011-05-02 19:56:28 +00:00
Happy-melon
229b5aa755 (bug 19942) remove deprecated HTML attributes (cellpadding, align, valign) from TablePager. 2011-03-30 17:37:25 +00:00
Happy-melon
f050fabd6b Complete the trinity of blocking frontend interfaces by rewriting SpecialIpblocklist:
* Move and rename to SpecialBlockList
* Use an HTMLForm in GET mode for the options form
* Use TablePager to organise the results more nicely
* Standardise the filtration for IPs and IP ranges, so looking at blocks for a range will now also show rangeblocks which contain the range
* General tidy up
2011-03-14 16:09:44 +00:00
Raimond Spekking
5e74a2007c Follow-up r82391 per Nikerabbit's CR: Fix it in a better way 2011-02-18 15:14:08 +00:00
Raimond Spekking
a8c76bc86c Don't clutter the HTML source with useless class="" 2011-02-18 11:20:49 +00:00
Sam Reed
e4a9c89be0 Fixup fixme on r76844
Only "known issue", is the bottom limit thing posts, and won't override the top one, if it's set one in the URL, which is a PITA. 2 clicks does it. Hopefully this can be fixed, and uncommented when VVV sorts out our queryparameters? :)
2010-12-14 18:17:42 +00:00
Sam Reed
2ce4fc0cb5 Return type documentation 2010-12-03 01:43:23 +00:00
Sam Reed
5bb5747674 Variablise $navigationBar
Add a couple of braces
2010-11-16 14:06:21 +00:00
Max Semenik
c2db336916 Fixed E_STRICT from r71059 2010-08-15 07:03:59 +00:00
Ryan Kaldari
1a45345aa8 fix to handle case of mIndexField including a table prefix 2010-08-14 01:57:05 +00:00
Raimond Spekking
ad375dddaf Add the current limit (manually changed by a user) from the query string to avoid that the limit is lost after clicking Go next time 2010-06-17 07:32:39 +00:00
Aryeh Gregor
74a21f3bd1 Remove most named character references from output
Recommit of r66254 to trunk.  This was just

find extensions phase3 -iname '*.php' \! -iname '*.i18n.php' \! -iname 'Messages*.php' \! -iname '*_Messages.php' -exec sed -i 's/ /\ /g;s/—/―/g;s/•/•/g;s/á/á/g;s/´/´/g;s/à/à/g;s/α/α/g;s/ä/ä/g;s/ç/ç/g;s/©/©/g;s/↓/↓/g;s/°/°/g;s/é/é/g;s/ê/ê/g;s/ë/ë/g;s/è/è/g;s/€/€/g;s/↔//g;s/…/…/g;s/í/í/g;s/ì/ì/g;s/←/←/g;s/“/“/g;s/·/·/g;s/−/−/g;s/–/–/g;s/ó/ó/g;s/ô/ô/g;s/œ/œ/g;s/ò/ò/g;s/õ/õ/g;s/ö/ö/g;s/£/£/g;s/′/′/g;s/″/″/g;s/»/»/g;s/→/→/g;s/”/”/g;s/Σ/Σ/g;s/×/×/g;s/ú/ú/g;s/↑/↑/g;s/ü/ü/g;s/¥/¥/g' {} +

followed by reading over every single line of the resulting diff and
fixing a whole bunch of false positives.  The reason for this change is
given in <http://lists.wikimedia.org/pipermail/wikitech-l/2010-April/047617.html>.
I cleared it with Tim and Brion on IRC before committing.  It might
cause a few problems, but I tried to be careful; please report any
issues.

I skipped all messages files.  I plan to make a follow-up commit that
alters wfMsgExt() with 'escapenoentities' to sanitize all the entities.
That way, the only messages that will be problems will be ones that
output raw HTML, and we want to get rid of those anyway.

This should get rid of all named entities everywhere except messages.  I
skipped a few things like &nbsp that I noticed in manual inspection,
because they weren't well-formed XML anyway.

Also, to everyone who uses non-breaking spaces when they could use a
normal space, or nothing at all, or CSS padding: I still hate you.  Die.
2010-05-30 17:33:59 +00:00
Alexandre Emsenhuber
a85002625a * Fixed some doxygen warnings
* Documented a bit
2010-02-28 15:43:51 +00:00
Tim Starling
688edac45b For r58153: in HistoryPage, removed the user permissions checks for deleted revision filtering. Added a tag to the SQL filtered SQL query so that sysadmins can easily find the relevant code if there is a problem. 2010-02-09 01:17:01 +00:00
Siebrand Mazeland
e8a65f9e25 Update break notation to self enclosed and properly spaced 2009-11-14 20:59:15 +00:00