Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
42987 commits 1 branch 0 tags 744 MiB
Commit graph

84 commits

Author SHA1 Message Date
umherirrender
2f190c4792 user table: replace some '*' with explicit fields in selects 
It is good practice to select only fields, which are used later

Change-Id: Iaaa252d594112894334a8ee9916007352d5bc4e7
 2012-05-25 17:53:29 +02:00
Reedy
c87a63935a Merge "(bug 19195) Make user IDs more readily available with the API" 2012-05-10 18:47:42 +00:00
Petr Onderka
4f17f49b78 Fixed whitespace in API classes 
Change-Id: Ia06de4822e32612c4f668e14643236322837a3e1
 2012-05-02 15:48:02 +02:00
umherirrender
426ccbf42e (bug 19195) Make user IDs more readily available with the API 
Add some block ids and user ids to the result of some modules

Change-Id: If50604b888a54827eddde76574e779db6c7263ec
 2012-04-22 14:20:46 +02:00
Sam Reed
53000baecf Oh noes, moar http:// -> https:// 2011-11-28 15:43:11 +00:00
John Du Hart
2e7d867478 Removed the 'eclipse helper' bit on top of every API module 
It's a parctice that dates back to 2006 when the API was first written, and frankly isn't covered by the coding conventions. Same thing with the docblocks, they're all copypasted with some bits changed and don't even make sense if you look at them in the genereated code docs.
I don't feel that any of us depend on this anymore (get a better IDE), so in the inerest of consistancy it's time we said goodbye to it.
 2011-11-16 00:17:26 +00:00
Sam Reed
fa65fa3243 Documentation 
Deprecated code updates
 2011-10-27 00:46:17 +00:00
Sam Reed
5ed71b715e Bug 31199 - Fix notification of implicit groups so it doesn't massively change json output 
Needs merging to 1.18, 1.18wmf1 and pushing to site
 2011-09-28 16:36:17 +00:00
Sam Reed
a5628f5734 Based on diff to wikia, set more functions consistently public rather than protected 2011-08-17 22:24:21 +00:00
Sam Reed
d510cdd91d * (bug 29938) list=users&usprop=rights shows rights the user doesn't have 2011-07-18 21:26:33 +00:00
Sam Reed
9c37ab4fb3 * (bug 28817) Add reference help page link to API Modules 
Last followup of r92396

Should be all modules with documentation pages in core now documented...
 2011-07-17 17:02:06 +00:00
Chad Horohoe
783d4e0862 Remove @static from all over the place. That's what the static keyword is for, this being PHP5 and all 2011-04-21 00:07:09 +00:00
Sam Reed
29df5af44e Followup r84361, numerical keys ftw 2011-03-20 00:32:28 +00:00
Sam Reed
db45168a0d * (bug 27469) label implicit groups in list=allusers&auprop=groups/list=users&usprop=groups 2011-03-20 00:19:29 +00:00
Sam Reed
86ce74c75d * (bug 28010) Passing a non existant user to list=users gives internal error 
* (bug 27549) action=query&list=users&usprop=groups doesn't show implicit groups if a user doesn't have explicit groups

Also follows up r79556, where I'd done a couple of daft things... (accessing undefined objects)
 2011-03-12 22:23:43 +00:00
Sam Reed
aea7a5a482 Followup r83390 
If the user is allowed to view hidden users, put a missing property on all users.

For list=users, do the same, but we can't easily distinguish to other people the difference between "hidden", or "missing", so no reason to do it
 2011-03-06 20:51:31 +00:00
Sam Reed
8c4f349a63 Fix leading whitespace before class ApiQueryUsers 2011-03-06 18:17:28 +00:00
Sam Reed
67d4ee1d26 Followup r83390, change cache modes 2011-03-06 18:16:44 +00:00
Sam Reed
c488abeeb8 * (bug 27897) list=allusers and list=users list hidden users 
Refactored addition of block information, and also checked if user is allowed to view hidden user fields
 2011-03-06 17:59:08 +00:00
Sam Reed
20d56c63b3 * (bug 27708) list=users does not have a property to return user id 
Add userid to ApiQueryUsers

Move userid in ApiQueryAllUsers before name
 2011-02-25 16:19:44 +00:00
Sam Reed
448ab3b78d Fixup one missed alias rename from r82739 2011-02-24 20:46:45 +00:00
Sam Reed
35296f391f Followup to r82739 (bug 27688) 
Remove u1 table aliases
 2011-02-24 18:46:12 +00:00
Sam Reed
57923b31fa * (bug 27688) Simplify queries to list user block information 
Also expose block expiry information, listed on Users, but not all users

Some minor simplifications to come
 2011-02-24 18:43:44 +00:00
Sam Reed
fa64025161 More parameter documentation 2011-02-19 00:30:18 +00:00
Sam Reed
df0a765cfe * (bug 26559) list=allusers auprop=rights does not match list=users usprop=rights 2011-01-04 03:36:39 +00:00
Sam Reed
0014c1113c * (bug 26558) list=allusers auprop=groups does not list groups a user is automatically a member of 2011-01-04 02:48:02 +00:00
Sam Reed
e1bcab1ab8 * (bug 25767) Add userrights properties to allusers and users query lists 
First part of this bug. Listing of all rights that users have
 2011-01-04 01:39:02 +00:00
Sam Reed
1da2cd2dde Move comment about groups potentially returning less results from server. 
Comment out description line about rights from ApiQueryUsers, as that prop doesn't exist (Might do in future. Possible artifact from large scale comment addition?)
 2011-01-03 20:41:22 +00:00
Sam Reed
6309c920dd Delete all the "API for MediaWiki 1.8+" comments 
Add since to ApiQueryQueryPage
 2010-12-22 20:52:06 +00:00
Roan Kattouw
17487e40ba Replace my old e-mail address with my new one in API comments. A bit outdated (dropped the old one in September '08) 2010-12-22 20:48:10 +00:00
Sam Reed
15b65258d1 Spaces to tab, add a couple of braces 2010-11-23 23:58:57 +00:00
Sam Reed
38f9c25b27 Explicit variable definition, tweak documentation 2010-11-23 21:43:56 +00:00
Sam Reed
4aaecdcd9d * (bug 26089) add block expiration to blockinfo 2010-11-23 21:37:27 +00:00
Sam Reed
68e1a821f4 Capitalise first letters 2010-11-04 13:07:57 +00:00
Sam Reed
550271e806 Explicit class variable definition 
Parameter hints
 2010-10-06 21:18:55 +00:00
Sam Reed
f07567201f Remove some unused variables 
Tweak php doc, "One" is not a type, so insert string in there
 2010-09-25 16:37:39 +00:00
Alexandre Emsenhuber
457eb73b61 Standardised file description headers, added @file 2010-08-07 19:59:42 +00:00
Sam Reed
5387b8a806 Stylize API up to date 
Fix spaces from r69755

Minor update to RELEASE-NOTES per r69753
 2010-07-23 07:33:40 +00:00
Tim Starling
b2dc451c82 Rewrote r69339 etc. to clean up API cache header handling. 
* Introduced a "cache mode" concept to simplify the header generation code, and to avoid odd results when conflicting cache header requests are received from submodules, or at least to formalise the handling of such cases.
* Made the cache mode private by default, so that code written in ignorance of caching tends to be safe. If different query modules are used in a single request, private caching is preferred over public caching.
* Removed the "must-revalidate" option from all CC headers, this is really specific to page views with a hacked squid in front, I don't think it's applicable here.
* Made the watchlist module private. This is really the definition of private data. There's nothing in the HTTP spec that says the URL for a CC:public request is private and can't be leaked. CC:private provides protection against unknown proxy behaviour.
* In ApiQueryAllmessages: avoid calling $wgLang->getCode() to check if it's necessary to make a new $wgLang when lang= is specified, since this is the only thing that unstubs $wgUser.
* Removed "FIXME: should this check $user instead of $wgUser?" Answer is no.
 2010-07-23 07:17:56 +00:00
Sam Reed
8f1d2cb199 Big blitz on unused variables (a lot of $db = $this->getDb() ) 2010-07-22 22:13:21 +00:00
Roan Kattouw
70824ccccc API: Make output containing private or user-specific data uncacheable for logged-in users by setting Vary: Cookie or Cache-Control: private, whichever is appropriate. Fixes instances in core and WMF-deployed extensions only. Without this change, the output of requests like ?action=query&list=recentchanges&rcprop=patrolled&smaxage=3600 would be cached in Squid and viewable for anyone using the same URL, even if they don't have patrol rights. Other, more serious exploits are also possible. Also avoid using $wgUser in one place, kill some unused global $wgUser; instances and tweak a comment. 2010-07-14 19:00:54 +00:00
Sam Reed
0e2576a250 Fix typo (and change wrong variable) 2010-06-22 06:05:20 +00:00
Derk-Jan Hartman
921619b119 Correct the address of the FSF in some of the GPL headers 
59 Temple Place -> 51 Franklin Street
 2010-06-21 13:13:32 +00:00
Sam Reed
faf34b4073 Per http://www.mediawiki.org/wiki/Special:Code/MediaWiki/66168#c7252 switch while ( $row = $db->fectchObject( $res ) ) to foreach ( $res as row ) 
On ApiQueryUsers switch $r to row, and remove nested brackets
 2010-06-20 18:48:34 +00:00
Sam Reed
232cabd9f8 Followup r68157 and r68161 per Bryans comment (anons aren't in the group user) 2010-06-20 17:30:23 +00:00
Roan Kattouw
a1db76daaf Followup to r68157: simplify ApiQueryUsers::getAutoGroups() 2010-06-17 09:39:07 +00:00
Sam Reed
a5054efc97 Rem whitespace, function comment for r68158 2010-06-17 08:15:56 +00:00
Sam Reed
18227749a6 Minor followup to r68156, add "user" as implicit group 
Refactor out and reuse in ApiQueryUserInfo

Add couple more braces to SpecialUserrights
 2010-06-17 08:00:42 +00:00
Sam Reed
a19c0eb2a3 * (bug 24009) Include implicit groups in action=query&list=users&usprop=groups 
Add some whitespace, fix some braces in ApiQueryUsers

Add a few braces to SpecialUserrights.php, change or to || and and to &&
 2010-06-17 07:39:31 +00:00
Jack Phoenix
7ced9bc569 API: fix copyright symbol, coding style cleanup, more braces 2010-02-26 13:18:56 +00:00