Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
42987 commits 1 branch 0 tags 744 MiB
Commit graph

85 commits

Author SHA1 Message Date
Alexandre Emsenhuber
78a56a67ba Added missing GPLv2 headers in includes/db. 
Change-Id: Ib8fe301c6db77603e411113cea5a39c25c664961
 2012-04-26 10:47:10 +02:00
Max Semenik
a8f718267e Follow-up r112565: fix code duplication 2012-02-28 14:42:08 +00:00
Chad Horohoe
2177a4d8b4 (bug 34762) Calling close() on a DatabaseBase object now clears the connection. Based on patch by Christian. 
By the way, the duplication here is stupid.
 2012-02-28 02:18:18 +00:00
Sam Reed
76246b9bf5 More return documentation 2012-02-09 21:33:27 +00:00
Sam Reed
6f3c9ff025 Fix syntax error I introduced from r102683 2011-11-10 20:49:11 +00:00
Sam Reed
9814e6b075 Add $fname to tableExists 
Pass $fname/__METHOD__ in in upstream callers
 2011-11-10 20:39:23 +00:00
Tim Starling
0e73205470 General database-related code cleanup: 
* Merged the 4 simulated implementations of Database*::replace(). I took diffs, they were nearly identical. I made one based on the IBM DB2 version, since it used insert() which looked like a nice touch.
* Provided the non-simulated implementation of Database*::replace() via a protected member function, and made DatabaseMysql::replace() and DatabaseSqlite::replace() into a wrapper for it. 
* Moved the MySQL-specific functionality from masterPosWait(), getSlavePos() and getMasterPos() from DatabaseBase to DatabaseMysql. 
* Renamed getStatus() to getMysqlStatus() and moved it to DatabaseMysql. Removed "unimplemented" errors from two other subclasses. Really there's no way another DBMS could or should implement this function. 
* Split the LoadMonitor class into a no-op class and a MySQL-specific class, to avoid fatal errors due to the getMysqlStatus() call if other DBMSs tried to use LoadBalancer with multiple servers. Of course there are lots of other reasons it won't work, I'm just fixing the architecture issue here.

And while I have a replicated test setup handy:
* On MySQL 4.1.9 and later, use SHOW SLAVE STATUS to get the lag instead of SHOW PROCESSLIST. This has the advantage of reading zero when there are no events for a while.
 2011-06-23 03:14:11 +00:00
Tim Starling
5fcd668a02 Followup r90429: 
* Reverted the public -> protected changes from r90429, except for doQuery() after a review of usage:
** resultObject() is used by lots of things in core and extensions. 
** makeSelectOptions() is used by SMW, and if that's going to be public, the other two probably should be too, for consistency. 
** doQuery() was used by several things, but mostly by mistake. It's been marked private since r21359 which is before almost all of them. I updated the callers to use query().

* Added "protected" to doQuery() declarations in other database classes.
 2011-06-20 12:09:22 +00:00
Platonides
8093e9733c All the databases but MySQL were overriding DatabaseBase::deleteJoin() with the same code. 
Move DatabaseBase::deleteJoin() to DatabaseMysql::deleteJoin() and the common code to DatabaseBase::deleteJoin()
Follow up r90356
 2011-06-18 20:26:31 +00:00
Sam Reed
bdf84cb20e Swap else if for elseif 
Trimming trailing whitespace also

Doing in 3 commits, so hopefully reviewable in CR...
 2011-06-17 16:03:52 +00:00
Chad Horohoe
f82a605eba More silly ternary true : false fixes 2011-05-09 20:49:19 +00:00
Platonides
bdbe39d28c Follow up r85888: Add the parameter to DatabasePostgres.php and DatabaseOracle.php 
Follow up r85884: The parent tableName() should work now for DatabaseMssql.php
 2011-04-12 18:59:19 +00:00
Platonides
a91d6f4cac Abstract tableName() by adding new function isQuotedIdentifier() to databases. 
This fixes bug in DatabaseOracle.php tableName() on line 671 and allows it to call 
the parent implementation instead of copying it with different quotes.
Adapt Mssql addIdentifierQuotes(). Replace its addIdentifierQuotes calls with addQuotes
as it's what it really is. The serialize() is probably unneeded, since I don't think it will
ever be called with objects but I kept it anyway.
 2011-04-12 16:34:12 +00:00
Sam Reed
b3d0f35aee Remove unreachable return 
Swap "dieout" for "die" in DatabaseMssql
 2011-02-27 00:29:21 +00:00
Sam Reed
b30dd0d98c Fixup assignment in loop 
comment out undefined variable used in function call
 2011-02-18 22:59:01 +00:00
Sam Reed
b35adc8934 Fixup whitespace, brackets etc 
Remove usage of @
 2011-02-18 22:49:56 +00:00
Chad Horohoe
a5053d4c5a * Cleanup massive duplication across Database constructors. Default implementation fairly sane. Now they all share the same if( $server ) logic to allow constructing the class without forcing open a connection (MySQL has done this since at least r15094) 
* Get rid of intermediate installTables() callback
* Actually cache the result of DbInstaller::getConnection() like the documentation says
 2011-01-24 18:36:09 +00:00
Chad Horohoe
4ece90ed4b Remove ancient and deprecated newFromParams() constructor wrappers from various DatabaseBase implementations. Only callers are AskSql and WikiTrust. Both are calling the (very old) Database class anyway, so are obviously expecting a MySQL connection and can use the fallback (which yells wfDeprecated) in DatabaseBase 2011-01-07 20:25:52 +00:00
Chad Horohoe
b61756cdea Followup r73348, r70608: move 'infinity' stuff to DB classes 2011-01-05 13:43:13 +00:00
Roan Kattouw
475c331f60 Remove now-unused SQL timestamp conversion functions added in r77231. They were made obsolete by the querypage-work2 branch merge in r78786 2010-12-31 16:29:44 +00:00
Daniel Friesen
aae05c49f8 MySQL is the only database which quotes identifiers primarily using backticks. Move the backtick based addIdentifierQuotes implementation from the generic into DatabaseMysql and take the duplicated implementation used by oracle, sqlite, ibm_db2, postgresql, and mssql and remove it from all of them migrating it to the generic Database class as the default. 2010-12-04 15:35:36 +00:00
Daniel Friesen
692ad26f68 Followup to r77713, rename quote_ident to addIdentifierQuotes to follow naming conventions better. While I'm at it adding a missing addIdentifierQuotes implementation for Ibm_db2. 2010-12-04 15:14:08 +00:00
Sam Reed
76555b68ad qualify call to array_to_obj 
Followup r70608
 2010-11-30 18:52:49 +00:00
Sam Reed
cadc951d15 More reversion of r77297, 1 of 2 commits to keep it readable in CR (hopefully) 2010-11-25 22:24:11 +00:00
Antoine Musso
6fe29c9c30 revert r76464 
* mixed style changes and variable removing
* logic changes
* useful comments removed
 2010-11-25 20:01:34 +00:00
Alexandre Emsenhuber
6cb276056b Moved switches in Special:Unusedimages and Special:Ancientpages to extract a unix timestamp from a fielf to DatabaseBase and related classes to avoid code duplication 2010-11-24 15:40:25 +00:00
Antoine Musso
af7558aa94 dieout() now default to empty text. follow up r76165 2010-11-23 20:39:04 +00:00
Max Semenik
4345c2c20e Refactoring of *Field classes: 
* Made them all implement one common interface (might add more functions to it later)
* Moved MySQLField to DatabaseMysql.php
* Renamed nullable() to isNullable()
* Removed maxLength() from:
** SQLiteField: makes no sense
** MySQLField: doesn't do what people may think, useless for this class' purpose of assisting querying the DB schema
 2010-11-21 19:56:51 +00:00
Sam Reed
10ecfeb03b Various unused variables, add some braces 
Explicitally define some variables used in hook type calls
 2010-11-10 19:49:04 +00:00
Platonides
4147b8a5bb dieout() function already takes into account if a </ul> is needed. 2010-11-05 23:36:30 +00:00
Sam Reed
39c005ca79 bug 25517 Assignment in conditions should be avoided/ http://www.mediawiki.org/wiki/Manual:Coding_conventions#Assignment_expressions 2010-11-01 00:07:17 +00:00
Sam Reed
604ae0ca1c Update deprecated method calls 
Remove some unused stuff
 2010-10-31 16:20:48 +00:00
Sam Reed
d189aaee05 (bug 24853) Kill failFunction - Fixed! :D 2010-10-24 21:27:33 +00:00
Sam Reed
16cded8b32 Start of bug 24853, killing off 'functional' parts of failfunction code. Seems when the constructors start getting changed, it starts borking. Using this as a point of reversion/stashing 2010-10-24 20:48:48 +00:00
Sam Reed
6b3b915353 Big attack on unused variables... 2010-10-14 20:53:04 +00:00
Sam Reed
a2589ff8c6 Assignment in loop conditions suck 
while ( $row = $dbw->fetchObject( $res ) ) { to foreach ( $res as $row ) in includes

Add some braces
 2010-10-13 23:11:40 +00:00
Platonides
c780168f9f Follow up r74135 removing the globals, too. 
htmlescape the global.
 2010-10-10 14:39:16 +00:00
Max Semenik
64acd61377 Fix botched up comments 2010-10-02 18:45:18 +00:00
Alexandre Emsenhuber
7ce38e5006 removed some unused variables 2010-10-02 08:31:55 +00:00
Alexandre Emsenhuber
1da312a72e Fix for r74134: copy-paste error 2010-10-02 08:30:03 +00:00
Alexandre Emsenhuber
1360aadafd removed call to deprecated function dbsource() and a comment that mentioned it 2010-10-02 08:29:01 +00:00
Alexandre Emsenhuber
3c386b90cb __FUNCTION__ -> __METHOD__ 2010-10-02 08:04:58 +00:00
Jack Phoenix
1252d00372 trim trailing spaces 2010-09-05 18:00:33 +00:00
Aryeh Gregor
338ae40072 Suggest running update.php on database error 
This is a pretty frequently asked question in #mediawiki -- most
database errors are probably due to not running update.php.
 2010-09-05 17:40:47 +00:00
Sam Reed
e04cd31791 Change usages of Database:: for function names in DatabaseMssql to DatabaseMssql:: 2010-08-25 15:58:58 +00:00
Sam Reed
bb6b4ba0cb Whitespace, I hate you. 2010-08-24 22:44:44 +00:00
Sam Reed
8a01281913 Remove some unreachable code (usually returns after throwing exceptions) 
Fixup call of method after return in DatabaseMssql by using a temp
 2010-08-24 22:03:18 +00:00
Chad Horohoe
e0cb9ef9b6 Make getSoftwareLink() static so I can use it without instantiating (and opening) a bunch of databases I probably can't support. Can't have an abstract parent now, so throw an exception for anyone who writes a child class without bothering to implement it. All of this to add some helpful text links in an infobox in the installer :) 2010-08-22 20:55:07 +00:00
Alexandre Emsenhuber
c72516a428 Fixed some doxygen warnings 2010-08-22 15:58:59 +00:00
Platonides
5d98e13b78 Try to address some of the issues of r70608. 
@yaauie: Set the error_level in your php.ini, do not use calls to error_reporting() for that.
 2010-08-21 14:33:32 +00:00