Commit graph

96 commits

Author SHA1 Message Date
Alexandre Emsenhuber
09bb6975c5 Added missing GPLv2 headers in some places.
Also made file/class documentation more consistent.

Change-Id: I1615bf268515ed7169e33173cea6ec30402451dc
2012-05-06 07:50:15 +02:00
Robin Pepermans
9184dc83d6 Update core usage of getLanguageName[s]. 2012-03-08 20:56:26 +00:00
Sam Reed
2ec09c5165 More return documentation 2012-02-09 21:35:05 +00:00
Max Semenik
561bf3146a Made WebInstaller::showStatusMessage() look uniformly for one and multiple errors/warnings per status 2012-01-04 10:08:59 +00:00
Chad Horohoe
590b7a0f54 Separate Cli/Web logic for envCheckServer() per CR on r104576 2011-12-12 15:11:08 +00:00
John Du Hart
39fb989713 Followup r103814, fixed a few typos and a stray newline 2011-11-23 00:03:42 +00:00
Sam Reed
f5278ec11f Few bits of documentation 2011-11-22 16:31:33 +00:00
John Du Hart
2ee37f2267 Bug 28296 - Installer should honor &uselang= parameter 2011-11-21 15:30:20 +00:00
Sam Reed
701491d4c4 Followup r100126, per brion remove htmlspecialchars() call
Swap back a code line to use $text

Swap some space indents to tabs
2011-11-05 14:22:58 +00:00
Sam Reed
856faea6d6 Add documentation
Fix some unused variables, commented some others out
2011-10-18 17:26:09 +00:00
Mark A. Hershberger
6cf18f9324 * Make envCheckPath() specific to each installer, web vs cli
* Add warning during the CLI install that the uploads directory isn't
  being checked for arbitrary script execution
2011-08-03 15:46:06 +00:00
Mark A. Hershberger
80522a129a Fixes Bug #30061 - Command line installer $wgScriptPath
Patch from Edward Z. Yang
2011-08-01 18:03:06 +00:00
Chad Horohoe
852334b736 (bug 29492) Long-running steps in the installer (such as Upgrade and Install) can sometimes timeout 2011-06-21 01:13:45 +00:00
Chad Horohoe
89529808d8 Make user right selection in installer actually work, thanks Krinkle for spotting this 2011-06-02 01:26:26 +00:00
Jure Kajzer
62a12d2454 * moved infobox to Html (r88109#c16937) 2011-06-01 13:57:50 +00:00
Sam Reed
0d47a2ae90 More parameter documentation!! 2011-05-28 14:52:55 +00:00
Mark A. Hershberger
44f9460caf w/s cleanup 2011-05-20 18:20:16 +00:00
Jure Kajzer
a069d8bde0 discussion with hashar
* moved getInfoBox into Xml.php as infoBox static method
* moved config-infobox* css classes from config to mw-infobox* in shared
* left getInfoBox as a wrapper in the installer
2011-05-14 16:54:22 +00:00
Sam Reed
f675c6bf05 Documentation 2011-05-02 16:58:29 +00:00
Tim Starling
7bb50c630a The beginnings of HipHop compiled mode support. It works now for parser cache hits.
* Work around HipHop issue 314 (volatile broken) and issue 308 (no compilation detection) by adding some large and ugly compilation detection code to WebStart.php and doMaintenance.php.
* Provide an MW_COMPILED constant which can be used to detect compiled mode throughout the codebase.
* Introduced wfIsHipHop(), which detects either compiled or interpreted mode. Used this to work around unusual eval() return value in eval.php.
* Work around lack of ini_get() in Maintenance.php, by duplicating wfIsHipHop(). 
* In Maintenance::shouldExecute(), accept "include" as an inclusion function name, since all kinds of inclusion give this string in HipHop.
* Introduced new class MWInit, which provides some static functions in the pre-autoloader environment.
* Introduced MWInit::compiledPath(), which provides a relative path for invoking a compiled file, and MWInit::interpretedPath(), which provides an absolute path for interpreting a PHP file. Used these new functions in the appropriate places.
* When we are running compiled code, don't include files which would generate duplicate class, function or constant definitions. Documented the new requirements on the contents of Defines.php and UtfNormalDefines.php.
* In HipHop compiled mode, it's not possible to have executable code in the same file as a class definition. 
  ** Moved MimeMagic initialisation to the constructor.
  ** Moved Namespace.php global variable initialisation to Setup.php.
  ** Moved MemcachedSessions.php initialisation to the caller in GlobalFunctions.php.
  ** Moved Sanitizer.php constants and global variables to static class members. Introduced an accessor function for the attribs regex, as a new place to put code formerly at file level. 
  ** Moved Language.php initialisation of $wgLanguageNames to Language::getLanguageNames(). Removed the global variable, marked "private" since forever.

* In two places: don't use error_log() with type=3 to append to a file, HipHop doesn't support it. Use file_put_contents() with FILE_APPEND instead.
* Work around the terrible breakage of class_exists() by using MWInit::classExists() instead in various places. In WebInstaller::getPageByName(), the class_exists() was marked with a fixme comment already, so I replaced it with an autoloader solution.
2011-04-04 12:59:55 +00:00
Brion Vibber
d3005cfbd5 * (bug 27170) [Installer] Install now completes when choosing a CC license with the picker
There were two things breaking this:
* X-Frame-Options forbade our final step of the license selector, or the license selection shower, from being loaded properly. This lead to it looking wrong.
* The installation URL fingerprinting broke on the long query string that's on the final step. As a result, the user's selection got saved into a different session subkey, thinking it belonged to a different installation. It would then not get seen by the surrounding page's installer instance, causing the confusion.

Fix removes the X-Frame-Options for the CC bit, and drops query strings before the rest of URL normalization in the fingerprint check so the CC bits now see the same session key as the rest.
2011-03-27 20:13:30 +00:00
Max Semenik
b9c560f343 Fixed <doclink> broken by r83023 2011-03-20 17:54:43 +00:00
Max Semenik
1fdaf8db17 (bug 1379) Installer directory conflicts with some hosts' configuration panel.
Renamed config/ to mw-config/, however left aliases for b/c.
2011-02-26 12:35:23 +00:00
Chad Horohoe
f7f43c1332 (bug 25855) Installer does not validate Memcached server settings 2011-02-23 17:54:45 +00:00
Chad Horohoe
1db4e51ea8 Move doclink pages to the left sidebar, rather than the right.
The right should be steps :)
2011-02-23 17:22:09 +00:00
Chad Horohoe
aafed9f146 Minor cleanup, docs 2011-01-28 15:00:18 +00:00
Chad Horohoe
44dd1794a1 Partially revert r69738 (splitting Installer/CoreInstaller). As discussed on CR, this probably wasn't the best route to go with this code.
We can figure that out sometime in 1.18
2011-01-21 15:27:16 +00:00
Krinkle
bb03eae13d Follow-up r77121
* Clearing float after sidebar to prevent it from sticking out on short pages
* Changing line-breaking clear-float to a non-line breaking one
2010-12-24 01:41:15 +00:00
Mark A. Hershberger
aa08646a71 Misc whitespace changes, mostly EOL w/s and indention fixes so TAB = 4 spaces 2010-12-19 04:31:15 +00:00
Sam Reed
984c692ec4 Removing trailing whitespace 2010-12-16 11:20:39 +00:00
Chad Horohoe
92f8c162be Remove bogus session_path checks. Reverts r67465, r63813, r75256, r64717. 2010-12-12 17:25:56 +00:00
Tim Starling
31eae6a575 * Made the web upgrade process more friendly. Instead of saying "access denied, go away" when the user has a normal LocalSettings.php file, generate a random $wgUpgradeKey and instruct the user to insert it into their LocalSettings.php. The subsequent file modification then authenticates the session and allows the upgrade.
* When an upgrade key is entered, or a supplied upgrade key is edited into LocalSettings.php by the upgrader, fetch database settings from LocalSettings.php and AdminSettings.php for use during the upgrade. This allows the DBConnect page to be skipped, making web upgrade almost as easy to use as CLI upgrade.
* Made LocalSettingsGenerator add $wgUpgradeKey in non-commented form, for easier subsequent upgrades.
* Converted the $wgUpgradeKey check to a normal in-sequence page, called ExistingWiki. This allows the removal of related special cases from WebInstaller. The code for WebInstaller_ExistingWiki is loosely based on WebInstaller_Locked.
* Added Status::replaceMessage(), to support informative DB connection error messages from the ExistingWiki page.
* In WebInstaller::getInfoBox(), call parse() with $lineStart=true, so that line-start syntax like bullet points can work.
* Reduced the length of the generated $wgUpgradeKey from 64 to 16. This is ample for what it does, and makes it fit on the screen and not overlap with the right sidebar when when displayed by WebInstaller_ExistingWiki.
* Added $wgUpgradeKey to DefaultSettings.php.
2010-12-09 08:24:54 +00:00
Tim Starling
5c608ed979 Modify config-install-done, hopefully this is what Chad was looking for in CR r77948. Added a large, obvious download link with icon from the Crystal Project. 2010-12-07 03:15:51 +00:00
Tim Starling
1b24fc4070 * Pop up a download box for LocalSettings.php when the user goes to page=Complete. Committing for review: I'm not wedded to the concept, but we do need some way of making sure users download that file.
* Fix MIME type on LocalSettings.php download to not be something that IE considers ambiguous. In Firefox, this makes it say "which is a: PHP file" instead of "plain text document" in the download dialog box.
2010-12-07 02:01:07 +00:00
Tim Starling
eede2807ed Fix incorrect use of wfMsgReal() from r77929, causes several warnings. 2010-12-07 00:50:36 +00:00
Brandon Harris
44a91da53a * Fix issues brought up in r75832
* Really and truly add in a couple files that were supposed to go in with r77898, and fully revert r77860 (which was a reversion of r75832). (Ran previous commit for r77898 from wrong directory. Oops.)
* Fixed issue with help box text not being parsed.
* Modified help system to remove tooltips and instead open/show hidden boxes.
  - I am not happy with this design and future revisions will iterate upon it.
  - The biggest problem is everything sitting "on top" of itself.  I dislike this a great deal and plan on changing it to be more aesthetic and natural; however, I wanted to get a version of this in that allowed for cut-and-pasting and solved the text parsing issue.
  - With javascript disabled, help text is visible by default.
* Remove redundancy in checkboxes
* Added i18n entry for "help", which wasn't there for some reason.
* Removed references to tipsy library in installer html
  - Kept tipsy library in core; this is being used elsewhere.
2010-12-06 23:13:35 +00:00
Brandon Harris
4f8f4bf675 Revert r77860, which was a reversion of r75832.
Didn't see comments about escaping html and use of tipsy; will be addressed in next commit.
2010-12-06 20:04:28 +00:00
Tim Starling
bc46722902 * Made it possible to run multiple installer instances in the same cookie domain without them overwriting or misinterpreting each others' sessions. This is mostly paranoia: one could imagine a situation where the installer from one version of MW becomes insecure when run on the session from another. Did this by making installerData an array indexed by a hash of path and $wgVersion. I could have used $wgCookiePrefix, but that would have broken NoLocalSettings.php, which has no access to AutoLoader and so can't access Installer methods.
* Moved most of the functionality of config/index.php from the file level to a function, so that we can have local variables.
2010-12-06 13:20:01 +00:00
Tim Starling
41b92f3343 Reverted r75832 per my comments on CR, unanswered for 19 days. Moving all help information into tooltips is a step backwards for usability. Reverted followups r75836, r75866, r76314 and r76315. 2010-12-06 07:08:31 +00:00
Krinkle
54d15eb51f * Swapping enableForOther locked input-field from disabled to readonly. No need to block users from selecting the text inside, only block editing it field.
* On top of that, also using javascript to hide the input-field if/when not needed, untill needed (PHP has a backup check to only use this value if the radio-button was on 'other') 
* Escaping special html characters in the attributes. The message for .mw-help-field-hint contained the phrase "  content pages, in a "'''project namespace'''".  " which (raw, unescaped) ends the attribute right after the "a". Fixed now.
2010-11-23 00:40:45 +00:00
Krinkle
836dbd7bfd whitespace commit (removing trailing space) 2010-11-22 23:55:37 +00:00
Krinkle
fcf8776068 Putting .config-page-list (sidebar nav) floating to the right as part of the page (instead of floating outside the page content). This takes away the dead white space on longer pages by making it grey instead of white (previously this made the page look very unorganized and off-grid in more narrow windows). This also fixes a layout bug in Safari where the tops didn't line up. 2010-11-22 23:52:59 +00:00
Chad Horohoe
9f867044f2 (bug 25856) fix exaggerated indentation of checkbox text 2010-11-10 15:37:55 +00:00
Max Semenik
0c09c4e1f7 Allow downloading LocalSettings after upgrades 2010-11-08 19:54:53 +00:00
Chad Horohoe
ba49b0e68a Dynamically generate CSS (using vector now). Handles RTL/LTR flip properly \o/ UI's busted though ;-) 2010-11-05 13:14:24 +00:00
Chad Horohoe
2c965c5dc4 Followup r76055, missed a few more 2010-11-04 23:23:34 +00:00
Brandon Harris
d00ddeef7f * Added tipsy library
* Added associated files for tooltip display
* Added associated css rules for tooltip display
* Updated installer's help system in (most?) places to display help as tooltips instead of show/hide system
* Beginnings of visual changes (e.g., less boxes, more color)
* Modified several of the installer's widget display methods
* Added a couple new i18n values
* Fixed small bug in installer logic:
  - Password validation on new users was being executed even if there wasn't a $user object
2010-11-01 21:17:15 +00:00
Chad Horohoe
95df9a1b08 Reduce more WebInstaller bloat, move getFieldset(Start|End) to WebInstallerPage where its used 2010-10-26 12:05:57 +00:00
Chad Horohoe
e9db0e2f1d Clarify some visibilities based on actual usage 2010-10-26 12:02:23 +00:00
Chad Horohoe
3c7bb8edd8 rm unused code 2010-10-26 11:55:47 +00:00