Commit graph

23 commits

Author SHA1 Message Date
Aaron Schulz
e369f66d00 Replace wfRunHooks calls with direct Hooks::run calls
* This avoids the overhead of an extra function call

Change-Id: I8ee996f237fd111873ab51965bded3d91e61e4dd
2014-12-10 12:26:59 -08:00
jenkins-bot
00f9ce1105 Merge "Bound the cache size of numberofWatchingusers()" 2014-09-04 20:03:11 +00:00
Aaron Schulz
220d30f8f4 Bound the cache size of numberofWatchingusers()
Change-Id: I60c9898318e340ee3c97d24b528d85a5f8c492e5
2014-09-04 12:49:43 -07:00
umherirrender
26e71dd640 Use getConfig for ChangesList
Change-Id: I1f440a2fca2dd8f1973987d635c70954938b6ea6
2014-08-22 22:01:08 +02:00
Tom Arrow
510da8d776 Remove unreachable return in ChangesList.php
Change-Id: Ic00d7b4eaebdaa795b550c4213c518b1c56bd297
2014-08-09 12:25:33 +00:00
JuneHyeon Bae
17ebbe492c Remove obsolete RC_MOVE and RC_MOVE_OVER_REDIRECT rc types
RC_MOVE and RC_MOVE_OVER_REDIRECT are obsolete, since at least 2006.
So it is considered safe to remove.

Bug: 63755
Change-Id: I0f17c4d164585a48fb9f0d40b90a7d3b975c7ab8
2014-06-11 02:44:48 +00:00
withoutaname
866f478dc9 Append redirect=no to RecentChanges/Watchlist redirect entries
This change adds redirect=no in the URL of redirect entries in the RecentChanges or in the Watchlist.
Entries which are not redirects will not be affected.
Some typos in documentation were also fixed.

Bug: 890
Change-Id: I79593811d92b2f57abd742c8ba9e66769d8bc9b7
2014-04-28 18:11:13 -07:00
umherirrender
9c614ac02d Fixed some @params documentation
Swapped some "$var type" to "type $var" or added missing types
before the $var. Changed some other types to match the more common
spelling. Makes beginning of some text in captial.

Change-Id: I8c9f30128b46086064326708a4878228ba459447
2014-04-14 19:52:18 +00:00
Erik Bernhardson
36a664643b New Hook rc/watchlist hook ChangesListInitRows
An extension hooking into recent changes may need to load additional
data that did not fit into the recentchanges table.  This hook gives
extensions an opportunity to see the full result prior to rendering
and batch load where approprite rather than loading piecemeal during
the render process.

This is implemented as an optional method called by the ChangesList
consumer, since the ChangesList never sees the full result set. Hook
implementers must be able to work regardless of the hook being called,
they just have the oportunity to be more efficient when it is called.

Change-Id: If74ae600ffba949364dd381dd3d466cbbaa27286
2014-04-01 09:38:16 -07:00
Siebrand
34c239655e Revert "New Hook rc/watchlist hook ChangesListBegin"
This reverts commit 01798c3813.

The patch set changed a RecentChanges interface used in at least the
extension CleanChanges so that it was generating a lot of warnings.
Additional parameters to existing methods that are used elsewhere
should have defaults to not break backward compatibility.

Change-Id: I1851e23e186ba7aaeb001ba212e56888657a3ae0
2014-03-26 14:08:40 +00:00
Erik Bernhardson
01798c3813 New Hook rc/watchlist hook ChangesListBegin
An extension hooking into recent changes may need to load additional
data that did not fit into the recentchanges table.  This hook gives
revisions an opportunity to see the full result prior to rendering
and batch load where approprite rather than loading piecemeal during
the render process.

Change-Id: I28d4e41437e485e518f2a23b6da00cdc430a8c23
2014-03-24 18:33:15 -07:00
Erik Bernhardson
1b8db29ed5 Method to identify if a ChangesList is watchlist or normal
There are differences, like grouping, between watchlist and
normal rendering that hook recipients need to know about.
This exposes if the setWatchlistDivs method has been called
which currently happens immediatly after instantiation in
SpecialWatchlist

Change-Id: Ibc06c6d9b878cad3f5da92cfbe3f650ad3f63efa
2014-03-13 10:35:56 -07:00
Siebrand Mazeland
f077c4b1d6 Update formatting
Change-Id: I18aff576262479c9bb1c56eb8e1d1aaae200e4b1
2014-02-06 09:27:05 +01:00
Bartosz Dziewoński
2ec4ed4711 Changes list legend modules cleanup
The legend is not part of the ChangesList itself, but a part of the
ChangesListSpecialPage; move around modules and calls appropriately.

Followup to I02f2ced4.

Change-Id: I2c8922135404aab1960158cee06e2d8d07a1ace7
2014-01-16 19:26:43 +01:00
Bartosz Dziewoński
a9e0c52c06 Make legend on Special:RecentChanges and Special:Watchlist collapsible
Some of the code added here is duplicated, redundant or would be
better off placed somewhere else. I know about this, but this is not
the time to fix that (and nobody would review such patches anyway…).

Bug: 52005
Change-Id: I02f2ced42f33649b6c972d35a4739372ca265e10
2013-12-18 17:40:03 +01:00
Bartosz Dziewoński
48cc8109c8 Wrap changes lists in <div class="mw-changeslist" />
This affects Watchlist, RecentChanges and RecentChangesLinked.

A <div class="mw-changeslist-empty" /> is already used on all of these
when the list isn't generated (somewhat inconsistently coded, though).

Bug: 8844
Change-Id: I1ab2a54e22f318713c2211d63b29c184751a3589
2013-11-26 23:13:51 +01:00
Siebrand Mazeland
8a0eb6de15 Various fixes for ChangesList
* Define dynamic class properties
* Update documentation and doc formatting
* Ensure variables are defined

Change-Id: I309affea9a8e8cfa24bd8fe694a16bf79d6f2419
2013-11-19 12:44:15 +00:00
Siebrand Mazeland
0470a55b77 Update formatting
Change-Id: I7586c4d50f7332c515b8377749c4250cc9e04d83
2013-11-19 06:32:18 +00:00
Siebrand Mazeland
511d594bf6 Address CodeSniffer errors and warnings
Change-Id: Ie119db7d6d9e9eb3c1cd9c07b8f84fd155847c62
2013-11-19 06:28:51 +01:00
jenkins-bot
c62949f697 Merge "Remove deprecated ChangesList::newFromUser function" 2013-11-07 21:14:00 +00:00
aude
4ba5a09d05 Remove deprecated ChangesList::newFromUser function
newFromUser() is unused in core and all extensions in gerrit,
except BlueSpiceExtensions RSSStandards. (there is a
patch for that I1455052)

Change-Id: I4559146cc0e9973e6e4f6297138cbfd8e387e8b7
2013-11-07 02:14:28 +01:00
Timo Tijhof
5f078d3e56 Add rc.unpatrolled to the recentchanges API
On SpecialRecentChanges, the unpatrolled "bang" icon is only
rendered when:
- the user has the patrol right.
- the rc type is EDIT and rcpatrol is permitted, or
  the tc type is NEW and nppatrol is permitted.
- the rc event is in fact still unpatrolled.

In other words, when an edit is patrollable and unpatrolled.

However, consumers of the API are unable to render this because
the API only has a boolean "patrolled" attribute. Apps using
the absence of "patrolled" and presence of "patrol" right as
meaning "unpatrolled" get into trouble on wikis with RCpatrol
disabled and NPpatrol enabled. In those cases the app would
render a change as unpatrolled, but when the user clicks it
find out it can't be patrolled.

This adds an "unpatrolled" flag that does just that.

Change-Id: Ic947c6c75eb7936fcebdccbcd27ff62e07f1feda
2013-10-25 17:26:43 +02:00
aude
761b880e98 Split changes list classes into separate files
Having them separate improves readability of the code
and makes it easier to work with this code.

Change-Id: Ic6aaf1ace3640f66ad41c2d85b4f7d740b259e0c
2013-10-19 14:26:27 +00:00