Commit graph

12 commits

Author SHA1 Message Date
umherirrender
b0cfcd0fcb Add missing @return and @param to doc blocks
Change-Id: I9d99ba1968ed8f97624d957754c8847dfe1b41da
2014-08-27 21:57:45 +02:00
Kunal Mehta
523ba0cf8b ResourcesTest: Add variable type annotations
Change-Id: I07ec986830dcec739b0553395b9a220b44bba77d
2014-08-22 00:32:09 +02:00
Bartosz Dziewoński
3971d0646c resourceloader: Allow skins to provide additional styles for any module
The newly introduced $wgResourceModuleSkinStyles global enables skins to
provide additional stylesheets to existing ResourceLoader module.

This both makes it easier (or at all possible) to override default
styles and lowers the style footprint by making it possible not to
load styles unused on most pages.

----

Example:

Use the file 'foo-styles.css' for the 'mediawiki.foo' module when using
the MySkin skin:

  $wgResourceModuleSkinStyles['myskin'] = array(
    'mediawiki.foo' => 'foo-styles.css',
    'remoteSkinPath' => 'MySkin',
    'localBasePath' => __DIR__,
  );

For detailed documentation, see the doc comment in DefaultSettings.php.
For a practical usage example, see Vector.php.

----

Implementation notes:

* The values defined in $wgResourceModuleSkinStyles are embedded into
  the modules as late as possible (in ResourceLoader::register()).
* Only plain file modules are supported, setting module skin styles
  for other module types has no effect.
* ResourceLoader and ResourceLoaderFileModule now support loading
  files from arbitrary paths to make this possible, defined using
  ResourceLoaderFilePath objects.
  * This required some adjustments in seemingly unrelated places for
    code which didn't handle the paths fully correctly before.
* ResourceLoader and ResourceLoaderFileModule are now a bit more
  tightly coupled than before :(
* Included a tiny example change for the Vector skin, a lot more of
  similar cleanup is possible and planned for the future.
* Many of the non-essential mediawiki.* modules defined in
  Resources.php should be using `'skinStyles' => array( 'default' => … )`
  instead of `'styles' => …` to allow more customizations, this is
  also planned for the future after auditing which ones would actually
  benefit from this.

Change-Id: Ica4ff9696b490e35f60288d7ce1295766c427e87
2014-07-29 00:53:41 +02:00
jenkins-bot
66d3eb56af Merge "ResourceLoader: Test that all module dependencies are satisfiable" 2014-07-27 21:21:41 +00:00
umherirrender
4ee680a8b3 Fixed spacing
- Removed spaces after not operator (!)
- Removed spaces inside array index
- use tab as indent instead of spaces
- Add newline at end of file
- Removed spaces after casts

Change-Id: I9ba17c4385fcb43d38998d45f89cf42952bc791b
2014-07-24 11:53:04 +02:00
Bartosz Dziewoński
278e58bd66 ResourceLoader: Test that all module dependencies are satisfiable
Whenever module A depends on module B, module B must exist.

Whenever module A depends on module B, the possible targets of A must
be a subset of targets of module B.

Bug: 64513
Change-Id: I9de291d20d08df2813eb55be9a1f7e5efd907d6f
2014-06-29 20:28:05 +02:00
Siebrand Mazeland
4ede8c2e9d Pass phpcs-strict on some test files (11/11)
Woo!

Change-Id: I9fc116dfdf18c2772d047adb5bb14535d0bd39ed
2014-04-24 13:51:05 -07:00
Timo Tijhof
330444a4f9 resourceloader: Add unit test to ensure absence of illegal dependencies
Loading these can cause side-effects and is just redundant in
general.

Change-Id: Ic8b4ed45d4d42172a456cc5eaf314c41e4e6fd18
2014-04-08 17:10:34 -07:00
umherirrender
5dbfd5bf80 Fixed spacing
- Removed trailing spaces in comments
- Removed multiple empty lines
- Removed space after object operator

Change-Id: I9fd3256ab490c7cd2034de3fd94e6be6e6d6d8f2
2013-11-21 18:52:25 +00:00
Timo Tijhof
4eb60da520 ResourcesTest: Assert no @media is used inside 'media'-specified resources
Change-Id: I85d652da7c1713d46a5085b9fde7fb24045348be
2013-11-03 23:08:41 +00:00
Antoine Musso
3c8674bdff tests: remove date from @author docs statements
phpunit interprets '@author' documentation statements to generate group.
Appending the year to the author name created duplicates entry:

 $ php phpunit.php --list-groups|grep Antoine
 Antoine Musso
 Antoine Musso, 2012
 $

Removing the date fix the duplication. I have also inserted
corresponding '@copyright' statements.

Change-Id: I65b19adb59c4894314ce68a0c815c5d3e4c30df0
2013-10-03 10:48:12 +02:00
Antoine Musso
67b935edb4 tests: resources tests were not being run
The ResourcesTest class under ./resources/ were not registered anywhere.
This patch move it under the `structure` testsuite and phaseout the, now
empty, `resources` directory.

Change-Id: I53410e1dc83263c4c541f4dc278a9e616265d7b1
2013-05-30 17:17:46 +02:00
Renamed from tests/phpunit/resources/ResourcesTest.php (Browse further)