Make SqlPlatform::tableNameWithAlias() include the unqualified table
name as an alias if doing so is not redundant. This assures that the
default alias from JoinGroupBase::addJoin(), equal to the unqualified
table name, will be usable in SQL (regardless of table prefixes).
Clean up use of identifier quotes for sqlite_master tables. The called
methods expect unqualified names and a passthrough exception already
exists for sqlite_* tables.
Use "block_target.bt_user" directly in ApiQueryBlocks and BlockPager,
instead of using addIdentifierQuotes(). The "block_target" alias is
automatically added to the SQL by the rdbms layer when it's not clearly
redundant, so it is always safe to use block_target.bt_user. Also, there
is no reason for aliases to include quote characters. They are supposed
to be simple alphanumerics like column names. This makes it easy for
tableNameWithAlias() to avoid redundant aliases by checking tableName().
Avoid unneeded quotes around pg_catalog.* table names in the Postgres
installer. The relevant documentation of methods like selectField() is
that the table names be unqualified (no quotes nor dots), though dots
are still supported internally for compatibility reasons and ease of
querying schemas like pg_catalog and information_schema.
Change-Id: Ic7d7826da31f49915141692cb3bd84ed1e872e96
* Update skins/Vector from branch 'REL1_43'
to 31564b81866770ed2235b9248ed9c4f93614ad92
- Localisation updates from https://translatewiki.net.
Change-Id: I54cffcf162035adfb57cea2b33540966d9ac3b8d
* Update extensions/VisualEditor from branch 'REL1_43'
to 3bce60dbcb45d7195c831e527636c88d97bd7bfc
- Localisation updates from https://translatewiki.net.
Change-Id: If482852575c64c63a8fb79e96a51c8f987826719
* Update extensions/WikiEditor from branch 'REL1_43'
to 399939f42fd910e0de5eb49e658d2d0b865b8fd3
- Localisation updates from https://translatewiki.net.
Change-Id: I41b956eb17bba7200f420fccc34008b3da414898
* Update extensions/Thanks from branch 'REL1_43'
to ae78d974e3143d9d10c48f4c8c12ecdba4fecd52
- Localisation updates from https://translatewiki.net.
Change-Id: Ic2dcd4bdd53f1afb8223c3ef45c8642c0beb5eff
* Update extensions/TitleBlacklist from branch 'REL1_43'
to aec41ad533a15282d7d4a825d7b1893b81b25c8e
- Localisation updates from https://translatewiki.net.
Change-Id: Ic2dcd4bdd53f1afb8223c3ef45c8642c0beb5eff
* Update extensions/TemplateData from branch 'REL1_43'
to 12f813122ee580a37bbacb5543b7b490f4ebc4d0
- Localisation updates from https://translatewiki.net.
Change-Id: I17aaa7b93ab5abad84cb7f1dfa943d66e410d8a4
* Update extensions/SyntaxHighlight_GeSHi from branch 'REL1_43'
to 5b790882024a38d2ba3cca25d6322d2cacf75e88
- Localisation updates from https://translatewiki.net.
Change-Id: I2ad1f5673d915f9f405bb4394f55c33a16584486
* Update extensions/OATHAuth from branch 'REL1_43'
to 806e7ea9036bf49637d1a8c40e1c8994220ea909
- Localisation updates from https://translatewiki.net.
Change-Id: I50b598d0331a20e5831d65f3b774eb53a0d824a2
* Update extensions/Nuke from branch 'REL1_43'
to d12367dc6d1c63c2b0302363a1a4c05fe7b4058d
- Localisation updates from https://translatewiki.net.
Change-Id: I6e80d6e16d0c598de66b57a1f3dbe9b953e25959
* Update extensions/Math from branch 'REL1_43'
to 641f3dff30d072cfe0db194557fc3cfc07831b31
- Localisation updates from https://translatewiki.net.
Change-Id: I7b044d4641bcf05c9ee5d0bcae052ea1de9706f9
* Update extensions/Linter from branch 'REL1_43'
to 99863268508a3a5797742868898c73ea1e2cb2c4
- Localisation updates from https://translatewiki.net.
Change-Id: I0033a76f020bae206c6bd8687ae54bc866595c54
* Update extensions/InputBox from branch 'REL1_43'
to c07b5c7f1f60781397ab48ee4ebde494146657e4
- Localisation updates from https://translatewiki.net.
Change-Id: I18aa483f03d5f06027066f0f194b7684cca9aed8
* Update extensions/Gadgets from branch 'REL1_43'
to 543775d2ce5e93ee1f3bb941d9c8261fbd2fc88c
- Localisation updates from https://translatewiki.net.
Change-Id: I3e4a816e9168c56b7fb21f60bd3ea8ea21880f8b
* Update extensions/DiscussionTools from branch 'REL1_43'
to f7a9938618ae47e7ce9ec5d6184ca9a9902f4ded
- Localisation updates from https://translatewiki.net.
Change-Id: I5902d139178a6791af58758d4919907c57a150f1
* Update extensions/Echo from branch 'REL1_43'
to ed7bf37520c5b3b4e452802a781bdee8cac01b12
- Localisation updates from https://translatewiki.net.
Change-Id: Ic84d30a4040f1e2a253bdbf93ea9b06331d2ca88
* Update extensions/ConfirmEdit from branch 'REL1_43'
to 76b40f1224f90791d1d59fdb950bca8abb26356a
- Localisation updates from https://translatewiki.net.
Change-Id: I047e97acc74854ef71ec93172a5c7e2ff390ccab
* Update extensions/Cite from branch 'REL1_43'
to c6a08aaccb4921bc96e5f53aae88d4802fdd346c
- Localisation updates from https://translatewiki.net.
Change-Id: I2786ab7a18463e5ab977a89641f0116467166526
* Update extensions/CiteThisPage from branch 'REL1_43'
to 799d7891252021ef927bba8806cc14574e063832
- Localisation updates from https://translatewiki.net.
Change-Id: Iab84e7239c8685b9b9814f78c17d2f1782e8cf8d
* Update extensions/AbuseFilter from branch 'REL1_43'
to d06c1478ea7f5452336d78610c68ce9e8a3ec7d0
- Localisation updates from https://translatewiki.net.
Change-Id: I1244ca3ac479f645ccaecd71e767721ff419d8e3
* Update extensions/OATHAuth from branch 'REL1_43'
to edaa14b13c708fa23e6ded8f614a0a87cd049387
- UpdateTables: Fix running order of updates
Non virtual domain updates are run first, so this means UpdateForMultipleDevicesSupport
would be run before the necessary schema changes.
Bug: T396955
Follows-Up: I2985c755a2302e7cc7c8ec55041f7e5d8192e4a7
Change-Id: I50c177bc785b67f1674b556ac6a3dcce0406d92e
(cherry picked from commit ed524ba0ec4427bfb40e470831e737307d9c175a)
This patch was applied to release branches for MW 1.42 in April 2024, and
since ported to MW 1.43 and then MW 1.44 as well. This one-of-a-kind hot
patch will finally discontinue once this lands in the master branch as
part of MW 1.45+ releases.
A small handful of phan fixes make this pass so it can land; the rest
(including fixes rather than suppressions of events here) will happen in
later patches.
Bug: T328921
Bug: T359868
Change-Id: Ica2c11a6243795437ec652923e42ef3bd74a5fd8
psr/log 3.0.0 adds this return type.
For this specific case the fix is very simple, fully
compatible with the older version of psr/log, and
something we’ll have to do sooner or later anyway.
Bug: T356451
Change-Id: I49562ac7f1a71e82cab79fe44296feea573e26d4
(cherry picked from commit 9244d4b2623b9d789e7dea28e65b5ca6f9651aaf)
* Update skins/Vector from branch 'REL1_43'
to 90c7d096cf511b3eb15cbe5b6b96139f08fb08cc
- Localisation updates from https://translatewiki.net.
Change-Id: I778299251efe109518ecb416bd7c145b7ecdb033
* Update skins/Timeless from branch 'REL1_43'
to 6a28c3edbc5eb7ad0b55550cd3a2f54ac12c698c
- Localisation updates from https://translatewiki.net.
Change-Id: I97c9dd7ed490f5983f84f36128ee9e0d3a7e3d7a
* Update skins/MinervaNeue from branch 'REL1_43'
to 27c35ed83c1ad41e6d7ba68883b8a54b4ff8e1a2
- Localisation updates from https://translatewiki.net.
Change-Id: I78064dcc5375f77776c3c3a0c0bacba681c69f59
* Update extensions/VisualEditor from branch 'REL1_43'
to b58193d80b2a26b00f5de695ba3b7358005fe16c
- Localisation updates from https://translatewiki.net.
Change-Id: I0c8a19ed37440b06ec7192d78777f451110181ee
* Update extensions/WikiEditor from branch 'REL1_43'
to 70d9f3ef516d9446810218f2d6c4f12cc341b1d6
- Localisation updates from https://translatewiki.net.
Change-Id: I730e252314ea04c1056c9284c7a8444090e1ed10
* Update extensions/TemplateData from branch 'REL1_43'
to e2bd173349e6f907a8c5354bba888805c8357601
- Localisation updates from https://translatewiki.net.
Change-Id: I1753d025495bc64898ebc721a5f4e21cca8c3a72
* Update extensions/TitleBlacklist from branch 'REL1_43'
to 8ac8152477dcdba5e86bb2ff7c58f10a9f14af80
- Localisation updates from https://translatewiki.net.
Change-Id: I6a86543bb431d2060a05ab4788016e448dcd0c52
* Update extensions/Thanks from branch 'REL1_43'
to 740fb288205a20c468ae7f44118c34e99fa8ce45
- Localisation updates from https://translatewiki.net.
Change-Id: Idb782693834f5ac763807c661e5d466cd02b178c
* Update extensions/Scribunto from branch 'REL1_43'
to 12f255bf59c2845fe38c1cd12277c76bc4147333
- Localisation updates from https://translatewiki.net.
Change-Id: I1f7d07bab28660c050a9dbef6bd9e44667abca69
* Update extensions/ParserFunctions from branch 'REL1_43'
to 15a759c3c9d194cf8ed157676a4e3038a3581060
- Localisation updates from https://translatewiki.net.
Change-Id: I1be39df80cbd93e423a1c7955838e3037610b8e0
* Update extensions/PageImages from branch 'REL1_43'
to 5682aefdd7ede0ac0338b1deb2c571d5d9fe38f1
- Localisation updates from https://translatewiki.net.
Change-Id: I7b5b2568ab3dea47002dc85c2554a9ad6e2e81f7
* Update extensions/OATHAuth from branch 'REL1_43'
to b4a2a0404e80add3640ed9436747952eb20111a0
- Localisation updates from https://translatewiki.net.
Change-Id: I8b25f63862936250ac459b14d3ab6837f83370cf
* Update extensions/Math from branch 'REL1_43'
to 6d84f6dfb0a6357e53737b2cf8db82793d539395
- Localisation updates from https://translatewiki.net.
Change-Id: I666e15b423dfcc2a0e394173a9fc4f606e277804
