Commit graph

53 commits

Author SHA1 Message Date
umherirrender
23bb3d1cb4 Follow-Ups to "Fixed some @params documentation"
Fix of inline comments of the following patch sets:
Follow-Up: I0056b4a8df243cfc0c5f25378de48f7a35170aca
Follow-Up: I7f605aa9e117b5fd80d9b1440864fe526d2b14a5
Follow-Up: I3622f216a2ca8ac1b5e51892be9f98665f65bc36
Follow-Up: I6627ba0e76d3577c40bf2473e0f78a5ad7368634
Follow-Up: Id75b5ecf648ca50f955b3bde3307c82c4366b102
Follow-Up: I4ca5231119f33039d91da3b57a41cd40719a576b

Change-Id: Id9bbe84b2820e9db44af5783411e955f55f643d4
2014-04-23 13:39:49 +02:00
umherirrender
8ad1c92441 Fixed some @params documentation (includes/*)
Swapped some "$var type" to "type $var" or added missing types
before the $var. Changed some other types to match the more common
spelling. Makes beginning of some text in captial.
Also added some missing @param.

Change-Id: I7f605aa9e117b5fd80d9b1440864fe526d2b14a5
2014-04-20 21:16:57 +02:00
Ladsgroup
1ba0445c12 Changing URLs of mediawiki.org in scripts to the SSL-based website
http://www.mediawiki.org --> https://www.mediawiki.org

Part 2

Change-Id: I3be61fe3dfb502cc20180486eb1a8016eac151df
2014-03-12 23:24:03 +00:00
Siebrand Mazeland
e61cb8218b Update docs and declare visibility on class props
Change-Id: Ib0f02202d075d4a56dc4e37b08d7ac9399e8c86c
2013-11-01 12:35:27 +01:00
Mathias Ertl
b8b91a0092 add and use updateExternalDBGroups function, fixes #49641
This enables plugins to add/remove groups in an external authentication
service when a group is added via the MediaWiki interface without relying
on the related Hooks. Relying on the Hook would mean that a plugin cannot
use User::addGroup or User::delGroup to add/remove groups comming FROM
the authentication service, as these functions would call the hook and
then redundantly add these groups to the auth-service again.

Change-Id: Ia04d5bb30831a89dfc66128e3c335bbe07f724b6
2013-07-08 19:46:31 +02:00
Tyler Anthony Romeo
4dcc7961df Fixed @param tags to conform with Doxygen format.
Doxygen expects parameter types to come before the
parameter name in @param tags. Used a quick regex
to switch everything around where possible. This
only fixes cases where a primitve variable (or a
primitive followed by other types) is the variable
type. Other cases will need to be fixed manually.

Change-Id: Ic59fd20856eb0489d70f3469a56ebce0efb3db13
2013-03-11 13:15:01 -04:00
csteipp
ed5b575667 (bug 39184) LDAP password leakage
Allow AuthPlugin to determine if user passwords should be stored
locally.

* Released as part of 1.20wmf10, 1.19.2, 1.18.5

Change-Id: Ie41bed7ecf5390f8815128c227bae371880a6058
2012-08-31 14:39:31 -07:00
Reedy
a97f6b035c Fix undefined property domain in AuthPlugin
[21-Jun-2012 20:35:17] PHP Notice:  Undefined property: AuthPlugin::$domain in /www/w/includes/AuthPlugin.php on line 92

Change-Id: I0c470b41881e0fd12d9615f7ac258feeff1a52e4
2012-06-21 22:56:12 +01:00
Ryan Lane
80fbb705e5 Simplifying domain getting/setting
Adding a function to AuthPlugin for getting the user's domain. This allows the extension to determine how the user's domain is get and set, rather than core.

Change-Id: Ib2414bd55dfde67f7caf6439680fa88d9266e991
2012-06-21 14:59:01 +02:00
mrbluesky
1aead61d4c Add and fix comments in some includes files
Change-Id: If781ad1a9eeba8310cef97dc9786685e8b265fa1
2012-05-24 20:42:56 +02:00
Sam Reed
76246b9bf5 More return documentation 2012-02-09 21:33:27 +00:00
Ryan Lane
5bf7522c8e Adding support for domains in SpecialPasswordReset.php. 2011-09-08 19:54:32 +00:00
Jeroen De Dauw
ee2b4ad57b added doc 2011-08-12 15:42:23 +00:00
Sam Reed
33ad682ab0 Add/remove/tweak method documentation 2011-05-19 00:03:31 +00:00
Alexandre Emsenhuber
7b79d94515 * Standardised file description headers
* Added some descriptions
* Added @file where needed
2010-08-14 17:42:40 +00:00
Siebrand Mazeland
d279df340e Ran stylize.php, removed trailing whitespace, updated indentation and code formatting. 2010-05-30 14:48:30 +00:00
Alexandre Emsenhuber
60a11e5035 Fix some doxygen warnings 2010-01-05 21:24:23 +00:00
Brion Vibber
0d1d984313 Revert broken rewrite of login system; totally broken.
* Login doesn't attach to session properly, so can't stay logged in!
* Password field shown in plaintext!

If it just DOESN'T WORK please keep it on a work branch, don't put it in trunk!

Reverted:
r56682
r56683
r56684
r56686
r56688
r56696
r56699
r56702
r56703
r56704
r56782
r56896
2009-09-26 00:49:32 +00:00
Happy-melon
d3f901b029 Merge in Login rewrite, second time lucky. 2009-09-20 20:28:27 +00:00
Brion Vibber
841014ad91 Revert broken rewrite of login forms:
r55990 "* Totally refactor includes/specials/SpecialUserlogin.php:"
r55991 "Followup to r55990 - Remove debugging hack :("
r55994 "Followup to r55990 - rename method to avoid PHP Strict warnings"
r55997 "Follow-up to r55990, per comments:"

Continued reports of breakage with the new version...
Non-vital changes of this magnitude should probably be worked up on a branch to ensure everything's consistent before pushing them to trunk.
2009-09-08 18:40:05 +00:00
Happy-melon
fca012212f * Totally refactor includes/specials/SpecialUserlogin.php:
** Split backend stuff out into includes/Login.php
** Split account creation and login stuff up, into includes/specials/CreateAccount.php and includes/specials/Userlogin.php.
* Reimplement the special pages as subclasses of SpecialPage
* Use HTMLForm to generate the input forms
** Deprecate and delete includes/templates/Userlogin.php, which is horrible and old :D

This changes the syntax of the UserLoginForm and UserCreateForm hooks, and AuthPlugin::modifyUITemplate; they now receive the SpecialPage subclass rather than the template to work with. Update everything I could find in SVN to accommodate this.
2009-09-07 19:00:49 +00:00
Chad Horohoe
00a3b7956a (bug 9691) Add type parameter to ModifyUITemplate function calls 2009-07-27 23:53:23 +00:00
Chad Horohoe
9a97ba7bd0 Per code review: call allowPropChange() directly, and only reference the deprecated methods if they're available, this way if someone _has_ implemented these, they will still get their desired results. Removed them so A) We don't encourage people to use them, and B) We don't fool ourselves with is_callable() 2009-06-11 23:35:34 +00:00
Niklas Laxström
eac9273e08 Added wfDeprecated too 2009-05-20 05:45:18 +00:00
Charles Melbye
46003d5693 Follow-up to r50776. Retaining old method names for backwards compatibility,
but making them as deprecated. Patch by ^demon.
2009-05-20 04:30:03 +00:00
Chad Horohoe
9b3711e58b Per code review: Redo these allowBlah() functions (except allowPasswordChange) into a general allowPropChange(), update Preferences to use this. Checked extensions in SVN using AuthPlugin and none have implemented any of the allow*() functions, so nothing should break. 2009-05-19 16:23:58 +00:00
Chad Horohoe
e3d5b672e8 Default true :) 2009-05-01 01:34:37 +00:00
Chad Horohoe
1f18e8b35c (bug 9219) Auth plugins can control editing RealName/Email/Nick preferences. Based on patch by MrPete. 2009-05-01 01:27:22 +00:00
Aaron Schulz
84ab744191 (bug 16721) Reset auth token to stop auto-login. Auto-login defeats the user rename/touch change to break the login since the user can just get logged in again under the old name without noticing, which results in edits under the old name. 2008-12-28 11:50:33 +00:00
Aaron Schulz
381e589e96 (bug 16445) add info if accounts are not sul accounts to cu results 2008-11-27 07:45:08 +00:00
Aaron Schulz
66b4483f3d Remove cruft here 2008-10-05 02:48:40 +00:00
Aaron Schulz
5e326c34b5 Partial revert of r41527. Do this in a cleaner way. 2008-10-05 02:45:12 +00:00
Aaron Schulz
326e4d86c4 * Pull isLocked() and isHidden() up to User using callbacks
* Add quick globalblock check function to User
* Add 'locked'/'globally blocked' notices to checkuser (bug 15272) (bug 15792)
2008-10-02 01:12:07 +00:00
Siebrand Mazeland
79d5225c0e * remove end of line whitespace
* remove empty lines at end of file
* remove "?>" where still present
2008-04-14 07:45:50 +00:00
Alexandre Emsenhuber
e7259d6fb8 Fixed E_STRICT for CentralAuth extension 2008-03-27 14:03:22 +00:00
Thomas Bleher
ece86ccdb3 A few trivial changes:
* Update some URLs (pages moved from meta to mw.org)
* Update and fix some comments
* Fix indentation and whitespace in phase3/includes/filerepo/ICRepo.php
2008-02-09 21:48:41 +00:00
Brion Vibber
4f379f91c1 * AuthPlugin added strictUserAuth() method to allow per-user override
of the strict() authentication behavior.

Fixes the hole where old local passwords could still be used to log into the global account after merging.
Based on patch by Rotem Liss from http://he.wikipedia.org/wiki/%D7%9E%D7%A9%D7%AA%D7%9E%D7%A9:Rotemliss/CentralAuth#2
Changed function name from authenticateLocally() to strictUserAuth() and reversed return value to mesh a little better with strict()
2007-10-02 19:02:44 +00:00
Brion Vibber
987629dfec update prototype 2007-08-04 16:36:25 +00:00
Aryeh Gregor
a15c419b3d Remove ?>'s from files. They're pointless, and just asking for people to mess with the files and add trailing whitespace. (Yes, I looked over every one and reverted those that were bogus. Slash-enter a million times in less worked well enough, although it was a bit mind-numbing.) 2007-06-29 01:19:14 +00:00
Antoine Musso
c771fc9c96 Use Doxygen @addtogroup instead of phpdoc @package && @subpackage 2007-01-20 15:09:52 +00:00
Brion Vibber
0a780e83bf * Pass e-mail and real name fields to AuthPlugin::addUser, as additional
optional fields, which may be considered useful at registration time.

This fixes the problem where the e-mail address given for a new account
got replaced with null. Woops!
2007-01-12 08:42:36 +00:00
Brion Vibber
295d0bf295 * Accept null parameter to User::setPassword() as indicating the password
field should be cleared to an unusable state. Login will only be possible
  after the password is reset, for instance by e-mail.
* (bug 6394) Invalidate the password set for "by e-mail" account creations
  to avoid accidental empty password creations.
2006-12-13 08:59:20 +00:00
Brion Vibber
b421ac803e Woops, left a parameter off of the AuthPlugin default interface class. *embarrassed* 2006-11-28 00:16:49 +00:00
Rob Church
7e9ddc0e23 * (bug 6006) Allow hiding the password change fields using an authentication plugin 2006-06-29 00:57:56 +00:00
Antoine Musso
69689725c1 Switching from phpdoc to doxygen (use less than 32MB of memory).
Run maintenance/mwdocgen.php to generate doc in ./docs/html/ .
2006-04-19 15:46:24 +00:00
Brion Vibber
f2c29baf9f Update the FSF's address in all these GPL stub headers 2006-04-05 07:43:17 +00:00
Ævar Arnfjörð Bjarmason
a26d5a49d7 * s~\t+$~~ 2006-01-07 13:31:29 +00:00
Ævar Arnfjörð Bjarmason
7bbe971aec * s~ +$~~ 2006-01-07 13:09:30 +00:00
Brion Vibber
e4480a80af * (bug 2943) AuthPlugin::getCanonicalName() name canonicalization hook, patch from robla
http://bugzilla.wikimedia.org/show_bug.cgi?id=2943
http://bugzilla.wikimedia.org/attachment.cgi?id=739
2005-07-24 09:48:14 +00:00
Brion Vibber
cfa06c17ae * (bug 814) Integrate AuthPlugin changes to support Ryan Lane's external
LDAP authentication plugin
2005-06-03 11:56:02 +00:00