* Update extensions/Thanks from branch 'REL1_43'
to 2b83a718030d8c9002f368372128109c50df2b19
- Localisation updates from https://translatewiki.net.
Change-Id: Idec11188db45e7b9285162048cf7b84673c2b58c
* Update extensions/TitleBlacklist from branch 'REL1_43'
to f06c65d4c320456addc83f45e91647fb11ee7381
- Localisation updates from https://translatewiki.net.
Change-Id: I19edb68db48e1afb0dc786291fe7f904b8fb31b9
* Update extensions/TemplateData from branch 'REL1_43'
to 0ab24d333aa04a8d4d072354ed09aa86aa565d4f
- Localisation updates from https://translatewiki.net.
Change-Id: I53c32b7c3b4e2b614aac444e45a563456e0a8612
* Update extensions/SpamBlacklist from branch 'REL1_43'
to 30bf4393901cd44397031b802ed60ed22002fb16
- Localisation updates from https://translatewiki.net.
Change-Id: I251c6e15c136d907a0baf6da4bbec447a4858f87
* Update extensions/Scribunto from branch 'REL1_43'
to fa16cdf711b97465bec563d42389cafd423de658
- Localisation updates from https://translatewiki.net.
Change-Id: I2bf0117588b7dc885b68c5067f6f7f56878a9c5f
* Update extensions/ReplaceText from branch 'REL1_43'
to 97bd5a869cbde2fb044ff9c2aee6a23686a21fe7
- Localisation updates from https://translatewiki.net.
Change-Id: I1db73bfbaea9bf7fac6291be8548ce237980fbc7
* Update extensions/OATHAuth from branch 'REL1_43'
to a76b11b53d62514916c25d687d04bf7a03f65825
- Localisation updates from https://translatewiki.net.
Change-Id: I7e7bca642c25fa69306621b186cb299ee16ac078
* Update extensions/Nuke from branch 'REL1_43'
to e85e75c76bbf77e5a9152fdf78e28ff0ac6ca219
- Localisation updates from https://translatewiki.net.
Change-Id: Icfa69d2e4f041a761b7329590c786cb8402e36cb
* Update extensions/MultimediaViewer from branch 'REL1_43'
to 06db7e5865dfbaf6d82184026083ccbf2c966ac5
- Localisation updates from https://translatewiki.net.
Change-Id: I6bb90248df9365239dbe446fa234543fbe111175
* Update extensions/Linter from branch 'REL1_43'
to 606265ab8d0037e1685b557e62fab9b3d44f4608
- Localisation updates from https://translatewiki.net.
Change-Id: I68a94523274d028ad4b02cd65c45365bc293a82c
* Update extensions/ImageMap from branch 'REL1_43'
to 59fed34310fd2a8e750a732effd8d5d9550b6ccc
- Localisation updates from https://translatewiki.net.
Change-Id: Id25a4d4578ff08ea5ca79b6478b6dcd985a8c901
* Update extensions/Gadgets from branch 'REL1_43'
to 883c4c603ebae3ed2e90834b7217667c7775fc41
- Localisation updates from https://translatewiki.net.
Change-Id: Id451da233527614b5fd8594376e9c377a2142a31
* Update extensions/Echo from branch 'REL1_43'
to 50de6b386c6cc9476049fc88e1fbdd19b2e455f6
- Localisation updates from https://translatewiki.net.
Change-Id: I26f062986423e24ebb1bcf4b532d503a56315f7d
* Update extensions/DiscussionTools from branch 'REL1_43'
to 71fcae8d4d3121cf2479af6e5f476016137434c6
- Localisation updates from https://translatewiki.net.
Change-Id: Ibba98a6062eacd7591777df828a0c3ffcc0904df
* Update extensions/ConfirmEdit from branch 'REL1_43'
to 1cd34a0377f9bf5d8ffc646fc54ca292caecd6e6
- Localisation updates from https://translatewiki.net.
Change-Id: If5387eb340d26cd10dd68966e4fc862b1e615560
* Update extensions/Cite from branch 'REL1_43'
to e38afcb1b11f25be43836161b13c42d2b8daa9c0
- Localisation updates from https://translatewiki.net.
Change-Id: I8b5bc59bcb954145a816a05cb8009dec8f75ac51
* Update extensions/CategoryTree from branch 'REL1_43'
to 9a0e7fe99833d86cf5e00db05e97fdce4d14b347
- Localisation updates from https://translatewiki.net.
Change-Id: Ieefb72bcf4e63afbbcd86780a3638a082303d626
* Update extensions/AbuseFilter from branch 'REL1_43'
to c5eaaa1cd7542f23f82ab89369e7bbd09e658a55
- Localisation updates from https://translatewiki.net.
Change-Id: I5f66b3c60211df7129d399d310f731c459f141af
* Update extensions/OATHAuth from branch 'REL1_43'
to f54dda23a9a95fc4fcf4d054834812c972714a80
- Remove ReauthenticateTime override
Removing ReauthenticateTime override to
use the new 3600 default set in MW core
in Ic9a4585afcfe72f795868cbf7d5281a809e6a7c5
Bug: T402094
Change-Id: I1bf5e51701e6aded41d3c5a7f10b192a6c8f1f43
(cherry picked from commit 066baab3f5b72564ec03455d11e9155b8ced25cf)
* Update extensions/PageImages from branch 'REL1_43'
to 1ff9e184614925aa2fe46d6dbd87522145283585
- Make $wgPageImagesNamespaces default to $wgContentNamespaces
Make PageImagesNamespaces default to ContentNamespaces instead of only NS_MAIN.
Use false as "default" based on 34f9eb92e0/includes/MainConfigSchema.php
Bug: T393346
Change-Id: Icd13a85cacdf68daf00a046e3dfdd60094ca213b
(cherry picked from commit 26e829b66ef01e94f4b9580c6680435341190baa)
Update the default Reauthenticate time to 3600
moving from 1 minute timeout to 1 hour to improve
user experience
Bug: T402037
Change-Id: Ic9a4585afcfe72f795868cbf7d5281a809e6a7c5
(cherry picked from commit fa04ae9ab260082b859876bee7b162b8c833c85b)
Why:
* ServiceWiring.php is documented to say that "Services MUST NOT
vary their behaviour on the global state, especially not ...
RequestContext ... or ... "current" user"
** However, the constructor of the CommentParserFactory calls
`RequestContext::getMain()->getLanguage()` which is in
violation of this rule by both using the RequestContext
and being controlled by the state of the "current" user.
* This has caused issues with premature access to the session
user as demonstrated in T397900.
** Specifically, the call to ::getLanguage will load the request
user's preferences and then as part of this checks if the
user is named (which will load the User object).
* Instead of using the incorrect method of getting the user's
language, it should instead be fetched in
CommentParserFactory::create.
** This will also allow the Language associated with the main
request to change without leaving the service with an
outdated and stale version of the user's Language object.
What:
* Update CommentParserFactory to call `RequestContext::getMain()
->getLanguage()` in the ::create method instead of getting it
from the constructor.
* Remove the call to `RequestContext::getMain()->getLanguage()`
in ServiceWiring.php as no longer needed.
* Update the unit test to instead be an integration test due to
::create now calling code which uses the service container.
Bug: T397900
Change-Id: I36c9d8650eb5040f94626fa50f90b8026d3c3fe9
(cherry picked from commit 536f41bce51ca67733c4879d17992ee0b0db1de8)
* Update extensions/AbuseFilter from branch 'REL1_43'
to f16f3d042e37223141df777b7f22ade857cd3c80
- Protected variables logging: Only compute protected variable values
Why:
* To log when a user views the value of a protected variable,
the AbuseFilter code needs to determine if the value of those
protected variables are not null and the variable is set.
** To do this we need to compute all protected variable values
even if the values are lazily loaded.
** However, the code that does this also loads all other lazily
loaded variables.
* Loading all the lazily loaded variables causes expensive
variables to be loaded even if they are not used.
** This causes noticeable issues when testing filter conditions
against a set of recent actions.
* Instead of computing all lazily loaded variables, the code only
needs to compute lazily protected variables.
** In some cases we can also not load any variable values, because
the code was only looking for the list of defined variables
and not their values.
What:
* Update CheckMatch, SpecialAbuseLog, AbuseFIlterViewExamine,
and AbuseFilterViewTestBatch to not compute all lazily loaded
variables via VariablesManager::dumpAllVars:
** In cases where it is possible, the ::dumpAllVars call is replaced
with a calls to VariableHolder to get the variables.
** In all other cases update the second argument to ::dumpAllVars
from `true` to the list of all protected variables.
Bug: T400673
Change-Id: I7136c61f4e4574de8ffde21076df1c6645a36f81
(cherry picked from commit 7d948eead42241aa6495bf2d0c3fc9b3c42aea72)
* Update skins/MinervaNeue from branch 'REL1_43'
to 8733e6bf633cbd2885fa6f6939e1c33910afa501
- Localisation updates from https://translatewiki.net.
Change-Id: I41f55538f80a11ce54804aaf7b46b060b79e0a34
* Update skins/Vector from branch 'REL1_43'
to 8258e3d519fefc2c36629ac15922c6a8a96ba1f0
- Localisation updates from https://translatewiki.net.
Change-Id: Icc39ca5e3cb377aaf1b074a41967da19213338c1
* Update extensions/TemplateData from branch 'REL1_43'
to ea4424ec99eff40d71149d04da65ca86376ac075
- Localisation updates from https://translatewiki.net.
Change-Id: Iebab15d3e6af1528589ab6dca393eb3dcc0503a2
* Update extensions/VisualEditor from branch 'REL1_43'
to 00fc695507fd01767be8ed91154fd2474c816b9b
- Localisation updates from https://translatewiki.net.
Change-Id: I40cafdac96d191eb018621f9a988d504c7671e8c
* Update extensions/WikiEditor from branch 'REL1_43'
to 6c5e81ad24aaaef6546229c4ef3f2988c1aa2f37
- Localisation updates from https://translatewiki.net.
Change-Id: If6049d29f370b7bb1de5ef0b2a77c8098a49e931
* Update extensions/SyntaxHighlight_GeSHi from branch 'REL1_43'
to 08a01c78dc284f02ece3c5f909857769664d0176
- Localisation updates from https://translatewiki.net.
Change-Id: I369de5f5329037f3007adf6f36a16350b2d1692e
* Update extensions/Scribunto from branch 'REL1_43'
to ea571ce91012ee211c02adfcb7fe7232565ee2e9
- Localisation updates from https://translatewiki.net.
Change-Id: Ifc597c5085c3cbead7aa2ef0d240a9b8ae1e7fdd
* Update extensions/ParserFunctions from branch 'REL1_43'
to f5aaf52e31bc79d5104d4186fdf79b5a90fdd00a
- Localisation updates from https://translatewiki.net.
Change-Id: Idfcbc038dfd4de1dcea33e25c86e1533c9fbb5e6
* Update extensions/Nuke from branch 'REL1_43'
to fc8661532e4f9c54c8f97c41e34b90c98e04614e
- Localisation updates from https://translatewiki.net.
Change-Id: I7f6507188400f36053beef75c38f925a9414aacb
* Update extensions/OATHAuth from branch 'REL1_43'
to 07812f4994641de8fdbaaf284356c2c7793f0df5
- Localisation updates from https://translatewiki.net.
Change-Id: Ib143d2789b2fc4808b51febbb2e27766eb4d2b2a
* Update extensions/Math from branch 'REL1_43'
to 3d0e697cde146880f429ed46fe0fe5a1fa8cce45
- Localisation updates from https://translatewiki.net.
Change-Id: If768b49ccc790472ceb3620945dc62bc82128d23
* Update extensions/InputBox from branch 'REL1_43'
to 1b0f0e91afed194a9f9479c61c142e669d17acdc
- Localisation updates from https://translatewiki.net.
Change-Id: Ibc315d69cabc7244022cef610f032acbaa618743
* Update extensions/DiscussionTools from branch 'REL1_43'
to 185036b0ab5150b4706c73ae583a6a1611d7c4a9
- Localisation updates from https://translatewiki.net.
Change-Id: I0a66b92cdebd59ce03b88cba0ff5b4f9dc12bf18
* Update extensions/Echo from branch 'REL1_43'
to c1b049e6e36d9cedd2f0b771b00131e722a55586
- Localisation updates from https://translatewiki.net.
Change-Id: I0a66b92cdebd59ce03b88cba0ff5b4f9dc12bf18
* Update extensions/CodeEditor from branch 'REL1_43'
to c7c4a0f8c31203139635d8fe7ed836e8bf62096b
- Localisation updates from https://translatewiki.net.
Change-Id: Ifb23df690981bda70adf504f149ce954e5d3942f
* Update extensions/ConfirmEdit from branch 'REL1_43'
to 845db6e7f68b11c96e347397f732837a3579a4f0
- Localisation updates from https://translatewiki.net.
Change-Id: I70a480c0d69ea60a6bd4e2e598958d74bf2986b6
* Update extensions/Cite from branch 'REL1_43'
to 9f098f6fd88476d28e43b39c6cd237f759c4b406
- Localisation updates from https://translatewiki.net.
Change-Id: Ie57039c07cf9954a0006a60261f544316bfdd3e7
* Update extensions/CategoryTree from branch 'REL1_43'
to 3194c7ae4d41972c45f07bdb2150864431c418ed
- Localisation updates from https://translatewiki.net.
Change-Id: I8535848e96de9f8b157e6140e4e1db06929f3fb3
* Update extensions/AbuseFilter from branch 'REL1_43'
to b77316f3518d94e4836d167542d3f416f9094601
- Localisation updates from https://translatewiki.net.
Change-Id: I4c65dc26eeae26c190843d86a01167c6bd53ffe2
These requests are usually sent to a wiki operated by a different
organization so UA etiquette is important.
* Add the site's URL (the URL of the main page, more specifically)
as a contact address.
* Add the site's URL as a referer as well.
Considered but not done:
* Use $wgEmergencyContact as the contact part of the UA. It's not
guaranteed to be set correctly, while the main page URL always
exists and will usually be enough to pinpoint the wiki (except
maybe in some intranet scenarios).
* Include information about the user making the request. Would
be a privacy risk + probably useless due to caching.
* Include information about the page the request is for. Would
require lots of refactoring (making the patch harder to
backport) or relying on the context title (which might be
fragile), and in any case probably unreliable due to caching,
and doesn't seem very relevant to the operator of the foreign
site.
Bug: T400881
Change-Id: I968fac6ee0ebbc5a2bd3244f57851eb64125c93d
Running "SELECT @@GLOBAL.read_only" on MariaDB 12.0.2 returns "OFF"
instead of "0", which appears as "true" when cast to boolean in PHP. We
fix that by adding a specific check.
Discord thread where the bug is discussed:
https://discord.com/channels/178359708581625856/1404036592527741049
JIRA ticket in MariaDB: https://jira.mariadb.org/browse/MDEV-37429
Bug: T401570
Change-Id: Ifb04e8b7d04403b6f3dd8517c20c9c0070bd57ac
(cherry picked from commit 54d2416fbcb3a7d0e2a197ca58a755134bd18866)
* Update skins/Vector from branch 'REL1_43'
to c193424bc8894fa80964c47deb6bfe990d5f7dc6
- Localisation updates from https://translatewiki.net.
Change-Id: Ic9a07a46d989a98a23ed8f096033267ada9bf873
* Update skins/MonoBook from branch 'REL1_43'
to c23ebf1470dfbae311c2b5b1df0b68cc612692c3
- Localisation updates from https://translatewiki.net.
Change-Id: Iec38c68efea56a87ce5835fe2682caac7b99b46a
* Update skins/MinervaNeue from branch 'REL1_43'
to 1a30ba7bcd342534b8de9c3105212fca5f9fbc93
- Localisation updates from https://translatewiki.net.
Change-Id: Iec38c68efea56a87ce5835fe2682caac7b99b46a
