Commit graph

310 commits

Author SHA1 Message Date
daniel
b5b2b2f898 (Bug 41574) Supply Title object to Revision if possible.
The Revision object needs the Title to determine the default content model.
Providing the Title explicitely wherever possible avoids an extra database
lookup. Most importanlty, this fixes fatal errors that ocurr when the
database lookup fails due to slave lag or transaction state.

Change-Id: I516e82f7a893b274c513b128b8a46db491160b55
2012-11-01 13:48:18 +01:00
jeroendedauw
dc8f3e6c78 Added a pile of missing brackets
Change-Id: Id7b331e1b12875736c8e7e93660e71630360a723
2012-09-27 21:46:22 +02:00
Dereckson
a1e602a939 (bug 40072) Add semantic CSS classes to identify changes list items
In the special pages containing changes list, adding the following
CSS classes to revision rows:
    - mw-changeslist-date
    - mw-changeslist-title
    - mw-changeslist-separator (matching the dots, ". .")

This enhancement has been implemented to the following special pages:
    - [[Special:Contributions]]
    - [[Special:DeletedContributions]]
    - [[Special:RecentChanges]]
    - [[Special:Watchlist]]

It's also implemented on pages history.

Change-Id: I2385ef21d9aed4bdbe4971bfcfa28efaf058e7dd
2012-09-07 22:46:56 +02:00
Siebrand Mazeland
8d4913ec4d Replace deprecated wfMsg* calls with Message class calls.
Change-Id: Ifa80db1d81b9b9d1a5adfcac06a9ed14203c100e
2012-08-19 22:08:08 +02:00
Dereckson
8d68833208 (bug 37638) Remove calls to deprecated LogPage::logName method.
The LogPage::logName method has been deprecated in 1.19,
warnings being planned in 1.21.

This change removes any call in the MediaWiki core to this
deprecated method.

Removing extra whitespaces/tabs in includes/ProtectionForm.php.

Change-Id: I1907f17341ecb6448967a5283e3c913778dcb1a9
2012-08-15 07:50:01 +00:00
umherirrender
58b7b644f9 change some rc_new to rc_type == RC_NEW
The field rc_new is obsolete and should be removed, see bug 34320

Change-Id: I411ec2cb0fe3eb078094eded210d4aefee5f8e74
2012-08-06 00:08:35 +02:00
Antoine Musso
d5737f8f17 update @param @return doc in several files
Change-Id: I0e23227330f90dc4121fd2a313d2e9a33c3c97a7
2012-07-10 17:08:52 +02:00
Antoine Musso
aab43dd495 escape tags and entity in doxygen comments
When inserting XML elements inline <such as this one>, doxygen chokes
about it not being known. Simply enclosing the tag in double quotes
prevents doxygen from emitting a warning.

Also enclosed a few invalid functions calls such as \. and double quoted
the HTML entities such as &foobar;

Change-Id: I4019637145e683c2bec3d17b2fd98b0c50a932f1
2012-07-10 17:08:32 +02:00
Catrope
3bb6217db3 Merge "(bug 38148) Fix E_WARNING in ChangesList.php line 1218" 2012-07-03 18:50:02 +00:00
Aaron
79c774d362 Fixed exception in diff size formatter.
Change-Id: Iaa4887453ba6b136e507e51af6c80849b7c6873c
2012-07-03 11:20:24 -07:00
Alexandre Emsenhuber
5b01c0c867 (bug 38148) Fix E_WARNING in ChangesList.php line 1218
The error is PHP Warning: explode() expects parameter 2 to be string, array given in includes/ChangesList.php on line 1218.
The problem is that $classes is always an array, so no need to explode() it.

Change-Id: I6917273aecc6b9ddbf377e69ecbd343ee25fa8ef
2012-07-03 19:46:53 +02:00
Brad Jorsch
c1bf80f8df (bug 36788) Add classes to containing row on watchlist/history
Each line on the watchlist and on the history pages should have a
specific class to indicate the "updated since my last visit" status,
to allow for more comprehensive styling than is possible with individual
elements embedded within the line.

Also some cleanup: turn the $classes variable in the enhanced watchlist
code path into an array, and change the bolding of titles in the
watchlist from <strong> tags to styling via CSS.

Change-Id: I90bc95db061274d4de782578a4e91f954481adfd
2012-07-01 23:28:21 -04:00
Alexandre Emsenhuber
1df8e0369a Use local context to get messages and time formatting methods of Language class
Also added ChangesList::formatCharacterDifference() to replace RecentChange::getCharacterDifference()
so that it's easier to pass a context object ChangesList::showCharacterDifference().

Change-Id: I345f46d2812ed6ee222ddd2dd085efbd4a1f6a36
2012-06-28 23:42:46 +02:00
Demon
7790bcfdae Merge "Follow-up Idae8d920 (8c65834): no need to call getContext() and escape the message." 2012-06-27 21:17:22 +00:00
Reedy
d9f3e8df0f Can't use return value of void functions
Change-Id: Idce6e31f3f0eff0a0045c1cc62def3f5d79b9d48
2012-06-16 14:42:30 +01:00
awjrichards
c29fd59775 Big oops - merged to wrong branch.
Revert "Revert to arbitrarily old point before initial remote branch creation to help clean up"

This reverts commit ee0d3d330f
2012-06-05 22:58:54 +00:00
awjrichards
ee0d3d330f Revert to arbitrarily old point before initial remote branch creation to help clean up
Change-Id: I41a3d1e55d3ea9dffa42451237fe065f9334361d
2012-06-02 08:43:04 -07:00
Alexandre Emsenhuber
8cf3d21ac5 Follow-up Idae8d920 (8c65834): no need to call getContext() and escape the message.
Change-Id: I6a6b06be19d4fb655674c2e930a7e5f52374fbe2
2012-05-30 13:46:52 +02:00
Liangent
8c65834425 Add new message 'brackets' and use it to kill some hardcoded []s.
Change-Id: Idae8d9201d1c291316ab520d204ae8c5cde2d890
2012-05-30 14:40:11 +08:00
Alexandre Emsenhuber
1082c71e9b Added missing GPLv2 headers in some places.
Also made file/class documentation more consistent.

Change-Id: Ibe7815124d6915792dcbb150d01df21d9b22b0b0
2012-05-21 21:56:39 +02:00
Niklas Laxström
4d94927715 Restore many missing spaces from r112589
Also fixed indentation by spaces
And please don't ever use != ''. It's misleading.
2012-03-01 10:42:02 +00:00
Siebrand Mazeland
481943429e (bug 34702) More localised parentheses. Patch contributed by Yusuke Matsubara. 2012-02-28 11:56:59 +00:00
Krinkle
5d68836825 [mediawik.special.changeslist] Remove ugly arrow swapping hack
* Use CSS and change the background image, instead of displaying 2 <img> tags and hiding one based on the parent element's class
* touches bug 17616 a bit, although it doesn't address the focus issue yet, but does improve the overal structure of this module
* Also speeds up by:
- Outputting less markup
- Having 1 embedded images in the CSS file instead of (N changes)*<img> tags
* jquery.makeCollapsible:
2012-02-27 00:03:14 +00:00
Sam Reed
c052fc3b7b Documentation followups from lastnight 2012-02-10 15:37:33 +00:00
Sam Reed
76246b9bf5 More return documentation 2012-02-09 21:33:27 +00:00
Sam Reed
7b25f8231f Fixing some of the "@return true" or "@return false", need to be "@return bool" and then the metadata can say true if foo, false if bar
Other documentation improvements
2012-02-09 19:30:01 +00:00
Antoine Musso
fc6bc233be Fix doxygen docs before REL1_19 branching 2012-02-01 20:53:38 +00:00
Sam Reed
b4a276e72e Documentation
Wrap some long lines
2012-01-12 19:03:32 +00:00
Antoine Musso
fea77a9117 enhance size tooltip on changelist
follow r104085
2012-01-04 11:33:35 +00:00
Sam Reed
5d39b698b6 Add braces
Fix documentation
2011-12-31 00:21:27 +00:00
Niklas Laxström
e4183b1f59 Non oldrc change lists were not displaying the names of new log types properly. While at it, drop support for displaying very old style log entries 2011-12-29 12:58:43 +00:00
Jeroen De Dauw
a62e242a30 revert r106095, fix apparently not this simple 2011-12-13 21:34:16 +00:00
Jeroen De Dauw
29e81897f9 logName -> getName 2011-12-13 21:17:32 +00:00
Jeroen De Dauw
49cdca93be add missing deprecation notices and added deprecation version to existing ones 2011-12-13 05:19:05 +00:00
John Du Hart
54b9769920 Followup r100722, show the full size of the page in the tooltip 2011-11-23 21:01:03 +00:00
John Du Hart
216d661d3b Bug 29524 - Rename RequestContext::getLang to getLanguage
I'll be amazed if this doens't break any tests.
2011-11-21 16:13:21 +00:00
Aaron Schulz
33a86e678a Made ChangesList generate page links with rcid=x for new pages when $wgUseNPPatrol is on (not just $wgUseRCPatrol) 2011-11-19 05:37:24 +00:00
Daniel Friesen
32b4dd8a77 Refactor core from Title::getLinkUrl to Title::getLinkURL to match Title's getLocalURL and getFullURL.
This shouldn't cause any back or forward compat issues since php treats method names as case-insensitive. So this change shouldn't break any old extensions, and extensions are free to start using getLinkURL and won't have any issue breaking with old versions of MediaWiki.
2011-11-10 03:27:55 +00:00
Amir E. Aharoni
c93dfd61fb Followup to r101120, replaced hardcoded parentheses with the 'parentheses' message. 2011-10-28 08:04:58 +00:00
Amir E. Aharoni
08513967f9 Adding dirmark after changed bytes to prevent mixing with LTR usernames and summaries. 2011-10-28 06:04:22 +00:00
Derk-Jan Hartman
dd50a31d90 Follow up to r79085. Fixes bug 31408.
There was a typo, causing the minoredit tag not to show up in the enhanced recentchanges.
2011-10-22 19:50:43 +00:00
Amir E. Aharoni
7b85c7be51 Made the arrow point in the correct direction according to the user's language, which may be different from the wiki language. 2011-10-13 13:43:02 +00:00
Alexandre Emsenhuber
0da17a29c3 * Added User paremeter to Revision::userCan(), Revision::userCanBitfield(), LogEventsList::userCan(), LogEventsList::userCanBitfield(), File::userCan() and its subclasses so that they can check against any user instead of always $wgUser.
* Updated callers that have a context or may use another user than $wgUser
* Revision::getUser(), Revision::getUserText(), Revision::getComment() and Revision::getText() also have a User as parameter, but it will be used only when Revision::FOR_THIS_USER is passed in the first parameter
2011-10-12 15:09:04 +00:00
Amir E. Aharoni
231dbc7d46 Followup to r98839 and r98851 according to Nikerabbit's suggestions: Xml -> Html and some whitespace. 2011-10-05 06:45:11 +00:00
Amir E. Aharoni
11a4a70a17 Followup to r98847. Replacing .= with = 2011-10-04 07:33:12 +00:00
Amir E. Aharoni
c10d3fe3da Followup to r98839. Removed 'escape' from wfMsgExt (suggested by Nikerabbit); wrote full class names (suggested by Krinkle). 2011-10-04 03:08:49 +00:00
Amir E. Aharoni
e5c159ae2e The general fix is setting the directionality of added or removed bytes in recent changes. It is always supposed to be LTR.
Details:
* Spelling of variable names and comments: formated -> formatted
* Replaced "<$tag" with Xml::element
* Added a dirmark before the username (otherwise the added or removed appear on the other side)
2011-10-04 00:12:09 +00:00
Niklas Laxström
610db6c338 * (bug 30245) Use the correct way to construct a log page title 2011-09-21 09:41:40 +00:00
Aaron Schulz
bf224c75c0 Removed duplication in insertArticleLink 2011-09-19 21:55:17 +00:00
Niklas Laxström
175cdae687 My changes in r96548 were too radical, stripping of edit commits (oops!) and rollback links on some places. 2011-09-19 12:36:58 +00:00