Commit graph

30 commits

Author SHA1 Message Date
Reedy
8b60be946b Fatal error: Call to a member function getExtension() on a non-object in /usr/local/apache/common-local/php-1.20wmf1/includes/ExternalEdit.php on line 84
Change-Id: I9e54204ebac69dc0e8682b502cee8ec43ff2d9a4
2012-04-28 01:21:42 +01:00
Sam Reed
42ab77ee6f Unindent code to use elseif 2012-01-12 19:04:06 +00:00
gicode
db0cac00da Attempt to fix External Edit for files.
I would feel better if I knew how to test this all the way through...

Follow-up r102521.
2011-12-01 19:11:54 +00:00
Alexandre Emsenhuber
588539858c Some updates to EditPage and ExternalEdit:
* Made ExternalEdit use a context
* Updated DifferenceEngine to use ExternalEdit to send the diff stuff to reduce code duplication
* Introduced ExternalEdit::useExternalEngine() to check whether to use the external edit or diff (except for the action, section and oldid which are still checked in Wiki.php) to remove code duplication; external diff can now also be controlled with externaledit or internaledit URL parameters
* Use $wgContLang to get the name of the "Special" namespace instead of user's language
* Modified the line breaks in the comment on the top of the control file so that the URL is on its own line
* Updated extension to call EditPage::edit() instead of EditPage::submit(), the latter will just call the former
* Updated extension to let core handle itself the ExternalEdit mode instead of doing this themself
2011-11-09 15:31:55 +00:00
Roan Kattouw
24f6e5f721 Use canonical URLs in sitemaps, diff stuff and external edit stuff 2011-08-19 17:33:41 +00:00
Chad Horohoe
a5d4b3a560 Fix for r92187 2011-07-15 05:32:57 +00:00
Chad Horohoe
5d9d464e21 Various cleanups to ExternalEdit. Documentation, code style, removed some unused variables, removed silly 'm' prefix, etc. 2011-07-14 20:19:59 +00:00
Aaron Schulz
55c6aed1ab Removed raw Article->field accessing 2011-06-28 14:10:55 +00:00
Sam Reed
15df9a9d5c Kill off the long deprecated $wgInputEncoding and $wgOutputEncoding globals 2011-05-06 22:09:47 +00:00
Brian Wolff
6ca0ea07a2 (bug 26716, well partially anyways. kind of second half of r80608) Add a comment to external editor ini control file explaining
what it is. This will give people who accidently select the preference a fighting chance to debug what is going on.

Of course, since it has a mime type of application/x-external-edit (or something like that), and the download would have
a .php extension, the chance they will open it in a text editor is pretty slim...

See bug 2760 for proposal to just kill the preference altogether.
2011-01-20 01:49:49 +00:00
Alexandre Emsenhuber
7b79d94515 * Standardised file description headers
* Added some descriptions
* Added @file where needed
2010-08-14 17:42:40 +00:00
Alexandre Emsenhuber
087a9f70c5 WARNING: HUGE COMMIT
Doxygen documentation update:
* Changed alls @addtogroup to @ingroup. @addtogroup adds the comment to the group description, but doesn't add the file, class, function, ... to the group like @ingroup does. See for example http://svn.wikimedia.org/doc/group__SpecialPage.html where it's impossible to see related files, classes, ... that should belong to that group.
* Added @file to file description, it seems that it should be explicitely decalred for file descriptions, otherwise doxygen will think that the comment document the first class, variabled, function, ... that is in that file.
* Removed some empty comments
* Removed some ?>

Added following groups:
* ExternalStorage
* JobQueue
* MaintenanceLanguage

One more thing: there are still a lot of warnings when generating the doc.
2008-05-20 17:13:28 +00:00
Siebrand Mazeland
79d5225c0e * remove end of line whitespace
* remove empty lines at end of file
* remove "?>" where still present
2008-04-14 07:45:50 +00:00
Brion Vibber
9676b2c86b Add an explicit Cache-control: no-cache header on external edit; possible reports that our caches are aggressively caching these, though they shouldn't in an ideal world. 2008-01-16 20:59:24 +00:00
Brion Vibber
ef1545f14a * Add {{filepath:}} parser function to get full path to an uploaded file, complementing {{fullurl:}} for pages.
Giving this a |nowiki option to wrap the returned path in <nowiki>s for non-linked standalone use.
Added File::getFullURL() function for cleaner calls; using full path to ensure consistency here.
2007-09-14 15:29:52 +00:00
Aryeh Gregor
a15c419b3d Remove ?>'s from files. They're pointless, and just asking for people to mess with the files and add trailing whitespace. (Yes, I looked over every one and reverted those that were bogus. Slash-enter a million times in less worked well enough, although it was a bit mind-numbing.) 2007-06-29 01:19:14 +00:00
Tim Starling
ed4303922f Merged filerepo-work branch:
* Added support for configuration of an arbitrary number of commons-style file repositories.
* Split Image.php into filerepo/File.php and filerepo/LocalFile.php
* Renamed Image::getImagePath() to File::getPath()
* Added initial support for timestamp-based file fetching (OldLocalFile), to be expanded upon by aaron.
* Changed the interface for Image/File object creation: use wfFindFile() or wfLocalFile() depending on semantics
* ImageGallery::add() now accepts a title object as the first parameter
* Moved file handling operations on upload from SpecialUpload to File
* Removed path-related functions from ImageFunctions.php. Removed static path accessors from File. 
* Added a Content-Disposition header to thumb.php output
* Improved thumb.php error handling
* Updated the unit test suite to kind of partially work with modern computers. RunTests.php doesn't work just yet. Fixed an actual regression that the test suite detected -- moved some defines to Defines.php where they will be loaded consistently.
2007-05-30 21:02:32 +00:00
Antoine Musso
c771fc9c96 Use Doxygen @addtogroup instead of phpdoc @package && @subpackage 2007-01-20 15:09:52 +00:00
Antoine Musso
b144fcb85d Rename constructors to __constructor 2007-01-20 13:34:31 +00:00
Antoine Musso
fa813bd470 Fix #6622: image::newFromTitle deprecated but still used 2006-07-10 19:49:22 +00:00
Ævar Arnfjörð Bjarmason
a26d5a49d7 * s~\t+$~~ 2006-01-07 13:31:29 +00:00
Ævar Arnfjörð Bjarmason
7bbe971aec * s~ +$~~ 2006-01-07 13:09:30 +00:00
Antoine Musso
2ca68a256d Clean up unused globals! 2005-12-04 18:27:59 +00:00
Erik Moeller
e56ab3154a bugfix: if the upload path is absolute, don't prepend the server URL 2005-06-28 05:02:09 +00:00
Erik Moeller
90586917b2 handle Special: namespaces in multiple languages 2005-04-13 06:57:31 +00:00
Erik Moeller
e7b1a9e8e3 1) add new preference: use external diffs (uses same framework as external
editors)
2) support for external diffs
3) shuffle some user preferences around
2005-04-12 03:36:20 +00:00
Erik Moeller
f9d54adab1 1) we need an absolute path for the image, since it needs to be retrieved
by the external editor helper application (NB: that fatal error was probably
a PHP 4/5 thing, I'm using PHP 5 here).

2) adding some extra information for the helper, this should all be made
a little more logical (only pass on as much information as needed to
construct the proper URLs)
2005-04-07 06:29:08 +00:00
Erik Moeller
a5b7daf1d7 change MIME type to x-external-edit 2005-04-04 16:00:10 +00:00
Ævar Arnfjörð Bjarmason
94e06f20a5 This is probably what eloquenc meant to do ( at least it fixes that fatal error) 2005-03-26 17:19:39 +00:00
Erik Moeller
1b562068b6 Preliminary support for application/external-editor
allows editing wiki pages or files with an external application, by using
an intermediate helper application (such as the reference one in
extensions/ee) which fetches the data and transmits the changes back to the
server.

This version adds external editor support for uploaded files, as well as for
pages. More operations, such as diffs and merges, should support
application/external-editor in the future.

See extensions/ee/README for some more info on the concept. Documentation
will also be placed on http://meta.wikimedia.org/wiki/Help:External_editors
2005-03-24 13:30:09 +00:00