Fix return documentation for blockLogFlags() in SpecialBlock.php.
Make whitespace of if() and foreach() consistent per coding standards in SpecialBlock.php
Change-Id: I87ea271e71c45dcc3f7cdd0960eb8f60a13cfec6
If a block includes the "Hide username" to revdel the username, check
that the user has permission to 'hideuser' before showing the reason
for the block.
Other metadata about the block (expiration, limits) will still be visible
to admins.
Change-Id: I50a49ea6876b99a944d27f7c34910f0aa47556c3
Minor side change 1: fix preservation of infinite expiry time when reblocking:
the hardcoded value "indefinite" did not match with the default value
specified in ipboptions "infinite"
Minor side change 2: fix link in includes/Message.php's documentation
Change-Id: Icb1edabd8bb3dd1020c023b27b1270b9d2735b06
Special:Block is showing checkboxes that apply only to IP blocks when
blocking usernames, and vice versa. The code to hide these checkboxes
already exists in resources/mediawiki.special/mediawiki.special.block.js,
but it's not being loaded.
Change-Id: I875125b56e9f234dbff87bff3b045877fb1614be
I know this doesn't change anything, but that's with stuff like this
we do get E_NOTICEs when suddenly there're no more items in the array.
Change-Id: I633d04297e756cc1e1cc74cd0e65ebf1cb6dfdd1
Was comparing the normalized name to the non-normalized name that gets inserted into the form, since
request variables from previous request override form defaults.
* Made HTMLFormField pass the HTMLForm object to the validation and filter callbacks (so that they can get a context)
* Added new parameter to SpecialBlock::checkUnblockSelf() to pass the user doing the request
* SpecialBlock::processForm() and SpecialUnblock::processUnblock() now require a context as second parameter; added SpecialBlock::processUIForm() and SpecialUnblock::processUIUnblock() as adaptators from HTMLForm as second parameter to context
* Removed OutputPage::setPageTitleMsg() and OutputPage::setHTMLTitleMsg() and make OutputPage::setPageTitle() and OutputPage::setHTMLTitle() accept a Message object
* Updated core calls (including some that I missed last time because of non-matching case)
* Added Message::setContext() and use it in RequestContext so that I don't need to duplicate the call in OutputPage
* Yes, I'm calling $this->msg() on places and then setting the context one more time in OutputPage::setPageTitle() or OutputPage::setHTMLTitle(), but at least I won't be confused about which objects $
* Directly throw an ReadOnlyError instead of calling OutputPage::readOnlyPage()
* In Special:Block: don't let user think the error is temporary if he doesn't have right and the database is locked, instead check permissions first and then the database lock
