Commit graph

201 commits

Author SHA1 Message Date
umherirrender
c157f4d424 Remove a bunch of trailing spaces and unneeded newlines
Change-Id: I52ae3c55044bc8c53698e356bad74969406670bf
2012-10-20 13:32:35 +02:00
Liangent
4e35b4b72c Localize comma separators in jump-to-nav.
Change-Id: Id618041286d3bbd432b06a92ceffdb4c95d8afe3
2012-07-29 08:49:14 +08:00
Alexandre Emsenhuber
58852d8827 Deprecated Title::userIsWatching(); use User::isWatched() instead.
* The problem is that Title::userIsWatching() relies on $wgUser,
  which is not suitable on every case. Instead User::isWatched()
  requires both an User and a Title object.
* Replaced all core calls from the former to the latter
* Added a cache in User for the WatchedItem instances so we do not
  need to do a database request every time something want to know
  whether a page is watched or not, which can happen several times
  per request.

Change-Id: Ifa9c55b7ffb487ce6893c74df233eedc7654dc5e
2012-06-29 23:22:35 +02:00
awjrichards
c29fd59775 Big oops - merged to wrong branch.
Revert "Revert to arbitrarily old point before initial remote branch creation to help clean up"

This reverts commit ee0d3d330f
2012-06-05 22:58:54 +00:00
awjrichards
ee0d3d330f Revert to arbitrarily old point before initial remote branch creation to help clean up
Change-Id: I41a3d1e55d3ea9dffa42451237fe065f9334361d
2012-06-02 08:43:04 -07:00
Alexandre Emsenhuber
cf5f055707 Added missing GPLv2 headers in some places.
Also made file/class documentation more consistent.

Change-Id: If00cc0c63c49e441de56bc7b55d764d4a9a53ae8
2012-06-04 15:36:23 +02:00
Alexandre Emsenhuber
097bd24fb0 Fix E_STRICT from I6d164e45c1e31d4f83e0fa390011c5d182eb69c3.
The error is Strict Standards: Declaration of SkinVector::addToBodyAttributes() should be compatible with that of Skin::addToBodyAttributes() in skins/Vector.php on line 71.

Change-Id: I429609359870547f3df895902909754899ec30df
2012-05-10 21:53:21 +02:00
Trevor Parscal
79dc96f355 Added a class to body which enables/disables layout transitions
This allows people to disable animation of CSS properties temporarily
if needed by removing the vector-animateLayout class from the body.

// Disabled CSS transitions on properties customized by the hd layout
$( 'body' ).removeClass( 'vector-animateLayout' );
// Change something that would normally be animated
$( '#content' ).css( 'margin-left', 0 );
// Re-enables transitions
$( 'body' ).addClass( 'vector-animateLayout' );

Change-Id: I6d164e45c1e31d4f83e0fa390011c5d182eb69c3
2012-05-10 11:29:32 -07:00
Amir E. Aharoni
6011f2d2f4 Removing unnecessary space from the end of the page heading.
Addresses a comment Fomafix made at
http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105870#c32772

Change-Id: Ic9887a079734b28155f46ffaeedec02ff8ad81ca
2012-05-02 15:35:36 +03:00
Daniel Friesen
fee04fc52d Vector did not show watch star on Special:MovePage
Fix the bug where Vector leaves "unwatch" in an action in the menu
instead of converting it into an icon when you are on
Special:MovePage/Foo.

Apply to when using $wgVectorUseIconWatch = true;

Change-Id: Ie914ac50974aa473fa474931ca69776dd1c2fc54
2012-03-23 11:36:05 +01:00
Robin Pepermans
b5e276e8f0 Remove the explicit user lang/dir attributes, because variant names are usually not in the user language, and there are lang attributes on those li items. 2012-03-11 03:25:22 +00:00
Brion Vibber
9ed66fcb99 * (bug 34768) Set width and height for search-ltr.png (and search-rtl.png) in Vector skin
<img> in <button> didn't have width or height set.
2012-02-29 20:02:42 +00:00
Derk-Jan Hartman
60f1f969b4 Add lang and hreflang tags to the variants in the variant menu's. This fixes bug 24742.
I have not added the rel 'alternate' links, because they are also present in the <head>
2012-02-26 16:52:37 +00:00
Mark A. Hershberger
7c710c3f8f fixes Bug 26459 - The renderNavigation and renderPortals functions should be protected or public instead of private
Patch from Christian Neubauer
2012-02-10 20:28:12 +00:00
Sam Reed
c052fc3b7b Documentation followups from lastnight 2012-02-10 15:37:33 +00:00
Krinkle
2b3733ecab [Core JS] wikibits.js / IEFixes clean up
* fix on-the-loose fixalpha() call
-- Calls should not be dangling loose like that
-- Removed local calls from skins and installer
-- instead calling from the IEFixes script (which is loaded raw by wikibits which is loaded from the bottom, as are all legacy scripts)
* Removing usage of 'skinpath' and 'skin' globals in wikibits.js, those aren't globals per se since introduction of mw.config and $wgLegacyJavaScriptGlobals
* Wrapping wikibits.js in closure to avoid leakage of "local" variables. This shouldn't break anything as it is loaded through resource loader which, in production mode, wraps it in a closure anyway.
* adding explicit posision=>bottom for wikibits. 'bottom' is default but repeating here since it must not change for legacy reasons.
2011-12-26 16:12:07 +00:00
Brion Vibber
d2d4d1c243 Revert r106094 (broken unnecessary cleanup), r106454 (ugly unneceessary cleanup)
The ugliness of this sort of code is probably part of why there's still a Linker::tooltip() function.
Please don't just replace it with worse code; if truly cleaning it up this should be done by giving a saner interface to the nav generation code
2011-12-20 21:57:17 +00:00
Jeroen De Dauw
fd70e68a2e follow up to r106094 2011-12-16 18:17:04 +00:00
Jeroen De Dauw
864252801a fix depracted method usage 2011-12-13 21:16:57 +00:00
Amir E. Aharoni
2fde32bed6 Followup to r105854. Made directionality inline rather than block-level, because text alignment should be consistent with the rest of the site. Added support for Monobook and Modern skins. 2011-12-12 12:47:07 +00:00
Amir E. Aharoni
ed8d0c2206 Fixes Bug 32403. Will only work on browsers that support dir="auto". Won't break in other browsers. 2011-12-12 06:31:13 +00:00
Robin Pepermans
b1d7167444 Remove the (useless) configuration option $wgVectorShowVariantName. If set to false (which is default), it is not clear to users what the dropdown menu is about. Secondly, other skins display all variants as different tabs. Thirdly, Serbian and Chinese projects (most active projects relevant to this) have set it to true. 2011-12-12 00:03:15 +00:00
Platonides
b80d7c2418 Move the hidden input with the title inside the <div> (adding a silly one for two-button search).
Removes dumb XHTML1 conformance warning about <input> (an inline element) not being able to be there 
(a place for a block element). (Bug 13381)
2011-11-20 21:38:15 +00:00
Daniel Friesen
f3589463b1 Followup r98212; Ensure that true is passed to all uses of SkinTemplateToolboxEnd where we use getToolbox while they haven't been migrated to use getSidebar. 2011-10-09 19:54:12 +00:00
Daniel Friesen
db1a37382c Improve the accessibility of our jump-to functionality
- Stop hiding with display: none;, this hides our jump links from modern screen readers and users with motor disabilities (ie: nowadays, pratically everyone they are intended to help).
- Instead hide with an overflow that will make the links viable <tab> targets. This alone is enough to help screen reader users.
- Add in a script that will show the jump-links area on-focus for motor-impared users who can still see who have js enabled (this can't be done with css unfortunately)
2011-09-25 00:49:39 +00:00
Alexandre Emsenhuber
b29f8545d7 Don't use isset() to check for null 2011-09-21 09:11:26 +00:00
Daniel Friesen
e33f0f8907 Kill off $wg{Request,User,Lang,Output} usage within skins/ and redundant $this->skin local vars. 2011-09-09 15:41:30 +00:00
Daniel Friesen
bd756e6684 Followup r87340: Post-hook swap bodytext into a new bodycontent key and append printfooter and debughtml to bodytext so that we get the same behaviour as before for skins, the advantage of letting extensions modify them separately, and let skins opt-in to the ability to display these separately. 2011-09-04 12:38:04 +00:00
Daniel Friesen
0a9b4c6dc2 Remove the basic styles that vector coppied from monobook from both monobook and vector and relocate them to a series of css stylesheets which 3rd party skins can include.
Havent touched Modern yet. External link icons are too complex to deal with this round due to vector and monobook using different icons.
2011-08-31 06:59:15 +00:00
Sam Reed
2d106cb050 Partial revert to r94024
Only 2 lines in Vector needed reverting, not the whole revision
2011-08-06 12:18:15 +00:00
Brion Vibber
868f61e63b Revert r89123 -- caused bug 30259 (switched correct calls with incorrect calls because of some interpretation of 'deprecation', causing invalid HTML output and breakage of watch tab on edit page) 2011-08-06 12:06:11 +00:00
Antoine Musso
2d55b1670f revert r93284 and follow up r93285
breaks parser tests. Please update the parser tests and reapply.
2011-07-27 19:24:43 +00:00
Leo Koppelkamm
4fc85ff098 Fix Bug 11270 & Bug 11555 : Make editsection link more understandable by positioning it directly left ( RTL: right ) of the title.
Patch by Aryeh Gregor, updated by Roan Kattouw, and updated again by me. I also fixed one bug with modern.css.
Tested in IE6,7,8, Chrome & FF in all skins and both LTR and RTL contexts. I tested with floating images above and below the headers and couldn't find regressions.
2011-07-27 16:43:04 +00:00
Robin Pepermans
7c624542f0 (bug 6100; follow-up to r91315) Being bold and removing $wgBetterDirectionality (and dependent wfUILang) in core, as most or all work is finished.
Also:
* Introduce classes mw-float-end, mw-float-start so we don't have to use inline css depending on wfUILang()/$wgLang (see HistoryPage and SpecialFileDuplicateSearch)
* Add direction mark to protection log
* Remove specialpageattributes as it is obsoleted by this commit (also fixes bug 28572)
* Add two direction marks in wfSpecialList, which makes ltr links on rtl wiki (and vice versa) display nicely as well (only on those special pages however)
* Revert r91340 partially: use mw-content-ltr/rtl class anyway in shared.css. Both ways have their [dis]advantages...
* Set the direction of input fields by default to the content language direction (except buttons etc.) in shared.css
2011-07-06 02:26:06 +00:00
Sam Reed
afc77d6bb7 Remove unused parameter, update callers
Trim whitespace
2011-07-01 01:37:15 +00:00
Chad Horohoe
17139f2c42 Fix for r91081, I think he meant $content, not $cont. 2011-06-29 18:40:08 +00:00
Platonides
b439ecb76c Make a sidebar key with value false mean 'skip this header'.
Intended for the forced headers, such as SEARCH.
These entries would be added using SkinBuildSidebar hook.
2011-06-29 17:20:47 +00:00
Sam Reed
10f8290829 Followup r87584, r87963
Why not fix both?
2011-05-31 20:23:02 +00:00
Sam Reed
b02f506c34 Fix up a couple of deprecated calls
Documentation
2011-05-29 18:32:30 +00:00
Alexandre Emsenhuber
4ac963f70f * Simplify message existence checks by using wfMessage() instead of wfMsg() with wfEmptyMsg()
* Fixed one check in Skin::addToSidebarPlain() that used user language for existence and content language for message's content
* Changed SkinTemplate::buildContentNavigationUrls() to use Title::getDefaultMessageText() instead of wfEmptyMsg()
2011-05-23 16:32:52 +00:00
Krinkle
9fa58c6d93 Putting debughtml after visualClear in Vector skin. Messed up Special:UserLogin (debug starts to the right of the form. Doesn't affect other skins. 2011-05-21 20:06:58 +00:00
Jack Phoenix
bca7cfb5e5 Vector.php: coding style 2011-05-14 15:14:03 +00:00
Krinkle
9a6b0a26e7 Re-do r87961 in a better way. Like I said, it's not acting the same as Linker::tooltip, which is already expended. Calling it when generating the HTML will try to expend the output from Linker::tooltip, which failed. Instead expending it where it's not normalized yet. 2011-05-13 10:34:01 +00:00
Krinkle
e708e03a4f Reverted r87961. Broke stuff on action=edit... 2011-05-13 10:29:21 +00:00
Krinkle
1670dbf36d Fixing broken tooltip/accesskey's for view_urls in Vector. Thanks JeroenDeDauw for reporting this! In contrary to Linker:tooltip (which returns a string (attributes expanded allready), Linker::tooltipAndAccesskeyAttribs returns an array. This caused the link to be like <a href='..' array></a> 2011-05-13 10:26:20 +00:00
Sam Reed
f985524076 More versions added to @deprecated tags
Couple of inbound calls fixed up

Some ancient code removed as it's been marked deprecated
2011-05-06 21:50:18 +00:00
Alexandre Emsenhuber
52fe58784a Moved "printfooter" and debug HTML away from "bodytext" so that they can be easily modified by extensions with the SkinTemplateOutputPageBeforeExec hook; always moved generation of debug HTML just before executing the hook so that it includes more items 2011-05-03 17:23:17 +00:00
Krinkle
f0ceb8b304 FU: r87041: Oops 2011-04-27 20:27:26 +00:00
Krinkle
0d2ff127e8 Fixes for IE7 (alignment of checkboxes due to double-margin bug on floated elements. The popular display:inline hack doesn't fix this. Removed the margin for now, was collapsed/invisible in most browsers anyway. Covered by the margins on the parent elements. 2011-04-27 20:25:35 +00:00
Roan Kattouw
573d3dafc1 (bug 24298) Make dropdown menus in Vector more accessible by expanding and collapsing them when the hidden link behind the dropdown arrow receives a click event (triggered by an enter or space bar key press in the typical use case) and changing the appearance of the arrow when the hidden link behind it is focused. Patch by Jan Paul Posma
--This line, and those behind, will be ignored--

M    phase3/skins/Vector.php
M    phase3/skins/vector/images/arrow-down-icon.png
M    phase3/skins/vector/screen.css
AM   phase3/skins/vector/vector.js
M    phase3/resources/Resources.php
2011-04-25 14:08:01 +00:00