* The problem is that Title::userIsWatching() relies on $wgUser,
which is not suitable on every case. Instead User::isWatched()
requires both an User and a Title object.
* Replaced all core calls from the former to the latter
* Added a cache in User for the WatchedItem instances so we do not
need to do a database request every time something want to know
whether a page is watched or not, which can happen several times
per request.
Change-Id: Ifa9c55b7ffb487ce6893c74df233eedc7654dc5e
The error is Strict Standards: Declaration of SkinVector::addToBodyAttributes() should be compatible with that of Skin::addToBodyAttributes() in skins/Vector.php on line 71.
Change-Id: I429609359870547f3df895902909754899ec30df
This allows people to disable animation of CSS properties temporarily
if needed by removing the vector-animateLayout class from the body.
// Disabled CSS transitions on properties customized by the hd layout
$( 'body' ).removeClass( 'vector-animateLayout' );
// Change something that would normally be animated
$( '#content' ).css( 'margin-left', 0 );
// Re-enables transitions
$( 'body' ).addClass( 'vector-animateLayout' );
Change-Id: I6d164e45c1e31d4f83e0fa390011c5d182eb69c3
Fix the bug where Vector leaves "unwatch" in an action in the menu
instead of converting it into an icon when you are on
Special:MovePage/Foo.
Apply to when using $wgVectorUseIconWatch = true;
Change-Id: Ie914ac50974aa473fa474931ca69776dd1c2fc54
* fix on-the-loose fixalpha() call
-- Calls should not be dangling loose like that
-- Removed local calls from skins and installer
-- instead calling from the IEFixes script (which is loaded raw by wikibits which is loaded from the bottom, as are all legacy scripts)
* Removing usage of 'skinpath' and 'skin' globals in wikibits.js, those aren't globals per se since introduction of mw.config and $wgLegacyJavaScriptGlobals
* Wrapping wikibits.js in closure to avoid leakage of "local" variables. This shouldn't break anything as it is loaded through resource loader which, in production mode, wraps it in a closure anyway.
* adding explicit posision=>bottom for wikibits. 'bottom' is default but repeating here since it must not change for legacy reasons.
The ugliness of this sort of code is probably part of why there's still a Linker::tooltip() function.
Please don't just replace it with worse code; if truly cleaning it up this should be done by giving a saner interface to the nav generation code
- Stop hiding with display: none;, this hides our jump links from modern screen readers and users with motor disabilities (ie: nowadays, pratically everyone they are intended to help).
- Instead hide with an overflow that will make the links viable <tab> targets. This alone is enough to help screen reader users.
- Add in a script that will show the jump-links area on-focus for motor-impared users who can still see who have js enabled (this can't be done with css unfortunately)
Patch by Aryeh Gregor, updated by Roan Kattouw, and updated again by me. I also fixed one bug with modern.css.
Tested in IE6,7,8, Chrome & FF in all skins and both LTR and RTL contexts. I tested with floating images above and below the headers and couldn't find regressions.
Also:
* Introduce classes mw-float-end, mw-float-start so we don't have to use inline css depending on wfUILang()/$wgLang (see HistoryPage and SpecialFileDuplicateSearch)
* Add direction mark to protection log
* Remove specialpageattributes as it is obsoleted by this commit (also fixes bug 28572)
* Add two direction marks in wfSpecialList, which makes ltr links on rtl wiki (and vice versa) display nicely as well (only on those special pages however)
* Revert r91340 partially: use mw-content-ltr/rtl class anyway in shared.css. Both ways have their [dis]advantages...
* Set the direction of input fields by default to the content language direction (except buttons etc.) in shared.css
* Fixed one check in Skin::addToSidebarPlain() that used user language for existence and content language for message's content
* Changed SkinTemplate::buildContentNavigationUrls() to use Title::getDefaultMessageText() instead of wfEmptyMsg()
--This line, and those behind, will be ignored--
M phase3/skins/Vector.php
M phase3/skins/vector/images/arrow-down-icon.png
M phase3/skins/vector/screen.css
AM phase3/skins/vector/vector.js
M phase3/resources/Resources.php